Page MenuHomePhabricator

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (336 w, 1 d)
Roles
Administrator
Slack Username
Fabien

Recent Activity

Today

Fabien accepted D17812: [Cashtab] Move native2 to top.
Mon, Mar 17, 05:03

Yesterday

Fabien requested changes to D17808: [electrum] properly exclude ALP tokens when sending XEC.
Sun, Mar 16, 19:24
Fabien accepted D17809: [electrum] make it possible to spend tokens by manually selecting the coins to spend.
Sun, Mar 16, 19:22
Fabien accepted D17774: [ecash-lib-wasm] Add readme with installation instructions.
Sun, Mar 16, 19:19

Fri, Mar 14

Fabien accepted D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Fri, Mar 14, 20:36

Thu, Mar 13

Fabien accepted D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Thu, Mar 13, 21:12
Fabien committed rABCc35bd582d99f: [avalanche] Add a mempool isWorthPolling method for txs (authored by Fabien).
[avalanche] Add a mempool isWorthPolling method for txs
Thu, Mar 13, 21:09
Fabien closed D17801: [avalanche] Add a mempool isWorthPolling method for txs.
Thu, Mar 13, 21:09
Fabien accepted D17803: [Cashtab] Drop test causing problems in CI.
Thu, Mar 13, 21:08
Fabien accepted D17788: [avalanche] Move contender cache to peer manager.
Thu, Mar 13, 21:05
Fabien closed D17798: [electrum] Update trezor firmware.
Thu, Mar 13, 15:28
Fabien committed rABC163c0d03f1f6: [electrum] Update trezor firmware (authored by Fabien).
[electrum] Update trezor firmware
Thu, Mar 13, 15:28
Fabien requested changes to D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Thu, Mar 13, 15:27
Fabien closed D17800: [fuzzer] Fix the validation_load_mempool build.
Thu, Mar 13, 15:15
Fabien committed rABCa88c53babb4e: [fuzzer] Fix the validation_load_mempool build (authored by Fabien).
[fuzzer] Fix the validation_load_mempool build
Thu, Mar 13, 15:15
Fabien updated the diff for D17798: [electrum] Update trezor firmware.

Don't use python 3.12 syntax

Thu, Mar 13, 15:06
Fabien requested review of D17801: [avalanche] Add a mempool isWorthPolling method for txs.
Thu, Mar 13, 15:03
Fabien requested review of D17800: [fuzzer] Fix the validation_load_mempool build.
Thu, Mar 13, 14:47
Fabien committed rABC4bfa18b31d05: [avalanche] Use the block fitter to track the finalized txs statistics (authored by Fabien).
[avalanche] Use the block fitter to track the finalized txs statistics
Thu, Mar 13, 14:24
Fabien closed D17795: [avalanche] Use the block fitter to track the finalized txs statistics.
Thu, Mar 13, 14:24
Fabien closed D17793: Extract the block fitting logic from the block assembler logic.
Thu, Mar 13, 14:24
Fabien committed rABC65cd0d3d2796: Reset the block template in the constructor (authored by Fabien).
Reset the block template in the constructor
Thu, Mar 13, 14:24
Fabien closed D17792: Reset the block template in the constructor.
Thu, Mar 13, 14:24
Fabien committed rABC9ac95e329a2b: Extract the block fitting logic from the block assembler logic (authored by Fabien).
Extract the block fitting logic from the block assembler logic
Thu, Mar 13, 14:24
Fabien closed D17791: Use constants for the coinbase reserved size in the block assembler.
Thu, Mar 13, 14:24
Fabien committed rABCa5d9b7229373: Use constants for the coinbase reserved size in the block assembler (authored by Fabien).
Use constants for the coinbase reserved size in the block assembler
Thu, Mar 13, 14:24
Fabien accepted D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Thu, Mar 13, 13:07
Fabien requested review of D17798: [electrum] Update trezor firmware.
Thu, Mar 13, 10:26
Fabien accepted D17797: [electrum] also use patched btchip-python in non-deterministic requirements-hw.txt.
Thu, Mar 13, 10:17
Fabien accepted D17796: [electrum] bump hidapi and remove --only-binary workaround.
Thu, Mar 13, 10:16
Fabien accepted D17790: [electrum] build: use pyca/cryptography release version.
Thu, Mar 13, 08:39
Fabien requested changes to D17774: [ecash-lib-wasm] Add readme with installation instructions.
Thu, Mar 13, 08:38
Fabien added inline comments to D17774: [ecash-lib-wasm] Add readme with installation instructions.
Thu, Mar 13, 08:38
Fabien accepted D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Thu, Mar 13, 08:37
Fabien requested changes to D17778: [Cashtab] Use ecash-lib to sign and verify msgs.

More a question than requesting change here

Thu, Mar 13, 08:36
Fabien updated the diff for D17795: [avalanche] Use the block fitter to track the finalized txs statistics.

The blockfitter now needs to be part of the kernel for bitcoin-chainstate to build

Thu, Mar 13, 08:13

Wed, Mar 12

Fabien requested review of D17795: [avalanche] Use the block fitter to track the finalized txs statistics.
Wed, Mar 12, 21:16
Fabien accepted D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Wed, Mar 12, 20:55
Fabien requested review of D17793: Extract the block fitting logic from the block assembler logic.
Wed, Mar 12, 20:45
Fabien requested review of D17792: Reset the block template in the constructor.
Wed, Mar 12, 20:38
Fabien requested review of D17791: Use constants for the coinbase reserved size in the block assembler.
Wed, Mar 12, 20:30
Fabien added inline comments to D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Wed, Mar 12, 20:24
Fabien requested changes to D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.

Please update your title and summary

Wed, Mar 12, 19:27
Fabien added inline comments to D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Wed, Mar 12, 16:18
Fabien added inline comments to D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Wed, Mar 12, 14:17
Fabien requested changes to D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Wed, Mar 12, 14:15
Fabien requested changes to D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Wed, Mar 12, 13:39
Fabien requested changes to D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Wed, Mar 12, 13:36
Fabien requested changes to D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Wed, Mar 12, 13:24

Tue, Mar 11

Fabien committed rABC66fb757a1fb5: [ci] Fix wasm install with newer rust versions (authored by Fabien).
[ci] Fix wasm install with newer rust versions
Tue, Mar 11, 21:13
Fabien closed D17780: [ci] Fix wasm install with newer rust versions.
Tue, Mar 11, 21:13
Fabien closed D17781: [chronik] Bump corrosion to 0.5.1.
Tue, Mar 11, 21:13
Fabien committed rABCe522e2476965: [chronik] Bump corrosion to 0.5.1 (authored by Fabien).
[chronik] Bump corrosion to 0.5.1
Tue, Mar 11, 21:13
Fabien accepted D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Tue, Mar 11, 21:08
Fabien requested review of D17781: [chronik] Bump corrosion to 0.5.1.
Tue, Mar 11, 20:59
Fabien requested review of D17780: [ci] Fix wasm install with newer rust versions.
Tue, Mar 11, 19:47

Mon, Mar 10

Fabien closed D17771: [avalanche] Remove useless timeout in the tx finalization test.
Mon, Mar 10, 21:31
Fabien committed rABC45b81d2fa789: [avalanche] Remove useless timeout in the tx finalization test (authored by Fabien).
[avalanche] Remove useless timeout in the tx finalization test
Mon, Mar 10, 21:31
Fabien accepted D17772: [Cashtab] Patch flaky test in XECX redemption workflow.
Mon, Mar 10, 16:49
Fabien requested review of D17771: [avalanche] Remove useless timeout in the tx finalization test.
Mon, Mar 10, 15:15
Fabien committed rABCc9a42a9daf58: [electrum] Add native eCash support for compatible Trezor One firmware (authored by Fabien).
[electrum] Add native eCash support for compatible Trezor One firmware
Mon, Mar 10, 14:45
Fabien closed D17770: [electrum] Add native eCash support for compatible Trezor One firmware.
Mon, Mar 10, 14:45
Fabien retitled D17770: [electrum] Add native eCash support for compatible Trezor One firmware from [electrum] Has native eCash support for compatible Trezor One firmware to [electrum] Add native eCash support for compatible Trezor One firmware.
Mon, Mar 10, 14:45
Fabien requested review of D17770: [electrum] Add native eCash support for compatible Trezor One firmware.
Mon, Mar 10, 13:26

Fri, Mar 7

Fabien accepted D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.
Fri, Mar 7, 22:00
Fabien added a comment to D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.

Not sure why the builds failed and the bot doesn't respond. The change works on my end. Lints say there's nothing to lint (since it's just updating an image file).

Fri, Mar 7, 21:59
Fabien accepted D17755: [monorepo] eslint all the js with a single version-pinned flat config.
Fri, Mar 7, 15:29
Fabien accepted D17760: [electrum] implement eMPP parsing.
Fri, Mar 7, 15:26
Fabien closed D17763: [linter] Update the prettier installation hint.
Fri, Mar 7, 15:18
Fabien committed rABCadc80e267816: [linter] Update the prettier installation hint (authored by Fabien).
[linter] Update the prettier installation hint
Fri, Mar 7, 15:18
Fabien requested review of D17763: [linter] Update the prettier installation hint.
Fri, Mar 7, 13:00
Fabien requested changes to D17755: [monorepo] eslint all the js with a single version-pinned flat config.
Fri, Mar 7, 10:51
Fabien added a comment to D17755: [monorepo] eslint all the js with a single version-pinned flat config.

Failed tests logs:

====== CashTab Unit Tests: <Token /> available actions rendered We can redeem XECX for XEC 1:1 using a workflow unique to XECX ======
Error: expect(element).toBeDisabled()

Received element is not disabled:
  <button class="sc-caSCKo sc-kjoXOD DHATx" style="margin-top: 12px;" />
    at Object.toBeDisabled (/work/cashtab/src/components/Etokens/__tests__/TokenActions.test.js:1985:30)

Each failure log is accessible here:
CashTab Unit Tests: <Token /> available actions rendered We can redeem XECX for XEC 1:1 using a workflow unique to XECX

Fri, Mar 7, 10:21
Fabien requested changes to D17760: [electrum] implement eMPP parsing.
Fri, Mar 7, 10:19
Fabien accepted D17759: [electrum] add copyright header to slp.py.
Fri, Mar 7, 10:07
Fabien accepted D17758: [electrum] rename package slp -> tokens.
Fri, Mar 7, 10:06
Fabien accepted D17757: [electrum] import the slp module directly.
Fri, Mar 7, 10:04

Thu, Mar 6

Fabien updated the summary of D13068: [avalanche] Add transaction management to the processor core.
Thu, Mar 6, 09:54
Fabien added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

This is a update.
Perhaps my update method wasn't quite right? It created a new sub-diff, this is the initial submission https://reviews.bitcoinabc.org/D17756?id=52941

Thu, Mar 6, 09:00
Fabien accepted D17753: test: adjust chainstate tests to use recognized snapshot base.
Thu, Mar 6, 08:44
Fabien added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Please prefix your title with [cashtab] so we now in the review queue what part of the code is changed

Thu, Mar 6, 08:13
Fabien added a comment to D17755: [monorepo] eslint all the js with a single version-pinned flat config.

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

On another note, I'm getting the following from arc lint --everything

image.png (245×1 px, 37 KB)

However, arc lint on the cashtab folder runs fine, which doesn't seem to be a local issue?

image.png (55×512 px, 9 KB)

Thu, Mar 6, 08:10

Wed, Mar 5

Fabien accepted D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Wed, Mar 5, 14:30
Fabien requested changes to D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Wed, Mar 5, 12:42
Fabien requested changes to D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Wed, Mar 5, 08:34

Tue, Mar 4

Fabien accepted D17752: [ecash-coinselect, token-server] Remove ecash-coinselect from the monorepo.
Tue, Mar 4, 22:23
Fabien closed D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.
Tue, Mar 4, 20:27
Fabien committed rABC3bca6fa41005: [avalanche] Add the finalized transactions ancestors to the list of recently… (authored by Fabien).
[avalanche] Add the finalized transactions ancestors to the list of recently…
Tue, Mar 4, 20:27
Fabien added inline comments to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Tue, Mar 4, 16:21
Fabien requested changes to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Tue, Mar 4, 16:14
Fabien added inline comments to D17741: [monorepo] Upgrade eslint to 9 and use pinned version instead of global.
Tue, Mar 4, 15:51
Fabien added inline comments to D17741: [monorepo] Upgrade eslint to 9 and use pinned version instead of global.
Tue, Mar 4, 15:50
Fabien updated the diff for D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.

Feedback

Tue, Mar 4, 15:04
Fabien added inline comments to D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.
Tue, Mar 4, 15:03
Fabien accepted D17750: index: verify blocks data existence only once.
Tue, Mar 4, 14:29
Fabien accepted D17749: init: don't start indexes sync thread prematurely.
Tue, Mar 4, 14:27
Fabien accepted D17748: refactor: simplify pruning violation check.
Tue, Mar 4, 14:25
Fabien accepted D17747: make GetFirstStoredBlock assert that 'start_block' always has data.
Tue, Mar 4, 14:23
Fabien accepted D17746: refactor: init indexes, decouple 'Start()' from the creation step.
Tue, Mar 4, 14:21
Fabien accepted D17745: rename 'loadblk' thread name to 'initload'.
Tue, Mar 4, 14:19