Page MenuHomePhabricator
People Fabien

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (302 w, 5 d)
Roles
Administrator
Slack Username
Fabien

Recent Activity
View All

Thu, Jul 25

Fabien requested changes to D16532: [Chronik] Add PluginsWrite::{insert, delete}.

The build is failing, back to your queue

Thu, Jul 25, 14:39
Fabien requested changes to D16527: [Chronik] Add `PluginContext::run_on_tx`.

Can you please add a couple tests with data=b'' and data=[] ? Note this can be unit tests for extract_bytes_or_list instead of the whole run_on_tx

Thu, Jul 25, 14:38
Fabien accepted D16525: [Chronik] Add `plugin` field to `TxInput` in `tx.py`.
Thu, Jul 25, 14:13
Fabien accepted D16526: [chronik] add a headers endpoint.
Thu, Jul 25, 14:08
Fabien accepted D16508: [chronik] add a header endpoint.
Thu, Jul 25, 14:02

Wed, Jul 24

Fabien requested changes to D16526: [chronik] add a headers endpoint.

The deduplication was correct, you just called the boundary check later in the code flow which changed the behavior.

Wed, Jul 24, 12:24
Fabien accepted D16530: [Chronik] Remove unneeded `.as_ref()` call.
Wed, Jul 24, 12:11
Fabien added inline comments to D16525: [Chronik] Add `plugin` field to `TxInput` in `tx.py`.
Wed, Jul 24, 10:19
Fabien accepted D16522: [Chronik] Store index of plugins and ensure versions match.
Wed, Jul 24, 09:45
Fabien accepted D16520: [Chronik] Add `PluginsWriter` and `PluginsReader` (only for PluginMeta).

Is this test run as part of ninja check-crates ?

Wed, Jul 24, 09:13

Tue, Jul 23

Fabien requested changes to D16508: [chronik] add a header endpoint.

Otherwise LGTM

Tue, Jul 23, 19:16
Fabien requested changes to D16526: [chronik] add a headers endpoint.

back to your queue

Tue, Jul 23, 18:59
Fabien closed D16521: [explorer] Properly handle html chars in token ticker.
Tue, Jul 23, 11:15
Fabien committed rABC7c5664b00bf6: [explorer] Properly handle html chars in token ticker (authored by Fabien).
[explorer] Properly handle html chars in token ticker
Tue, Jul 23, 11:15
Fabien requested changes to D16508: [chronik] add a header endpoint.
Tue, Jul 23, 08:01
Fabien requested review of D16521: [explorer] Properly handle html chars in token ticker.
Tue, Jul 23, 07:32

Mon, Jul 22

Fabien requested changes to D16516: [Cashtab] Add maintenance mode with config toggle.

The tests are failing

Mon, Jul 22, 12:23
Fabien accepted D16514: [Cashtab] version bump for D16513.
Mon, Jul 22, 08:53
Fabien accepted D16513: [Cashtab] Remove article hyperlink.
Mon, Jul 22, 08:21
Fabien requested changes to D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.
Mon, Jul 22, 07:39

Fri, Jul 19

Fabien closed D16507: fuzz: increase txorphan harness stability.
Fri, Jul 19, 14:08
Fabien committed rABC0fafd7b7095f: fuzz: increase txorphan harness stability (authored by marcofleon <marleo23@proton.me>).
fuzz: increase txorphan harness stability
Fri, Jul 19, 14:08
Fabien closed D16504: [log] updates in TxOrphanage.
Fri, Jul 19, 14:08
Fabien committed rABCe7ca7c17ac73: [log] updates in TxOrphanage (authored by Fabien).
[log] updates in TxOrphanage
Fri, Jul 19, 14:08
Fabien closed D16503: test: tx orphan handling.
Fri, Jul 19, 14:07
Fabien committed rABC969e03c50dad: test: tx orphan handling (authored by glozow <gloriajzhao@gmail.com>).
test: tx orphan handling
Fri, Jul 19, 14:07
Fabien closed D16505: net_processing: ignore transactions while in IBD.
Fri, Jul 19, 14:06
Fabien committed rABC673bc1eb29cf: net_processing: ignore transactions while in IBD (authored by glozow <gzhao408@berkeley.edu>).
net_processing: ignore transactions while in IBD
Fri, Jul 19, 14:06
Fabien closed D16506: fuzz: Improve fuzzing stability for txorphan harness.
Fri, Jul 19, 14:04
Fabien committed rABC1e1bd1cbf62a: fuzz: Improve fuzzing stability for txorphan harness (authored by dergoegge <n.goeggi@gmail.com>).
fuzz: Improve fuzzing stability for txorphan harness
Fri, Jul 19, 14:04
Fabien requested review of D16507: fuzz: increase txorphan harness stability.
Fri, Jul 19, 12:48
Fabien requested review of D16506: fuzz: Improve fuzzing stability for txorphan harness.
Fri, Jul 19, 12:23
Fabien updated the diff for D16504: [log] updates in TxOrphanage.

Rebase

Fri, Jul 19, 11:58
Fabien updated the summary of D16503: test: tx orphan handling.
Fri, Jul 19, 11:57
Fabien updated the diff for D16503: test: tx orphan handling.

Rebase on D16505.

Fri, Jul 19, 11:57
Fabien requested review of D16505: net_processing: ignore transactions while in IBD.
Fri, Jul 19, 11:55
Fabien planned changes to D16503: test: tx orphan handling.
Fri, Jul 19, 11:18
Fabien requested review of D16504: [log] updates in TxOrphanage.
Fri, Jul 19, 09:46
Fabien requested review of D16503: test: tx orphan handling.
Fri, Jul 19, 09:32
Fabien closed D16502: test: Add more tests for orphan tx handling.
Fri, Jul 19, 08:05
Fabien committed rABC3628e52ed106: test: Add more tests for orphan tx handling (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
test: Add more tests for orphan tx handling
Fri, Jul 19, 08:05
Fabien closed D16501: refactor: Use type-safe time in txorphanage.
Fri, Jul 19, 08:05
Fabien committed rABCa53da9376411: refactor: Use type-safe time in txorphanage (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Use type-safe time in txorphanage
Fri, Jul 19, 08:05
Fabien closed D16498: opportunistic 1p1c followups.
Fri, Jul 19, 08:04
Fabien committed rABCbe7fbc1fd1be: opportunistic 1p1c followups (authored by glozow <gloriajzhao@gmail.com>).
opportunistic 1p1c followups
Fri, Jul 19, 08:04

Thu, Jul 18

Fabien requested review of D16502: test: Add more tests for orphan tx handling.
Thu, Jul 18, 14:27
Fabien requested review of D16501: refactor: Use type-safe time in txorphanage.
Thu, Jul 18, 13:28
Fabien closed D16494: [p2p] opportunistically accept 1-parent-1-child packages.
Thu, Jul 18, 13:11
Fabien committed rABCd0b3d2524b06: [p2p] opportunistically accept 1-parent-1-child packages (authored by glozow <gloriajzhao@gmail.com>).
[p2p] opportunistically accept 1-parent-1-child packages
Thu, Jul 18, 13:11
Fabien requested review of D16498: opportunistic 1p1c followups.
Thu, Jul 18, 09:55
Fabien closed D16497: Avoid the p2p delays on some functional tests.
Thu, Jul 18, 09:46
Fabien committed rABCd754f53dfaf3: Avoid the p2p delays on some functional tests (authored by Fabien).
Avoid the p2p delays on some functional tests
Thu, Jul 18, 09:46
Fabien added inline comments to D16494: [p2p] opportunistically accept 1-parent-1-child packages.
Thu, Jul 18, 09:15
Fabien updated the diff for D16494: [p2p] opportunistically accept 1-parent-1-child packages.

Fix comment nit, and remove the unecessary noban_tx_relay

Thu, Jul 18, 09:13
Fabien closed D16493: [txorphanage] add method to get all orphans spending a tx.
Thu, Jul 18, 09:06
Fabien committed rABC1f4999794394: [txorphanage] add method to get all orphans spending a tx (authored by glozow <gloriajzhao@gmail.com>).
[txorphanage] add method to get all orphans spending a tx
Thu, Jul 18, 09:06
Fabien closed D16491: [txpackages] add canonical way to get hash of package.
Thu, Jul 18, 09:05
Fabien committed rABC39a2132c1e7c: [txpackages] add canonical way to get hash of package (authored by glozow <gloriajzhao@gmail.com>).
[txpackages] add canonical way to get hash of package
Thu, Jul 18, 09:05
Fabien closed D16490: rpc: allow submitpackage to be called outside of regtest.
Thu, Jul 18, 09:03
Fabien committed rABC48cb63e4a344: rpc: allow submitpackage to be called outside of regtest (authored by glozow <gloriajzhao@gmail.com>).
rpc: allow submitpackage to be called outside of regtest
Thu, Jul 18, 09:03
Fabien requested review of D16497: Avoid the p2p delays on some functional tests.
Thu, Jul 18, 08:53

Wed, Jul 17

Fabien updated the diff for D16494: [p2p] opportunistically accept 1-parent-1-child packages.

Using the same quote marks for an embedded dict key and its f-string is a Python 3.12+ feature, TIL

Wed, Jul 17, 20:01
Fabien requested review of D16494: [p2p] opportunistically accept 1-parent-1-child packages.
Wed, Jul 17, 19:20
Fabien updated the diff for D16493: [txorphanage] add method to get all orphans spending a tx.

Rebase

Wed, Jul 17, 19:03
Fabien updated the diff for D16491: [txpackages] add canonical way to get hash of package.

Rebase

Wed, Jul 17, 19:02
Fabien updated the diff for D16490: rpc: allow submitpackage to be called outside of regtest.

Rebase

Wed, Jul 17, 18:59
Fabien requested review of D16493: [txorphanage] add method to get all orphans spending a tx.
Wed, Jul 17, 18:30
Fabien requested review of D16491: [txpackages] add canonical way to get hash of package.
Wed, Jul 17, 18:07
Fabien requested review of D16490: rpc: allow submitpackage to be called outside of regtest.
Wed, Jul 17, 18:03
Fabien accepted D16489: Seeder: do not exclude nodes that use a non-default port.
Wed, Jul 17, 17:43
Fabien accepted D16483: [e.cash] Bump nodejs version used for deployments.
Wed, Jul 17, 17:40
Fabien accepted D16488: [docs] Update Dockerfile for local dependency.
Wed, Jul 17, 13:52
Fabien closed D16486: Move fill_mempool to util function.
Wed, Jul 17, 13:51
Fabien committed rABCf7a23c763c00: Move fill_mempool to util function (authored by Greg Sanders <gsanders87@gmail.com>).
Move fill_mempool to util function
Wed, Jul 17, 13:51
Fabien closed D16485: test: Run feature_bip68_sequence.py with MiniWallet.
Wed, Jul 17, 13:09
Fabien committed rABC4a354dc7f54b: test: Run feature_bip68_sequence.py with MiniWallet (authored by Miles Liu <miles@bung.cc>).
test: Run feature_bip68_sequence.py with MiniWallet
Wed, Jul 17, 13:09
Fabien closed D16487: Fix release notes for v0.29.8 (archive) and v0.29.9 (current).
Wed, Jul 17, 13:08
Fabien committed rABC5f3d2fb3a4dd: Fix release notes for v0.29.8 (archive) and v0.29.9 (current) (authored by Fabien).
Fix release notes for v0.29.8 (archive) and v0.29.9 (current)
Wed, Jul 17, 13:08
Fabien updated the diff for D16486: Move fill_mempool to util function.

Remove the node and wallet assignment lines

Wed, Jul 17, 13:02
Fabien requested review of D16487: Fix release notes for v0.29.8 (archive) and v0.29.9 (current).
Wed, Jul 17, 12:42
Fabien requested review of D16486: Move fill_mempool to util function.
Wed, Jul 17, 10:11
Fabien updated the diff for D16485: test: Run feature_bip68_sequence.py with MiniWallet.

Fix docstring

Wed, Jul 17, 09:53
Fabien requested review of D16485: test: Run feature_bip68_sequence.py with MiniWallet.
Wed, Jul 17, 09:25
Fabien added a comment to D16483: [e.cash] Bump nodejs version used for deployments.

That didn't fix the issue

Wed, Jul 17, 07:45
Fabien requested changes to D16483: [e.cash] Bump nodejs version used for deployments.
Wed, Jul 17, 07:36
Fabien accepted D16483: [e.cash] Bump nodejs version used for deployments.

@bot preview-e.cash

Wed, Jul 17, 07:18

Tue, Jul 16

Fabien closed D16472: Add HashWriter without ser-type and ser-version and use it where possible.
Tue, Jul 16, 21:15
Fabien committed rABC78cbb32b9c3d: Add HashWriter without ser-type and ser-version and use it where possible (authored by MacroFake <falke.marco@gmail.com>).
Add HashWriter without ser-type and ser-version and use it where possible
Tue, Jul 16, 21:15
Fabien accepted D16481: [electrum] bump dependencies.
Tue, Jul 16, 15:48
Fabien closed D16482: [CI] Update the sha256 sum for the nodejs setup script.
Tue, Jul 16, 15:44
Fabien committed rABC7fb78fbe85da: [CI] Update the sha256 sum for the nodejs setup script (authored by Fabien).
[CI] Update the sha256 sum for the nodejs setup script
Tue, Jul 16, 15:44
Fabien closed D16480: Fix style nits in p2p_compactblocks, make it easier to debug.
Tue, Jul 16, 15:43
Fabien committed rABC29da2db59a44: Fix style nits in p2p_compactblocks, make it easier to debug (authored by Fabien).
Fix style nits in p2p_compactblocks, make it easier to debug
Tue, Jul 16, 15:43
Fabien requested review of D16482: [CI] Update the sha256 sum for the nodejs setup script.
Tue, Jul 16, 14:41
Fabien requested review of D16480: Fix style nits in p2p_compactblocks, make it easier to debug.
Tue, Jul 16, 13:29
Fabien closed D16474: Properly cache policy rejected transactions for compact block reconstruction.
Tue, Jul 16, 13:27
Fabien committed rABC9ce93fecb6d6: Properly cache policy rejected transactions for compact block reconstruction (authored by Fabien).
Properly cache policy rejected transactions for compact block reconstruction
Tue, Jul 16, 13:27
Fabien accepted D16479: [chronik docs] upgrade dependencies.
Tue, Jul 16, 12:37
Fabien accepted D16478: [alias-server] Upgrade dependencies.
Tue, Jul 16, 12:36
Fabien accepted D16475: [e.cash] Upgrade dependencies.
Tue, Jul 16, 12:36