Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since: Oct 7 2018, 09:05 (289 w, 5 d)
Roles: Administrator
Slack Username: Fabien

Recent Activity
View All

Yesterday

Fabien closed D16059: [explorer] Make the specification a clickable link.

Fri, Apr 26, 19:30

Fabien committed rABC4543714e20b7: [explorer] Make the specification a clickable link (authored by Fabien).

[explorer] Make the specification a clickable link

Fri, Apr 26, 19:30

teamcity awarded D16059: [explorer] Make the specification a clickable link a Haypence token.

Fri, Apr 26, 19:18

Fabien requested review of D16059: [explorer] Make the specification a clickable link.

Fri, Apr 26, 19:15

Fabien accepted D16058: [explorer] SLPv2 -> Type2.

Fri, Apr 26, 16:14

Fabien requested changes to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

You want to check the hash of the binary to be loaded by the lib. There is no point checking it during the tests (where it's expected to change) and no point documenting the value, it will be out of sync in no time.

Fri, Apr 26, 08:59

Thu, Apr 25

Fabien accepted D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace.

Thu, Apr 25, 17:49

Fabien added a comment to D16052: [ecash-lib] Move ecash-lib-wasm back to root workspace.

@bot build-linux-arm

Thu, Apr 25, 17:33

Fabien requested changes to D16050: [ecash-lib] checksum for ecash-lib-wasm in CI build.

Thu, Apr 25, 06:53

Fabien closed D16048: Reduce port range in functional tests.

Thu, Apr 25, 06:29

Fabien committed rABC3b3c5674a35b: Reduce port range in functional tests (authored by Fabien).

Reduce port range in functional tests

Thu, Apr 25, 06:29

Wed, Apr 24

Fabien published D16048: Reduce port range in functional tests for review.

Wed, Apr 24, 15:50

teamcity awarded D16048: Reduce port range in functional tests a Like token.

Wed, Apr 24, 15:38

teamcity awarded D16048: Reduce port range in functional tests a Mountain of Wealth token.

Wed, Apr 24, 15:19

teamcity awarded D16048: Reduce port range in functional tests a Doubloon token.

Wed, Apr 24, 14:53

teamcity awarded D16048: Reduce port range in functional tests a Piece of Eight token.

Wed, Apr 24, 14:39

teamcity awarded D16048: Reduce port range in functional tests a Haypence token.

Wed, Apr 24, 13:57

Fabien closed D16044: [chronik-docs] Trim to version number in installation steps.

Wed, Apr 24, 07:19

Fabien committed rABC2aa757dd2aeb: [chronik-docs] Trim to version number in installation steps (authored by Fabien).

[chronik-docs] Trim to version number in installation steps

Wed, Apr 24, 07:19

Tue, Apr 23

Fabien requested review of D16044: [chronik-docs] Trim to version number in installation steps.

Tue, Apr 23, 18:56

Fabien accepted D16042: [chronik-docs] Patch dockerfile so that chronik links are not broken.

Tue, Apr 23, 18:32

Fabien requested changes to D16042: [chronik-docs] Patch dockerfile so that chronik links are not broken.

Noticed during testing: the .abclatestversion.sample file has a newline which is causing a line break in the file name. Remove the line break, and better trim the content as well when generating the content.

Tue, Apr 23, 14:19

Fabien requested changes to D16042: [chronik-docs] Patch dockerfile so that chronik links are not broken.

The port in the build-configurations.yml is set to 3000 but this Dockerfile create a nginx container using the default port (80). You should remove the port line in the build config.

Tue, Apr 23, 08:42

Fabien requested changes to D13101: [Mitra] Add Intcode integer format.

Tue, Apr 23, 07:38

Mon, Apr 22

Fabien accepted D15921: [Chronik] Add LOKAD ID index.

Mon, Apr 22, 16:24

Fabien accepted D16041: [e.cash] Fix non-clickable button on /get-ecash.

Mon, Apr 22, 14:56

Fabien added a comment to D16041: [e.cash] Fix non-clickable button on /get-ecash.

@bot preview-e.cash

Mon, Apr 22, 14:54

Fabien requested changes to D13101: [Mitra] Add Intcode integer format.

Mon, Apr 22, 14:47

Fabien added inline comments to D15921: [Chronik] Add LOKAD ID index.

Mon, Apr 22, 07:43

Fabien closed D16019: [avalanche] Remove finalized txs upon block finalization.

Mon, Apr 22, 07:34

Fabien committed rABCf47d323192d1: [avalanche] Remove finalized txs upon block finalization (authored by Fabien).

[avalanche] Remove finalized txs upon block finalization

Mon, Apr 22, 07:33

Fri, Apr 19

Fabien accepted D16023: blockstorage: Adjust fastprune limit if block exceeds blockfile size.

Fri, Apr 19, 14:22

Fabien closed D16026: [avalanche] Fix a potential race in the quorum functional test.

Fri, Apr 19, 14:12

Fabien committed rABCda36689fd3ab: [avalanche] Fix a potential race in the quorum functional test (authored by Fabien).

[avalanche] Fix a potential race in the quorum functional test

Fri, Apr 19, 14:12

Fabien accepted D16030: [Cashtab] Improve Token component tests.

Fri, Apr 19, 14:06

Fabien accepted D16028: test: simplify tests by using the pre-mined chain.

Did you take a look at the chronik tests ? I think there are opportunities for similar improvements

Fri, Apr 19, 13:48

Fabien accepted D16027: test: remove redundant blocks generation logic.

Fri, Apr 19, 13:47

Fabien accepted D16025: test: add `rescan_utxos` in MiniWallet's initialization.

Fri, Apr 19, 13:30

Fabien accepted D16021: test: Remove from_node from create_self_transfer* MiniWallet helpers.

Fri, Apr 19, 13:30

Fabien accepted D16020: [ecash-herald] Parse new miner AnandrajSingh Pool.

Fri, Apr 19, 13:22

Fabien requested review of D16026: [avalanche] Fix a potential race in the quorum functional test.

Fri, Apr 19, 13:21

Fabien closed D16024: [BPF] Fix the interface_usdt_utxocache.py test.

Fri, Apr 19, 13:00

Fabien committed rABC305666ac9ee6: [BPF] Fix the interface_usdt_utxocache.py test (authored by Fabien).

[BPF] Fix the interface_usdt_utxocache.py test

Fri, Apr 19, 13:00

Fabien requested review of D16024: [BPF] Fix the interface_usdt_utxocache.py test.

Fri, Apr 19, 12:11

Fabien accepted D16022: [test] fix broken interface_usdt_utxocache.py test.

Fri, Apr 19, 12:06

Fabien requested review of D16019: [avalanche] Remove finalized txs upon block finalization.

Fri, Apr 19, 10:18

Fabien accepted D16018: [ecash-herald] Group Cashtab rewards separately.

Fri, Apr 19, 10:11

Thu, Apr 18

Fabien accepted D16007: Move ::nPruneTarget into BlockManager.

Thu, Apr 18, 19:52

Fabien accepted D15624: validation: Stricter assumeutxo error handling when renaming chainstates.

Thu, Apr 18, 19:52

Fabien accepted D16016: Replace pindex pointer with block reference.

Thu, Apr 18, 16:03

Fabien accepted D16015: Add BlockManagerOpts::chainparams reference.

Thu, Apr 18, 16:01

Fabien accepted D16010: refactor: Add and use PRUNE_TARGET_MANUAL constexpr.

Thu, Apr 18, 15:58

Fabien accepted D16009: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager.

Thu, Apr 18, 15:57

Fabien accepted D16008: Move ::fPruneMode into BlockManager.

Thu, Apr 18, 15:56

Fabien requested changes to D16007: Move ::nPruneTarget into BlockManager.

Thu, Apr 18, 15:55

Fabien accepted D16006: Remove reindex special case from the progress bar label.

Thu, Apr 18, 15:50

Fabien added a comment to D15624: validation: Stricter assumeutxo error handling when renaming chainstates.

Why do you say there is no change in behavior ? Previously the node would shut down, now it only prints an error. Am I missing something ?

Thu, Apr 18, 15:47

Tue, Apr 16

Fabien closed D15991: [avalanche] Cleanup deprecated 'sharing' RPC field.

Tue, Apr 16, 17:44

Fabien committed rABC591fe28e01b2: [avalanche] Cleanup deprecated 'sharing' RPC field (authored by Fabien).

[avalanche] Cleanup deprecated 'sharing' RPC field

Tue, Apr 16, 17:44

Fabien requested review of D15991: [avalanche] Cleanup deprecated 'sharing' RPC field.

Tue, Apr 16, 14:01

Fabien accepted D15990: [Cashtab] Patch use of legacy const missed in rebase.

Tue, Apr 16, 13:07

Fabien accepted D15989: [electrum] fix flaky tear-down in functional tests.

Talked offline, there is not much that can be done and we just want to rm the dir which this achieves.

Tue, Apr 16, 11:38

Fabien requested changes to D15989: [electrum] fix flaky tear-down in functional tests.

Tue, Apr 16, 11:29

Fabien closed D15988: Bump version to 0.29.2.

Tue, Apr 16, 08:58

Fabien committed rABCf1d3f0db3573: Bump version to 0.29.2 (authored by Fabien).

Bump version to 0.29.2

Tue, Apr 16, 08:58

Fabien accepted D15767: [chronik.e.cash] Docs site for chronik.

rebase for ci re-run

Tue, Apr 16, 07:55

Fabien requested review of D15988: Bump version to 0.29.2.

Tue, Apr 16, 07:50

Mon, Apr 15

Fabien closed D15978: [explorer] Massage column priority in the address history.

Mon, Apr 15, 19:36

Fabien committed rABC047b48968199: [explorer] Massage column priority in the address history (authored by Fabien).

[explorer] Massage column priority in the address history

Mon, Apr 15, 19:36

Fabien closed D15977: [explorer] Show finalization status in the transaction page.

Mon, Apr 15, 19:35

Fabien committed rABC7f4ebeccd2f3: [explorer] Show finalization status in the transaction page (authored by Fabien).

[explorer] Show finalization status in the transaction page

Mon, Apr 15, 19:35

Fabien closed D15976: [explorer] Show the finalization status in the block page.

Mon, Apr 15, 19:35

Fabien committed rABC13deb63962b7: [explorer] Show the finalization status in the block page (authored by Fabien).

[explorer] Show the finalization status in the block page

Mon, Apr 15, 19:35

Fabien closed D15975: [explorer] Show invalid token txs as such.

Mon, Apr 15, 19:34

Fabien committed rABCf845d6cbdbcd: [explorer] Show invalid token txs as such (authored by Fabien).

[explorer] Show invalid token txs as such

Mon, Apr 15, 19:34

Fabien requested changes to D15767: [chronik.e.cash] Docs site for chronik.

Minor things, it's getting there

Mon, Apr 15, 19:23

Fabien accepted D15979: test: Combine sync_send_with_ping and sync_with_ping.

Mon, Apr 15, 19:09

Fabien requested review of D15978: [explorer] Massage column priority in the address history.

Mon, Apr 15, 14:26

Fabien requested review of D15977: [explorer] Show finalization status in the transaction page.

Mon, Apr 15, 14:25

Fabien requested review of D15976: [explorer] Show the finalization status in the block page.

Mon, Apr 15, 14:25

Fabien requested review of D15975: [explorer] Show invalid token txs as such.

Mon, Apr 15, 14:24

Sat, Apr 13

Fabien closed D15965: [explorer] Show block finalization on blocks page.

Sat, Apr 13, 10:12

Fabien committed rABC4ded4d52b68f: [explorer] Show block finalization on blocks page (authored by Fabien).

[explorer] Show block finalization on blocks page

Sat, Apr 13, 10:12

Fri, Apr 12

Fabien added inline comments to D15921: [Chronik] Add LOKAD ID index.

Fri, Apr 12, 19:53

Fabien added inline comments to D15921: [Chronik] Add LOKAD ID index.

Fri, Apr 12, 19:18

Fabien updated the summary of D15965: [explorer] Show block finalization on blocks page.

Fri, Apr 12, 19:12

Fabien accepted D15964: [e.cash] Remove uneeded halving banner.

Fri, Apr 12, 17:45

Fabien updated the diff for D15965: [explorer] Show block finalization on blocks page.

Rebase

Fri, Apr 12, 17:22

Fabien added a comment to D15964: [e.cash] Remove uneeded halving banner.

@bot preview-e.cash

Fri, Apr 12, 17:22

Fabien closed D15930: [explorer] Switch to new chronik.

Fri, Apr 12, 17:20

Fabien committed rABC42f15d7e8a7e: [explorer] Switch to new chronik (authored by Fabien).

[explorer] Switch to new chronik

Fri, Apr 12, 17:20

Fabien requested review of D15965: [explorer] Show block finalization on blocks page.

Fri, Apr 12, 15:45

Fabien updated the diff for D15930: [explorer] Switch to new chronik.

CamelCasify the snake_casified js function

Fri, Apr 12, 15:32

Fabien requested changes to D15921: [Chronik] Add LOKAD ID index.

Fri, Apr 12, 14:09

Fabien accepted D15961: Faster -reindex by initially deserializing only headers.

Fri, Apr 12, 14:00

Fabien accepted D15960: util: add CBufferedFile::SkipTo() to move ahead in the stream.

Fri, Apr 12, 13:55

Fabien accepted D15959: Add LoadExternalBlockFile() benchmark.

Fri, Apr 12, 13:45

Fabien closed D15962: [explorer] Simplify JsonToken.

Fri, Apr 12, 13:43

Fabien committed rABCdde4f83cd5d0: [explorer] Simplify JsonToken (authored by Fabien).

[explorer] Simplify JsonToken

Fri, Apr 12, 13:43

Fabien published D15930: [explorer] Switch to new chronik for review.

Fri, Apr 12, 13:39