Page MenuHomePhabricator

Fabien (Fabien)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (9 w, 4 d)

Recent Activity

Today

Fabien requested changes to D2189: Remove redundant connect_nodes call in abc-parkedchain.py.
Thu, Dec 13, 16:06
Fabien requested changes to D2188: Added abc-sync-chain test to ensure node doesn't seize while syncing many blocks.
Thu, Dec 13, 14:56

Tue, Dec 11

Fabien requested changes to D2169: [secp256k1] Implement Schnorr signatures.
Tue, Dec 11, 20:16
Fabien accepted D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.
Tue, Dec 11, 08:02

Mon, Dec 10

Fabien updated the diff for D2009: Add test for signrawtransaction.

Rebase

Mon, Dec 10, 16:04
Fabien updated the diff for D2008: Change signrawtransaction to signrawtransactionwithwallet in tests.

Rebase

Mon, Dec 10, 16:03
Fabien updated the diff for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Resume locking "twice" cs_main, avoiding signrawtransactionwithwallet deadlock

Mon, Dec 10, 15:12
Fabien requested review of D2008: Change signrawtransaction to signrawtransactionwithwallet in tests.

Request review again since now contains the "deprecatedrpc=signrawtransaction" removal from D2184

Mon, Dec 10, 08:29
Fabien accepted D2185: Use the variable name _ for unused return values.
Mon, Dec 10, 08:25

Sun, Dec 9

Fabien updated the diff for D2009: Add test for signrawtransaction.

Rebase

Sun, Dec 9, 21:05
Fabien updated the diff for D2008: Change signrawtransaction to signrawtransactionwithwallet in tests.

Rebase

Sun, Dec 9, 20:59
Fabien updated the diff for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Rebase

Sun, Dec 9, 20:56
Fabien updated the diff for D2184: Prepare functional tests for deprecation of signrawtransaction rpc.

Add missing deprecated arg on node restart

Sun, Dec 9, 20:55
Fabien updated the diff for D2009: Add test for signrawtransaction.

Rebase

Sun, Dec 9, 20:45
Fabien updated the summary of D2008: Change signrawtransaction to signrawtransactionwithwallet in tests.
Sun, Dec 9, 20:45
Fabien updated the diff for D2008: Change signrawtransaction to signrawtransactionwithwallet in tests.

Rebase

Sun, Dec 9, 20:43
Fabien added a parent revision for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet: D2184: Prepare functional tests for deprecation of signrawtransaction rpc.
Sun, Dec 9, 20:32
Fabien added a child revision for D2184: Prepare functional tests for deprecation of signrawtransaction rpc: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Sun, Dec 9, 20:32
Fabien updated the diff for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Rebase on top of D2184, avoid breaking tests

Sun, Dec 9, 20:32
Herald added a reviewer for D2184: Prepare functional tests for deprecation of signrawtransaction rpc: deadalnix.
Sun, Dec 9, 20:29

Fri, Dec 7

Fabien requested changes to D2169: [secp256k1] Implement Schnorr signatures.
Fri, Dec 7, 22:26
Fabien committed rABC7e1857a25075: [wallet] Remove Wallet dependencies from init.cpp (authored by John Newbery <john@johnnewbery.com>).
[wallet] Remove Wallet dependencies from init.cpp
Fri, Dec 7, 21:02
Fabien closed D2181: [wallet] Remove Wallet dependencies from init.cpp.
Fri, Dec 7, 21:01
Fabien committed rABCe90de6eb79bc: [wallet] Clarify wallet initialization / destruction interface (authored by John Newbery <john@johnnewbery.com>).
[wallet] Clarify wallet initialization / destruction interface
Fri, Dec 7, 20:53
Fabien closed D2180: [wallet] Clarify wallet initialization / destruction interface.
Fri, Dec 7, 20:52
Fabien committed rABC7cc44b87c1f3: Fix undefined behaviour errors due to long int overflow in Amount (authored by Fabien).
Fix undefined behaviour errors due to long int overflow in Amount
Fri, Dec 7, 20:52
Fabien closed D2179: Fix undefined behaviour errors due to long int overflow in Amount.
Fri, Dec 7, 20:51
Fabien added inline comments to D2181: [wallet] Remove Wallet dependencies from init.cpp.
Fri, Dec 7, 20:45
Fabien updated the diff for D2181: [wallet] Remove Wallet dependencies from init.cpp.

Fix comment layout

Fri, Dec 7, 20:45
Herald added a reviewer for D2181: [wallet] Remove Wallet dependencies from init.cpp: deadalnix.
Fri, Dec 7, 15:52
Fabien added a child revision for D2180: [wallet] Clarify wallet initialization / destruction interface: D2181: [wallet] Remove Wallet dependencies from init.cpp.
Fri, Dec 7, 15:52
Herald added a reviewer for D2180: [wallet] Clarify wallet initialization / destruction interface: deadalnix.
Fri, Dec 7, 15:15
Herald added a reviewer for D2179: Fix undefined behaviour errors due to long int overflow in Amount: deadalnix.
Fri, Dec 7, 14:53

Thu, Dec 6

Fabien committed rABC3ceb48399f8c: Make bip68-112-113-p2p.py conform to magnetic anomaly (authored by Fabien).
Make bip68-112-113-p2p.py conform to magnetic anomaly
Thu, Dec 6, 21:09
Fabien closed D2177: Make bip68-112-113-p2p.py conform to magnetic anomaly.
Thu, Dec 6, 21:09
Fabien committed rABC002b8d9fbfff: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p (authored by Fabien).
Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p
Thu, Dec 6, 21:03
Fabien closed D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Thu, Dec 6, 21:02
Fabien committed rABC0890051f4081: Add new test cases to abc-finalize-.py (authored by Fabien).
Add new test cases to abc-finalize-.py
Thu, Dec 6, 20:29
Fabien closed D2162: Add new test cases to abc-finalize-.py.
Thu, Dec 6, 20:28
Fabien updated the diff for D2162: Add new test cases to abc-finalize-.py.

Update assertion

Thu, Dec 6, 20:17
Fabien updated the diff for D2162: Add new test cases to abc-finalize-.py.

Address feedbacks

Thu, Dec 6, 19:43
Fabien added inline comments to D2162: Add new test cases to abc-finalize-.py.
Thu, Dec 6, 19:37
Fabien requested changes to D1894: Added RPCCommand base classes in preparation for RPC migration.
Thu, Dec 6, 18:00
Fabien added a comment to D1894: Added RPCCommand base classes in preparation for RPC migration.

One small change, looks good otherwise

Thu, Dec 6, 17:59
Fabien requested changes to D2169: [secp256k1] Implement Schnorr signatures.
Thu, Dec 6, 16:46
Fabien accepted D2166: Remove unused variables and/or function calls.
Thu, Dec 6, 08:17
Fabien accepted D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs.
Thu, Dec 6, 07:32

Wed, Dec 5

Fabien updated the diff for D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.

Update create_test_block_spend_utxos to make it less confusing regarding tip height

Wed, Dec 5, 20:10
Fabien accepted D1979: [qt] Multiwallet support for GUI (Core PR12610).
Wed, Dec 5, 16:44

Tue, Dec 4

Fabien requested changes to D1979: [qt] Multiwallet support for GUI (Core PR12610).

Otherwise LGTM

Tue, Dec 4, 22:05
Fabien requested changes to D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.
Tue, Dec 4, 21:46
Fabien added inline comments to D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Tue, Dec 4, 20:43
Fabien updated the diff for D2162: Add new test cases to abc-finalize-.py.

Rebase

Tue, Dec 4, 17:30
Fabien committed rABCa51d18fc5566: Prevent auto-finalization from moving backward the finalization point (authored by Fabien).
Prevent auto-finalization from moving backward the finalization point
Tue, Dec 4, 17:00
Fabien closed D2161: Prevent auto-finalization from moving backward the finalization point.
Tue, Dec 4, 16:59
Fabien updated the diff for D2161: Prevent auto-finalization from moving backward the finalization point.

Rebase

Tue, Dec 4, 16:46
Fabien updated the summary of D2162: Add new test cases to abc-finalize-.py.
Tue, Dec 4, 16:28
Fabien updated the diff for D2162: Add new test cases to abc-finalize-.py.

Update as per review

Tue, Dec 4, 16:23
Herald added a reviewer for D2177: Make bip68-112-113-p2p.py conform to magnetic anomaly: deadalnix.
Tue, Dec 4, 15:47
Fabien added a child revision for D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p: D2177: Make bip68-112-113-p2p.py conform to magnetic anomaly.
Tue, Dec 4, 15:47
Fabien updated the diff for D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.

Remove debug mods in interpreter.cpp

Tue, Dec 4, 15:32
Herald added a reviewer for D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p: deadalnix.
Tue, Dec 4, 15:30
Fabien added a child revision for D2146: Fix some nits in bip68-112-113-p2p.py: D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Tue, Dec 4, 15:30

Mon, Dec 3

Fabien committed rABC2334ca69a82f: Defaults block index received time to 0 when init from a block header (authored by Fabien).
Defaults block index received time to 0 when init from a block header
Mon, Dec 3, 18:33
Fabien closed D2131: Defaults block index received time to 0 when init from a block header.
Mon, Dec 3, 18:32
Fabien committed rABCf5d4f4eab53d: Fix abc-finalize-block.py header propagation issue (authored by Fabien).
Fix abc-finalize-block.py header propagation issue
Mon, Dec 3, 18:23
Fabien closed D2130: Fix abc-finalize-block.py header propagation issue.
Mon, Dec 3, 18:23
Fabien updated the diff for D2009: Add test for signrawtransaction.

Rebase

Mon, Dec 3, 17:51
Fabien updated the diff for D2008: Change signrawtransaction to signrawtransactionwithwallet in tests.

Rebase

Mon, Dec 3, 17:50
Fabien updated the diff for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Rebase

Mon, Dec 3, 17:50
Fabien accepted D2148: [avalanche] Use black magic for popcount..
Mon, Dec 3, 14:32

Sun, Dec 2

Fabien updated the diff for D2161: Prevent auto-finalization from moving backward the finalization point.

Add an assertion

Sun, Dec 2, 22:28
Fabien added inline comments to D2161: Prevent auto-finalization from moving backward the finalization point.
Sun, Dec 2, 22:22
Fabien updated the diff for D2162: Add new test cases to abc-finalize-.py.

Rebase

Sun, Dec 2, 21:43
Fabien updated the diff for D2161: Prevent auto-finalization from moving backward the finalization point.

Update as per review

Sun, Dec 2, 21:39
Fabien updated the diff for D2161: Prevent auto-finalization from moving backward the finalization point.

Rebase

Sun, Dec 2, 21:26
Fabien updated the diff for D2130: Fix abc-finalize-block.py header propagation issue.

Update bad comment

Sun, Dec 2, 00:56

Sat, Dec 1

Fabien requested changes to D2148: [avalanche] Use black magic for popcount..

There is a build warning in the popcount algo

Sat, Dec 1, 13:58
Fabien accepted D2148: [avalanche] Use black magic for popcount..
Sat, Dec 1, 12:30

Fri, Nov 30

Fabien removed a child revision for D2130: Fix abc-finalize-block.py header propagation issue: Unknown Object (Differential Revision).
Fri, Nov 30, 22:16
Fabien added a child revision for D2162: Add new test cases to abc-finalize-.py: Unknown Object (Differential Revision).
Fri, Nov 30, 22:16
Fabien committed rSTAGING3bb7c6c992ee: Fix some nits in bip68-112-113-p2p.py (authored by Fabien).
Fix some nits in bip68-112-113-p2p.py
Fri, Nov 30, 21:34
Fabien committed rSTAGING3031ed6fed5f: [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly (authored by Fabien).
[qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly
Fri, Nov 30, 21:34
Fabien committed rSTAGINGa1f16b44e6ba: Move CLTV from scriptSig to scriptPubKey in bip65-cltv-p2p.py (authored by Fabien).
Move CLTV from scriptSig to scriptPubKey in bip65-cltv-p2p.py
Fri, Nov 30, 21:34
Fabien committed rSTAGING6725d3a0f515: Fix nits in bip65-cltv-p2p.py (authored by Fabien).
Fix nits in bip65-cltv-p2p.py
Fri, Nov 30, 21:33
Fabien committed rSTAGING146234984563: [rpc] add getfinalizedblockhash to return the current finalized block (authored by schancel).
[rpc] add getfinalizedblockhash to return the current finalized block
Fri, Nov 30, 21:33
Fabien committed rSTAGING3d981bc03584: Finish conversion of rpc to use pushKV (authored by schancel).
Finish conversion of rpc to use pushKV
Fri, Nov 30, 21:33
Fabien committed rSTAGINGb9bb910e7b12: Fix a bug with duplicate logging (authored by Fabien).
Fix a bug with duplicate logging
Fri, Nov 30, 21:31
Fabien committed rSTAGINGc70157147763: Fix functional test --help raising an exception (authored by Fabien).
Fix functional test --help raising an exception
Fri, Nov 30, 21:31
Fabien committed rSTAGING3262fe453f1e: Correct addrman logging (authored by Fabien).
Correct addrman logging
Fri, Nov 30, 21:31
Fabien committed rSTAGING1570008cf96d: Fix missing argument in requestedInitialize signal for bitcoin-qt (authored by Fabien).
Fix missing argument in requestedInitialize signal for bitcoin-qt
Fri, Nov 30, 21:31
Fabien committed rSTAGING143beb53dbcf: Update man page for 0.18.3 (authored by Fabien).
Update man page for 0.18.3
Fri, Nov 30, 21:30
Fabien updated the diff for D2162: Add new test cases to abc-finalize-.py.

Remove assertions against block height and rebase

Fri, Nov 30, 21:02
Fabien updated the diff for D2161: Prevent auto-finalization from moving backward the finalization point.

Rebase

Fri, Nov 30, 20:45
Fabien updated the diff for D2130: Fix abc-finalize-block.py header propagation issue.

Update assertion message

Fri, Nov 30, 20:37
Fabien updated the diff for D2161: Prevent auto-finalization from moving backward the finalization point.

Update as per review

Fri, Nov 30, 20:30
Herald added a reviewer for D2162: Add new test cases to abc-finalize-.py: Restricted Project.
Fri, Nov 30, 17:41
Fabien added a child revision for D2161: Prevent auto-finalization from moving backward the finalization point: D2162: Add new test cases to abc-finalize-.py.
Fri, Nov 30, 17:41
Fabien updated the diff for D2161: Prevent auto-finalization from moving backward the finalization point.

Update functional test to be in accordance with the new behavior

Fri, Nov 30, 17:11
Fabien updated the diff for D2130: Fix abc-finalize-block.py header propagation issue.

Add missing assertion

Fri, Nov 30, 16:47