Page MenuHomePhabricator

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (294 w, 1 d)
Roles
Administrator
Slack Username
Fabien

Recent Activity

Yesterday

Fabien closed D16222: Bump version to 0.29.5.
Mon, May 27, 08:32
Fabien committed rABCda3768cf9394: Bump version to 0.29.5 (authored by Fabien).
Bump version to 0.29.5
Mon, May 27, 08:32
Fabien requested review of D16222: Bump version to 0.29.5.
Mon, May 27, 08:23
Fabien requested changes to D16219: [Chronik] Plugins: Load plugins based on plugins.toml in datadir.
Mon, May 27, 08:11
Fabien requested changes to D16171: [ecash-herald, mock-chronik-client, alias-server] Migrate ecash-herald to in-node chronik-client and add supporting mock-chronik-client methods.

I'm not sure about the finalization thing, being time dependent looks like a bad idea as you will always get false positives/negatives.

I suggest you don't handle finalization at all in this diff, so you get feature parity with the nng version, and add the finalization in follow up diffs.

I think the justification for keeping it in is that we would learn more about the blockchain. even with this type of failure, it still improves the herald as an always-on push-notification blockchain monitoring service.

Say we get some blocks that connect and do finalize, but it takes 12s, mb this happens every 500 blocks. Would be useful to learn that, useful to check these blocks out and see if anything interesting caused this.

Mb 1 in 3000 blocks connects and does finalize, but it takes 30s. Would also be interesting to learn this.

Since the failure mode here is bad (but investigatable) msgs, I think it's more a value add than a performance issue.

Mon, May 27, 07:29

Fri, May 24

Fabien requested changes to D16190: [Cashtab] Implement ecash-lib for tx building.
Fri, May 24, 15:24
Fabien requested changes to D16171: [ecash-herald, mock-chronik-client, alias-server] Migrate ecash-herald to in-node chronik-client and add supporting mock-chronik-client methods.

I'm not sure about the finalization thing, being time dependent looks like a bad idea as you will always get false positives/negatives.

Fri, May 24, 14:45
Fabien added a comment to D16217: refactor: Move system from util to common library.

@bot build-chronik

Fri, May 24, 13:04
Fabien accepted D16217: refactor: Move system from util to common library.
Fri, May 24, 13:04
Fabien accepted D16216: Output license info when binaries are passed -version.
Fri, May 24, 12:30
Fabien accepted D16215: refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp.
Fri, May 24, 12:27
Fabien accepted D16214: refactor: Split util::AnyPtr into its own file.
Fri, May 24, 12:25
Fabien accepted D16213: refactor: Split util::insert into its own file.
Fri, May 24, 12:07

Thu, May 23

Fabien accepted D16209: util: Replace non-threadsafe strerror.
Thu, May 23, 17:10
Fabien accepted D16212: [cmake] define STRERROR_R_CHAR_P.
Thu, May 23, 17:10
Fabien accepted D16206: kernel: Add progress method to notifications.
Thu, May 23, 17:09
Fabien accepted D16210: util: Refactor SysErrorString logic.
Thu, May 23, 13:53
Fabien requested changes to D16209: util: Replace non-threadsafe strerror.
Thu, May 23, 13:52
Fabien accepted D16208: refactor: Move ScheduleBatchPriority to its own file.
Thu, May 23, 13:47
Fabien accepted D16207: kernel: Add warning method to notifications.
Thu, May 23, 13:46
Fabien requested changes to D16206: kernel: Add progress method to notifications.
Thu, May 23, 13:45
Fabien accepted D16205: kernel: Add headerTip method to notifications.
Thu, May 23, 13:40
Fabien accepted D16204: kernel: Add notification interface.
Thu, May 23, 13:39
Fabien accepted D16202: move-only: Extract common/args and common/config.cpp from util/system.
Thu, May 23, 07:37
Fabien accepted D16203: add missing includes and remove unneeded ones.
Thu, May 23, 07:18
Fabien added a comment to D16203: add missing includes and remove unneeded ones.

We should try to get a iwyu linter at some point. It can be integrated into cmake iirc

Thu, May 23, 07:17

Wed, May 22

Fabien requested changes to D16202: move-only: Extract common/args and common/config.cpp from util/system.

There seem to be a lot of include changes that are not the 2 impacted files and could be split apart. This is a big diff and this makes the review much more difficult

Wed, May 22, 14:31
Fabien requested changes to D16190: [Cashtab] Implement ecash-lib for tx building.

This is hard to understand what the diff really does. E.g. why all the txs are changed ? Why isn't the bitgo dependency removed ? Is this a complete conversion or only partial ?

Wed, May 22, 08:25
Fabien accepted D16201: util, refactor: Drop explicit conversion to fs::path.
Wed, May 22, 07:59
Fabien accepted D16200: util, refactor: Use GetPathArg to read "-rpccookiefile" value.
Wed, May 22, 07:57
Fabien accepted D16199: util, refactor: Use GetPathArg to read "-conf" value.
Wed, May 22, 07:15
Fabien closed D16198: Don't use a PeerManager for the net group limit test.
Wed, May 22, 06:32
Fabien committed rABCe5dabdb0689a: Don't use a PeerManager for the net group limit test (authored by Fabien).
Don't use a PeerManager for the net group limit test
Wed, May 22, 06:32

Tue, May 21

Fabien accepted D16197: [Cashtab] Remove copypasta mock from integration test.
Tue, May 21, 21:46
Fabien added a comment to D16196: [ecash-lib] Add validation to confirm user input param feePerKb is an integer.

This is the wrong approach imo, ecash-lib should accept floating points or use sat/kB instead

Tue, May 21, 20:13
Fabien requested review of D16198: Don't use a PeerManager for the net group limit test.
Tue, May 21, 20:10
Fabien accepted D16195: refactor: Stop using gArgs global in system.cpp.
Tue, May 21, 15:46
Fabien retitled D16195: refactor: Stop using gArgs global in system.cpp from refactor: Stop using gArgs global in system.cpp# This is a combination of 2 commits. to refactor: Stop using gArgs global in system.cpp.
Tue, May 21, 15:43
Fabien accepted D16193: util: make GetDataDir read-only & create datadir only in bitcoind and bitcoin-qt.
Tue, May 21, 15:43
Fabien closed D16194: [chronik] Wait for the correct tip finalization in chronik_ws_ordering.
Tue, May 21, 14:40
Fabien committed rABC44d71a2036b2: [chronik] Wait for the correct tip finalization in chronik_ws_ordering (authored by Fabien).
[chronik] Wait for the correct tip finalization in chronik_ws_ordering
Tue, May 21, 14:40
Fabien closed D16191: Consistently delete nodes at the end of the net tests.
Tue, May 21, 14:38
Fabien committed rABC5bf917094e3d: Consistently delete nodes at the end of the net tests (authored by Fabien).
Consistently delete nodes at the end of the net tests
Tue, May 21, 14:38
Fabien requested changes to D16193: util: make GetDataDir read-only & create datadir only in bitcoind and bitcoin-qt.
Tue, May 21, 14:36
Fabien accepted D16192: gui: Prompt to reset settings when settings.json cannot be read.
Tue, May 21, 14:28
Fabien accepted D16184: refactor: Move functions to BlockManager methods.
Tue, May 21, 14:22
Fabien published D16191: Consistently delete nodes at the end of the net tests for review.
Tue, May 21, 14:18
Fabien requested review of D16194: [chronik] Wait for the correct tip finalization in chronik_ws_ordering.
Tue, May 21, 14:18
teamcity awarded D16191: Consistently delete nodes at the end of the net tests a Haypence token.
Tue, May 21, 13:57
Fabien requested changes to D16184: refactor: Move functions to BlockManager methods.
Tue, May 21, 08:40
Fabien accepted D16189: fix check-crates target.
Tue, May 21, 07:53
Fabien closed D16181: [avalanche] Improve logging on staking reward.
Tue, May 21, 07:10
Fabien committed rABCc94b7e9bf14f: [avalanche] Improve logging on staking reward (authored by Fabien).
[avalanche] Improve logging on staking reward
Tue, May 21, 07:10

Mon, May 20

Fabien accepted D16187: refactor, blockstorage: Replace stopafterblockimport arg.
Mon, May 20, 11:25
Fabien accepted D16186: refactor, blockstorage: Replace blocksdir arg.
Mon, May 20, 11:23
Fabien accepted D16185: refactor, BlockManager: Replace fastprune from arg with options.
Mon, May 20, 11:21
Fabien requested changes to D16184: refactor: Move functions to BlockManager methods.

Back to your queue

Mon, May 20, 11:16
Fabien accepted D16183: zmq: Pass lambda to zmq's ZMQPublishRawBlockNotifier.
Mon, May 20, 11:15
Fabien accepted D16182: refactor: Declare g_zmq_notification_interface as unique_ptr.
Mon, May 20, 11:12
Fabien accepted D16178: Use PoolAllocator for CCoinsMap.
Mon, May 20, 08:27
Fabien accepted D16177: Call ReallocateCache() on each Flush().
Mon, May 20, 08:19
Fabien accepted D16176: Calculate memory usage correctly for unordered_maps that use PoolAllocator.
Mon, May 20, 08:18
Fabien accepted D16175: Add pool based memory resource & allocator.
Mon, May 20, 08:15
Fabien requested review of D16181: [avalanche] Improve logging on staking reward.
Mon, May 20, 07:12

Fri, May 17

Fabien accepted D16174: Add simulation-based CCoinsViewCache fuzzer.
Fri, May 17, 12:16
Fabien accepted D16180: util: improve streams.h:FindByte() performance.
Fri, May 17, 09:42
Fabien accepted D16179: [bench] add streams findbyte.
Fri, May 17, 09:37
Fabien requested changes to D16174: Add simulation-based CCoinsViewCache fuzzer.
Fri, May 17, 09:36

Thu, May 16

Fabien closed D16173: Replace May 15, 2024 activation with Nov 15.
Thu, May 16, 10:28
Fabien committed rABC4faa4923ec82: Replace May 15, 2024 activation with Nov 15 (authored by Fabien).
Replace May 15, 2024 activation with Nov 15
Thu, May 16, 10:28
Fabien accepted D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.
Thu, May 16, 10:27
Fabien requested review of D16173: Replace May 15, 2024 activation with Nov 15.
Thu, May 16, 09:26
Fabien requested changes to D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.

now you know :)

Thu, May 16, 08:19
Fabien accepted D16162: coins: add Sync() method to allow flush without cacheCoins drop.
Thu, May 16, 08:11
Fabien accepted D16161: test: refactor: clarify the coins simulation.
Thu, May 16, 07:59
Fabien added a comment to D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.

@bot build-linux32 build-linux-arm build-linux-aarch64

Thu, May 16, 07:57

Wed, May 15

Fabien accepted D16169: [token server + chronik-client + mock-chronik-client + ecash-herald] Remove legacy Dockerfile(s).
Wed, May 15, 19:07
Fabien accepted D16170: [ecash-lib] Update CI to also build ecashaddrjs now that chronik-client pulls this from the monorepo.
Wed, May 15, 18:56
Fabien closed D16168: Add a checkpoint after the May 15 2024 upgrade.
Wed, May 15, 14:58
Fabien committed rABC9b6e6fe6eb5f: Add a checkpoint after the May 15 2024 upgrade (authored by Fabien).
Add a checkpoint after the May 15 2024 upgrade
Wed, May 15, 14:58
Fabien accepted D16167: [e.cash] Remove unused upgrade countdown.
Wed, May 15, 14:43
teamcity awarded D16168: Add a checkpoint after the May 15 2024 upgrade a Haypence token.
Wed, May 15, 14:38
Fabien added a comment to D16168: Add a checkpoint after the May 15 2024 upgrade.

@bot build-ibd

Wed, May 15, 14:38
Fabien updated the diff for D16168: Add a checkpoint after the May 15 2024 upgrade.

Fix testnet height, hash was correct

Wed, May 15, 14:28
Fabien requested review of D16168: Add a checkpoint after the May 15 2024 upgrade.
Wed, May 15, 13:59
Fabien accepted D16166: [e.cash] Mark upgrade complete in navbar.
Wed, May 15, 13:32
Fabien accepted D16164: [ecash-herald] Finish deprecating unused API.
Wed, May 15, 13:30
Fabien closed D16165: [website] Show upgrade completed.
Wed, May 15, 13:29
Fabien committed rABCWEBfc5cc5cd33f0: [website] Show upgrade completed (authored by Fabien).
[website] Show upgrade completed
Wed, May 15, 13:29
Fabien requested review of D16165: [website] Show upgrade completed.
Wed, May 15, 13:25
Fabien accepted D16163: [e.cash] Update upgrade page for completed upgrade - 2024-05-15.
Wed, May 15, 13:11
Fabien accepted D16155: Move random test util code from setup_common to random.
Wed, May 15, 11:46
Fabien accepted D16154: refactor: Move fs.* to util/fs.*.
Wed, May 15, 11:39
Fabien accepted D16153: Add missing includes in assumptions.h and chainstate.cpp.
Wed, May 15, 07:44
Fabien accepted D16134: [chronik-client]+[alias-server]+[examples] Use local dep instead of npm.
Wed, May 15, 07:43

Tue, May 14

Fabien accepted D16152: misc fixes for file syncing.
Tue, May 14, 09:22
Fabien added a comment to D16152: misc fixes for file syncing.

@bot build-win64 build-linux64 build-osx

Tue, May 14, 08:12
Fabien accepted D16151: refactor: Extract util/fs_helpers from util/system.
Tue, May 14, 08:09
Fabien accepted D16150: refactor: Move error() from util/system.h to logging.h.
Tue, May 14, 08:04
Fabien accepted D16149: refactor: Extract util/exception from util/system.
Tue, May 14, 07:59