Page MenuHomePhabricator
Feed Advanced Search

Today

Fabien committed rABC04cf5437c814: [CI] Improve teamcity error reporting by setting the failure message (authored by Fabien).
[CI] Improve teamcity error reporting by setting the failure message
Sat, Jul 4, 07:34
Fabien closed D6817: [CI] Improve teamcity error reporting by setting the failure message.
Sat, Jul 4, 07:34

Yesterday

Fabien added a comment to D6817: [CI] Improve teamcity error reporting by setting the failure message.

Examples of rendering:
Success: https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=91213&guest=1
And failure: https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=91243&guest=1

Fri, Jul 3, 21:34
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:25
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Fri, Jul 3, 21:24
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

Don't keep the original message in case of a failure

Fri, Jul 3, 21:24
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

Deduplicate the status message

Fri, Jul 3, 21:15
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:12
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Fri, Jul 3, 21:11
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Fri, Jul 3, 21:06
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.
  • Actually write to the log BEFORE publishing the artifacts...
  • Override the build status message in case of a failure
Fri, Jul 3, 21:06
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 20:46
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Fri, Jul 3, 20:45
Fabien planned changes to D6817: [CI] Improve teamcity error reporting by setting the failure message.
Fri, Jul 3, 20:41
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

flash => flush

Fri, Jul 3, 20:41
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

Sync to make sure the build logs are complete before aborting

Fri, Jul 3, 20:40
Fabien planned changes to D6817: [CI] Improve teamcity error reporting by setting the failure message.
Fri, Jul 3, 20:37
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 20:26
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase on top of D6817 to see failure messages

Fri, Jul 3, 20:26
Fabien requested review of D6817: [CI] Improve teamcity error reporting by setting the failure message.
Fri, Jul 3, 20:11
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Fri, Jul 3, 19:24
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Fri, Jul 3, 18:49
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 18:47
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Make it fail

Fri, Jul 3, 18:46
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

@bot build-tsan

Fri, Jul 3, 18:29
Fabien planned changes to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

Talked to @jasonbcox and the server will be upgraded to more memory

Fri, Jul 3, 17:55
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

The stress test is still running full capacity on all other tests, and when running with TSAN we are especially looking for deadlocks rather than performance issues.
The point still stands, this patch was a solution I can leverage by myself to work around the issue now but I will look at if/how we can increase the machines capacity.

Fri, Jul 3, 07:43
Fabien updated the diff for D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

Pass by reference

Fri, Jul 3, 07:35
Fabien accepted D6810: [avalanche] Bail when selecting a peer fails too many times.
Fri, Jul 3, 07:22
Fabien requested changes to D6799: [land-bot] Pass committer name/email to land bot endpoint.
Fri, Jul 3, 07:19

Thu, Jul 2

Fabien updated the diff for D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

Move the test argument decalaration where it belongs

Thu, Jul 2, 10:01
Fabien accepted D6808: [website] Add upgrade instructions.
Thu, Jul 2, 08:54
Fabien accepted D6805: Cleanup leftover phononactivationtime option.
Thu, Jul 2, 08:50
Fabien accepted D6804: [backport#16415] Get rid of PendingWalletTx class..
Thu, Jul 2, 08:49
Fabien accepted D6802: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction.
Thu, Jul 2, 08:45
Fabien accepted D6800: [backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before success.
Thu, Jul 2, 08:42

Wed, Jul 1

Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

https://build.bitcoinabc.org/viewLog.html?buildId=90008&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=buildResultsDiv&guest=1 completed successfully

Wed, Jul 1, 13:45
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

The above comment will trigger a build failure, don't take it into account.

Wed, Jul 1, 13:40
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

@bot build-tsan

Wed, Jul 1, 13:40
Fabien requested review of D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.
Wed, Jul 1, 13:19
Fabien accepted D6797: Cleanup unused --with-phononactivation from test_framework.
Wed, Jul 1, 07:00
Fabien accepted D6796: Cleanup phonon activation in functional tests.
Wed, Jul 1, 06:59

Tue, Jun 30

Fabien accepted D6710: [backport#15492] [rpc] remove deprecated generate method.
Tue, Jun 30, 19:51
Fabien accepted D6786: [avalanche] Early bail when no matchign slot exists.
Tue, Jun 30, 14:30
Fabien committed rABCbab969716d1a: Add an exception for the TSAN lock-order-inversion on reverselock_tests (authored by Fabien).
Add an exception for the TSAN lock-order-inversion on reverselock_tests
Tue, Jun 30, 13:58
Fabien closed D6785: Add an exception for the TSAN lock-order-inversion on reverselock_tests.
Tue, Jun 30, 13:58
Fabien committed rABCe0649a4bc593: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout (authored by Fabien).
Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout
Tue, Jun 30, 13:57
Fabien closed D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.
Tue, Jun 30, 13:57
Fabien added a comment to D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.

The bot build ran from master, there is a bug there

Tue, Jun 30, 09:35
Fabien requested review of D6785: Add an exception for the TSAN lock-order-inversion on reverselock_tests.
Tue, Jun 30, 08:56
Fabien added a comment to D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.

@bot build-ubsan

Tue, Jun 30, 08:55
Fabien added a comment to D6775: [avalanche] separate avalanche.{h|cpp} into more relevent files.

Can you rename the UBSAN exception accordingly ? See D6784

Tue, Jun 30, 08:41
Fabien requested review of D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.
Tue, Jun 30, 08:37
Fabien accepted D6779: [avalanche] Build Slot using start and score rather than start/stop.
Tue, Jun 30, 08:16
Fabien accepted D6778: [avalanche] Track slots as start+score rather than start/stop.
Tue, Jun 30, 08:14
Fabien accepted D6777: [avalanche] Abstract the Slot infos so that layout can be changed easily.
Tue, Jun 30, 08:12
Fabien accepted D6775: [avalanche] separate avalanche.{h|cpp} into more relevent files.
Tue, Jun 30, 08:09
Fabien added inline comments to D6783: Fix out-of-bounds index in Avalanche PeerManager.
Tue, Jun 30, 08:07

Mon, Jun 29

Fabien committed rABCdbf3ab2a2f44: [CI] Log sanitizers output to stdout instead of log files (authored by Fabien).
[CI] Log sanitizers output to stdout instead of log files
Mon, Jun 29, 16:16
Fabien closed D6767: [CI] Log sanitizers output to stdout instead of log files.
Mon, Jun 29, 16:15
Fabien added inline comments to D6767: [CI] Log sanitizers output to stdout instead of log files.
Mon, Jun 29, 16:04
Fabien committed rABC90aaf20e54cf: Move NodeContext from TestingSetup to BasicTestingSetup (authored by Fabien).
Move NodeContext from TestingSetup to BasicTestingSetup
Mon, Jun 29, 15:52
Fabien closed D6766: Move NodeContext from TestingSetup to BasicTestingSetup.
Mon, Jun 29, 15:52
Fabien requested review of D6767: [CI] Log sanitizers output to stdout instead of log files.
Mon, Jun 29, 15:50
Fabien requested review of D6766: Move NodeContext from TestingSetup to BasicTestingSetup.
Mon, Jun 29, 14:52
Fabien committed rABCb23802b86950: test: Check that wait_until returns if time point is in the past (authored by MarcoFalke <falke.marco@gmail.com>).
test: Check that wait_until returns if time point is in the past
Mon, Jun 29, 13:08
Fabien closed D6765: test: Check that wait_until returns if time point is in the past.
Mon, Jun 29, 13:08
Fabien committed rABCed2f9c673fdd: refactor: Make scheduler methods type safe (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Make scheduler methods type safe
Mon, Jun 29, 13:07
Fabien closed D6764: refactor: Make scheduler methods type safe.
Mon, Jun 29, 13:07
Fabien committed rABCd4da1816a80c: [CI] Run the check target instead of a list of subtargets (authored by Fabien).
[CI] Run the check target instead of a list of subtargets
Mon, Jun 29, 13:04
Fabien closed D6763: [CI] Run the check target instead of a list of subtargets.
Mon, Jun 29, 13:04
Fabien requested review of D6765: test: Check that wait_until returns if time point is in the past.
Mon, Jun 29, 12:18
Fabien updated the diff for D6764: refactor: Make scheduler methods type safe.

Relayout the usage comment

Mon, Jun 29, 12:13
Fabien updated the diff for D6763: [CI] Run the check target instead of a list of subtargets.

Rebase

Mon, Jun 29, 11:38
Fabien requested review of D6764: refactor: Make scheduler methods type safe.
Mon, Jun 29, 11:34
Fabien accepted D6760: [seeder] Use testutil library in seeder tests.
Mon, Jun 29, 11:20
Fabien added a comment to D6760: [seeder] Use testutil library in seeder tests.

If you rebase on top of D6763 you only have a single occurrence of the seeder target remaining in contrib/teamcity/builds/build-osx.sh

Mon, Jun 29, 07:31
Fabien requested review of D6763: [CI] Run the check target instead of a list of subtargets.
Mon, Jun 29, 07:28
Fabien accepted D6762: Move minimum boost version to 1.59.
Mon, Jun 29, 06:53
Fabien accepted D6761: Move avalanche in its own folder.
Mon, Jun 29, 06:48
Fabien requested changes to D6760: [seeder] Use testutil library in seeder tests.

Please keep the targets renaming for another diff as there are some places where this needs to be updated as well.

Mon, Jun 29, 06:39
Fabien accepted D6741: [backport#17076] tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions.
Mon, Jun 29, 06:30

Sat, Jun 27

Fabien accepted D6758: Remove dead checkpoint test.
Sat, Jun 27, 16:14
Fabien committed rABC99069046cb0c: [CI] Fix wrong configuration when there is no template (authored by Fabien).
[CI] Fix wrong configuration when there is no template
Sat, Jun 27, 12:42
Fabien closed D6757: [CI] Fix wrong configuration when there is no template.
Sat, Jun 27, 12:42
Fabien requested review of D6757: [CI] Fix wrong configuration when there is no template.
Sat, Jun 27, 07:20
Fabien accepted D6744: [linter] add exceptions to include guards and file name linters.

Only nits

Sat, Jun 27, 06:53
Fabien accepted D6753: [CI] Increase stream buffer limit for build subprocess.

More context: the bash traces are echoing a list of the valid targets, as it checks for validity when a list is passed to build_with_cmake. This list has no line break and causes the overflow.

Sat, Jun 27, 06:48
Fabien accepted D6752: Bump version to 0.21.11.
Sat, Jun 27, 06:43

Fri, Jun 26

Fabien committed rABC2786c2432edf: [CI] Refactor the build by making it a class (authored by Fabien).
[CI] Refactor the build by making it a class
Fri, Jun 26, 20:01
Fabien closed D6750: [CI] Refactor the build by making it a class.
Fri, Jun 26, 20:01
Fabien committed rABC8b79d85a6f40: [CI] Make the build configuration a class (authored by Fabien).
[CI] Make the build configuration a class
Fri, Jun 26, 19:59
Fabien closed D6749: [CI] Make the build configuration a class.
Fri, Jun 26, 19:59
Fabien committed rABC0d2341bee658: [CI] Filter what is printed to the console and log it to files (authored by Fabien).
[CI] Filter what is printed to the console and log it to files
Fri, Jun 26, 19:58
Fabien closed D6748: [CI] Filter what is printed to the console and log it to files.
Fri, Jun 26, 19:58
Fabien committed rABCe23422471d46: [CI] Manage the build artifacts from the configuration (authored by Fabien).
[CI] Manage the build artifacts from the configuration
Fri, Jun 26, 19:58
Fabien closed D6735: [CI] Manage the build artifacts from the configuration.
Fri, Jun 26, 19:57
Fabien requested review of D6751: [CMAKE] Run the leveldb tests serially.

Setting the job pool for custom targets is only possible with cmake >= 3.15 and we enforce cmake >= 3.13 (debian 10 default): https://gitlab.kitware.com/cmake/cmake/-/merge_requests/3308.
Note that due to the wrapper, USES_TERMINAL will not dump the test to the console unless there is a failure. It's still not equivalent to a dedicated pool but close enough.

Fri, Jun 26, 19:20
Fabien requested review of D6751: [CMAKE] Run the leveldb tests serially.
Fri, Jun 26, 19:10
Fabien requested review of D6750: [CI] Refactor the build by making it a class.
Fri, Jun 26, 14:54