Page MenuHomePhabricator
Feed Advanced Search

Today

Fabien requested changes to D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.
Thu, Apr 25, 17:52
Fabien committed rABC1f126a0b8f42: [DOC] Add headers inclusion guidelines to the developer notes (authored by Fabien).
[DOC] Add headers inclusion guidelines to the developer notes
Thu, Apr 25, 17:49
Fabien closed D2877: [DOC] Add headers inclusion guidelines to the developer notes.
Thu, Apr 25, 17:49
Fabien requested changes to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Thu, Apr 25, 17:49
Fabien updated the diff for D2877: [DOC] Add headers inclusion guidelines to the developer notes.

Update as per feedbacks

Thu, Apr 25, 17:33
Herald added a reviewer for D2877: [DOC] Add headers inclusion guidelines to the developer notes: deadalnix.
Thu, Apr 25, 16:26
Fabien committed rABCd97910652534: Use angle bracket in include for wallet test (authored by Fabien).
Use angle bracket in include for wallet test
Thu, Apr 25, 15:43
Fabien closed D2870: Use angle bracket in include for wallet test.
Thu, Apr 25, 15:43
Fabien updated the diff for D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

Move to the root CMakeLists.txt

Thu, Apr 25, 09:31
Fabien requested changes to D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Thu, Apr 25, 09:09
Fabien requested changes to D2867: blockfilter: add block filters.
Thu, Apr 25, 08:57
Fabien requested changes to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Thu, Apr 25, 08:06
Fabien accepted D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().
Thu, Apr 25, 06:30
Fabien accepted D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked().
Thu, Apr 25, 06:29
Fabien committed rABCefd894165c01: Use angle bracket in include for seeder (authored by Fabien).
Use angle bracket in include for seeder
Thu, Apr 25, 06:25
Fabien closed D2868: Use angle bracket in include for seeder.
Thu, Apr 25, 06:25
Fabien committed rABCf05e34fccfe8: Use angle bracket in include for wallet (authored by Fabien).
Use angle bracket in include for wallet
Thu, Apr 25, 06:25
Fabien closed D2869: Use angle bracket in include for wallet.
Thu, Apr 25, 06:24

Yesterday

Fabien requested review of D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Wed, Apr 24, 20:22
Fabien added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

From the cmake mailing list, this tends to confirm that this property has no impact outside of a windows build: https://cmake.org/pipermail/cmake/2008-March/020577.html

Wed, Apr 24, 16:07
Fabien requested changes to D2846: Do not allow users to get keys from keypool without reserving them.

If -deprecatedrpc=fundrawtransaction is set and the reserveChangeKey option is true, you end up removing the key twice.

Wed, Apr 24, 16:04
Fabien added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

Link to the doc: https://cmake.org/cmake/help/v3.10/prop_tgt/WIN32_EXECUTABLE.html#prop_tgt:WIN32_EXECUTABLE

Wed, Apr 24, 14:24
Fabien requested review of D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Wed, Apr 24, 13:46
Fabien updated the diff for D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

I discovered by chance that cmake targets have a property which does exactly the same
(setting the exact same flag) in a more cmake fashion way.
This property has no impact if the build is not a windows executable, so no need to
make it explicitely windows only.

Wed, Apr 24, 13:46
Fabien added inline comments to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Wed, Apr 24, 13:00
Fabien added inline comments to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Wed, Apr 24, 12:43
Fabien updated the diff for D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.

Fix bugs in the contrib/convert-prl-libs-to-cmake.pl. This allows for
converting the windows plugin prl script rather than manually linking
the dependencies.

Wed, Apr 24, 12:39

Tue, Apr 23

Fabien updated the diff for D2870: Use angle bracket in include for wallet test.

Rebase

Tue, Apr 23, 10:20
Fabien added inline comments to D2869: Use angle bracket in include for wallet.
Tue, Apr 23, 10:18
Fabien updated the diff for D2869: Use angle bracket in include for wallet.

Add an include in coincontrol.h that would make wallet tests to fail compiling due to include reordering.

Tue, Apr 23, 10:16
Fabien planned changes to D2870: Use angle bracket in include for wallet test.
Tue, Apr 23, 08:35
Fabien updated the summary of D2870: Use angle bracket in include for wallet test.
Tue, Apr 23, 08:09
Fabien updated the diff for D2870: Use angle bracket in include for wallet test.

Depends on D2869

Tue, Apr 23, 08:09
Fabien updated the diff for D2869: Use angle bracket in include for wallet.

Attempt to upload missing files to the diff, no idea what is happening

Tue, Apr 23, 08:07
Herald added a reviewer for D2870: Use angle bracket in include for wallet test: deadalnix.
Tue, Apr 23, 07:39
Herald added a reviewer for D2869: Use angle bracket in include for wallet: deadalnix.
Tue, Apr 23, 07:33
Herald added a reviewer for D2868: Use angle bracket in include for seeder: deadalnix.
Tue, Apr 23, 07:20
Fabien accepted D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Tue, Apr 23, 06:04

Mon, Apr 22

Fabien committed rABC197f49b2017b: Use angle bracket in include for src (part 6) (authored by Fabien).
Use angle bracket in include for src (part 6)
Mon, Apr 22, 19:24
Fabien closed D2860: Use angle bracket in include for src (part 6).
Mon, Apr 22, 19:24
Fabien committed rABC93704c28de90: Use angle bracket in include for src (part 5) (authored by Fabien).
Use angle bracket in include for src (part 5)
Mon, Apr 22, 19:24
Fabien closed D2859: Use angle bracket in include for src (part 5).
Mon, Apr 22, 19:23
Fabien committed rABCb90665491704: Use angle bracket in include for src (part 4) (authored by Fabien).
Use angle bracket in include for src (part 4)
Mon, Apr 22, 19:23
Fabien closed D2858: Use angle bracket in include for src (part 4).
Mon, Apr 22, 19:23
Fabien committed rABCd96e9c6f3e05: Use angle bracket in include for src (part 3) (authored by Fabien).
Use angle bracket in include for src (part 3)
Mon, Apr 22, 19:22
Fabien closed D2857: Use angle bracket in include for src (part 3).
Mon, Apr 22, 19:22
Fabien committed rABCaaa8336c306e: Use angle bracket in include for src (part 2) (authored by Fabien).
Use angle bracket in include for src (part 2)
Mon, Apr 22, 19:22
Fabien closed D2856: Use angle bracket in include for src (part 2).
Mon, Apr 22, 19:22
Fabien committed rABC7696d55089f2: Use angle bracket in include for src (part 1) (authored by Fabien).
Use angle bracket in include for src (part 1)
Mon, Apr 22, 19:21
Fabien closed D2855: Use angle bracket in include for src (part 1).
Mon, Apr 22, 19:21
Fabien committed rABCec9f94e30f87: Use angle bracket in include for test (part 5) (authored by Fabien).
Use angle bracket in include for test (part 5)
Mon, Apr 22, 19:20
Fabien closed D2849: Use angle bracket in include for test (part 5).
Mon, Apr 22, 19:20
Fabien updated the diff for D2858: Use angle bracket in include for src (part 4).

Add missing newlines

Mon, Apr 22, 18:27
Fabien updated the diff for D2855: Use angle bracket in include for src (part 1).

Add missing newlines

Mon, Apr 22, 18:16
Fabien updated the diff for D2860: Use angle bracket in include for src (part 6).

Fix ordering

Mon, Apr 22, 18:10
Fabien updated the diff for D2859: Use angle bracket in include for src (part 5).

Fix ordering

Mon, Apr 22, 18:04
Fabien updated the diff for D2857: Use angle bracket in include for src (part 3).

Fix ordering + missing copyright

Mon, Apr 22, 17:52
Fabien updated the diff for D2855: Use angle bracket in include for src (part 1).

Fix ordering

Mon, Apr 22, 17:16
Fabien accepted D2861: Bump version number to 0.19.5.
Mon, Apr 22, 16:39
Fabien requested review of D2849: Use angle bracket in include for test (part 5).
Mon, Apr 22, 15:23
Herald added a reviewer for D2860: Use angle bracket in include for src (part 6): deadalnix.
Mon, Apr 22, 13:07
Herald added a reviewer for D2859: Use angle bracket in include for src (part 5): deadalnix.
Mon, Apr 22, 12:58
Herald added a reviewer for D2858: Use angle bracket in include for src (part 4): deadalnix.
Mon, Apr 22, 12:51
Herald added a reviewer for D2857: Use angle bracket in include for src (part 3): deadalnix.
Mon, Apr 22, 12:46
Herald added a reviewer for D2856: Use angle bracket in include for src (part 2): deadalnix.
Mon, Apr 22, 12:25
Herald added a reviewer for D2855: Use angle bracket in include for src (part 1): deadalnix.
Mon, Apr 22, 11:45
Fabien requested changes to D2846: Do not allow users to get keys from keypool without reserving them.

You can add a deprecatedrpc=fundrawtransaction option to allow users to transition between the versions.

Mon, Apr 22, 11:12
Fabien accepted D2845: Remove direct bitcoin calls from qt/rpcconsole.cpp.
Mon, Apr 22, 11:08

Sun, Apr 21

Fabien accepted D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Sun, Apr 21, 19:55
Fabien accepted D2847: Fix typos..
Sun, Apr 21, 18:52
Fabien committed rABCd845e0192322: Use angle bracket in include for zmq (authored by Fabien).
Use angle bracket in include for zmq
Sun, Apr 21, 08:48
Fabien closed D2850: Use angle bracket in include for zmq.
Sun, Apr 21, 08:48
Fabien committed rABC29c2cb313bff: Use angle bracket in include for test (part 4) (authored by Fabien).
Use angle bracket in include for test (part 4)
Sun, Apr 21, 08:47
Fabien closed D2848: Use angle bracket in include for test (part 4).
Sun, Apr 21, 08:47
Fabien accepted D2827: Added missing notes to release notes.
Sun, Apr 21, 07:27

Sat, Apr 20

Herald added a reviewer for D2850: Use angle bracket in include for zmq: deadalnix.
Sat, Apr 20, 14:13
Herald added a reviewer for D2849: Use angle bracket in include for test (part 5): deadalnix.
Sat, Apr 20, 14:06
Herald added a reviewer for D2848: Use angle bracket in include for test (part 4): deadalnix.
Sat, Apr 20, 13:47
Fabien accepted D2457: [schnorr] Refactor the signature process in reusable component.
Sat, Apr 20, 13:30
Fabien accepted D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.
Sat, Apr 20, 13:23
Fabien accepted D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Sat, Apr 20, 13:18
Fabien accepted D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Sat, Apr 20, 13:10
Fabien requested changes to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Sat, Apr 20, 12:51
Fabien requested changes to D2847: Fix typos..
Sat, Apr 20, 12:37
Fabien committed rABC4fd606d524f0: Use angle bracket in include for test (part 3) (authored by Fabien).
Use angle bracket in include for test (part 3)
Sat, Apr 20, 12:33
Fabien closed D2843: Use angle bracket in include for test (part 3).
Sat, Apr 20, 12:33

Fri, Apr 19

Herald added a reviewer for D2843: Use angle bracket in include for test (part 3): deadalnix.
Fri, Apr 19, 20:33
Fabien committed rABCcbfb55891ca1: Use angle bracket in include for tests (part 2) (authored by Fabien).
Use angle bracket in include for tests (part 2)
Fri, Apr 19, 20:15
Fabien closed D2841: Use angle bracket in include for tests (part 2).
Fri, Apr 19, 20:15
Fabien committed rABCa8a53a7b5169: Use angle bracket in include for tests (part 1) (authored by Fabien).
Use angle bracket in include for tests (part 1)
Fri, Apr 19, 20:14
Fabien closed D2839: Use angle bracket in include for tests (part 1).
Fri, Apr 19, 20:14
Fabien committed rABC1c0046c661dc: Use angle bracket in include for support (authored by Fabien).
Use angle bracket in include for support
Fri, Apr 19, 20:13
Fabien closed D2838: Use angle bracket in include for support.
Fri, Apr 19, 20:13
Fabien committed rABC131ab5a19d99: Use angle bracket in include for script (authored by Fabien).
Use angle bracket in include for script
Fri, Apr 19, 20:12
Fabien closed D2837: Use angle bracket in include for script.
Fri, Apr 19, 20:12
Fabien committed rABC5d290ad42391: Use angle bracket in include for rpc (authored by Fabien).
Use angle bracket in include for rpc
Fri, Apr 19, 20:10
Fabien closed D2836: Use angle bracket in include for rpc.
Fri, Apr 19, 20:10
Fabien accepted D2842: build: Move interfaces/* to libbitcoin_server.
Fri, Apr 19, 20:08
Fabien committed rABC0b3542cedf56: Use angle bracket in include for primitives (authored by Fabien).
Use angle bracket in include for primitives
Fri, Apr 19, 19:51
Fabien closed D2835: Use angle bracket in include for primitives.
Fri, Apr 19, 19:51