Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Yesterday

Fabien requested review of D17185: [chronik] Create a new optional JSON RPC interface.
Fri, Nov 22, 16:24
Fabien added inline comments to D17180: [ecash-herald] Add staker info to block msgs.
Fri, Nov 22, 09:18

Thu, Nov 21

Fabien accepted D17179: [guix] Use CMake's PROJECT_NAME for source package.
Thu, Nov 21, 19:40
Fabien accepted D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.
Thu, Nov 21, 17:00
Fabien added a comment to D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.

@bot guix-linux

Thu, Nov 21, 13:53

Wed, Nov 20

Fabien accepted D17169: [arclint] Fix arc lint for Cashtab.
Wed, Nov 20, 14:40
Fabien added inline comments to D17169: [arclint] Fix arc lint for Cashtab.
Wed, Nov 20, 14:33
Fabien closed D17166: [chronik-docs] Fix a wrong link in the websocket documentation.
Wed, Nov 20, 12:10
Fabien committed rABC7805d72b0caa: [chronik-docs] Fix a wrong link in the websocket documentation (authored by Fabien).
[chronik-docs] Fix a wrong link in the websocket documentation
Wed, Nov 20, 12:10
Fabien requested review of D17166: [chronik-docs] Fix a wrong link in the websocket documentation.
Wed, Nov 20, 10:19
Fabien accepted D17155: [CHRONIK] add is_final to tx struct in util.rs.
Wed, Nov 20, 08:52
Fabien closed D17162: [CI] Fix previews.
Wed, Nov 20, 08:44
Fabien committed rABCd866e5203822: [CI] Fix previews (authored by Fabien).
[CI] Fix previews
Wed, Nov 20, 08:44
Fabien accepted D17163: [avalanche] Do not modify the chaintip in stake contender test.
Wed, Nov 20, 08:43

Tue, Nov 19

Fabien requested changes to D17163: [avalanche] Do not modify the chaintip in stake contender test.
Tue, Nov 19, 21:11
Fabien requested review of D17162: [CI] Fix previews.
Tue, Nov 19, 20:21
Fabien added a comment to D17143: [cashtab] Hide balance button style edits.

@bot preview-cashtab

Tue, Nov 19, 20:02
Fabien accepted D17138: Rework receive buffer pushback.
Tue, Nov 19, 14:21

Mon, Nov 18

Fabien requested changes to D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation.

See comment in D17138

Mon, Nov 18, 19:50
Fabien requested changes to D17138: Rework receive buffer pushback.

Can you please squash D17139 ? I don't think it makes sense to have the bugfix and the test be separate diffs.

Mon, Nov 18, 19:49
Fabien accepted D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.
Mon, Nov 18, 19:34
Fabien accepted D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test.
Mon, Nov 18, 19:31
Fabien accepted D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.
Mon, Nov 18, 10:09
Fabien accepted D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
Mon, Nov 18, 10:08
Fabien accepted D17151: Use std::string_view throughout util strencodings/string.
Mon, Nov 18, 10:08
Fabien accepted D17150: Make DecodeBase{32,64} take string_view arguments.
Mon, Nov 18, 10:00
Fabien requested changes to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
Mon, Nov 18, 09:53
Fabien accepted D17148: Make strencodings functions use string_view.
Mon, Nov 18, 09:34
Fabien accepted D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).
Mon, Nov 18, 09:16
Fabien requested changes to D17155: [CHRONIK] add is_final to tx struct in util.rs.

When you add a new feature like this you need to also add a test for the new feature so you demonstrate that it works as expected.
You can look at the functional tests in test/functional/chronik_*.py for test examples, and most likely you can extend one of the existing test instead of creating a new one.

Mon, Nov 18, 08:42
Fabien accepted D17121: [avalanche] Add stake contender polling.
Mon, Nov 18, 08:31

Fri, Nov 15

Fabien closed D17145: [website] Update the upgrade page after the November 15 2024 activation.
Fri, Nov 15, 20:21
Fabien committed rABCWEB1ab101d83133: [website] Update the upgrade page after the November 15 2024 activation (authored by Fabien).
[website] Update the upgrade page after the November 15 2024 activation
Fri, Nov 15, 20:21 · Restricted Project
Fabien requested review of D17145: [website] Update the upgrade page after the November 15 2024 activation.
Fri, Nov 15, 20:18
Fabien requested changes to D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.
Fri, Nov 15, 18:14
Fabien closed D17142: Add checkpoints after the November 2024 upgrade.
Fri, Nov 15, 17:46
Fabien committed rABC6aa479fa6861: Add checkpoints after the November 2024 upgrade (authored by Fabien).
Add checkpoints after the November 2024 upgrade
Fri, Nov 15, 17:46
teamcity awarded D17142: Add checkpoints after the November 2024 upgrade a Haypence token.
Fri, Nov 15, 14:39
Fabien added a comment to D17142: Add checkpoints after the November 2024 upgrade.

@bot build-ibd

Fri, Nov 15, 14:38
Fabien requested review of D17142: Add checkpoints after the November 2024 upgrade.
Fri, Nov 15, 14:21
Fabien accepted D17141: [e.cash] Mark upgrade as complete - 2024-11-15.
Fri, Nov 15, 13:56

Thu, Nov 14

Fabien accepted D17131: net: use Sock in CNode.
Thu, Nov 14, 14:07
Fabien accepted D17137: fuzz: Add fuzzing harness for Socks5(...).
Thu, Nov 14, 14:05
Fabien added inline comments to D17137: fuzz: Add fuzzing harness for Socks5(...).
Thu, Nov 14, 13:43
Fabien added a comment to D17131: net: use Sock in CNode.
In D17131#388836, @PiRK wrote:

rebase onto D17137 which fixes the fuzzer

Thu, Nov 14, 13:18
Fabien requested changes to D17137: fuzz: Add fuzzing harness for Socks5(...).

I think the backports are not correct for this diff, none of the netbase changes are from the listed commits afaict

Thu, Nov 14, 13:17
Fabien accepted D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().
Thu, Nov 14, 09:04
Fabien accepted D17133: net: introduce Sock::WaitMany().
Thu, Nov 14, 08:48
Fabien accepted D17132: net: also wait for exceptional events in Sock::Wait().
Thu, Nov 14, 08:29
Fabien requested changes to D17121: [avalanche] Add stake contender polling.
Thu, Nov 14, 08:23

Wed, Nov 13

Fabien requested changes to D17121: [avalanche] Add stake contender polling.
Wed, Nov 13, 09:03

Tue, Nov 12

Fabien accepted D17117: [avalanche] Add manual stake winners to the contender cache.
Tue, Nov 12, 20:23
Fabien added a comment to D17117: [avalanche] Add manual stake winners to the contender cache.

@bot build-tsan

Tue, Nov 12, 19:41
Fabien accepted D17115: test: add option to speed up tx relay/mempool sync.
Tue, Nov 12, 16:22
Fabien requested changes to D17115: test: add option to speed up tx relay/mempool sync.
Tue, Nov 12, 15:41
Fabien added a comment to D17115: test: add option to speed up tx relay/mempool sync.

please include the mining_getblocktemplate_longpoll.py from D17113

Tue, Nov 12, 15:40
Fabien accepted D17114: p2p: Allow whitelisting manual connections.
Tue, Nov 12, 15:39
Fabien accepted D17110: net: Add CNodeOptions and increase constness.
Tue, Nov 12, 15:38
Fabien closed D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.
Tue, Nov 12, 15:26
Fabien committed rABC88af2bfac785: Improve test coverage of the getblocktemplate longpoll feature with avalanche (authored by Fabien).
Improve test coverage of the getblocktemplate longpoll feature with avalanche
Tue, Nov 12, 15:26
Fabien added inline comments to D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.
Tue, Nov 12, 15:26
Fabien requested changes to D17115: test: add option to speed up tx relay/mempool sync.

You should go through the abc tests also. I use this a lot to speed up proof relay in tests

Tue, Nov 12, 14:41
Fabien requested changes to D17114: p2p: Allow whitelisting manual connections.
Tue, Nov 12, 14:39
Fabien accepted D17112: Bump version to 0.30.5.
Tue, Nov 12, 14:06
Fabien accepted D17111: scripted-diff: net: rename permissionFlags to permission_flags.
Tue, Nov 12, 14:05
Fabien requested changes to D17110: net: Add CNodeOptions and increase constness.

The commits are not the correct ones

Tue, Nov 12, 14:02
Fabien accepted D17109: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection.
Tue, Nov 12, 13:53
Fabien requested review of D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.
Tue, Nov 12, 13:41

Mon, Nov 11

Fabien accepted D17105: util: implement noexcept move assignment & move ctor for prevector.
Mon, Nov 11, 13:15

Sat, Nov 9

Fabien accepted D17104: [e.cash] Add link to Hearbeat article on upgrade page.
Sat, Nov 9, 17:07

Thu, Nov 7

Fabien accepted D17098: [ecash-herald] Parse blocks from miner eastpool.
Thu, Nov 7, 20:20
Fabien accepted D17090: [Cashtab] Improve flakiness in orderbook tests.
Thu, Nov 7, 08:42
Fabien accepted D17088: [ecash-herald] parse new miner westpool.
Thu, Nov 7, 08:40

Wed, Nov 6

Fabien closed D17086: [CI] Disable chronik plugins in the release.
Wed, Nov 6, 12:39
Fabien committed rABCeccc5241ca91: [CI] Disable chronik plugins in the release (authored by Fabien).
[CI] Disable chronik plugins in the release
Wed, Nov 6, 12:39
Fabien requested review of D17086: [CI] Disable chronik plugins in the release.
Wed, Nov 6, 12:34
Fabien committed rABC559395ebdfe9: Add a release note for the parralel compact block download (authored by Fabien).
Add a release note for the parralel compact block download
Wed, Nov 6, 11:05
Fabien closed D17082: Parallel compact block downloads, take 3.
Wed, Nov 6, 08:48
Fabien committed rABC21a89c2d5e73: Parallel compact block downloads, take 3 (authored by Fabien).
Parallel compact block downloads, take 3
Wed, Nov 6, 08:48
Fabien added inline comments to D17082: Parallel compact block downloads, take 3.
Wed, Nov 6, 08:47

Tue, Nov 5

Fabien requested review of D17082: Parallel compact block downloads, take 3.
Tue, Nov 5, 21:21
Fabien closed D17071: [avalanche] Cleanup the logs.
Tue, Nov 5, 19:23
Fabien committed rABC00ed23b33c12: [avalanche] Cleanup the logs (authored by Fabien).
[avalanche] Cleanup the logs
Tue, Nov 5, 19:23
Fabien closed D17076: [avalanche] Fix the getavaaddr functional test.
Tue, Nov 5, 15:23
Fabien committed rABC7a0c2cf9ec4a: [avalanche] Fix the getavaaddr functional test (authored by Fabien).
[avalanche] Fix the getavaaddr functional test
Tue, Nov 5, 15:22
Fabien updated the summary of D17037: [chronik] index scripts by scripthashes in the mempool.
Tue, Nov 5, 13:26
Fabien updated the diff for D17071: [avalanche] Cleanup the logs.

Make sure the spam is processed after sending, otherwise it can be processed after the mocktime is increased and cause the getavaaddr test to fail.

Tue, Nov 5, 08:30

Mon, Nov 4

Fabien accepted D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Mon, Nov 4, 21:26
Fabien updated the summary of D17071: [avalanche] Cleanup the logs.
Mon, Nov 4, 21:15
Fabien updated the diff for D17071: [avalanche] Cleanup the logs.

Rebase on top of D17076 to fix the test

Mon, Nov 4, 21:15
Fabien updated the diff for D17076: [avalanche] Fix the getavaaddr functional test.

Uncomment tests

Mon, Nov 4, 21:11
Fabien planned changes to D17076: [avalanche] Fix the getavaaddr functional test.
Mon, Nov 4, 21:09
Fabien requested review of D17076: [avalanche] Fix the getavaaddr functional test.
Mon, Nov 4, 21:08
Fabien added a comment to D17071: [avalanche] Cleanup the logs.

I will split out the test fix

Mon, Nov 4, 19:28
Fabien closed D17068: [avalanche] Always print the finalization messages.
Mon, Nov 4, 19:26
Fabien committed rABC5e91e0989f8b: [avalanche] Always print the finalization messages (authored by Fabien).
[avalanche] Always print the finalization messages
Mon, Nov 4, 19:26
Fabien requested review of D17071: [avalanche] Cleanup the logs.
Mon, Nov 4, 16:35
Fabien closed D17070: [CI] Fix the wasm build in the container.
Mon, Nov 4, 15:33
Fabien committed rABC600fa4f562d8: [CI] Fix the wasm build in the container (authored by Fabien).
[CI] Fix the wasm build in the container
Mon, Nov 4, 15:33
Fabien requested review of D17070: [CI] Fix the wasm build in the container.
Mon, Nov 4, 15:14
Next