Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Fabien updated the summary of D2557: Add a linter to detect python % format and convert them to use .format().
Mon, Feb 18, 21:06
Fabien updated the diff for D2557: Add a linter to detect python % format and convert them to use .format().

More special cases handling:

  • Allow nested formatting in functions, lists or dictionaries
  • Allow multiple formatting on a single line
  • Handle special cases for %i (no longer exist), %s (more strict behavior), %d, %r and %-
  • Replace %% with %
Mon, Feb 18, 21:06
Fabien planned changes to D2557: Add a linter to detect python % format and convert them to use .format().

The second limitation is an important part of the use case. It needs to be handled correctly.

Mon, Feb 18, 11:53
Fabien updated the diff for D2558: Integrates the python format linter with arcanist.

Rtrim the original content in arcanist message.
Under some circumstance arcanist would also replace the line break,
resulting in 2 lines being merged.

Mon, Feb 18, 11:02
Fabien updated the diff for D2557: Add a linter to detect python % format and convert them to use .format().

Found another limitation, add a commented test case in the txt file to reflect it

Mon, Feb 18, 10:54
Fabien updated the summary of D2557: Add a linter to detect python % format and convert them to use .format().
Mon, Feb 18, 10:45
Fabien updated the summary of D2557: Add a linter to detect python % format and convert them to use .format().
Mon, Feb 18, 10:45
Fabien updated the diff for D2557: Add a linter to detect python % format and convert them to use .format().

Add a missing case when line ends with % and is not followed by \

Mon, Feb 18, 09:54

Sat, Feb 16

Herald added a reviewer for D2561: Make --enable-debug to pick better options: deadalnix.
Sat, Feb 16, 15:36
Herald added a reviewer for D2560: Add a test for signrawtransaction with various sighashes parameters: deadalnix.
Sat, Feb 16, 14:09
Fabien updated the diff for D2558: Integrates the python format linter with arcanist.

Remove php closing tag and fix linter exclusion filter in .arclint

Sat, Feb 16, 08:09
Fabien planned changes to D2558: Integrates the python format linter with arcanist.
Sat, Feb 16, 08:08

Fri, Feb 15

Fabien updated the diff for D2558: Integrates the python format linter with arcanist.

Rebase

Fri, Feb 15, 21:06
Fabien updated the diff for D2557: Add a linter to detect python % format and convert them to use .format().

Rebase

Fri, Feb 15, 21:06
Herald added a reviewer for D2558: Integrates the python format linter with arcanist: deadalnix.
Fri, Feb 15, 20:37
Fabien added a child revision for D2557: Add a linter to detect python % format and convert them to use .format(): D2558: Integrates the python format linter with arcanist.
Fri, Feb 15, 20:36
Herald added a reviewer for D2557: Add a linter to detect python % format and convert them to use .format(): deadalnix.
Fri, Feb 15, 20:25
Fabien requested changes to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Fri, Feb 15, 16:06
Fabien accepted D2556: Reset default -g -O2 flags when enable debug.
Fri, Feb 15, 15:35
Fabien accepted D2555: Update timing.json.
Fri, Feb 15, 15:29

Thu, Feb 14

Fabien accepted D2553: BIP32 extra test vector.
Thu, Feb 14, 20:29
Fabien accepted D2483: Schnorr signature activation.
Thu, Feb 14, 20:26
Fabien accepted D2551: Various nits in key.{h|cpp}.
Thu, Feb 14, 15:28
Fabien accepted D2550: Various nit in pubkey.h.
Thu, Feb 14, 15:26
Fabien accepted D2549: Use the correct icon name in bitcoin-qt.desktop.
Thu, Feb 14, 11:40

Wed, Feb 13

Fabien accepted D2544: Improve shutdown process.
Wed, Feb 13, 21:21
Fabien added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Wed, Feb 13, 18:56
Herald added a reviewer for D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit: deadalnix.
Wed, Feb 13, 11:10
Fabien accepted D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee.
Wed, Feb 13, 09:25
Fabien added inline comments to D2483: Schnorr signature activation.
Wed, Feb 13, 09:09
Fabien accepted D2527: Improved mempool handling when changing validation rulesets.
Wed, Feb 13, 08:57

Tue, Feb 12

Fabien accepted D2538: Add Qt tests for wallet spends.
Tue, Feb 12, 20:22
Fabien added inline comments to D2483: Schnorr signature activation.
Tue, Feb 12, 17:32
Fabien requested changes to D2534: [schnorr] Add features to combine public keys in order to do musig..
Tue, Feb 12, 17:11
Fabien accepted D2539: nits in abc-replay-protection.
Tue, Feb 12, 16:27
Fabien requested changes to D2527: Improved mempool handling when changing validation rulesets.
Tue, Feb 12, 15:59
Fabien requested changes to D2483: Schnorr signature activation.

Bunch of nits in the test

Tue, Feb 12, 11:32
Fabien removed parent revisions for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet: D2214: More user-friendly error message when partially signing, D1967: Move transaction combining from signrawtransaction to new RPC.
Tue, Feb 12, 10:02
Fabien removed a child revision for D1967: Move transaction combining from signrawtransaction to new RPC: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Tue, Feb 12, 10:02
Fabien removed a child revision for D2214: More user-friendly error message when partially signing: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Tue, Feb 12, 10:02
Fabien updated the summary of D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Tue, Feb 12, 10:02
Fabien added a child revision for D2214: More user-friendly error message when partially signing: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Tue, Feb 12, 09:44
Fabien updated the diff for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Remove invalid sighash flags from the help messages

Tue, Feb 12, 09:44
Fabien added a child revision for D1967: Move transaction combining from signrawtransaction to new RPC: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Tue, Feb 12, 09:44
Fabien requested changes to D2538: Add Qt tests for wallet spends.

I can see this is a dependency for T417 in the task list but fail to see how they are linked together; is there another intermediate backport that needs to build on top of this one ?

Tue, Feb 12, 08:29
Fabien requested changes to D2508: [tests] nulldummy cleanup.

Could you please rebase on current master ? This will close the discussion regarding ToHex()/FromHex()

Tue, Feb 12, 07:42
Fabien planned changes to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Tue, Feb 12, 07:33

Mon, Feb 11

Fabien accepted D1894: Added RPCCommand base classes in preparation for RPC migration.
Mon, Feb 11, 20:07
Fabien committed rABC0cd9f5e87c81: Use ToHex() in feature_nulldummy.py (authored by Fabien).
Use ToHex() in feature_nulldummy.py
Mon, Feb 11, 18:34
Fabien closed D2537: Use ToHex() in feature_nulldummy.py.
Mon, Feb 11, 18:34
Fabien committed rABC06092e020159: Use ToHex() in rpc_decodescript.py, remove dependency to mininode (authored by Fabien).
Use ToHex() in rpc_decodescript.py, remove dependency to mininode
Mon, Feb 11, 18:33
Fabien closed D2536: Use ToHex() in rpc_decodescript.py, remove dependency to mininode.
Mon, Feb 11, 18:33
Herald added a reviewer for D2537: Use ToHex() in feature_nulldummy.py: deadalnix.
Mon, Feb 11, 13:22
Herald added a reviewer for D2536: Use ToHex() in rpc_decodescript.py, remove dependency to mininode: deadalnix.
Mon, Feb 11, 13:06
Fabien updated the diff for D2009: [Target v0.19] Deprecate and add test for signrawtransaction.

Rebase

Mon, Feb 11, 12:47
Fabien updated the diff for D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.

Rebase

Mon, Feb 11, 12:40
Fabien removed parent revisions for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet: D2214: More user-friendly error message when partially signing, D2184: Prepare functional tests for deprecation of signrawtransaction rpc, D1967: Move transaction combining from signrawtransaction to new RPC.
Mon, Feb 11, 12:23
Fabien removed a child revision for D1967: Move transaction combining from signrawtransaction to new RPC: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Mon, Feb 11, 12:23
Fabien removed a child revision for D2214: More user-friendly error message when partially signing: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Mon, Feb 11, 12:23
Fabien removed a child revision for D2184: Prepare functional tests for deprecation of signrawtransaction rpc: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Mon, Feb 11, 12:23
Fabien updated the summary of D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.
Mon, Feb 11, 12:14
Fabien added a comment to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

@markblundeberg Yes they are

Mon, Feb 11, 12:03
Fabien updated the diff for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Rebase

Mon, Feb 11, 12:02
Fabien requested changes to D2457: [schnorr] Refactor the signature process in reusable component.
Mon, Feb 11, 09:49

Sun, Feb 10

Fabien committed rABCbe1efa0f4f36: Integrate the lint-tests.sh linter into arcanist (authored by Fabien).
Integrate the lint-tests.sh linter into arcanist
Sun, Feb 10, 14:41
Fabien closed D2533: Integrate the lint-tests.sh linter into arcanist.
Sun, Feb 10, 14:40
Fabien added a parent revision for D2518: Add an argument to the test framework to enable great wall activation: D2535: Refactor TestNode arguments management.
Sun, Feb 10, 11:32
Fabien added a child revision for D2535: Refactor TestNode arguments management: D2518: Add an argument to the test framework to enable great wall activation.
Sun, Feb 10, 11:32
Fabien updated the diff for D2518: Add an argument to the test framework to enable great wall activation.

Rebase on top of D2535

Sun, Feb 10, 11:31
Herald added a reviewer for D2535: Refactor TestNode arguments management: deadalnix.
Sun, Feb 10, 11:16
Fabien committed rABCf952a1b9bf84: Add a linter to enfore unit tests file name/boost name match and unicity (authored by practicalswift <practicalswift@users.noreply.github.com>).
Add a linter to enfore unit tests file name/boost name match and unicity
Sun, Feb 10, 09:55
Fabien closed D2532: Add a linter to enfore unit tests file name/boost name match and unicity.
Sun, Feb 10, 09:55
Fabien updated the diff for D2533: Integrate the lint-tests.sh linter into arcanist.

Fix indentation and add space after if

Sun, Feb 10, 09:51
Fabien updated the summary of D2533: Integrate the lint-tests.sh linter into arcanist.
Sun, Feb 10, 09:43
Fabien accepted D2528: Remove dependency on BytesIO in feature_nulldummy.py.
Sun, Feb 10, 09:39
Fabien accepted D2529: Remove BytesIO dependency from feature_dersig.
Sun, Feb 10, 09:38

Sat, Feb 9

Fabien requested changes to D2528: Remove dependency on BytesIO in feature_nulldummy.py.
Sat, Feb 9, 09:05
Fabien requested changes to D2529: Remove BytesIO dependency from feature_dersig.
Sat, Feb 9, 08:59
Fabien accepted D2530: Remove unused function and dependencies from rpc_listtransactions.
Sat, Feb 9, 08:56
Fabien accepted D2531: Removed BytesIO dependency from rpc_decodescript.
Sat, Feb 9, 08:55
Fabien added a child revision for D2532: Add a linter to enfore unit tests file name/boost name match and unicity: D2533: Integrate the lint-tests.sh linter into arcanist.
Sat, Feb 9, 08:51
Herald added a reviewer for D2533: Integrate the lint-tests.sh linter into arcanist: deadalnix.
Sat, Feb 9, 08:51
Herald added a reviewer for D2532: Add a linter to enfore unit tests file name/boost name match and unicity: deadalnix.
Sat, Feb 9, 08:36
Fabien committed rABCb97a82b0f9a8: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check (authored by Fabien).
[CMAKE] Run test/util/bitcoin-util-test.py with ninja check
Sat, Feb 9, 08:23
Fabien closed D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.
Sat, Feb 9, 08:16
Fabien committed rABCa36c8cbcde44: Make the number service of service flag bits to display a constant (authored by Fabien).
Make the number service of service flag bits to display a constant
Sat, Feb 9, 08:13
Fabien closed D2452: Make the number service of service flag bits to display a constant.
Sat, Feb 9, 08:13
Fabien committed rABC5f0755ee358e: Fix name collision in crypto_tests (authored by Fabien).
Fix name collision in crypto_tests
Sat, Feb 9, 08:12
Fabien closed D2519: Fix name collision in crypto_tests.
Sat, Feb 9, 08:11
Fabien committed rABC3c88a99afbe9: Fix trailing ';' in walletdb_tests (authored by Fabien).
Fix trailing ';' in walletdb_tests
Sat, Feb 9, 08:11
Fabien closed D2520: Fix trailing ';' in walletdb_tests.
Sat, Feb 9, 08:11
Fabien committed rABC93a3a1eee9c3: Bump version to v0.19.0 (authored by Fabien).
Bump version to v0.19.0
Sat, Feb 9, 08:10
Fabien closed D2521: Bump version to v0.19.0.
Sat, Feb 9, 08:10

Fri, Feb 8

Fabien requested review of D2452: Make the number service of service flag bits to display a constant.
Fri, Feb 8, 22:57
Fabien planned changes to D2518: Add an argument to the test framework to enable great wall activation.
Fri, Feb 8, 22:42
Herald added a reviewer for D2521: Bump version to v0.19.0: Restricted Project.
Fri, Feb 8, 17:05
Fabien updated the diff for D2518: Add an argument to the test framework to enable great wall activation.

Remove parenthesis

Fri, Feb 8, 16:45
Fabien added inline comments to D2518: Add an argument to the test framework to enable great wall activation.
Fri, Feb 8, 15:11
Fabien updated the summary of D2518: Add an argument to the test framework to enable great wall activation.
Fri, Feb 8, 14:56
Fabien updated the summary of D2519: Fix name collision in crypto_tests.
Fri, Feb 8, 13:07