Please run some sanity checks on bitcoin-qt as part of the test plan.
Fri, Aug 16
One comment, can be saved for a later diff. I'm OK with or without.
Thu, Aug 15
Wed, Aug 14
NVM my previous comment, I missed you pointed this out in the summary.
Tue, Aug 13
Mind backporting the dependency for mining_basic.py ? https://github.com/bitcoin/bitcoin/pull/13399/files
Mon, Aug 12
Assert that the hex string length is even.
Update as per comment.
Add a newline between the TODO and the javadoc comments for better readability.
FreeBSD tests build is OK without this, it should be included by some other dependency.
Sun, Aug 11
Fri, Aug 9
Thu, Aug 8
Some of the tests modified by this diff have their estimated duration > 40s (you can check this from test/functional/timing.json).
Therefore they are not run as part of test_runner.py but are part of the extended tests, requiring the use of test_runner.py --extended to be run.
You need to try it and add it to the test plan once you're sure that the patch did not introduce any regression.