Page MenuHomePhabricator
Feed Advanced Search

Today

Fabien created D3912: Rename “OS X” to the newer “macOS” convention.
Mon, Aug 19, 13:41
Fabien created D3911: doc: add qrencode to brew install instructions.
Mon, Aug 19, 13:19
Fabien created D3910: [docs] initial QT documentation, move Qt Creator instructions.
Mon, Aug 19, 13:12
Fabien created D3909: docs: Update osx brew install instruction.
Mon, Aug 19, 12:43
Fabien created D3908: remove brew c++ flag.
Mon, Aug 19, 12:33
Fabien created D3907: Remove the tested versions from the OSX build guide.
Mon, Aug 19, 12:19
Fabien created D3906: Create dependencies.md, and link it from README & build docs.
Mon, Aug 19, 11:58
Fabien created D3905: Add python3 to list of dependencies on some platforms.
Mon, Aug 19, 09:19
Fabien created D3904: [doc] Minor corrections to osx dependencies.
Mon, Aug 19, 09:13
Fabien requested changes to D3903: Merge #12752: [MOVEONLY] Move compressor utility functions out of class.
Mon, Aug 19, 06:33
Fabien requested changes to D3899: Merge #12779: Qt: Remove unused method setupAmountWidget(...).

Please run some sanity checks on bitcoin-qt as part of the test plan.

Mon, Aug 19, 06:25

Fri, Aug 16

Fabien accepted D3891: Merge #11200: Allow for aborting rescans in the GUI.
Fri, Aug 16, 21:13
Fabien requested changes to D3891: Merge #11200: Allow for aborting rescans in the GUI.
Fri, Aug 16, 08:50
Fabien accepted D3882: Merge #12920: test: Fix sign for expected values.
Fri, Aug 16, 08:33
Fabien accepted D3879: Merge #11353: Small refactor of CCoinsViewCache::BatchWrite().
Fri, Aug 16, 08:11
Fabien accepted D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.
Fri, Aug 16, 08:00
Fabien accepted D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Fri, Aug 16, 07:57
Fabien accepted D3892: Migrated abc-replay-protection off of ComparisonTestFramework.
Fri, Aug 16, 07:56
Fabien accepted D3890: Migrate abc-mempool-accept-txn.py off of ComparisonTestFramework.

One comment, can be saved for a later diff. I'm OK with or without.

Fri, Aug 16, 07:43
Fabien accepted D3878: Read more reject messages from debug logs in feature_cltv.py.
Fri, Aug 16, 07:21
Fabien accepted D3875: Read more reject messages from debug logs in feature_dersig.py.
Fri, Aug 16, 07:19
Fabien accepted D3873: Cleanup reject_code in feature_block.py.
Fri, Aug 16, 07:07

Thu, Aug 15

Fabien accepted D3884: Update chainparams.
Thu, Aug 15, 19:46
Fabien accepted D3886: Update manpages for 0.20.0 release.
Thu, Aug 15, 19:43
Fabien accepted D3883: Update seeds.
Thu, Aug 15, 19:24
Fabien accepted D3881: Added some more release notes for 0.20.0.
Thu, Aug 15, 19:23

Wed, Aug 14

Fabien created D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.
Wed, Aug 14, 12:00
Fabien created D3870: [CMAKE] Allow for building static and shared versions of secp256k1.
Wed, Aug 14, 11:58
Fabien added inline comments to D3197: Make Teamcity agent setup easier.
Wed, Aug 14, 09:30
Fabien committed rABCe6eac5abd906: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file (authored by Fabien).
[CMAKE] Fix typos in the secp256k1 CMakeLists.txt file
Wed, Aug 14, 08:23
Fabien closed D3854: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file.
Wed, Aug 14, 08:23
Fabien accepted D3869: Add upgrade features to release notes.
Wed, Aug 14, 08:21
Fabien accepted D3868: Bump automatic replay protection to May 2020 upgrade.
Wed, Aug 14, 08:21
Fabien accepted D3862: qa: Read reject reasons from debug log, not p2p messages.
Wed, Aug 14, 08:15
Fabien requested changes to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Wed, Aug 14, 08:04
Fabien accepted D3861: Merge #14101: qa: Use named args in validation acceptance tests.

NVM my previous comment, I missed you pointed this out in the summary.

Wed, Aug 14, 07:41
Fabien added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.

@deadalnix Absolutely, sepc256k1 relies on BaseEncoding from the guava dependency which was removed from our codebase by D2681, hence the custom function in D3835.

Wed, Aug 14, 07:39

Tue, Aug 13

Fabien committed rABC82496919fa53: [CMAKE] Make secp256k1 build standalone (authored by Fabien).
[CMAKE] Make secp256k1 build standalone
Tue, Aug 13, 07:57
Fabien closed D3827: [CMAKE] Make secp256k1 build standalone.
Tue, Aug 13, 07:56
Fabien committed rABC36d8a89db509: Fix missing plural form from commit reversal (authored by Fabien).
Fix missing plural form from commit reversal
Tue, Aug 13, 07:56
Fabien closed D3855: Fix missing plural form from commit reversal.
Tue, Aug 13, 07:55
Fabien accepted D3858: Merge #11422: qa: Verify DBWrapper iterators are taking snapshots.
Tue, Aug 13, 07:54
Fabien requested changes to D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.
Tue, Aug 13, 07:49
Fabien accepted D3864: [teamcity/gitian] Do not remove src tarball from results.
Tue, Aug 13, 07:40
Fabien requested changes to D3862: qa: Read reject reasons from debug log, not p2p messages.
Tue, Aug 13, 07:38
Fabien added a comment to D3861: Merge #14101: qa: Use named args in validation acceptance tests.

Mind backporting the dependency for mining_basic.py ? https://github.com/bitcoin/bitcoin/pull/13399/files

Tue, Aug 13, 07:21
Fabien accepted D3860: Merge #14024: qa: Add TestNode::assert_debug_log.
Tue, Aug 13, 07:06
Fabien accepted D3833: Merge #11395: Qt: Enable searching by transaction id.
Tue, Aug 13, 07:01
Fabien accepted D3832: Merge #11015: [Qt] Add delay before filtering transactions.
Tue, Aug 13, 06:57
Fabien added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.

@deadalnix It's already the case, see D2681 or D2755. Also I have D3835 that will take ownership even more, but make your life easier for testing with buster.

Tue, Aug 13, 06:48

Mon, Aug 12

Fabien created D3855: Fix missing plural form from commit reversal.
Mon, Aug 12, 16:12
Fabien created D3854: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file.
Mon, Aug 12, 15:43
Fabien updated the diff for D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.

Assert that the hex string length is even.

Mon, Aug 12, 13:11
Fabien updated the diff for D3834: [TRIVIAL] Cleanup the JNI test file.

Update as per comment.
Add a newline between the TODO and the javadoc comments for better readability.

Mon, Aug 12, 12:53
Fabien accepted D3845: Merge #12447: test: Add missing signal.h header.

FreeBSD tests build is OK without this, it should be included by some other dependency.

Mon, Aug 12, 07:17
Fabien accepted D3848: Merge #11842: [build] Add missing stuff to clean-local.
Mon, Aug 12, 07:00
Fabien accepted D3846: Merge #12489: Bugfix: respect user defined configuration file (-conf) in QT settings.
Mon, Aug 12, 06:58
Fabien accepted D3843: Merge #10036: Fix init README format to render correctly on github.
Mon, Aug 12, 06:39
Fabien accepted D3841: Merge #10085: Docs: remove 'noconnect' option.
Mon, Aug 12, 06:38
Fabien accepted D3840: Merge #9910: Docs: correct and elaborate -rpcbind doc.
Mon, Aug 12, 06:34
Fabien accepted D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".
Mon, Aug 12, 06:11
Fabien accepted D3851: Revert "Bump version to 0.20.0".
Mon, Aug 12, 06:11

Sun, Aug 11

Fabien committed rABCa8e46a60271a: [CMAKE] Avoid duplicating the compiler/linker flags (authored by Fabien).
[CMAKE] Avoid duplicating the compiler/linker flags
Sun, Aug 11, 08:06
Fabien closed D3826: [CMAKE] Avoid duplicating the compiler/linker flags.
Sun, Aug 11, 08:06
Fabien committed rABCc907fdbf9748: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag (authored by Fabien).
[CMAKE] Fix -Wunused-command-line-argument when adding linker flag
Sun, Aug 11, 08:05
Fabien closed D3825: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag.
Sun, Aug 11, 08:05
Fabien committed rABC3584560a4b91: build: avoid getifaddrs when unavailable (authored by Cory Fields <cory-nospam-@coryfields.com>).
build: avoid getifaddrs when unavailable
Sun, Aug 11, 08:03
Fabien closed D3824: build: avoid getifaddrs when unavailable.
Sun, Aug 11, 08:02
Fabien committed rABC1ffdfb7e1271: build: Enable -Wredundant-decls where available (authored by practicalswift <practicalswift@users.noreply.github.com>).
build: Enable -Wredundant-decls where available
Sun, Aug 11, 07:59
Fabien closed D3823: build: Enable -Wredundant-decls where available.
Sun, Aug 11, 07:59

Fri, Aug 9

Fabien updated the test plan for D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.
Fri, Aug 9, 10:49
Fabien created D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.
Fri, Aug 9, 10:46
Fabien created D3834: [TRIVIAL] Cleanup the JNI test file.
Fri, Aug 9, 10:38
Fabien added a comment to D3807: Fix some more copies in loops.

@markblundeberg No need to skip, it's already in: D3795

Fri, Aug 9, 06:59

Thu, Aug 8

Fabien accepted D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
Thu, Aug 8, 20:49
Fabien accepted D3831: Updated manpages for 0.19.12 release.
Thu, Aug 8, 20:12
Fabien accepted D3830: Update chainparams.
Thu, Aug 8, 20:05
Fabien accepted D3805: Merge #12716: Fix typos and cleanup in various files.
Thu, Aug 8, 18:29
Fabien accepted D3828: Added some release notes for 0.19.12 release.
Thu, Aug 8, 18:28
Fabien accepted D3829: Update seeds.
Thu, Aug 8, 18:27
Fabien created D3827: [CMAKE] Make secp256k1 build standalone.
Thu, Aug 8, 14:46
Fabien created D3826: [CMAKE] Avoid duplicating the compiler/linker flags.
Thu, Aug 8, 14:42
Fabien created D3825: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag.
Thu, Aug 8, 14:39
Fabien created D3824: build: avoid getifaddrs when unavailable.
Thu, Aug 8, 11:50
Fabien created D3823: build: Enable -Wredundant-decls where available.
Thu, Aug 8, 09:40
Fabien committed rABC4412d8ab7a09: build: add missing leveldb defines (authored by Cory Fields <cory-nospam-@coryfields.com>).
build: add missing leveldb defines
Thu, Aug 8, 08:50
Fabien closed D3817: build: add missing leveldb defines.
Thu, Aug 8, 08:50
Fabien committed rABC0c4d36b3425d: Fix leveldb compilation for NetBSD (authored by Randolf Richardson <randolf@richardson.tw>).
Fix leveldb compilation for NetBSD
Thu, Aug 8, 08:48
Fabien closed D3816: Fix leveldb compilation for NetBSD.
Thu, Aug 8, 08:48
Fabien committed rABC4bc8ab85992e: Detect if char equals int8_t (authored by Chun Kuan Lee <ken2812221@gmail.com>).
Detect if char equals int8_t
Thu, Aug 8, 08:45
Fabien closed D3815: Detect if char equals int8_t.
Thu, Aug 8, 08:44
Fabien committed rABCb44d73a64c20: Enforce clang-format version 7.x (authored by Fabien).
Enforce clang-format version 7.x
Thu, Aug 8, 08:42
Fabien closed D3806: Enforce clang-format version 7.x.
Thu, Aug 8, 08:42
Fabien requested changes to D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..

Some of the tests modified by this diff have their estimated duration > 40s (you can check this from test/functional/timing.json).
Therefore they are not run as part of test_runner.py but are part of the extended tests, requiring the use of test_runner.py --extended to be run.
You need to try it and add it to the test plan once you're sure that the patch did not introduce any regression.

Thu, Aug 8, 08:38
Fabien accepted D3822: Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s.
Thu, Aug 8, 08:33
Fabien accepted D3819: Merge #12537: [arith_uint256] Make it safe to use "self" in operators.
Thu, Aug 8, 08:23
Fabien requested changes to D3805: Merge #12716: Fix typos and cleanup in various files.
Thu, Aug 8, 07:16

Wed, Aug 7

Fabien created D3817: build: add missing leveldb defines.
Wed, Aug 7, 16:47
Fabien created D3816: Fix leveldb compilation for NetBSD.
Wed, Aug 7, 16:41
Fabien created D3815: Detect if char equals int8_t.
Wed, Aug 7, 15:51