Page MenuHomePhabricator
Feed Advanced Search

Today

Fabien requested changes to D4258: Implement PSBT Structures and un/serialization methods per BIP 174.
Fri, Oct 18, 08:31
Fabien accepted D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.
Fri, Oct 18, 07:12
Fabien accepted D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Fri, Oct 18, 06:59

Wed, Oct 16

Fabien requested changes to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Wed, Oct 16, 15:20
Fabien planned changes to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Wed, Oct 16, 06:58
Fabien updated the summary of D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Wed, Oct 16, 06:58
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Revert dependency, now depends on D4257.

Wed, Oct 16, 06:58
Fabien updated the summary of D4257: [CMAKE] Propagate requirements for cmake >= 3.12.
Wed, Oct 16, 06:56
Fabien updated the diff for D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Revert diff dependency.

Wed, Oct 16, 06:56
Fabien committed rABC1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt (authored by Fabien).
[CMAKE] Add resource file to bitcoin-qt
Wed, Oct 16, 06:53
Fabien closed D4256: [CMAKE] Add resource file to bitcoin-qt.
Wed, Oct 16, 06:53
Fabien accepted D4260: Fix misnamed 0.20.4 release notes.
Wed, Oct 16, 06:33

Tue, Oct 15

Fabien created D4257: [CMAKE] Propagate requirements for cmake >= 3.12.
Tue, Oct 15, 12:22
Fabien requested changes to D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.

The test plan doesn't cover the change.

Tue, Oct 15, 09:33
Fabien created D4256: [CMAKE] Add resource file to bitcoin-qt.
Tue, Oct 15, 08:37

Mon, Oct 14

Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Attempt to make the interface more simple and clear.
The add_library_with_type() function manages adding a library with one type or
more (STATIC, SHARED or both) but let the caller deal with properties.
This makes it easier to apply some property to only the static or shared variant
of a library if both are added.

Mon, Oct 14, 14:59
Fabien updated the summary of D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Mon, Oct 14, 14:34
Fabien accepted D4247: Decodehextx scripts sanity check.
Mon, Oct 14, 06:18

Fri, Oct 11

Fabien planned changes to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Fri, Oct 11, 13:14
Fabien accepted D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Fri, Oct 11, 08:13

Thu, Oct 10

Fabien accepted D4232: [gitian-build] Move manifest files to output directory.
Thu, Oct 10, 22:24
Fabien requested changes to D4234: bench: Benchmark MempoolToJSON.

The test is failing.

Thu, Oct 10, 22:11
Fabien accepted D4237: Update manpages for 0.20.4 release.
Thu, Oct 10, 20:04
Fabien accepted D4235: Update chainparams.
Thu, Oct 10, 20:03
Fabien accepted D4233: Update seeds.
Thu, Oct 10, 17:44

Wed, Oct 9

Fabien committed rSTAGING7ae2dc514d8f: [LINTER] Check for header guard closure comment (authored by Fabien).
[LINTER] Check for header guard closure comment
Wed, Oct 9, 20:12
Fabien committed rSTAGING7961960585b5: [CMAKE] Enable Large File Support on platforms that don't enable it by default (authored by Fabien).
[CMAKE] Enable Large File Support on platforms that don't enable it by default
Wed, Oct 9, 20:10
Fabien committed rSTAGING98415c84aa38: Add support for Glibc version 2.28 (authored by Fabien).
Add support for Glibc version 2.28
Wed, Oct 9, 20:10
Fabien committed rSTAGING83ecf7011c1b: [CMAKE] Use CMake built-in to set PIC and PIE (authored by Fabien).
[CMAKE] Use CMake built-in to set PIC and PIE
Wed, Oct 9, 20:10
Fabien committed rSTAGINGa456acd71455: [CMAKE] Fix check-security to allow running on windows executables (authored by Fabien).
[CMAKE] Fix check-security to allow running on windows executables
Wed, Oct 9, 20:10
Fabien committed rSTAGING8f09215cbe73: Use only 3 levels for defining the version (authored by Fabien).
Use only 3 levels for defining the version
Wed, Oct 9, 20:10
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Pick better names for the wrapper function and its cmake file.
Make the install_target() a function to separate its scope from the caller's.

Wed, Oct 9, 13:03
Fabien accepted D4228: Do not cache version in cmake build.
Wed, Oct 9, 12:43
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Missing newline.

Wed, Oct 9, 11:50
Fabien created D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Wed, Oct 9, 11:46
Fabien requested changes to D4228: Do not cache version in cmake build.

It's breaking the doc/Doxyfile.cmake.in template.
Please replace the line:
PROJECT_NUMBER = ${CLIENT_VERSION_MAJOR}.${CLIENT_VERSION_MINOR}.${CLIENT_VERSION_REVISION}
with:
PROJECT_NUMBER = ${bitcoin-abc_VERSION}
to fix it.

Wed, Oct 9, 06:27

Tue, Oct 8

Fabien committed rABC7ae2dc514d8f: [LINTER] Check for header guard closure comment (authored by Fabien).
[LINTER] Check for header guard closure comment
Tue, Oct 8, 19:32
Fabien closed D4218: [LINTER] Check for header guard closure comment.
Tue, Oct 8, 19:31

Mon, Oct 7

Fabien created D4218: [LINTER] Check for header guard closure comment.
Mon, Oct 7, 12:44
Fabien accepted D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.
Mon, Oct 7, 07:57
Fabien accepted D4215: Drop ParseHashUV in favor of calling ParseHashStr.
Mon, Oct 7, 07:36

Fri, Oct 4

Fabien accepted D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Fri, Oct 4, 15:47
Fabien accepted D4212: Remove CombineSignatures and replace tests.
Fri, Oct 4, 09:22
Fabien accepted D4211: Replace CombineSignatures with ProduceSignature.
Fri, Oct 4, 09:11
Fabien accepted D4210: Make SignatureData able to store signatures and scripts.
Fri, Oct 4, 08:59
Fabien accepted D4205: [cmake] Create a lib specifically for script related components.
Fri, Oct 4, 08:30
Fabien accepted D4209: Inline Sign1 and SignN.
Fri, Oct 4, 08:28
Fabien accepted D4199: Introduce Span type and use it instead of FLATDATA.
Fri, Oct 4, 06:35

Thu, Oct 3

Fabien requested changes to D4195: Added a land bot script.

Should anything fail the script errors out immediately, but the user working tree may have been modified in between.
I think you should trap the error and restore the previous state to avoid confusing the user.

Thu, Oct 3, 20:28
Fabien accepted D4203: Drop UpdateTransaction in favor of UpdateInput.
Thu, Oct 3, 20:10
Fabien requested changes to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.

I'm sure you didn't run the test from the summary. Please make it clear that you are quoting core PR description.

Thu, Oct 3, 19:59
Fabien requested changes to D4199: Introduce Span type and use it instead of FLATDATA.
Thu, Oct 3, 19:50
Fabien accepted D4188: Add native support for serializing char arrays without FLATDATA.
Thu, Oct 3, 13:52
Fabien accepted D4186: refactor: Avoid locking tx pool cs thrice.
Thu, Oct 3, 13:26

Wed, Oct 2

Fabien accepted D4196: Minor improvements to github-release script.
Wed, Oct 2, 12:08
Fabien created D4198: [CMAKE] Add the bitcoinconsensus library.
Wed, Oct 2, 10:06
Fabien created D4197: [CMAKE] Rename bitcoinconsensus target to avoid collision.
Wed, Oct 2, 10:04

Tue, Oct 1

Fabien accepted D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.
Tue, Oct 1, 18:47
Fabien accepted D4193: Add phpcs exclusion for strict_types declararion.
Tue, Oct 1, 17:56
Fabien accepted D4187: Add static_assert to prevent VARINT(<signed value>).
Tue, Oct 1, 14:57
Fabien updated the test plan for D4187: Add static_assert to prevent VARINT(<signed value>).
Tue, Oct 1, 14:19
Fabien requested changes to D4186: refactor: Avoid locking tx pool cs thrice.

Build with Clang to check for -Wthread-safety-warnings.

Tue, Oct 1, 14:11
Fabien committed rABC7961960585b5: [CMAKE] Enable Large File Support on platforms that don't enable it by default (authored by Fabien).
[CMAKE] Enable Large File Support on platforms that don't enable it by default
Tue, Oct 1, 13:54
Fabien closed D4182: [CMAKE] Enable Large File Support on platforms that don't enable it by default.
Tue, Oct 1, 13:54
Fabien committed rABC98415c84aa38: Add support for Glibc version 2.28 (authored by Fabien).
Add support for Glibc version 2.28
Tue, Oct 1, 13:52
Fabien closed D4167: Add support for Glibc version 2.28.
Tue, Oct 1, 13:52
Fabien updated the diff for D4095: [contrib] Support ARM symbol check.

Rebase on top of D4185.

Tue, Oct 1, 12:47
Fabien created D4185: Migrate Gitian container to Debian 10 Buster.
Tue, Oct 1, 10:40
Fabien accepted D4180: Added more explicit instructions for release tagging.
Tue, Oct 1, 06:43
Fabien accepted D4181: Updated release-process to use github-release.sh.
Tue, Oct 1, 06:35
Fabien added a comment to D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.

Maybe there should be an explicit notice of backport here, as the remaining parts of the PR are Travis related ?

Tue, Oct 1, 06:33
Fabien requested changes to D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.
Tue, Oct 1, 06:31
Fabien accepted D4184: Change CI builds to use utf-8 encoding.
Tue, Oct 1, 06:09

Mon, Sep 30

Fabien added a comment to D4174: utils: Convert Windows args to utf-8 string.

I tried to reproduce on a fresh Debian Stretch, no success.
I will try to install the agent packages and run again.

Mon, Sep 30, 17:08
Fabien updated the test plan for D4182: [CMAKE] Enable Large File Support on platforms that don't enable it by default.
Mon, Sep 30, 16:39
Fabien retitled D4182: [CMAKE] Enable Large File Support on platforms that don't enable it by default from Enable Large File Support on platforms that don't enable it by default to [CMAKE] Enable Large File Support on platforms that don't enable it by default.
Mon, Sep 30, 16:39
Fabien created D4182: [CMAKE] Enable Large File Support on platforms that don't enable it by default.
Mon, Sep 30, 16:37
Fabien accepted D3714: Added a script for creating Github release drafts.
Mon, Sep 30, 13:03
Fabien accepted D4176: util: Replace boost::signals2 with std::function.
Mon, Sep 30, 12:53
Fabien committed rABC83ecf7011c1b: [CMAKE] Use CMake built-in to set PIC and PIE (authored by Fabien).
[CMAKE] Use CMake built-in to set PIC and PIE
Mon, Sep 30, 10:57
Fabien closed D4156: [CMAKE] Use CMake built-in to set PIC and PIE.
Mon, Sep 30, 10:57
Fabien committed rABCa456acd71455: [CMAKE] Fix check-security to allow running on windows executables (authored by Fabien).
[CMAKE] Fix check-security to allow running on windows executables
Mon, Sep 30, 10:56
Fabien closed D4155: [CMAKE] Fix check-security to allow running on windows executables.
Mon, Sep 30, 10:56
Fabien committed rABC8f09215cbe73: Use only 3 levels for defining the version (authored by Fabien).
Use only 3 levels for defining the version
Mon, Sep 30, 10:55
Fabien closed D4148: Use only 3 levels for defining the version.
Mon, Sep 30, 10:55
Fabien retitled D4167: Add support for Glibc version 2.28 from [WIP] Add support for Glibc version 2.28 to Add support for Glibc version 2.28.
Mon, Sep 30, 10:54
Fabien updated the diff for D4167: Add support for Glibc version 2.28.

Fix Invalid argument by passing the address of first vararg as a void *.
The same is done internally by the glibc, but the compatibility symbols seems
to complain when the full vararg list is passed.

Mon, Sep 30, 10:51

Sun, Sep 29

Fabien planned changes to D4167: Add support for Glibc version 2.28.
Sun, Sep 29, 06:17

Sat, Sep 28

Fabien updated the diff for D4167: Add support for Glibc version 2.28.

Rebase on master (was on top of D4095, thus failing the symbol check with gitian on stretch).

Sat, Sep 28, 06:45
Fabien updated the diff for D4167: Add support for Glibc version 2.28.

Revert configure logic to wrap when needed.

Sat, Sep 28, 01:58

Fri, Sep 27

Fabien committed rSTAGINGcd0f483aa801: [CMAKE] Detect if the compiler supports visibility function attribute (authored by Fabien).
[CMAKE] Detect if the compiler supports visibility function attribute
Fri, Sep 27, 22:49
Fabien committed rSTAGING6c467dfc4f6b: [CMAKE] Install the man pages (authored by Fabien).
[CMAKE] Install the man pages
Fri, Sep 27, 22:49
Fabien committed rSTAGING1010243bd5ab: [CMAKE] Install executables (authored by Fabien).
[CMAKE] Install executables
Fri, Sep 27, 22:49
Fabien committed rSTAGING4dab36ebb168: [CMAKE] Add the check-security target (authored by Fabien).
[CMAKE] Add the check-security target
Fri, Sep 27, 22:49
Fabien committed rSTAGINGa7b6fd856433: [CMAKE] Add the check-symbols target (authored by Fabien).
[CMAKE] Add the check-symbols target
Fri, Sep 27, 22:49
Fabien committed rSTAGINGe36935e09971: [CMAKE] Consistently find and use the python interpreter (authored by Fabien).
[CMAKE] Consistently find and use the python interpreter
Fri, Sep 27, 22:48
Fabien committed rSTAGING46261be23880: [CMAKE] Migrate the python header generation scripts to python 3 (authored by Fabien).
[CMAKE] Migrate the python header generation scripts to python 3
Fri, Sep 27, 22:48
Fabien committed rSTAGING71191d04adaa: [CMAKE] Only change obj/build.h if the content has changed (authored by Fabien).
[CMAKE] Only change obj/build.h if the content has changed
Fri, Sep 27, 22:48
Fabien committed rSTAGING317e1eaef78d: [CMAKE] Fix linux cross compilation with the glibc compatibility (authored by Fabien).
[CMAKE] Fix linux cross compilation with the glibc compatibility
Fri, Sep 27, 22:47
Fabien committed rSTAGING093479065d92: [CMAKE] Remove useless dependency for the check-rpcauth target (authored by Fabien).
[CMAKE] Remove useless dependency for the check-rpcauth target
Fri, Sep 27, 22:47