Page MenuHomePhabricator
Feed All Stories

Today

nakihito accepted D6399: Remove unused variable.
Sat, Jun 6, 00:43
nakihito requested review of D5380: Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.
Sat, Jun 6, 00:41
nakihito requested review of D6283: Seeder sends GETHEADERS message.
Sat, Jun 6, 00:41
nakihito requested review of D6357: Refactor seeder to use CNetMsgMaker to write its messages.

Updated summary to remove mention of previous seeder implementation being unable to send multiple messages. This was actually the result of a different bug that made it appear as if it was not possible.

Sat, Jun 6, 00:40
nakihito planned changes to D5380: Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.
Sat, Jun 6, 00:34
nakihito updated the diff for D5380: Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.

Rebased and changed the finish state to reflect changes to the getheaders trigger.

Sat, Jun 6, 00:34
nakihito planned changes to D6283: Seeder sends GETHEADERS message.
Sat, Jun 6, 00:27
nakihito updated the diff for D6283: Seeder sends GETHEADERS message.

Make use of CBlockLocator class.

Sat, Jun 6, 00:27
nakihito planned changes to D6357: Refactor seeder to use CNetMsgMaker to write its messages.
Sat, Jun 6, 00:26
nakihito updated the diff for D6357: Refactor seeder to use CNetMsgMaker to write its messages.

Added additionally test case.

Sat, Jun 6, 00:26
teamcity updated the summary of D6401: [refactor] Change tx_relay structure to be unique_ptr.
Sat, Jun 6, 00:13
teamcity added a comment to D6401: [refactor] Change tx_relay structure to be unique_ptr.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Sat, Jun 6, 00:13
deadalnix requested review of D6401: [refactor] Change tx_relay structure to be unique_ptr.
Sat, Jun 6, 00:13

Yesterday

teamcity added a comment to D6400: [refactor] Move tx relay state to separate structure.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 23:30
teamcity updated the summary of D6400: [refactor] Move tx relay state to separate structure.
Fri, Jun 5, 23:30
deadalnix requested review of D6400: [refactor] Move tx relay state to separate structure.
Fri, Jun 5, 23:30
deadalnix accepted D6395: Merge #15330: test: Fix race in p2p_invalid_messages.
Fri, Jun 5, 23:29
deadalnix accepted D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.
Fri, Jun 5, 23:29
deadalnix accepted D6397: [land-bot] Point land bot at bitcoinabc.org.
Fri, Jun 5, 23:28
teamcity added a comment to D6399: Remove unused variable.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 23:25
teamcity updated the summary of D6399: Remove unused variable.
Fri, Jun 5, 23:25
deadalnix requested review of D6399: Remove unused variable.
Fri, Jun 5, 23:25
deadalnix requested review of D6398: Use BlockHash for vInventoryBlockToSend.
Fri, Jun 5, 23:02
nakihito planned changes to D6283: Seeder sends GETHEADERS message.
Fri, Jun 5, 22:59
nakihito updated the diff for D6283: Seeder sends GETHEADERS message.

Rebased off D6357. Adjusted trigger for GETHEADERS message to occur with GETADDR.

Fri, Jun 5, 22:59
nakihito planned changes to D6357: Refactor seeder to use CNetMsgMaker to write its messages.
Fri, Jun 5, 22:54
nakihito updated the diff for D6357: Refactor seeder to use CNetMsgMaker to write its messages.

Reverted vSend to CDataStream and adjusted unit tests to reflect this.

Fri, Jun 5, 22:54
nakihito updated the summary of D6357: Refactor seeder to use CNetMsgMaker to write its messages.
Fri, Jun 5, 22:50
jasonbcox requested review of D6397: [land-bot] Point land bot at bitcoinabc.org.
Fri, Jun 5, 21:57
majcosta committed rABC9d416a843f8c: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo… (authored by John Newbery <john@johnnewbery.com>).
[backport#15750] [rpc] Remove the addresses field from the getaddressinfo…
Fri, Jun 5, 21:57
majcosta closed D6392: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object.
Fri, Jun 5, 21:57
teamcity added a comment to D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 21:45
teamcity updated the summary of D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.
Fri, Jun 5, 21:45
jasonbcox requested review of D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.
Fri, Jun 5, 21:45
teamcity added a comment to D6395: Merge #15330: test: Fix race in p2p_invalid_messages.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 21:41
teamcity updated the summary of D6395: Merge #15330: test: Fix race in p2p_invalid_messages.
Fri, Jun 5, 21:41
jasonbcox requested review of D6395: Merge #15330: test: Fix race in p2p_invalid_messages.
Fri, Jun 5, 21:41
jasonbcox committed rABC705b3c6c8cca: Merge #15246: qa: Add tests for invalid message headers (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15246: qa: Add tests for invalid message headers
Fri, Jun 5, 21:36
jasonbcox closed D6394: Merge #15246: qa: Add tests for invalid message headers.
Fri, Jun 5, 21:36
jasonbcox committed rABC883815514dfe: Simplify install instructions for linter dependencies (authored by jasonbcox).
Simplify install instructions for linter dependencies
Fri, Jun 5, 21:08
jasonbcox closed D6389: Simplify install instructions for linter dependencies.
Fri, Jun 5, 21:07
deadalnix accepted D6392: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object.
Fri, Jun 5, 20:53
deadalnix accepted D6394: Merge #15246: qa: Add tests for invalid message headers.
Fri, Jun 5, 20:52
jasonbcox committed rABC554d897104b2: Add remaining linter dependencies to CI base image (authored by jasonbcox).
Add remaining linter dependencies to CI base image
Fri, Jun 5, 20:37
jasonbcox closed D6380: Add remaining linter dependencies to CI base image.
Fri, Jun 5, 20:37
jasonbcox retitled D6380: Add remaining linter dependencies to CI base image from Add shellcheck to CI base image to Add remaining linter dependencies to CI base image.
Fri, Jun 5, 20:30
jasonbcox committed rABC8227e3687e9b: [land-bot] Clarify review status error message (authored by jasonbcox).
[land-bot] Clarify review status error message
Fri, Jun 5, 20:29
jasonbcox closed D6388: [land-bot] Clarify review status error message.
Fri, Jun 5, 20:29
jasonbcox updated the diff for D6389: Simplify install instructions for linter dependencies.

clang-format -> clang-format-8

Fri, Jun 5, 20:29
jasonbcox retitled D6389: Simplify install instructions for linter dependencies from Simply install instructions for linter dependencies to Simplify install instructions for linter dependencies.
Fri, Jun 5, 20:28
jasonbcox added inline comments to D6394: Merge #15246: qa: Add tests for invalid message headers.
Fri, Jun 5, 20:27
teamcity updated the summary of D6394: Merge #15246: qa: Add tests for invalid message headers.
Fri, Jun 5, 20:26
teamcity added a comment to D6394: Merge #15246: qa: Add tests for invalid message headers.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 20:26
jasonbcox requested review of D6394: Merge #15246: qa: Add tests for invalid message headers.
Fri, Jun 5, 20:26
jasonbcox retitled D6389: Simplify install instructions for linter dependencies from Simply install instructions for linter depenendencies to Simply install instructions for linter dependencies.
Fri, Jun 5, 19:30
teamcity added a comment to D6392: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 19:27
teamcity updated the summary of D6392: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object.
Fri, Jun 5, 19:27
majcosta requested review of D6392: [backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object.
Fri, Jun 5, 19:27
Fabien accepted D6388: [land-bot] Clarify review status error message.
Fri, Jun 5, 19:17
Fabien accepted D6380: Add remaining linter dependencies to CI base image.
Fri, Jun 5, 19:16
Fabien accepted D6389: Simplify install instructions for linter dependencies.
Fri, Jun 5, 19:15
teamcity closed T921: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Fri, Jun 5, 18:51
jasonbcox requested review of D6389: Simplify install instructions for linter dependencies.
Fri, Jun 5, 18:49
jasonbcox updated the diff for D6380: Add remaining linter dependencies to CI base image.

Add missing php-codesniffer

Fri, Jun 5, 18:44
teamcity assigned T921: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. to jasonbcox.
Fri, Jun 5, 18:34
teamcity triaged T921: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Fri, Jun 5, 18:34
deadalnix committed rABC8792ff7cef71: Batch write imported stuff in importmulti (authored by Andrew Chow <achow101-github@achow101.com>).
Batch write imported stuff in importmulti
Fri, Jun 5, 18:08
deadalnix closed D6387: Batch write imported stuff in importmulti.
Fri, Jun 5, 18:08
jasonbcox requested review of D6388: [land-bot] Clarify review status error message.
Fri, Jun 5, 18:07
teamcity closed T920: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Fri, Jun 5, 18:03
jasonbcox requested changes to D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.

Missing backport of p2p_dos_header_tree.py

Fri, Jun 5, 17:57
jasonbcox committed rABC95173738367c: [devtools] Use -daemon instead of backgrounding bitcoind (authored by jasonbcox).
[devtools] Use -daemon instead of backgrounding bitcoind
Fri, Jun 5, 17:55
jasonbcox closed D6379: [devtools] Use -daemon instead of backgrounding bitcoind.
Fri, Jun 5, 17:55
majcosta committed rABC109fb473d256: [backport#16898] test: Reformat python imports to aid scripted diff (authored by majcosta).
[backport#16898] test: Reformat python imports to aid scripted diff
Fri, Jun 5, 17:46
majcosta closed D6386: [backport#16898] test: Reformat python imports to aid scripted diff.
Fri, Jun 5, 17:46
majcosta accepted D6387: Batch write imported stuff in importmulti.
Fri, Jun 5, 17:43
deadalnix committed rABCa62f3e2135af: Fix: importmulti only imports origin info for PKH outputs (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Fix: importmulti only imports origin info for PKH outputs
Fri, Jun 5, 17:40
deadalnix closed D6385: Fix: importmulti only imports origin info for PKH outputs.
Fri, Jun 5, 17:40
deadalnix accepted D6386: [backport#16898] test: Reformat python imports to aid scripted diff.
Fri, Jun 5, 17:35
majcosta accepted D6385: Fix: importmulti only imports origin info for PKH outputs.
Fri, Jun 5, 17:25
teamcity added a comment to D6387: Batch write imported stuff in importmulti.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 17:07
teamcity updated the summary of D6387: Batch write imported stuff in importmulti.
Fri, Jun 5, 17:07
deadalnix requested review of D6387: Batch write imported stuff in importmulti.
Fri, Jun 5, 17:07
teamcity added a comment to D6386: [backport#16898] test: Reformat python imports to aid scripted diff.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 16:40
teamcity updated the summary of D6386: [backport#16898] test: Reformat python imports to aid scripted diff.
Fri, Jun 5, 16:40
majcosta requested review of D6386: [backport#16898] test: Reformat python imports to aid scripted diff.
Fri, Jun 5, 16:40
teamcity added a comment to D6385: Fix: importmulti only imports origin info for PKH outputs.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 16:36
teamcity updated the summary of D6385: Fix: importmulti only imports origin info for PKH outputs.
Fri, Jun 5, 16:36
deadalnix requested review of D6385: Fix: importmulti only imports origin info for PKH outputs.
Fri, Jun 5, 16:36
majcosta updated the summary of D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.
Fri, Jun 5, 16:33
majcosta updated the diff for D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.

added the rest of the PR's changes, just one removed line

Fri, Jun 5, 16:33
teamcity added a comment to D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fri, Jun 5, 16:30
teamcity updated the summary of D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.
Fri, Jun 5, 16:30
majcosta requested review of D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.
Fri, Jun 5, 16:30
teamcity assigned T920: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. to majcosta.
Fri, Jun 5, 16:15
teamcity triaged T920: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Fri, Jun 5, 16:15
majcosta committed rABC71e5ab2112db: [backport#13756] wallet: avoid reuse flags (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] wallet: avoid reuse flags
Fri, Jun 5, 15:59
majcosta closed D6370: [backport#13756] wallet: avoid reuse flags.
Fri, Jun 5, 15:59
majcosta abandoned D6375: [backport#16898] test: Remove connect_nodes_bi.

abandoning in favor of a more piecemeal approach

Fri, Jun 5, 15:57
deadalnix committed rABCda5b2def31c0: Use a single wallet batch for UpgradeKeyMetadata (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Use a single wallet batch for UpgradeKeyMetadata
Fri, Jun 5, 15:34