Page MenuHomePhabricator
Feed All Stories

Today

Fabien updated the diff for D20616: [CI] Use the default linker for the debian build.

Fix weird whitespace chars

Fri, Sep 11, 13:15
Fabien requested review of D20621: [avalanche] Apply the timeout factor to the get_ava_p2p_interface helper.
Fri, Sep 11, 13:07
PiRK accepted D20619: [avalanche] Use noban_tx_relay in abc_p2p_avalanche_compactblocks.py.
Fri, Sep 11, 13:04
PiRK accepted D20616: [CI] Use the default linker for the debian build.
Fri, Sep 11, 13:04
teamcity added a comment to D20619: [avalanche] Use noban_tx_relay in abc_p2p_avalanche_compactblocks.py.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Fri, Sep 11, 13:01
Fabien requested review of D20619: [avalanche] Use noban_tx_relay in abc_p2p_avalanche_compactblocks.py.
Fri, Sep 11, 12:58
Fabien accepted D20608: consensus: Store transaction nVersion as uint32_t.
Fri, Sep 11, 12:13
teamcity closed T4056: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
Fri, Sep 11, 12:00
teamcity added a comment to D20608: consensus: Store transaction nVersion as uint32_t.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Fri, Sep 11, 11:39
teamcity triaged T4057: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
Fri, Sep 11, 11:16
PiRK updated the diff for D20608: consensus: Store transaction nVersion as uint32_t.

revert to constexpr for CURRENT_VERSION and remove blank line

Fri, Sep 11, 10:46
bytesofman closed D20597: [Cashtab] Parse XecVibe OP_RETURN.
Fri, Sep 11, 10:41
bytesofman committed rABCc66209e47e22: [Cashtab] Parse XecVibe OP_RETURN (authored by a2c.dev).
[Cashtab] Parse XecVibe OP_RETURN
Fri, Sep 11, 10:41
PiRK committed rABC34606774045c: test: Remove struct.pack from almost all places (authored by PiRK).
test: Remove struct.pack from almost all places
Fri, Sep 11, 10:36
PiRK closed D20614: test: Remove struct.pack from almost all places.
Fri, Sep 11, 10:36
PiRK closed D20612: scripted-diff: test: Use int from_bytes and to_bytes over struct packing.
Fri, Sep 11, 10:36
PiRK committed rABC511591e5d403: test: Remove struct import from messages.py (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Remove struct import from messages.py
Fri, Sep 11, 10:36
PiRK closed D20613: test: Remove struct import from messages.py.
Fri, Sep 11, 10:36
PiRK committed rABC397a1d70704d: scripted-diff: test: Use int from_bytes and to_bytes over struct packing (authored by PiRK).
scripted-diff: test: Use int from_bytes and to_bytes over struct packing
Fri, Sep 11, 10:36
PiRK closed D20611: test: Use int from_bytes and to_bytes over struct packing.
Fri, Sep 11, 10:36
PiRK committed rABC10c9e76303ad: test: Use int from_bytes and to_bytes over struct packing (authored by PiRK).
test: Use int from_bytes and to_bytes over struct packing
Fri, Sep 11, 10:36
teamcity triaged T4056: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
Fri, Sep 11, 10:32
bytesofman closed D20610: [cashtab] Require confirm for high AlpSwap price impact.
Fri, Sep 11, 09:57
bytesofman committed rABC8c6fe99567ea: [cashtab] Require confirm for high AlpSwap price impact (authored by bytesofman).
[cashtab] Require confirm for high AlpSwap price impact
Fri, Sep 11, 09:57
bytesofman added inline comments to D20610: [cashtab] Require confirm for high AlpSwap price impact.
Fri, Sep 11, 09:52
teamcity added a comment to D20616: [CI] Use the default linker for the debian build.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Fri, Sep 11, 09:44
teamcity added a comment to D20616: [CI] Use the default linker for the debian build.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Fri, Sep 11, 09:42
Fabien updated the diff for D20616: [CI] Use the default linker for the debian build.

Syntax fix

Fri, Sep 11, 09:38
Fabien requested review of D20616: [CI] Use the default linker for the debian build.
Fri, Sep 11, 09:36
Fabien accepted D20614: test: Remove struct.pack from almost all places.
Fri, Sep 11, 09:30
teamcity added a comment to D20614: test: Remove struct.pack from almost all places.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Fri, Sep 11, 09:30
teamcity awarded D20614: test: Remove struct.pack from almost all places a Haypence token.
Fri, Sep 11, 09:27
Fabien added a comment to D20614: test: Remove struct.pack from almost all places.

@bot ai-review

Fri, Sep 11, 09:27
teamcity added a comment to D20613: test: Remove struct import from messages.py.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Fri, Sep 11, 09:27
Fabien accepted D20613: test: Remove struct import from messages.py.
Fri, Sep 11, 09:27
teamcity awarded D20613: test: Remove struct import from messages.py a Haypence token.
Fri, Sep 11, 09:25
Fabien added a comment to D20613: test: Remove struct import from messages.py.

@bot ai-review

Fri, Sep 11, 09:25
Fabien accepted D20612: scripted-diff: test: Use int from_bytes and to_bytes over struct packing.

Thanks for this diff that saves me time by not having to learn struct, except that now that I reviewed it I know struct.

Fri, Sep 11, 09:22
Fabien accepted D20611: test: Use int from_bytes and to_bytes over struct packing.
Fri, Sep 11, 09:08
Fabien requested changes to D20608: consensus: Store transaction nVersion as uint32_t.
Fri, Sep 11, 09:06
Fabien accepted D20610: [cashtab] Require confirm for high AlpSwap price impact.
Fri, Sep 11, 08:39
Fabien accepted D20597: [Cashtab] Parse XecVibe OP_RETURN.
Fri, Sep 11, 08:24
teamcity added a comment to D20597: [Cashtab] Parse XecVibe OP_RETURN.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Fri, Sep 11, 04:26
bytesofman updated the diff for D20597: [Cashtab] Parse XecVibe OP_RETURN.

Reject bare opcodes as XecVibe memo; keep pushed 0x51 valid.

Fri, Sep 11, 04:23

Yesterday

PiRK added inline comments to D20608: consensus: Store transaction nVersion as uint32_t.
Thu, Sep 10, 17:25
PiRK published D20608: consensus: Store transaction nVersion as uint32_t for review.
Thu, Sep 10, 17:20
teamcity added a comment to D20610: [cashtab] Require confirm for high AlpSwap price impact.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Thu, Sep 10, 14:58
bytesofman published D20610: [cashtab] Require confirm for high AlpSwap price impact for review.
Thu, Sep 10, 14:49
Fabien requested changes to D20597: [Cashtab] Parse XecVibe OP_RETURN.

Rabbit is correct, the switch to stackArray dropped the edge case handling

Thu, Sep 10, 14:44
Fabien accepted D20597: [Cashtab] Parse XecVibe OP_RETURN.
Thu, Sep 10, 14:22
teamcity added a comment to D20597: [Cashtab] Parse XecVibe OP_RETURN.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Thu, Sep 10, 14:18
teamcity added a comment to D20614: test: Remove struct.pack from almost all places.
Thu, Sep 10, 14:12
teamcity added a comment to D20597: [Cashtab] Parse XecVibe OP_RETURN.
Thu, Sep 10, 14:09
bytesofman updated the diff for D20597: [Cashtab] Parse XecVibe OP_RETURN.

Decode XecVibe memos with fatal UTF-8 and ignoreBOM.

Thu, Sep 10, 14:06
teamcity added a comment to D20597: [Cashtab] Parse XecVibe OP_RETURN.
Thu, Sep 10, 14:05
teamcity added a comment to D20597: [Cashtab] Parse XecVibe OP_RETURN.
Thu, Sep 10, 14:03
teamcity updated the summary of D20614: test: Remove struct.pack from almost all places.
Thu, Sep 10, 14:00
PiRK requested review of D20614: test: Remove struct.pack from almost all places.
Thu, Sep 10, 14:00
teamcity added a comment to D20613: test: Remove struct import from messages.py.
Thu, Sep 10, 13:57
bytesofman updated the diff for D20597: [Cashtab] Parse XecVibe OP_RETURN.

Use stackArray.length !== 2 instead of index typeof checks.

Thu, Sep 10, 13:56
teamcity added a comment to D20612: scripted-diff: test: Use int from_bytes and to_bytes over struct packing.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Thu, Sep 10, 13:34
teamcity added a comment to D20597: [Cashtab] Parse XecVibe OP_RETURN.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Thu, Sep 10, 13:31
bytesofman updated the diff for D20597: [Cashtab] Parse XecVibe OP_RETURN.

Address Fabien: stackArray parse, drop BIP21/PUSHDATA1 asides, utf8 memo fixtures.

Thu, Sep 10, 13:30
PiRK updated the summary of D20611: test: Use int from_bytes and to_bytes over struct packing.
Thu, Sep 10, 13:29
Fabien requested changes to D20597: [Cashtab] Parse XecVibe OP_RETURN.
Thu, Sep 10, 13:26
bytesofman updated the diff for D20597: [Cashtab] Parse XecVibe OP_RETURN.

Keep the OP_1 stackArray vector; expect memo Q.

Thu, Sep 10, 13:24
teamcity updated the summary of D20613: test: Remove struct import from messages.py.
Thu, Sep 10, 13:24
PiRK requested review of D20613: test: Remove struct import from messages.py.
Thu, Sep 10, 13:24
teamcity updated the summary of D20612: scripted-diff: test: Use int from_bytes and to_bytes over struct packing.
Thu, Sep 10, 13:22
PiRK requested review of D20612: scripted-diff: test: Use int from_bytes and to_bytes over struct packing.
Thu, Sep 10, 13:22
teamcity added a comment to D20611: test: Use int from_bytes and to_bytes over struct packing.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Thu, Sep 10, 13:22
bytesofman planned changes to D20597: [Cashtab] Parse XecVibe OP_RETURN.

pending further review / clean up

Thu, Sep 10, 13:22
PiRK updated the summary of D20611: test: Use int from_bytes and to_bytes over struct packing.
Thu, Sep 10, 13:20
bytesofman updated the diff for D20597: [Cashtab] Parse XecVibe OP_RETURN.

Parse XecVibe from stackArray instead of rebuilding the script.

Thu, Sep 10, 13:19
PiRK updated the summary of D20611: test: Use int from_bytes and to_bytes over struct packing.
Thu, Sep 10, 13:19
teamcity updated the summary of D20611: test: Use int from_bytes and to_bytes over struct packing.
Thu, Sep 10, 13:18
PiRK requested review of D20611: test: Use int from_bytes and to_bytes over struct packing.
Thu, Sep 10, 13:18
bytesofman commandeered D20597: [Cashtab] Parse XecVibe OP_RETURN.
Thu, Sep 10, 13:01
teamcity closed T4053: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX MacOS is broken. as Resolved.
Thu, Sep 10, 12:43
bytesofman closed D20591: [alp-fusion] Verify Pedersen openings and blind-auth covert sigs.
Thu, Sep 10, 11:44
bytesofman committed rABC9d49e845cc42: [alp-fusion] Verify Pedersen openings and blind-auth covert sigs (authored by bytesofman).
[alp-fusion] Verify Pedersen openings and blind-auth covert sigs
Thu, Sep 10, 11:44
teamcity added a comment to D20597: [Cashtab] Parse XecVibe OP_RETURN.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Thu, Sep 10, 11:30
a2c.dev updated the diff for D20597: [Cashtab] Parse XecVibe OP_RETURN.

Simplify xecvibe.md; drop LOKAD-upgrade wording.

Thu, Sep 10, 11:02
PiRK closed D20605: validation: improve performance of CheckBlockIndex.
Thu, Sep 10, 09:10
PiRK committed rABC4623737bb113: validation: improve performance of CheckBlockIndex (authored by Martin Zumsande <mzumsande@gmail.com>).
validation: improve performance of CheckBlockIndex
Thu, Sep 10, 09:10
PiRK closed D20604: blockman: Replace m_reindexing with m_blockfiles_indexed.
Thu, Sep 10, 09:10
PiRK committed rABCa52908017756: blockman: Replace m_reindexing with m_blockfiles_indexed (authored by Ryan Ofsky <ryan@ofsky.org>).
blockman: Replace m_reindexing with m_blockfiles_indexed
Thu, Sep 10, 09:10
PiRK committed rABC8ddedf7d176a: indexes: Don't wipe indexes again when already reindexing (authored by TheCharlatan <seb.kung@gmail.com>).
indexes: Don't wipe indexes again when already reindexing
Thu, Sep 10, 09:10
PiRK closed D20603: indexes: Don't wipe indexes again when already reindexing.
Thu, Sep 10, 09:10
PiRK closed D20601: validation: Remove needs_init from LoadBlockIndex.
Thu, Sep 10, 09:10
PiRK closed D20602: kernel: Add less confusing reindex options.
Thu, Sep 10, 09:10
PiRK committed rABC38ab59afb05d: validation: Remove needs_init from LoadBlockIndex (authored by TheCharlatan <seb.kung@gmail.com>).
validation: Remove needs_init from LoadBlockIndex
Thu, Sep 10, 09:10
PiRK committed rABC154823af7972: kernel: Add less confusing reindex options (authored by Ryan Ofsky <ryan@ofsky.org>).
kernel: Add less confusing reindex options
Thu, Sep 10, 09:10
PiRK closed D20593: follow-ups for core#29612.
Thu, Sep 10, 09:10
PiRK committed rABC70ba2632c51d: follow-ups for core#29612 (authored by Fabian Jahr <fjahr@protonmail.com>).
follow-ups for core#29612
Thu, Sep 10, 09:10
PiRK closed D20607: cmake: always use the github tar.gz for corrosion, with original timestamp.
Thu, Sep 10, 09:09
PiRK committed rABC5b1606ec6610: cmake: always use the github tar.gz for corrosion, with original timestamp (authored by PiRK).
cmake: always use the github tar.gz for corrosion, with original timestamp
Thu, Sep 10, 09:09
Fabien accepted D20591: [alp-fusion] Verify Pedersen openings and blind-auth covert sigs.
Thu, Sep 10, 08:54
Fabien accepted D20607: cmake: always use the github tar.gz for corrosion, with original timestamp.
Thu, Sep 10, 08:49
Fabien accepted D20605: validation: improve performance of CheckBlockIndex.
Thu, Sep 10, 08:47