Page MenuHomePhabricator
Feed All Stories

Today

majcosta requested review of D6835: [cleanup] remove redundant m_node from wallet_test_fixture.h.
Tue, Jul 7, 01:09
majcosta updated the diff for D6539: [backport#14193] validation: Add missing mempool locks.

void UpdateMempoolForReorg was refactored into DisconnectedBlockTransactions::updateMempoolForReorg and
DisconnectedBlockTransactions::addForBlock in D1667

Tue, Jul 7, 00:34

Yesterday

majcosta committed rABCfc1de4a6ae0e: [refactor] add const CChainParams& m_params to interface::ChainImpl (authored by majcosta).
[refactor] add const CChainParams& m_params to interface::ChainImpl
Mon, Jul 6, 22:17
majcosta closed D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 22:17
Fabien committed rABC35faecfbd153: [CI] Add a runOnDiff flag to the build configurations (authored by Fabien).
[CI] Add a runOnDiff flag to the build configurations
Mon, Jul 6, 22:12
Fabien closed D6833: [CI] Add a runOnDiff flag to the build configurations.
Mon, Jul 6, 22:12
deadalnix requested review of D6834: [avalanche] Use PerrManager instead of ad hoc logic in AvalancheProcessor.
Mon, Jul 6, 21:51
deadalnix committed rABC7d1e29374d16: [avalanche] Factor AvalancheNode from PeerManager (authored by deadalnix).
[avalanche] Factor AvalancheNode from PeerManager
Mon, Jul 6, 21:49
deadalnix closed D6831: [avalanche] Factor AvalancheNode from PeerManager.
Mon, Jul 6, 21:49
deadalnix committed rABC2625cfcf5ed7: [avalanche] Move AvalancheNode to its own file (authored by deadalnix).
[avalanche] Move AvalancheNode to its own file
Mon, Jul 6, 21:48
deadalnix closed D6830: [avalanche] Move AvalancheNode to its own file.
Mon, Jul 6, 21:48
deadalnix added inline comments to D6831: [avalanche] Factor AvalancheNode from PeerManager.
Mon, Jul 6, 21:48
deadalnix accepted D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 21:47
deadalnix committed rABC4148611617c6: [avalanche] Remove getPubkey API (authored by deadalnix).
[avalanche] Remove getPubkey API
Mon, Jul 6, 21:42
deadalnix closed D6828: [avalanche] Remove getPubkey API.
Mon, Jul 6, 21:42
jasonbcox accepted D6833: [CI] Add a runOnDiff flag to the build configurations.
Mon, Jul 6, 21:37
Fabien requested review of D6833: [CI] Add a runOnDiff flag to the build configurations.
Mon, Jul 6, 21:36
jasonbcox accepted D6831: [avalanche] Factor AvalancheNode from PeerManager.
Mon, Jul 6, 21:36
majcosta added inline comments to D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 21:27
majcosta added inline comments to D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 21:26
jasonbcox accepted D6830: [avalanche] Move AvalancheNode to its own file.
Mon, Jul 6, 21:25
majcosta updated the diff for D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.

addressed comments

Mon, Jul 6, 21:25
jasonbcox accepted D6828: [avalanche] Remove getPubkey API.
Mon, Jul 6, 21:23
deadalnix requested review of D6831: [avalanche] Factor AvalancheNode from PeerManager.
Mon, Jul 6, 20:49
deadalnix updated the summary of D6830: [avalanche] Move AvalancheNode to its own file.
Mon, Jul 6, 20:48
deadalnix requested review of D6830: [avalanche] Move AvalancheNode to its own file.
Mon, Jul 6, 20:47
deadalnix requested changes to D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.

Good start, but you needlessly complicated yourself for the tests.

Mon, Jul 6, 20:00
majcosta updated the test plan for D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 19:36
majcosta updated the test plan for D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 19:36
majcosta updated the test plan for D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 19:36
majcosta requested review of D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 19:36
deadalnix requested review of D6828: [avalanche] Remove getPubkey API.
Mon, Jul 6, 18:11
deadalnix committed rABCc357d6422cbd: [avalanche] Add a facility to update node's timeout (authored by deadalnix).
[avalanche] Add a facility to update node's timeout
Mon, Jul 6, 12:41
deadalnix closed D6825: [avalanche] Add a facility to update node's timeout.
Mon, Jul 6, 12:41
deadalnix added inline comments to D6825: [avalanche] Add a facility to update node's timeout.
Mon, Jul 6, 12:40
deadalnix committed rABCdcae6a72516c: [avalanche] Add facilities to delete nodes from the PeerManager (authored by deadalnix).
[avalanche] Add facilities to delete nodes from the PeerManager
Mon, Jul 6, 12:39
deadalnix closed D6824: [avalanche] Add facilities to delete nodes from the PeerManager.
Mon, Jul 6, 12:39
deadalnix committed rABC785a2f794bac: [avalanche] Add node related functions to the peermanager (authored by deadalnix).
[avalanche] Add node related functions to the peermanager
Mon, Jul 6, 12:38
deadalnix closed D6822: [avalanche] Add node related functions to the peermanager.
Mon, Jul 6, 12:37
deadalnix committed rABCb406ddfc609f: [avalanche] Add the notion of Peer to the PeerManager (authored by deadalnix).
[avalanche] Add the notion of Peer to the PeerManager
Mon, Jul 6, 12:36
deadalnix closed D6818: [avalanche] Add the notion of Peer to the PeerManager.
Mon, Jul 6, 12:36
deadalnix committed rABC77ce7e791586: [avalanche] Use an hash_unique key for the node/round index in QuerySet (authored by deadalnix).
[avalanche] Use an hash_unique key for the node/round index in QuerySet
Mon, Jul 6, 12:34
deadalnix closed D6823: [avalanche] Use an hash_unique key for the node/round index in QuerySet.
Mon, Jul 6, 12:34
deadalnix committed rABC52d09d010769: Move NO_NODE to net.h (authored by deadalnix).
Move NO_NODE to net.h
Mon, Jul 6, 12:33
deadalnix closed D6826: Move NO_NODE to net.h.
Mon, Jul 6, 12:33
Fabien accepted D6826: Move NO_NODE to net.h.
Mon, Jul 6, 06:33
Fabien accepted D6825: [avalanche] Add a facility to update node's timeout.
Mon, Jul 6, 06:32
Fabien accepted D6824: [avalanche] Add facilities to delete nodes from the PeerManager.
Mon, Jul 6, 06:26
Fabien accepted D6823: [avalanche] Use an hash_unique key for the node/round index in QuerySet.
Mon, Jul 6, 06:21
Fabien accepted D6822: [avalanche] Add node related functions to the peermanager.
Mon, Jul 6, 06:20
Fabien accepted D6818: [avalanche] Add the notion of Peer to the PeerManager.
Mon, Jul 6, 06:02
deadalnix requested review of D6826: Move NO_NODE to net.h.
Mon, Jul 6, 00:01

Sun, Jul 5

deadalnix requested review of D6825: [avalanche] Add a facility to update node's timeout.
Sun, Jul 5, 21:59
deadalnix requested review of D6824: [avalanche] Add facilities to delete nodes from the PeerManager.
Sun, Jul 5, 21:46
deadalnix updated the diff for D6822: [avalanche] Add node related functions to the peermanager.

Flatten things such as one multi_index is used and all nodes are in it.

Sun, Jul 5, 17:56
deadalnix updated the diff for D6818: [avalanche] Add the notion of Peer to the PeerManager.

Simplify the Peer struct so that it doesn't contain nodes. Nodes wills be stored in their own datastructure later on.

Sun, Jul 5, 17:25
majcosta committed rABC061f629c7e3e: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache
Sun, Jul 5, 03:47
majcosta closed D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Sun, Jul 5, 03:47
deadalnix planned changes to D6822: [avalanche] Add node related functions to the peermanager.

See D6818

Sun, Jul 5, 02:42
deadalnix planned changes to D6818: [avalanche] Add the notion of Peer to the PeerManager.

There is a better way to do this using multi index magic.

Sun, Jul 5, 02:41
deadalnix requested review of D6823: [avalanche] Use an hash_unique key for the node/round index in QuerySet.
Sun, Jul 5, 02:28
deadalnix updated the diff for D6822: [avalanche] Add node related functions to the peermanager.

rebase

Sun, Jul 5, 00:44
deadalnix updated the diff for D6818: [avalanche] Add the notion of Peer to the PeerManager.

rebase

Sun, Jul 5, 00:44
deadalnix accepted D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Sun, Jul 5, 00:41
deadalnix committed rABC0f4e51c145e0: [avalanche] Use std::chrono for time constants (authored by deadalnix).
[avalanche] Use std::chrono for time constants
Sun, Jul 5, 00:38
deadalnix closed D6821: [avalanche] Use std::chrono for time constants.
Sun, Jul 5, 00:38
deadalnix committed rABC7bd7f8c0caea: [avalanche] Use constexpr for global constants (authored by deadalnix).
[avalanche] Use constexpr for global constants
Sun, Jul 5, 00:34
deadalnix closed D6820: [avalanche] Use constexpr for global constants.
Sun, Jul 5, 00:34
deadalnix updated the summary of D6822: [avalanche] Add node related functions to the peermanager.
Sun, Jul 5, 00:31
deadalnix requested review of D6822: [avalanche] Add node related functions to the peermanager.
Sun, Jul 5, 00:31
majcosta accepted D6821: [avalanche] Use std::chrono for time constants.
Sun, Jul 5, 00:13
majcosta accepted D6820: [avalanche] Use constexpr for global constants.

Nit: consider getting rid of the AVALANCHE_ prefix unless where needed to convey that info; this is all static and we're in src/avalanche after all

Sun, Jul 5, 00:11

Sat, Jul 4

deadalnix updated the diff for D6821: [avalanche] Use std::chrono for time constants.

Name tweaks

Sat, Jul 4, 23:52
deadalnix requested review of D6821: [avalanche] Use std::chrono for time constants.
Sat, Jul 4, 23:45
deadalnix updated the diff for D6820: [avalanche] Use constexpr for global constants.

Also do AVALANCHE_TIME_STEP_MILLISECONDS

Sat, Jul 4, 23:41
deadalnix requested review of D6820: [avalanche] Use constexpr for global constants.
Sat, Jul 4, 23:32
teamcity added a comment to D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Sat, Jul 4, 22:53
teamcity updated the summary of D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Sat, Jul 4, 22:53
majcosta requested review of D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Sat, Jul 4, 22:53
Fabien committed rABC04cf5437c814: [CI] Improve teamcity error reporting by setting the failure message (authored by Fabien).
[CI] Improve teamcity error reporting by setting the failure message
Sat, Jul 4, 07:34
Fabien closed D6817: [CI] Improve teamcity error reporting by setting the failure message.
Sat, Jul 4, 07:34
deadalnix updated the diff for D6818: [avalanche] Add the notion of Peer to the PeerManager.

vetor => vector

Sat, Jul 4, 01:01
deadalnix requested review of D6818: [avalanche] Add the notion of Peer to the PeerManager.
Sat, Jul 4, 01:00

Fri, Jul 3

jasonbcox accepted D6817: [CI] Improve teamcity error reporting by setting the failure message.
Fri, Jul 3, 21:49
deadalnix accepted D6817: [CI] Improve teamcity error reporting by setting the failure message.
Fri, Jul 3, 21:47
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:41
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:36
Fabien added a comment to D6817: [CI] Improve teamcity error reporting by setting the failure message.

Examples of rendering:
Success: https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=91213&guest=1
And failure: https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=91243&guest=1

Fri, Jul 3, 21:34
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:33
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:25
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Fri, Jul 3, 21:24
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

Don't keep the original message in case of a failure

Fri, Jul 3, 21:24
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:21
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:20
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:20
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

Deduplicate the status message

Fri, Jul 3, 21:15
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:12
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Fri, Jul 3, 21:11
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:08
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Fri, Jul 3, 21:08