Two of the commands don't work when copy-pasting them, due to a missing fragment of filename. Otherwise explanations and instructions LGTM.
More minor updates
Various updates and fixes
Update file name and date
Responding to review feedback
delete the right file
remove validation_load_mempool.cpp from the changeset.
Wed, Jun 29
Return $messages instead of array() when rustfmt made no changes to the code
Fix comments in .rustfmt.toml, don't group rules but sort by alphabet. Use rustfmt +abc-nightly in the linter.
Use nightly rustfmt, which simplifies the linter substantially
Use cargo fmt -- --check to lint files, which outputs a diff, and process that.
Tue, Jun 28
I'm not seeing the logic subscribing to websocket tx seen messages in this diff even though it's in the description. The next part (Part 4) of this stacked diff series doesn't seem to cover this either. Does this have anything to do with the build failure above?
script.push(Buffer.from(currency.opReturn.opReturnPrefixHex, 'hex')); actually evaluates to '016a' instead of keeping the hex string intact. This behavour is specific to the initial script array element. To get around this, I've followed the bch-js approach of directly using the opReturn prefix in decimal form for the initial entry.