Page MenuHomePhabricator
Feed All Stories

Today

PiRK requested changes to D11690: [WIP][website] Add blog post about running Electrum ABC in daemon mode.

Two of the commands don't work when copy-pasting them, due to a missing fragment of filename. Otherwise explanations and instructions LGTM.

Fri, Jul 1, 12:51
Fabien accepted D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.
Fri, Jul 1, 11:58
Fabien requested changes to D11688: [Chronik] Install nightly rust toolchain dependency (as "abc-nightly").
Fri, Jul 1, 11:53
Mengerian updated the diff for D11690: [WIP][website] Add blog post about running Electrum ABC in daemon mode.

More minor updates

Fri, Jul 1, 04:24
Mengerian updated the diff for D11690: [WIP][website] Add blog post about running Electrum ABC in daemon mode.

Various updates and fixes

Fri, Jul 1, 04:14

Yesterday

bytesofman requested changes to D11662: [Cashtab] Add parseInvalidSettingsForMigration function.
Thu, Jun 30, 21:58
bytesofman requested changes to D11689: [Cashtab] Parse airdrops in TxHistory.
Thu, Jun 30, 21:22
bytesofman requested review of D11691: [Cashtab] [WS update engine Part 4] On successful websocket connection, change wallet utxo refresh interval from 1s to 30s.
Thu, Jun 30, 20:54
Mengerian updated the diff for D11690: [WIP][website] Add blog post about running Electrum ABC in daemon mode.

Update file name and date
Update subtitle

Thu, Jun 30, 20:09
Mengerian requested review of D11690: [WIP][website] Add blog post about running Electrum ABC in daemon mode.
Thu, Jun 30, 20:04
kieran709 updated the diff for D11662: [Cashtab] Add parseInvalidSettingsForMigration function.

Responding to review feedback

Thu, Jun 30, 18:43
kieran709 requested review of D11689: [Cashtab] Parse airdrops in TxHistory.
Thu, Jun 30, 14:39
PiRK closed D11686: scripted-diff: tree-wide: Remove all review-only assertions.
Thu, Jun 30, 09:02
PiRK closed D11685: tree-wide: Remove stray review-only assertion.
Thu, Jun 30, 09:02
PiRK committed rABC7e8275e964af: tree-wide: Remove stray review-only assertion (authored by PiRK).
tree-wide: Remove stray review-only assertion
Thu, Jun 30, 09:02
PiRK committed rABC7e0e3d2c3b03: scripted-diff: tree-wide: Remove all review-only assertions (authored by PiRK).
scripted-diff: tree-wide: Remove all review-only assertions
Thu, Jun 30, 09:02
PiRK closed D11683: scripted-diff: wallet/test: Use existing chainman.
Thu, Jun 30, 09:02
PiRK closed D11684: qt/test: Use existing chainman in ::TestGUI.
Thu, Jun 30, 09:02
PiRK committed rABCc392b9db219c: qt/test: Use existing chainman in ::TestGUI (authored by Carl Dong <contact@carldong.me>).
qt/test: Use existing chainman in ::TestGUI
Thu, Jun 30, 09:02
PiRK committed rABC0655265d8d10: scripted-diff: wallet/test: Use existing chainman (authored by PiRK).
scripted-diff: wallet/test: Use existing chainman
Thu, Jun 30, 09:02
PiRK committed rABC88f0dc11af50: fuzz: Initialize a TestingSetup for test_one_input (authored by Carl Dong <contact@carldong.me>).
fuzz: Initialize a TestingSetup for test_one_input
Thu, Jun 30, 09:02
PiRK closed D11682: fuzz: Initialize a TestingSetup for test_one_input.
Thu, Jun 30, 09:02
Fabien accepted D11682: fuzz: Initialize a TestingSetup for test_one_input.
Thu, Jun 30, 09:01
PiRK updated the diff for D11682: fuzz: Initialize a TestingSetup for test_one_input.

delete the right file

Thu, Jun 30, 08:59
teamcity added a comment to D11682: fuzz: Initialize a TestingSetup for test_one_input.
Thu, Jun 30, 08:49
teamcity added a comment to D11682: fuzz: Initialize a TestingSetup for test_one_input.
Thu, Jun 30, 08:49
teamcity added a comment to D11682: fuzz: Initialize a TestingSetup for test_one_input.
Thu, Jun 30, 08:49
teamcity added a comment to D11682: fuzz: Initialize a TestingSetup for test_one_input.
Thu, Jun 30, 08:49
teamcity added a comment to D11682: fuzz: Initialize a TestingSetup for test_one_input.
Thu, Jun 30, 08:49
teamcity added a comment to D11682: fuzz: Initialize a TestingSetup for test_one_input.
Thu, Jun 30, 08:49
PiRK updated the diff for D11682: fuzz: Initialize a TestingSetup for test_one_input.

remove validation_load_mempool.cpp from the changeset.

Thu, Jun 30, 08:48
teamcity closed T2525: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Resolved.
Thu, Jun 30, 08:26
teamcity closed T2524: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Thu, Jun 30, 08:13
teamcity triaged T2525: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Unbreak Now! priority.
Thu, Jun 30, 08:02
Fabien closed D11681: [avalanche] Skip processing compact proofs with no shortid.
Thu, Jun 30, 07:58
Fabien committed rABC318195f9051b: [avalanche] Skip processing compact proofs with no shortid (authored by Fabien).
[avalanche] Skip processing compact proofs with no shortid
Thu, Jun 30, 07:58
Fabien closed D11677: [avalanche] Poll for unorphaned proofs.
Thu, Jun 30, 07:54
Fabien committed rABC82012e10d80c: [avalanche] Poll for unorphaned proofs (authored by Fabien).
[avalanche] Poll for unorphaned proofs
Thu, Jun 30, 07:54
Fabien closed D11680: [avalanche] Add a facility for building an compact proofs message in tests.
Thu, Jun 30, 07:48
Fabien committed rABC38372c64b611: [avalanche] Add a facility for building an compact proofs message in tests (authored by Fabien).
[avalanche] Add a facility for building an compact proofs message in tests
Thu, Jun 30, 07:48
Fabien closed D11676: [avalanche] Don't attempt to register the same proof several times during orphan rescan.
Thu, Jun 30, 07:47
Fabien committed rABCc2070bf6fcb0: [avalanche] Don't attempt to register the same proof several times during… (authored by Fabien).
[avalanche] Don't attempt to register the same proof several times during…
Thu, Jun 30, 07:47
sdulfari abandoned D11582: [avalanche] Limit the size of the valid proof pool.
Thu, Jun 30, 06:00
teamcity triaged T2524: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Thu, Jun 30, 03:46
abc-bot committed rABCec6d12388b70: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Thu, Jun 30, 03:19
teamcity closed T2523: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Resolved.
Thu, Jun 30, 02:33
abc-bot committed rABCdb580a4bc49c: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Thu, Jun 30, 02:15
teamcity triaged T2523: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
Thu, Jun 30, 02:14
abc-bot committed rABC080d1e9cbd66: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Thu, Jun 30, 02:06
deadalnix accepted D11677: [avalanche] Poll for unorphaned proofs.
Thu, Jun 30, 00:05
deadalnix accepted D11681: [avalanche] Skip processing compact proofs with no shortid.
Thu, Jun 30, 00:02
deadalnix accepted D11680: [avalanche] Add a facility for building an compact proofs message in tests.
Thu, Jun 30, 00:01

Wed, Jun 29

deadalnix accepted D11676: [avalanche] Don't attempt to register the same proof several times during orphan rescan.
Wed, Jun 29, 23:59
tobias_ruck updated the diff for D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.

Return $messages instead of array() when rustfmt made no changes to the code

Wed, Jun 29, 23:40
tobias_ruck updated the diff for D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.

Fix comments in .rustfmt.toml, don't group rules but sort by alphabet. Use rustfmt +abc-nightly in the linter.

Wed, Jun 29, 23:37
tobias_ruck requested review of D11688: [Chronik] Install nightly rust toolchain dependency (as "abc-nightly").
Wed, Jun 29, 23:20
bytesofman updated the diff for D11673: [Cashtab] [WS Update Engine Part 3] On websocket tx seen message, refresh the wallet utxo set.

Removing comments

Wed, Jun 29, 22:04
Fabien closed D11672: [avalanche] Simplify the proof reconciliation logic.
Wed, Jun 29, 19:15
Fabien committed rABC6a743626db33: [avalanche] Simplify the proof reconciliation logic (authored by Fabien).
[avalanche] Simplify the proof reconciliation logic
Wed, Jun 29, 19:15
Fabien accepted D11686: scripted-diff: tree-wide: Remove all review-only assertions.
Wed, Jun 29, 19:09
Fabien accepted D11684: qt/test: Use existing chainman in ::TestGUI.
Wed, Jun 29, 19:06
Fabien accepted D11685: tree-wide: Remove stray review-only assertion.
Wed, Jun 29, 19:05
Fabien accepted D11683: scripted-diff: wallet/test: Use existing chainman.
Wed, Jun 29, 16:20
Fabien requested changes to D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.
Wed, Jun 29, 16:19
Fabien requested changes to D11682: fuzz: Initialize a TestingSetup for test_one_input.
Wed, Jun 29, 15:56
tobias_ruck updated the diff for D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.

Use nightly rustfmt, which simplifies the linter substantially

Wed, Jun 29, 15:55
PiRK accepted D11672: [avalanche] Simplify the proof reconciliation logic.
Wed, Jun 29, 15:46
Fabien closed D11687: [linter] Fix a outdated comment on clang format version.
Wed, Jun 29, 15:35
Fabien committed rABC4ea84717df12: [linter] Fix a outdated comment on clang format version (authored by Fabien).
[linter] Fix a outdated comment on clang format version
Wed, Jun 29, 15:34
tobias_ruck accepted D11687: [linter] Fix a outdated comment on clang format version.
Wed, Jun 29, 15:33
Fabien requested review of D11687: [linter] Fix a outdated comment on clang format version.
Wed, Jun 29, 15:33
tobias_ruck updated the summary of D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.
Wed, Jun 29, 11:15
tobias_ruck updated the summary of D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.
Wed, Jun 29, 11:14
tobias_ruck updated the summary of D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.
Wed, Jun 29, 11:14
tobias_ruck updated the diff for D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.

Use cargo fmt -- --check to lint files, which outputs a diff, and process that.

Wed, Jun 29, 11:12
teamcity updated the summary of D11686: scripted-diff: tree-wide: Remove all review-only assertions.
Wed, Jun 29, 10:23
PiRK requested review of D11686: scripted-diff: tree-wide: Remove all review-only assertions.
Wed, Jun 29, 10:22
teamcity updated the summary of D11685: tree-wide: Remove stray review-only assertion.
Wed, Jun 29, 10:20
PiRK requested review of D11685: tree-wide: Remove stray review-only assertion.
Wed, Jun 29, 10:20
teamcity updated the summary of D11684: qt/test: Use existing chainman in ::TestGUI.
Wed, Jun 29, 10:18
PiRK requested review of D11684: qt/test: Use existing chainman in ::TestGUI.
Wed, Jun 29, 10:18
teamcity updated the summary of D11683: scripted-diff: wallet/test: Use existing chainman.
Wed, Jun 29, 10:17
PiRK requested review of D11683: scripted-diff: wallet/test: Use existing chainman.
Wed, Jun 29, 10:17
teamcity updated the summary of D11682: fuzz: Initialize a TestingSetup for test_one_input.
Wed, Jun 29, 10:16
PiRK requested review of D11682: fuzz: Initialize a TestingSetup for test_one_input.
Wed, Jun 29, 10:16
PiRK closed D11679: fuzz: Initialize a full TestingSetup where appropriate.
Wed, Jun 29, 08:32
PiRK committed rABC4f0ff1e2f9e2: fuzz: Initialize a full TestingSetup where appropriate (authored by Carl Dong <contact@carldong.me>).
fuzz: Initialize a full TestingSetup where appropriate
Wed, Jun 29, 08:32
PiRK closed D11678: fuzz: Consolidate fuzzing TestingSetup initialization.
Wed, Jun 29, 08:32
PiRK committed rABCc5004dcda240: fuzz: Consolidate fuzzing TestingSetup initialization (authored by Carl Dong <contact@carldong.me>).
fuzz: Consolidate fuzzing TestingSetup initialization
Wed, Jun 29, 08:32
Fabien abandoned D11637: [avalanche] Remove obsolete orphan proofs.
Wed, Jun 29, 07:21
bytesofman accepted D11626: [Cashtab] [Chronik] [Tx Gen] Generate encoded OP_RETURN script.
Wed, Jun 29, 04:23
teamcity closed T2521: Build Bitcoin-ABC / Nightly Builds / Health Checks / Check Seeds is broken. as Resolved.
Wed, Jun 29, 03:03
emack updated the diff for D11626: [Cashtab] [Chronik] [Tx Gen] Generate encoded OP_RETURN script.

Updated comments

Wed, Jun 29, 00:14

Tue, Jun 28

emack accepted D11673: [Cashtab] [WS Update Engine Part 3] On websocket tx seen message, refresh the wallet utxo set.
Tue, Jun 28, 23:41
Fabien accepted D11679: fuzz: Initialize a full TestingSetup where appropriate.
Tue, Jun 28, 20:18
Fabien accepted D11678: fuzz: Consolidate fuzzing TestingSetup initialization.
Tue, Jun 28, 20:16
Fabien requested review of D11681: [avalanche] Skip processing compact proofs with no shortid.
Tue, Jun 28, 18:54
bytesofman added a comment to D11673: [Cashtab] [WS Update Engine Part 3] On websocket tx seen message, refresh the wallet utxo set.

I'm not seeing the logic subscribing to websocket tx seen messages in this diff even though it's in the description. The next part (Part 4) of this stacked diff series doesn't seem to cover this either. Does this have anything to do with the build failure above?

Tue, Jun 28, 16:40
bytesofman requested changes to D11626: [Cashtab] [Chronik] [Tx Gen] Generate encoded OP_RETURN script.

script.push(Buffer.from(currency.opReturn.opReturnPrefixHex, 'hex')); actually evaluates to '016a' instead of keeping the hex string intact. This behavour is specific to the initial script array element. To get around this, I've followed the bch-js approach of directly using the opReturn prefix in decimal form for the initial entry.

Tue, Jun 28, 16:31
Fabien requested review of D11680: [avalanche] Add a facility for building an compact proofs message in tests.
Tue, Jun 28, 16:06