Page MenuHomePhabricator
Feed All Stories

Today

Fabien accepted D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.
Fri, Oct 18, 07:12
Fabien accepted D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Fri, Oct 18, 06:59
jasonbcox accepted D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Fri, Oct 18, 00:47
jasonbcox accepted D4254: ui: Support wallets unloaded dynamically.
Fri, Oct 18, 00:33

Yesterday

teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Oct 17, 19:18
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Oct 17, 19:11
teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Oct 17, 19:07
nakihito updated the diff for D3950: Merge #12953: Deprecate accounts.

Rebased.

Thu, Oct 17, 19:07
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Oct 17, 18:57
nakihito updated the diff for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Fixed shared pointers.

Thu, Oct 17, 18:57
teamcity added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Oct 17, 18:50
Harbormaster failed remote builds in B7800: Diff 13597 for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet!
Thu, Oct 17, 18:40
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Thu, Oct 17, 18:40
teamcity added a comment to D4254: ui: Support wallets unloaded dynamically.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Oct 17, 18:39
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Oct 17, 18:37
nakihito planned changes to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Thu, Oct 17, 18:37
teamcity added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Oct 17, 18:37
nakihito updated the diff for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Rebased.

Thu, Oct 17, 18:28
nakihito updated the diff for D3308: Merge #9894: remove 'label' filter for rpc command help.

Rebased.

Thu, Oct 17, 18:25
teamcity added a comment to D4254: ui: Support wallets unloaded dynamically.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Oct 17, 18:23
nakihito updated the diff for D4254: ui: Support wallets unloaded dynamically.

Reverted constructor change for BitcoinGUI.

Thu, Oct 17, 18:23
Nico Guiton <nico@bitframe.org> committed rABC5be9de3adac4: Merge #11050: Avoid treating null RPC arguments different from missing arguments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11050: Avoid treating null RPC arguments different from missing arguments
Thu, Oct 17, 18:19
Nico Guiton <nico@bitframe.org> closed D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.
Thu, Oct 17, 18:19
Nico Guiton <nico@bitframe.org> committed rABCbe32cf1c6cd2: Merge #11191: RPC: Improve help text and behavior of RPC-logging. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11191: RPC: Improve help text and behavior of RPC-logging.
Thu, Oct 17, 18:05
Nico Guiton <nico@bitframe.org> closed D3699: Merge #11191: RPC: Improve help text and behavior of RPC-logging..
Thu, Oct 17, 18:05
teamcity added a comment to D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Oct 17, 17:49
fpelliccioni added a comment to D4234: bench: Benchmark MempoolToJSON.

It's not clear you go the dependency in the right order.in any case, it seems that you have https://github.com/bitcoin/bitcoin/pull/11062 to go through first.

Thu, Oct 17, 17:46
fpelliccioni added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

I think you got the dependency reversed.

Thu, Oct 17, 17:46
Nico Guiton <nico@bitframe.org> committed rABCca5cfcef0609: Merge #11626: rpc: Make `logging` RPC public (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11626: rpc: Make `logging` RPC public
Thu, Oct 17, 17:42
Nico Guiton <nico@bitframe.org> closed D3684: Merge #11626: rpc: Make `logging` RPC public.
Thu, Oct 17, 17:42
fpelliccioni updated the summary of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Thu, Oct 17, 17:39
teamcity added a comment to D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Oct 17, 17:39
fpelliccioni created D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.
Thu, Oct 17, 17:39
Nico Guiton <nico@bitframe.org> committed rABCa1f767f4b1e9: [rpc] Add logging RPC (authored by John Newbery <john@johnnewbery.com>).
[rpc] Add logging RPC
Thu, Oct 17, 17:27
Nico Guiton <nico@bitframe.org> closed D3464: [rpc] Add logging RPC.
Thu, Oct 17, 17:27
deadalnix accepted D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Thu, Oct 17, 01:46
deadalnix requested changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

The changes made in D3371 do not affect the constructor, so the rationale for not backporting makes no sense whatsoever.

Thu, Oct 17, 01:44
deadalnix requested changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Thu, Oct 17, 01:41
deadalnix requested changes to D4190: Rename master key to seed.

Where are the other rename done, then ? I don't see a patch in the stack doing that. I don't understand why the double write doesn't come first, then the scripted diff? The way this is done is exceedingly difficult to review.

Thu, Oct 17, 01:36
deadalnix requested changes to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Actually run your test plan.

Thu, Oct 17, 01:33
deadalnix requested changes to D4234: bench: Benchmark MempoolToJSON.

It's not clear you go the dependency in the right order.in any case, it seems that you have https://github.com/bitcoin/bitcoin/pull/11062 to go through first.

Thu, Oct 17, 01:28
deadalnix added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

I think you got the dependency reversed.

Thu, Oct 17, 01:26
deadalnix accepted D3464: [rpc] Add logging RPC.
Thu, Oct 17, 01:25

Wed, Oct 16

jasonbcox added a comment to D4240: [gitian-build] Remove ambiguous buildsign argument.

Why increased automation would make this parameter obsolete? Why remove it before such automation exists and the parameter actually is obsolete?

Wed, Oct 16, 23:59
jasonbcox added a comment to D4241: [gitian-build] Rename ambiguous --sign argument.

First, I'm not convinced this is ambiguous. What would you sign in there that makes any sense? Is that worth breaking things? Second, the test plan doesn't cover the feature whatsoever.

Wed, Oct 16, 23:57
Nico Guiton <nico@bitframe.org> committed rABCbbfb8effa8f8: Change CDnsSeedOpts to use std::string instead of c-strings (authored by Nico Guiton <nico@bitframe.org>).
Change CDnsSeedOpts to use std::string instead of c-strings
Wed, Oct 16, 20:38
Nico Guiton <nico@bitframe.org> closed D4251: Change CDnsSeedOpts to use std::string instead of c-strings.
Wed, Oct 16, 20:38
jasonbcox accepted D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.
Wed, Oct 16, 20:27
jasonbcox requested changes to D4254: ui: Support wallets unloaded dynamically.
Wed, Oct 16, 20:26
jasonbcox accepted D4253: rpc: Add unloadwallet RPC, release notes, and tests.

I don't see a good reason to block this based on the discussion in PR14941. That change is an improvement, but we'll need to backport up to it to get it.

Wed, Oct 16, 20:15
jasonbcox accepted D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Wed, Oct 16, 20:00
teamcity added a comment to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 16, 18:19
teamcity added a comment to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 16, 18:09
nakihito updated the diff for D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Rebased.

Wed, Oct 16, 18:05
Nico Guiton <nico@bitframe.org> committed rABCaefa60f5c9fd: Introduce constant default variables to initialize seeder options (authored by Nico Guiton <nico@bitframe.org>).
Introduce constant default variables to initialize seeder options
Wed, Oct 16, 17:53
Nico Guiton <nico@bitframe.org> closed D4250: Introduce constant default variables to initialize seeder options.
Wed, Oct 16, 17:53
Nico Guiton <nico@bitframe.org> committed rABC995338aa7108: Remove strlcpy.h (authored by Nico Guiton <nico@bitframe.org>).
Remove strlcpy.h
Wed, Oct 16, 17:48
Nico Guiton <nico@bitframe.org> closed D4259: Remove strlcpy.h.
Wed, Oct 16, 17:48
jasonbcox committed rABCdef2d9c3216e: Fix misnamed 0.20.4 release notes (authored by jasonbcox).
Fix misnamed 0.20.4 release notes
Wed, Oct 16, 16:21
jasonbcox closed D4260: Fix misnamed 0.20.4 release notes.
Wed, Oct 16, 16:21
jasonbcox accepted D4250: Introduce constant default variables to initialize seeder options.
Wed, Oct 16, 16:21
fpelliccioni added inline comments to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Wed, Oct 16, 15:47
Fabien requested changes to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Wed, Oct 16, 15:20
deadalnix accepted D4259: Remove strlcpy.h.
Wed, Oct 16, 10:02
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 16, 07:16
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 16, 07:08
teamcity added a comment to D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 16, 07:07
Fabien planned changes to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Wed, Oct 16, 06:58
Fabien updated the summary of D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Wed, Oct 16, 06:58
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Revert dependency, now depends on D4257.

Wed, Oct 16, 06:58
teamcity added a comment to D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 16, 06:57
Fabien updated the summary of D4257: [CMAKE] Propagate requirements for cmake >= 3.12.
Wed, Oct 16, 06:56
Fabien updated the diff for D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Revert diff dependency.

Wed, Oct 16, 06:56
Fabien committed rABC1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt (authored by Fabien).
[CMAKE] Add resource file to bitcoin-qt
Wed, Oct 16, 06:53
Fabien closed D4256: [CMAKE] Add resource file to bitcoin-qt.
Wed, Oct 16, 06:53
teamcity added a comment to D4260: Fix misnamed 0.20.4 release notes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 16, 06:41
Fabien accepted D4260: Fix misnamed 0.20.4 release notes.
Wed, Oct 16, 06:33
teamcity added a comment to D4260: Fix misnamed 0.20.4 release notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 16, 06:32
jasonbcox created D4260: Fix misnamed 0.20.4 release notes.
Wed, Oct 16, 06:32
nakihito updated the summary of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Wed, Oct 16, 02:08
nakihito requested review of D4190: Rename master key to seed.

The diff doesn't match the description anymore. It's also unclear to me why the double outputs wasn't stacked first.

Wed, Oct 16, 02:06
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 16, 02:04
teamcity added a comment to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 16, 02:02
nakihito requested review of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.
Wed, Oct 16, 01:54
nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Wed, Oct 16, 01:54
nakihito updated the summary of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.
Wed, Oct 16, 01:53
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 16, 01:53
nakihito updated the diff for D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Removed changes from PR14444.

Wed, Oct 16, 01:52
teamcity added a comment to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 16, 01:51
nakihito planned changes to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.
Wed, Oct 16, 01:50
nakihito updated the diff for D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Added changes to validation.cpp. Removed them from D4026.

Wed, Oct 16, 01:50
teamcity added a comment to D4259: Remove strlcpy.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 16, 00:37
teamcity added a comment to D4259: Remove strlcpy.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 16, 00:27
nakihito created D4259: Remove strlcpy.h.
Wed, Oct 16, 00:27

Tue, Oct 15

teamcity added a comment to D4250: Introduce constant default variables to initialize seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Oct 15, 23:57
teamcity added a comment to D4250: Introduce constant default variables to initialize seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Oct 15, 23:48
nakihito updated the diff for D4250: Introduce constant default variables to initialize seeder options.

Changed default variable names and pattern from *_DEFAULT to DEFAULT_*.

Tue, Oct 15, 23:48
jasonbcox requested changes to D4250: Introduce constant default variables to initialize seeder options.
Tue, Oct 15, 22:31
teamcity added a comment to D4250: Introduce constant default variables to initialize seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Oct 15, 18:34
teamcity added a comment to D4250: Introduce constant default variables to initialize seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Oct 15, 18:24