Page MenuHomePhabricator
Feed All Stories

Today

majcosta accepted D8186: Send amount shows minimum amount placeholder.
Thu, Oct 29, 22:08
PiRK closed D8178: qt: Remove "Pay only required fee" checkbox.
Thu, Oct 29, 22:02
PiRK committed rABC0c866043338f: qt: Remove "Pay only required fee" checkbox (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
qt: Remove "Pay only required fee" checkbox
Thu, Oct 29, 22:02
PiRK closed D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 21:50
PiRK committed rABC6c4d530bf35c: [logging] Don't log REJECT code when transaction is rejected (authored by John Newbery <john@johnnewbery.com>).
[logging] Don't log REJECT code when transaction is rejected
Thu, Oct 29, 21:50
PiRK closed D8181: [validation] Fix peer punishment for bad blocks.
Thu, Oct 29, 21:39
PiRK committed rABC8a980e61c9f8: [validation] Fix peer punishment for bad blocks (authored by John Newbery <john@johnnewbery.com>).
[validation] Fix peer punishment for bad blocks
Thu, Oct 29, 21:39
teamcity updated the summary of D8186: Send amount shows minimum amount placeholder.
Thu, Oct 29, 21:25
PiRK requested review of D8186: Send amount shows minimum amount placeholder.
Thu, Oct 29, 21:25
jasonbcox accepted D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 20:46
PiRK updated the diff for D8178: qt: Remove "Pay only required fee" checkbox.

rebase

Thu, Oct 29, 20:00
Fabien closed D8157: [SECP256K1] Make autotools check for all the used openssl functions.
Thu, Oct 29, 19:25
Fabien committed rABCccf0cf3c662e: [SECP256K1] Make autotools check for all the used openssl functions (authored by Elichai Turkel <elichai.turkel@gmail.com>).
[SECP256K1] Make autotools check for all the used openssl functions
Thu, Oct 29, 19:24
majcosta closed D8179: [backport#12075] [scripts] Add missing univalue file to copyright_header.py.
Thu, Oct 29, 18:56
majcosta committed rABCf780be44599f: [backport#12075] [scripts] Add missing univalue file to copyright_header.py (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#12075] [scripts] Add missing univalue file to copyright_header.py
Thu, Oct 29, 18:56
majcosta closed D8180: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addresses.
Thu, Oct 29, 18:48
majcosta committed rABC1dd3de23870b: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly… (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly…
Thu, Oct 29, 18:48
PiRK closed D8176: qt: Improve BitcoinAmountField class.
Thu, Oct 29, 18:37
PiRK committed rABC3e543f79b679: qt: Improve BitcoinAmountField class (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
qt: Improve BitcoinAmountField class
Thu, Oct 29, 18:37
PiRK abandoned D8174: WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 18:33
PiRK updated the diff for D8183: [validation] Remove REJECT code from CValidationState.

rebase after moving some functional tests to previous commit D8182

Thu, Oct 29, 18:26
deadalnix accepted D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 18:24
PiRK updated the diff for D8182: [logging] Don't log REJECT code when transaction is rejected.

fix additional tests that were initially fixed in the following commit (D8183)

Thu, Oct 29, 18:22
deadalnix accepted D8157: [SECP256K1] Make autotools check for all the used openssl functions.
Thu, Oct 29, 18:22
deadalnix accepted D8183: [validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 18:21
deadalnix accepted D8184: [validation] Fix REJECT message comments.
Thu, Oct 29, 18:20
jasonbcox accepted D8180: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addresses.
Thu, Oct 29, 18:09
jasonbcox accepted D8179: [backport#12075] [scripts] Add missing univalue file to copyright_header.py.
Thu, Oct 29, 18:09
PiRK added a comment to D8182: [logging] Don't log REJECT code when transaction is rejected.

I need to move some test changes from the next commit into this one and update the test plan. WIP

Thu, Oct 29, 18:08
jasonbcox requested changes to D8182: [logging] Don't log REJECT code when transaction is rejected.

See test failures

Thu, Oct 29, 18:08
jasonbcox accepted D8181: [validation] Fix peer punishment for bad blocks.
Thu, Oct 29, 18:07
jasonbcox accepted D8185: [docs] Add release notes for removal of REJECT codes in logging.
Thu, Oct 29, 18:05
teamcity added a comment to D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 17:57
teamcity added a comment to D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 17:57
teamcity added a comment to D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 17:57
teamcity updated the summary of D8185: [docs] Add release notes for removal of REJECT codes in logging.
Thu, Oct 29, 17:56
PiRK requested review of D8185: [docs] Add release notes for removal of REJECT codes in logging.
Thu, Oct 29, 17:56
teamcity added a comment to D8181: [validation] Fix peer punishment for bad blocks.
Thu, Oct 29, 17:50
teamcity updated the summary of D8184: [validation] Fix REJECT message comments.
Thu, Oct 29, 17:48
PiRK requested review of D8184: [validation] Fix REJECT message comments.
Thu, Oct 29, 17:48
teamcity updated the summary of D8183: [validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 17:45
PiRK requested review of D8183: [validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 17:45
PiRK updated the summary of D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 17:39
teamcity updated the summary of D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 17:39
PiRK requested review of D8182: [logging] Don't log REJECT code when transaction is rejected.
Thu, Oct 29, 17:39
teamcity updated the summary of D8181: [validation] Fix peer punishment for bad blocks.
Thu, Oct 29, 17:35
PiRK requested review of D8181: [validation] Fix peer punishment for bad blocks.
Thu, Oct 29, 17:34
teamcity updated the summary of D8180: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addresses.
Thu, Oct 29, 17:12
majcosta requested review of D8180: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addresses.
Thu, Oct 29, 17:12
teamcity updated the summary of D8179: [backport#12075] [scripts] Add missing univalue file to copyright_header.py.
Thu, Oct 29, 17:04
majcosta requested review of D8179: [backport#12075] [scripts] Add missing univalue file to copyright_header.py.
Thu, Oct 29, 17:04
PiRK closed D8177: Remove custom fee radio group.
Thu, Oct 29, 16:07
PiRK committed rABC3e66b6d59e84: Remove custom fee radio group (authored by Andrew Chow <achow101-github@achow101.com>).
Remove custom fee radio group
Thu, Oct 29, 16:07
majcosta closed D8171: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests.
Thu, Oct 29, 16:06
majcosta committed rABCd678fee2afbb: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests
Thu, Oct 29, 16:06
PiRK updated the diff for D8176: qt: Improve BitcoinAmountField class.

closing comment on new line

Thu, Oct 29, 16:05
majcosta abandoned D8167: [backport#11448] [gui] reset addrProxy/addrSeparateProxyTor if colon char missing.

oh cool this is a skip then. abandoning

Thu, Oct 29, 15:55
Fabien accepted D8171: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests.
Thu, Oct 29, 15:50
Fabien accepted D8178: qt: Remove "Pay only required fee" checkbox.
Thu, Oct 29, 15:48
majcosta closed D8166: [backport#11419] Utils: Fix launchctl not being able to stop bitcoind.
Thu, Oct 29, 15:47
majcosta committed rABCa99a884db819: [backport#11419] Utils: Fix launchctl not being able to stop bitcoind (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#11419] Utils: Fix launchctl not being able to stop bitcoind
Thu, Oct 29, 15:47
majcosta closed D8168: [backport#11594] Improve -disablewallet parameter interaction.
Thu, Oct 29, 15:47
majcosta committed rABCe5c7da9fd970: [backport#11594] Improve -disablewallet parameter interaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#11594] Improve -disablewallet parameter interaction
Thu, Oct 29, 15:47
majcosta closed D8169: [backport#11676] contrib/init: Update openrc-run filename.
Thu, Oct 29, 15:46
majcosta committed rABC21f4914112c4: [backport#11676] contrib/init: Update openrc-run filename (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#11676] contrib/init: Update openrc-run filename
Thu, Oct 29, 15:46
Fabien accepted D8176: qt: Improve BitcoinAmountField class.
Thu, Oct 29, 15:40
majcosta closed D8170: [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it.
Thu, Oct 29, 15:40
majcosta committed rABC6c82ad9ec689: [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell…
Thu, Oct 29, 15:40
majcosta closed D8172: [backport#11140] Trivial: Improve #endif comments.
Thu, Oct 29, 15:39
majcosta committed rABC6b08ed7779e1: [backport#11140] Trivial: Improve #endif comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#11140] Trivial: Improve #endif comments
Thu, Oct 29, 15:39
majcosta closed D8173: [backport#11804] [docs] Fixed outdated link with archive.is.
Thu, Oct 29, 15:38
majcosta committed rABCbb727339e2de: [backport#11804] [docs] Fixed outdated link with archive.is (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#11804] [docs] Fixed outdated link with archive.is
Thu, Oct 29, 15:38
majcosta updated the diff for D8171: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests.

addressed comments

Thu, Oct 29, 15:36
Fabien accepted D8177: Remove custom fee radio group.
Thu, Oct 29, 15:23
teamcity added a comment to D8178: qt: Remove "Pay only required fee" checkbox.
Thu, Oct 29, 14:44
PiRK retitled D8174: WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState from WIP: [validation] Remove REJECT code from CValidationState to WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 14:40
PiRK updated the summary of D8178: qt: Remove "Pay only required fee" checkbox.
Thu, Oct 29, 14:33
teamcity updated the summary of D8178: qt: Remove "Pay only required fee" checkbox.
Thu, Oct 29, 14:32
PiRK requested review of D8178: qt: Remove "Pay only required fee" checkbox.
Thu, Oct 29, 14:32
PiRK updated the diff for D8176: qt: Improve BitcoinAmountField class.

rebase on top of D8177

Thu, Oct 29, 14:27
PiRK updated the summary of D8176: qt: Improve BitcoinAmountField class.
Thu, Oct 29, 14:23
teamcity updated the summary of D8177: Remove custom fee radio group.
Thu, Oct 29, 14:23
PiRK requested review of D8177: Remove custom fee radio group.
Thu, Oct 29, 14:23
teamcity updated the summary of D8176: qt: Improve BitcoinAmountField class.
Thu, Oct 29, 12:59
PiRK requested review of D8176: qt: Improve BitcoinAmountField class.
Thu, Oct 29, 12:59
woakeschris updated woakeschris.
Thu, Oct 29, 10:59
PiRK closed D8161: gui: don't disable the sync overlay when wallet is disabled.
Thu, Oct 29, 10:49
PiRK committed rABC5a179f986cc8: gui: don't disable the sync overlay when wallet is disabled (authored by Ben Carman <benthecarman@live.com>).
gui: don't disable the sync overlay when wallet is disabled
Thu, Oct 29, 10:49
PiRK abandoned D8175: Add private key derivation functions to descriptors.

D7804

Thu, Oct 29, 10:37
teamcity added a comment to D8175: Add private key derivation functions to descriptors.
Thu, Oct 29, 10:21
PiRK updated the diff for D8175: Add private key derivation functions to descriptors.

fix missing brackets

Thu, Oct 29, 10:16
teamcity added a comment to D8175: Add private key derivation functions to descriptors.
Thu, Oct 29, 10:16
PiRK updated the diff for D8175: Add private key derivation functions to descriptors.

fix docstring formatting

Thu, Oct 29, 10:13
teamcity added a comment to D8175: Add private key derivation functions to descriptors.
Thu, Oct 29, 10:11
teamcity updated the summary of D8175: Add private key derivation functions to descriptors.
Thu, Oct 29, 10:09
PiRK requested review of D8175: Add private key derivation functions to descriptors.
Thu, Oct 29, 10:09
PiRK updated the test plan for D8174: WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 09:18
teamcity added a comment to D8174: WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 09:11
PiRK updated the test plan for D8174: WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 09:07
teamcity added a comment to D8174: WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState.
Thu, Oct 29, 09:06