Page MenuHomePhabricator
Feed All Stories

Yesterday

James awarded T321: Create test to check node banning behavior a Mountain of Wealth token.
Sat, Aug 24, 04:53 · Bootcamp

Fri, Aug 23

nakihito added inline comments to D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Fri, Aug 23, 20:44
nakihito requested review of D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Fri, Aug 23, 20:32
nakihito updated the test plan for D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Fri, Aug 23, 20:31
nakihito requested review of D3893: Merge #12747: Fix typos.

The misspelled variable and function names were already correct.
See: D3306, D3243, and D3180

Fri, Aug 23, 20:28
Nico Guiton <nico@bitframe.org> committed rABCb5de3d10797f: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12305: [docs] [refactor] Add help messages for datadir path mangling
Fri, Aug 23, 20:18
Nico Guiton <nico@bitframe.org> closed D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Fri, Aug 23, 20:18
Nico Guiton <nico@bitframe.org> committed rABC3311745cc973: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to…
Fri, Aug 23, 19:27
Nico Guiton <nico@bitframe.org> closed D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.
Fri, Aug 23, 19:27
Nico Guiton <nico@bitframe.org> committed rABC546d8973648a: Merge #12561: Check for block corruption in ConnectBlock() (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12561: Check for block corruption in ConnectBlock()
Fri, Aug 23, 19:18
Nico Guiton <nico@bitframe.org> closed D3931: Merge #12561: Check for block corruption in ConnectBlock().
Fri, Aug 23, 19:17
Nico Guiton <nico@bitframe.org> committed rABCe26ef4b479c4: Merge #11131: rpc: Write authcookie atomically (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11131: rpc: Write authcookie atomically
Fri, Aug 23, 19:05
Nico Guiton <nico@bitframe.org> closed D3940: Merge #11131: rpc: Write authcookie atomically.
Fri, Aug 23, 19:05
Nico Guiton <nico@bitframe.org> committed rABC0832c3db3880: Merge #12721: Qt: remove "new" button during receive-mode in addressbook (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12721: Qt: remove "new" button during receive-mode in addressbook
Fri, Aug 23, 18:57
Nico Guiton <nico@bitframe.org> closed D3941: Merge #12721: Qt: remove "new" button during receive-mode in addressbook.
Fri, Aug 23, 18:57
nakihito updated the summary of D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Fri, Aug 23, 15:57
deadalnix accepted D3936: Disable wallet and address book Qt tests on macOS minimal platform.
Fri, Aug 23, 15:04
deadalnix accepted D3931: Merge #12561: Check for block corruption in ConnectBlock().
Fri, Aug 23, 15:03
Fabien accepted D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.
Fri, Aug 23, 14:17
Fabien requested changes to D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.

There's a typo in the PR number

Fri, Aug 23, 14:11
Fabien requested changes to D3938: use base58 map instead of strchr().
Fri, Aug 23, 13:49
Fabien accepted D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Fri, Aug 23, 10:09
Fabien accepted D3940: Merge #11131: rpc: Write authcookie atomically.
Fri, Aug 23, 09:38
Fabien accepted D3941: Merge #12721: Qt: remove "new" button during receive-mode in addressbook.
Fri, Aug 23, 06:47
Fabien committed rABC7d3bbc25a645: Add python3 script shebang lint (authored by John Newbery <john@johnnewbery.com>).
Add python3 script shebang lint
Fri, Aug 23, 06:26
Fabien closed D3928: Add python3 script shebang lint.
Fri, Aug 23, 06:26
Fabien committed rABC1dba6721b352: Remove the ZMQ example for Python 2 (authored by Fabien).
Remove the ZMQ example for Python 2
Fri, Aug 23, 06:22
Fabien closed D3927: Remove the ZMQ example for Python 2.
Fri, Aug 23, 06:22
Fabien committed rABCa0c28188543a: Various textual improvements in build docs (authored by Martin Erlandsson <martin@megabit.se>).
Various textual improvements in build docs
Fri, Aug 23, 06:20
Fabien closed D3926: Various textual improvements in build docs.
Fri, Aug 23, 06:20
Fabien committed rABCc10600f151c6: Docs: Add disable-wallet section to OSX build instructions (authored by Michael Goldstein <michael@bitstein.org>).
Docs: Add disable-wallet section to OSX build instructions
Fri, Aug 23, 06:19
Fabien closed D3925: Docs: Add disable-wallet section to OSX build instructions.
Fri, Aug 23, 06:18

Thu, Aug 22

teamcity added a comment to D3941: Merge #12721: Qt: remove "new" button during receive-mode in addressbook.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 23:02
teamcity added a comment to D3941: Merge #12721: Qt: remove "new" button during receive-mode in addressbook.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 22:55
nakihito created D3941: Merge #12721: Qt: remove "new" button during receive-mode in addressbook.
Thu, Aug 22, 22:55
teamcity added a comment to D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 20:58
teamcity added a comment to D3940: Merge #11131: rpc: Write authcookie atomically.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 20:53
nakihito updated the test plan for D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Thu, Aug 22, 20:48
nakihito updated the summary of D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Thu, Aug 22, 20:47
teamcity added a comment to D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 20:47
nakihito updated the diff for D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.

Squashed changes.

Thu, Aug 22, 20:46
teamcity added a comment to D3940: Merge #11131: rpc: Write authcookie atomically.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 20:45
nakihito created D3940: Merge #11131: rpc: Write authcookie atomically.
Thu, Aug 22, 20:45
teamcity added a comment to D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 20:42
nakihito planned changes to D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Thu, Aug 22, 20:33
teamcity added a comment to D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 20:32
nakihito created D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Thu, Aug 22, 20:32
teamcity added a comment to D3938: use base58 map instead of strchr().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 19:43
teamcity added a comment to D3938: use base58 map instead of strchr().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 19:36
fpelliccioni created D3938: use base58 map instead of strchr().
Thu, Aug 22, 19:36
nakihito added a comment to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

What steps did you take to make sure that this assert is unreachable?
Also, why isn't it at the start of the function like in the PR you backported from.

Thu, Aug 22, 19:33
Fabien added inline comments to D3936: Disable wallet and address book Qt tests on macOS minimal platform.
Thu, Aug 22, 18:17
deadalnix requested changes to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

What steps did you take to make sure that this assert is unreachable?

Thu, Aug 22, 18:16
deadalnix accepted D3925: Docs: Add disable-wallet section to OSX build instructions.
Thu, Aug 22, 18:04
deadalnix accepted D3926: Various textual improvements in build docs.
Thu, Aug 22, 18:03
deadalnix accepted D3927: Remove the ZMQ example for Python 2.
Thu, Aug 22, 18:02
deadalnix accepted D3928: Add python3 script shebang lint.
Thu, Aug 22, 18:02
deadalnix added inline comments to D3936: Disable wallet and address book Qt tests on macOS minimal platform.
Thu, Aug 22, 18:01
teamcity added a comment to D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 17:10
teamcity added a comment to D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 17:03
nakihito created D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Thu, Aug 22, 17:02
teamcity added a comment to D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 16:42
teamcity added a comment to D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 16:35
nakihito updated the diff for D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.

Fixed casting style.

Thu, Aug 22, 16:35
Fabien committed rABCfb52b4d0bf31: Remove Qt4 from the OSX build documentation (authored by Fabien).
Remove Qt4 from the OSX build documentation
Thu, Aug 22, 15:02
Fabien closed D3929: Remove Qt4 from the OSX build documentation.
Thu, Aug 22, 15:02
fpelliccioni committed rABC613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
trivial: Improve include comment in src/interfaces/wallet.h
Thu, Aug 22, 13:34
fpelliccioni closed D3930: trivial: Improve include comment in src/interfaces/wallet.h.
Thu, Aug 22, 13:34
Fabien accepted D3930: trivial: Improve include comment in src/interfaces/wallet.h.
Thu, Aug 22, 13:33
teamcity added a comment to D3930: trivial: Improve include comment in src/interfaces/wallet.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 13:32
teamcity added a comment to D3930: trivial: Improve include comment in src/interfaces/wallet.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 13:25
fpelliccioni updated the diff for D3930: trivial: Improve include comment in src/interfaces/wallet.h.

Fixed Diff summary and test case.

Thu, Aug 22, 13:25
fpelliccioni added a comment to D3930: trivial: Improve include comment in src/interfaces/wallet.h.
In D3930#92157, @Fabien wrote:

Please use PR12345 in the summary (no #) and use markdown to make the test plan look pretty.

Thu, Aug 22, 12:32
fpelliccioni updated the summary of D3930: trivial: Improve include comment in src/interfaces/wallet.h.
Thu, Aug 22, 12:30
teamcity added a comment to D3936: Disable wallet and address book Qt tests on macOS minimal platform.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 10:09
teamcity added a comment to D3936: Disable wallet and address book Qt tests on macOS minimal platform.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 10:02
Fabien created D3936: Disable wallet and address book Qt tests on macOS minimal platform.
Thu, Aug 22, 10:02
Fabien requested changes to D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.

This is a regression from C++ style casts to C style casts.

Thu, Aug 22, 08:14
teamcity added a comment to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Aug 22, 00:19
teamcity added a comment to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Aug 22, 00:12
nakihito created D3935: Merge #11411: script: Change SignatureHash input index check to an assert..
Thu, Aug 22, 00:12

Wed, Aug 21

teamcity added a comment to D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Aug 21, 23:13
teamcity added a comment to D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Aug 21, 23:07
teamcity added a comment to D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Aug 21, 23:04
nakihito planned changes to D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.
Wed, Aug 21, 23:03
nakihito created D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.
Wed, Aug 21, 23:03
teamcity added a comment to D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Aug 21, 23:00
nakihito planned changes to D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Wed, Aug 21, 23:00
nakihito created D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Wed, Aug 21, 23:00
teamcity added a comment to D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Aug 21, 20:28
teamcity added a comment to D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Aug 21, 20:21
nakihito created D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.
Wed, Aug 21, 20:21
teamcity added a comment to D3931: Merge #12561: Check for block corruption in ConnectBlock().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Aug 21, 20:20
teamcity added a comment to D3931: Merge #12561: Check for block corruption in ConnectBlock().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Aug 21, 20:13
nakihito created D3931: Merge #12561: Check for block corruption in ConnectBlock().
Wed, Aug 21, 20:13
nakihito updated the test plan for D3898: Merge #12048: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Wed, Aug 21, 19:22
deadalnix accepted D3929: Remove Qt4 from the OSX build documentation.
Wed, Aug 21, 19:22
deadalnix added inline comments to D3930: trivial: Improve include comment in src/interfaces/wallet.h.
Wed, Aug 21, 19:22
Fabien requested changes to D3930: trivial: Improve include comment in src/interfaces/wallet.h.

Please use PR12345 in the summary (no #) and use markdown to make the test plan look pretty.

Wed, Aug 21, 19:18
teamcity added a comment to D3930: trivial: Improve include comment in src/interfaces/wallet.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Aug 21, 18:32