- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Today
Yesterday
Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.178.130.230:41068 for the next 60 minutes.
@bot preview-explorer
Install proper Rust toolchain
the goal here is to get ecash-lib published to npm in CI, this approach does not really support that goal
You want to check the hash of the binary to be loaded by the lib. There is no point checking it during the tests (where it's expected to change) and no point documenting the value, it will be out of sync in no time.
Thu, Apr 25
You can use ecash-lib without TypeScript in CashTab!
The implication is that the tests now don't have to load the WASM themselves anymore, and we can remove this code from the tests.
In D16053#363390, @bytesofman wrote:But we still need to make sure it is in place before we compile the typescript and publish the npm package, right?
Yes, of course.
The implication is that the tests now don't have to load the WASM themselves anymore, and we can remove this code from the tests.
@bot build-linux-arm
update readme, back out the .gitignore change
update checksum to what was observed in CI
In D16050#363376, @bytesofman wrote:check if CI hash is 3f42174043db297043b853524f6da4f11900c2022c25e0f98343da1710d84734 again
check if CI hash is 3f42174043db297043b853524f6da4f11900c2022c25e0f98343da1710d84734 again
add debug log to see what checksum is coming from CI
update checksum to match local testing
output of ./build-wasm.sh does not appear to be deterministic, though output of dockerbuild.sh does seem to be so
perform checksum confirmation in CI, update README
add Cargo.lock to gitignore, artifact from running builds locally
./dockerbuild.sh: line 4: docker: command not found
In D16043#363300, @emack wrote:LGTM.
My only other feedback is to have a back button to navigate from the NFT back to the Collection otherwise it's a whole lot of clicks when viewing each NFT, but that can be done as part of the NFT child implementation.
Also the fan out tx seems to cost around 300-500 XEC each tx, incl fees. Should this be mentioned anywhere in case the user fans out a dozen times and is surprised by the cost. (this is in the context of a few people recently even complaining about the 5.5 XEC fee =) )
update script so it fails on checksum mismatch
LGTM.
My only other feedback is to have a back button to navigate from the NFT back to the Collection otherwise it's a whole lot of clicks when viewing each NFT, but that can be done as part of the NFT child implementation.
Also the fan out tx seems to cost around 300-500 XEC each tx, incl fees. Should this be mentioned anywhere in case the user fans out a dozen times and is surprised by the cost. (this is in the context of a few people recently even complaining about the 5.5 XEC fee =) )
remove debug logging
After fan out tx, the Mint NFT UI should indicate the total number of NFT mint inputs available. I can see this info is already available on Tx.js, so tracking it here would also be useful.
better table to present NFTs with limited size and scrollable overflow, show user number of Nft Mint Inputs available
After fan out tx, the Mint NFT UI should indicate the total number of NFT mint inputs available. I can see this info is already available on Tx.js, so tracking it here would also be useful.
add missing include
Wed, Apr 24
I think it would be cool to have it in doc/standards—but yeah the link is a permalink, "owned" by ABC (by Koush), through Notion, so it's fine for the forseeable future. When the doc is moved to the monorepo, we should update all the links in the source, which are easy enough to find.
is there a standard source spec for ALP yet? would be nice to have it in the monorepo under doc/standard -- is the notion site an ok permalink?
fix test (used a old chronik-client build)
remove unrelated line break change in useWallet.js
patch bug in fan tx output calculation, update related tests, add tests for rendering NFT parent with NFT and NFT, get rid of dedicated component for MintNFT form and use existing one with conditions