Page MenuHomePhabricator
Feed All Stories

Yesterday

nakihito planned changes to D4418: Add unit tests for parse_name().
Mon, Nov 18, 22:49
nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.
Mon, Nov 18, 22:49
nakihito planned changes to D4442: Seeder filters nodes by chainparams.
Mon, Nov 18, 22:49
teamcity added a comment to D4460: Add Windows shutdown handler.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Mon, Nov 18, 20:43
teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

Mon, Nov 18, 20:32
teamcity added a comment to D4460: Add Windows shutdown handler.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Mon, Nov 18, 20:30
teamcity added a comment to D4462: Use local instance of ArgsManager in getarg_tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 20:13
teamcity added a comment to D4462: Use local instance of ArgsManager in getarg_tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 20:01
teamcity added a comment to D4462: Use local instance of ArgsManager in getarg_tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 20:00
jasonbcox updated the diff for D4462: Use local instance of ArgsManager in getarg_tests.

Remove unnecessary ClearArgs()

Mon, Nov 18, 20:00
jasonbcox planned changes to D4462: Use local instance of ArgsManager in getarg_tests.
Mon, Nov 18, 19:55
teamcity added a comment to D4462: Use local instance of ArgsManager in getarg_tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 19:50
jasonbcox created D4462: Use local instance of ArgsManager in getarg_tests.
Mon, Nov 18, 19:49
jasonbcox committed rABC1a2facc2cf99: Add checkpoints for graviton upgrade (authored by jasonbcox).
Add checkpoints for graviton upgrade
Mon, Nov 18, 18:19
jasonbcox closed D4452: Add checkpoints for graviton upgrade.
Mon, Nov 18, 18:18
jasonbcox committed rABCcfc48b787dae: [github-release] Add optional param to specify release notes path (authored by jasonbcox).
[github-release] Add optional param to specify release notes path
Mon, Nov 18, 18:16
jasonbcox closed D4433: [github-release] Add optional param to specify release notes path.
Mon, Nov 18, 18:16
deadalnix accepted D4461: Add aarch64 qt depends support for cross compiling bitcoin-qt.
Mon, Nov 18, 17:51
jasonbcox accepted D4460: Add Windows shutdown handler.
Mon, Nov 18, 17:45
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 17:23
teamcity added a comment to D4461: Add aarch64 qt depends support for cross compiling bitcoin-qt.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 17:15
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 17:09
Fabien updated the diff for D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Remove CMAKE_EXTRA_OPTIONS.
I first planned to make it the rule but after D4461 it will become the
exception (only used on windows).

Mon, Nov 18, 17:09
teamcity added a comment to D4461: Add aarch64 qt depends support for cross compiling bitcoin-qt.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 17:05
Fabien created D4461: Add aarch64 qt depends support for cross compiling bitcoin-qt.
Mon, Nov 18, 17:05
teamcity added a comment to D4460: Add Windows shutdown handler.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 17:02
teamcity added a comment to D4460: Add Windows shutdown handler.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 16:50
teamcity added a comment to D4460: Add Windows shutdown handler.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 16:50
Fabien created D4460: Add Windows shutdown handler.
Mon, Nov 18, 16:50
teamcity added a comment to D4459: Additional sanity checks in SignPSBTInput.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 15:28
teamcity added a comment to D4459: Additional sanity checks in SignPSBTInput.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 15:28
teamcity added a comment to D4459: Additional sanity checks in SignPSBTInput.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 15:17
teamcity added a comment to D4459: Additional sanity checks in SignPSBTInput.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 15:17
deadalnix created D4459: Additional sanity checks in SignPSBTInput.
Mon, Nov 18, 15:17
teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 14:56
teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 14:56
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 14:48
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 14:48
teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 14:45
teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 14:44
Fabien updated the diff for D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Address comments from D4356 (they are applicable to this diff as well).

Mon, Nov 18, 14:44
Fabien updated the summary of D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.
Mon, Nov 18, 14:42
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 14:36
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 14:36
Fabien updated the diff for D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Address comments from D4356 (they are applicable to this diff as well).

Mon, Nov 18, 14:35
teamcity added a comment to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 14:30
teamcity added a comment to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Nov 18, 14:30
teamcity added a comment to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 14:20
teamcity added a comment to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Nov 18, 14:20
Fabien updated the summary of D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.
Mon, Nov 18, 14:08
Fabien added inline comments to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.
Mon, Nov 18, 14:00
deadalnix accepted D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.
Mon, Nov 18, 13:59
Fabien updated the diff for D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Rebase and address comments.

Mon, Nov 18, 13:57
Fabien updated the summary of D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.
Mon, Nov 18, 13:55
deadalnix committed rABC6baa2c0642de: Fix merging of global unknown data in PSBTs (authored by Andrew Chow <achow101-github@achow101.com>).
Fix merging of global unknown data in PSBTs
Mon, Nov 18, 13:36
deadalnix closed D4457: Fix merging of global unknown data in PSBTs.
Mon, Nov 18, 13:36
deadalnix committed rABCd395b70087cb: Check that PSBT keys are the correct length (authored by Andrew Chow <achow101-github@achow101.com>).
Check that PSBT keys are the correct length
Mon, Nov 18, 13:30
deadalnix closed D4456: Check that PSBT keys are the correct length.
Mon, Nov 18, 13:29
deadalnix committed rABC5b3bb8c4ef57: Add brace in bitcoin-tx.cpp (authored by deadalnix).
Add brace in bitcoin-tx.cpp
Mon, Nov 18, 13:23
deadalnix closed D4458: Add brace in bitcoin-tx.cpp.
Mon, Nov 18, 13:23
deadalnix committed rABCe8f1ceb01f0c: Fix PSBT error test vectors (authored by deadalnix).
Fix PSBT error test vectors
Mon, Nov 18, 13:19
deadalnix closed D4454: Fix PSBT error test vectors.
Mon, Nov 18, 13:19
deadalnix committed rABCc453a23e9675: Add outputtype module (authored by Anthony Towns <aj@erisian.com.au>).
Add outputtype module
Mon, Nov 18, 13:18
deadalnix closed D4424: Add outputtype module.
Mon, Nov 18, 13:18
Fabien requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Mon, Nov 18, 12:26
Fabien abandoned D4340: [CMAKE] Build the OSX DMG image.

Has been split in several diffs.

Mon, Nov 18, 12:24
Fabien abandoned D4406: [CMAKE] Build a stripped version of the application bundle and use it.

Superseded by D4438.

Mon, Nov 18, 12:23
Fabien abandoned D4426: [CMAKE] Strip the osx bundle binary.

Superseded by D4438.

Mon, Nov 18, 12:22
Fabien committed rABC736aaeedc13d: [CMAKE] Use a stripped binary to build the dist and DMG for OSX (authored by Fabien).
[CMAKE] Use a stripped binary to build the dist and DMG for OSX
Mon, Nov 18, 12:16
Fabien closed D4438: [CMAKE] Use a stripped binary to build the dist and DMG for OSX.
Mon, Nov 18, 12:16
Fabien committed rABC54886a6c6083: [CMAKE] Only build the bitcoin-qt application bundle on OSX (authored by Fabien).
[CMAKE] Only build the bitcoin-qt application bundle on OSX
Mon, Nov 18, 12:00
Fabien closed D4437: [CMAKE] Only build the bitcoin-qt application bundle on OSX.
Mon, Nov 18, 12:00
Fabien committed rABC77a0e7979593: [CI] Add a new build configuration to run tests with cmake and ninja (authored by Fabien).
[CI] Add a new build configuration to run tests with cmake and ninja
Mon, Nov 18, 11:01
Fabien closed D4444: [CI] Add a new build configuration to run tests with cmake and ninja.
Mon, Nov 18, 11:01
Fabien committed rABC0c8d3dbf1683: [CI] Rename build.sh to build_autotools.sh (authored by Fabien).
[CI] Rename build.sh to build_autotools.sh
Mon, Nov 18, 10:59
Fabien closed D4443: [CI] Rename build.sh to build_autotools.sh.
Mon, Nov 18, 10:59
Fabien planned changes to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.
Mon, Nov 18, 08:45
Fabien accepted D4457: Fix merging of global unknown data in PSBTs.
Mon, Nov 18, 08:44
Fabien accepted D4456: Check that PSBT keys are the correct length.
Mon, Nov 18, 08:44
Fabien accepted D4454: Fix PSBT error test vectors.
Mon, Nov 18, 08:44
Fabien accepted D4433: [github-release] Add optional param to specify release notes path.
Mon, Nov 18, 08:35
Fabien accepted D4458: Add brace in bitcoin-tx.cpp.
Mon, Nov 18, 08:23
Fabien accepted D4424: Add outputtype module.
Mon, Nov 18, 08:11
Fabien requested review of D4445: [CMAKE] Use a NSIS custom template.
Mon, Nov 18, 07:15
Fabien updated the summary of D4445: [CMAKE] Use a NSIS custom template.
Mon, Nov 18, 07:15
deadalnix added inline comments to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Mon, Nov 18, 00:23

Sun, Nov 17

deadalnix requested changes to D4300: Replace getopts() with gArgs in the Seeder..

It's getting there, this is now much better, but there are still a few things that could be improved.

Sun, Nov 17, 23:55
teamcity added a comment to D4458: Add brace in bitcoin-tx.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Nov 17, 23:52
teamcity added a comment to D4458: Add brace in bitcoin-tx.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Nov 17, 23:52
teamcity added a comment to D4458: Add brace in bitcoin-tx.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Nov 17, 23:43
teamcity added a comment to D4458: Add brace in bitcoin-tx.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Nov 17, 23:43
deadalnix created D4458: Add brace in bitcoin-tx.cpp.
Sun, Nov 17, 23:43
deadalnix accepted D4450: qa: Premine to deterministic address with -disablewallet.
Sun, Nov 17, 23:25
deadalnix accepted D4447: RPC: Add new getzmqnotifications method..
Sun, Nov 17, 23:22
deadalnix accepted D4455: add a couple more Schnorr checkmultisig tests.

More test is always welcome, unless they are flaky or slow as shit.

Sun, Nov 17, 23:14
deadalnix requested changes to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

See comments in D4356

Sun, Nov 17, 23:06
deadalnix requested changes to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Overall it looks good. A few details needs to be changed, though.

Sun, Nov 17, 23:04
deadalnix requested changes to D4445: [CMAKE] Use a NSIS custom template.

This isn't a really a change request per se, but I don't understand how the template come to be used, considering it is not referenced anywhere.

Sun, Nov 17, 22:51
deadalnix added inline comments to D4438: [CMAKE] Use a stripped binary to build the dist and DMG for OSX.
Sun, Nov 17, 22:47
deadalnix accepted D4438: [CMAKE] Use a stripped binary to build the dist and DMG for OSX.
Sun, Nov 17, 22:46