Page MenuHomePhabricator
Feed All Stories

Today

majcosta accepted D9345: [avalanche] set a minimum amount for a proof.
Fri, Apr 23, 10:17
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

rebase again after fixing the wallet dependency introduced in D9441

Fri, Apr 23, 09:48
PiRK updated the test plan for D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 09:16
PiRK updated the diff for D9441: [avalanche] improve stake generation in functional test.

This new way of generating stakes requires the wallet to be compiled. Fix the test to run only when possible, update the test plan.
Use a different bad proof for the delegateavalancheproof test, so that it does not depend on the wallet.

Fri, Apr 23, 09:14
PiRK closed D9430: [backport#19178] Make mininode_lock non-reentrant.
Fri, Apr 23, 08:53
PiRK committed rABCe7039654cdb3: [backport#19178] Make mininode_lock non-reentrant (authored by John Newbery <john@johnnewbery.com>).
[backport#19178] Make mininode_lock non-reentrant
Fri, Apr 23, 08:53
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Fri, Apr 23, 08:06
teamcity added a comment to D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 08:02
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

Rebase after updating dependency D9441

Fri, Apr 23, 07:58
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Fri, Apr 23, 07:56
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Fri, Apr 23, 07:54
PiRK updated the test plan for D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:53
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Fri, Apr 23, 07:51
PiRK updated the diff for D9441: [avalanche] improve stake generation in functional test.

Fix another functional test that was affected by renaming get_stakes
Update the test plan to include the entire functional test suite.

Fri, Apr 23, 07:50
teamcity added a comment to D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:49
teamcity added a comment to D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:43
teamcity added a comment to D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:41
PiRK updated the summary of D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:37
PiRK updated the summary of D9345: [avalanche] set a minimum amount for a proof.
Fri, Apr 23, 07:37
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

Fix test failure by rebasing onto D9441

Fri, Apr 23, 07:36
PiRK requested review of D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:35

Yesterday

Fabien updated the diff for D9365: [avalanche] Add an option to import a delegation.

Fix missed session key vs master key confusion, reorder the checks to make sure no wrong delegation can be generated

Thu, Apr 22, 19:42
deadalnix accepted D9430: [backport#19178] Make mininode_lock non-reentrant.
Thu, Apr 22, 17:38
PiRK added a comment to D9345: [avalanche] set a minimum amount for a proof.

TIL that the halvings are different on regtest than on mainnet. I need to work on a fix for the functional test that uses coinbase UTXOs to build a very large proof, because the coinbase amounts are lower than the dust threshold before I can reach 1000 stakes.
The problem did not appear earlier because this revision had not been rebased for a while, and the problematic test did not exist a couple of weeks ago.

Thu, Apr 22, 13:57
Fabien abandoned D9421: [avalanche] Move the initial proof verification to PeerData constructor.
Thu, Apr 22, 12:47
Fabien abandoned D9420: [avalanche] Initialize PeerData from ArgsManager.
Thu, Apr 22, 12:47
Fabien abandoned D9419: [avalanche] Move the session key to the PeerData structure.
Thu, Apr 22, 12:47
Fabien abandoned D9418: [avalanche] Make the peer data proof and delegation optional.
Thu, Apr 22, 12:47
Fabien closed D9422: [avalanche] Don't turn on service bit if we don't have a proof.
Thu, Apr 22, 12:02
Fabien committed rABC2335099e03a5: [avalanche] Don't turn on service bit if we don't have a proof (authored by Fabien).
[avalanche] Don't turn on service bit if we don't have a proof
Thu, Apr 22, 12:02
Fabien closed D9440: [avalanche] Move proof verification to processor.
Thu, Apr 22, 12:01
Fabien committed rABC35e52efad474: [avalanche] Move proof verification to processor (authored by Fabien).
[avalanche] Move proof verification to processor
Thu, Apr 22, 12:01
deadalnix accepted D9422: [avalanche] Don't turn on service bit if we don't have a proof.
Thu, Apr 22, 11:19
deadalnix accepted D9440: [avalanche] Move proof verification to processor.
Thu, Apr 22, 11:16
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Thu, Apr 22, 10:26
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Thu, Apr 22, 10:20
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Thu, Apr 22, 10:18
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

Rebase. The test failures seem unrelated to the revision, and are definitely unrelated to my last amend.

Thu, Apr 22, 10:10
PiRK requested review of D9430: [backport#19178] Make mininode_lock non-reentrant.
Thu, Apr 22, 08:42
PiRK updated the summary of D9430: [backport#19178] Make mininode_lock non-reentrant.
Thu, Apr 22, 08:41
PiRK added a comment to D9430: [backport#19178] Make mininode_lock non-reentrant.

When I backported core#18807, I did not backport the commit introducing this mistake (https://github.com/bitcoin/bitcoin/pull/18807/commits/00d44a534b4e5ae249b8011360c6b0f7dc731581), so the change to P2PTxInvStore is not relevant to our codebase.

Thu, Apr 22, 08:37
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

refactor the unit test so that any proof size can be tested, increase the number of tested proof sizes

Thu, Apr 22, 08:18
Fabien updated the diff for D9422: [avalanche] Don't turn on service bit if we don't have a proof.

Add a method in the Processor to return if the flag should be set.
Rebase on top of D9440.

Thu, Apr 22, 06:40
Fabien updated the summary of D9422: [avalanche] Don't turn on service bit if we don't have a proof.
Thu, Apr 22, 06:38
abc-bot committed rABCb4f28e9cd544: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Thu, Apr 22, 03:20
abc-bot committed rABC4e517ec9753a: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Thu, Apr 22, 02:16
abc-bot committed rABC314a86a4ef26: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Thu, Apr 22, 02:10

Wed, Apr 21

deadalnix accepted D9345: [avalanche] set a minimum amount for a proof.
Wed, Apr 21, 21:08
deadalnix added a comment to D9345: [avalanche] set a minimum amount for a proof.
In D9345#214194, @PiRK wrote:

What about bool hasDustStake(Proof p);?

Wed, Apr 21, 21:07
Fabien added a comment to D9440: [avalanche] Move proof verification to processor.

The build failure is an unrelated leveldb spurious failure

Wed, Apr 21, 20:47
teamcity added a comment to D9440: [avalanche] Move proof verification to processor.
Wed, Apr 21, 20:18
Fabien updated the diff for D9440: [avalanche] Move proof verification to processor.

Pass the session key by value and move it

Wed, Apr 21, 20:08
deadalnix requested changes to D9430: [backport#19178] Make mininode_lock non-reentrant.
Wed, Apr 21, 18:51
deadalnix added a comment to D9430: [backport#19178] Make mininode_lock non-reentrant.

Why are the changes to P2PTxInvStore ignored?

Wed, Apr 21, 18:51
deadalnix requested changes to D9440: [avalanche] Move proof verification to processor.
Wed, Apr 21, 18:26
jasonbcox requested review of D9414: Fix minerfund in GBT when cashaddr is disabled.
Wed, Apr 21, 18:06
jasonbcox updated the summary of D9414: Fix minerfund in GBT when cashaddr is disabled.
Wed, Apr 21, 18:05
jasonbcox reclaimed D9414: Fix minerfund in GBT when cashaddr is disabled.

Reopening this diff. See improved rationale in the summary.

Wed, Apr 21, 18:00
jasonbcox updated the summary of D9414: Fix minerfund in GBT when cashaddr is disabled.
Wed, Apr 21, 18:00
PiRK planned changes to D9425: [avalanche] add an OrphanProofPool class.
Wed, Apr 21, 15:11
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

Append new proof to the end of the container, use a forward iterator for trimming from the front, use the fact that erase already returns an iterator to the next element (no need to increment the iterator again).

Wed, Apr 21, 15:11
PiRK added inline comments to D9425: [avalanche] add an OrphanProofPool class.
Wed, Apr 21, 14:23
Fabien updated the diff for D9440: [avalanche] Move proof verification to processor.

Don't encode/decode the session key

Wed, Apr 21, 12:46
deadalnix requested changes to D9425: [avalanche] add an OrphanProofPool class.
Wed, Apr 21, 12:22
deadalnix requested changes to D9440: [avalanche] Move proof verification to processor.

Ok, now this is looking more like something that make sense. There is this encoding/decoding of the session key that needs to be addressed, but beside that, it's all good.

Wed, Apr 21, 12:08
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

Move SaltedProofIdHasher to proofid.h to make it available to both orphanproofpool and peermanager without additional includes.

Wed, Apr 21, 10:03
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Wed, Apr 21, 09:27
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Wed, Apr 21, 09:24
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Wed, Apr 21, 09:21
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

What about bool hasDustStake(Proof p);?

Wed, Apr 21, 09:13
PiRK abandoned D9368: [avalanche] move proof verification code to processor.cpp.
Wed, Apr 21, 08:54
PiRK updated the summary of D9430: [backport#19178] Make mininode_lock non-reentrant.
Wed, Apr 21, 08:01
PiRK updated the diff for D9430: [backport#19178] Make mininode_lock non-reentrant.

Don't acquire mininode_lock twice in abc_p2p_avalanche.py.
on_avahello, on_avapoll and on_avaresponse are called indirectly via mininode.P2PInterface.on_message, which does the call with the lock already acquired.

Wed, Apr 21, 07:59
Fabien added a comment to D9440: [avalanche] Move proof verification to processor.

Note to reviewers: the lint errors are false positive from a cppcheck bug introduced in a recent version. There is no such issue if you run arc lint against this patch on Debian.

Wed, Apr 21, 07:58
Fabien requested review of D9440: [avalanche] Move proof verification to processor.
Wed, Apr 21, 07:52
PiRK closed D9438: Make sure unconfirmed parents are requestable.
Wed, Apr 21, 06:53
PiRK committed rABCbe2afa6ffbf9: Make sure unconfirmed parents are requestable (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make sure unconfirmed parents are requestable
Wed, Apr 21, 06:53
PiRK closed D9431: test: move sync_blocks and sync_mempool functions to test_framework.py.
Wed, Apr 21, 06:42
PiRK committed rABC351c23d9d425: test: move sync_blocks and sync_mempool functions to test_framework.py (authored by Roy Shao <ycshao0402@gmail.com>).
test: move sync_blocks and sync_mempool functions to test_framework.py
Wed, Apr 21, 06:41
PiRK closed D9437: Drop setInventoryTxToSend based filtering.
Wed, Apr 21, 06:41
PiRK committed rABC2ee8732b2271: Drop setInventoryTxToSend based filtering (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Drop setInventoryTxToSend based filtering
Wed, Apr 21, 06:41
PiRK updated the summary of D9437: Drop setInventoryTxToSend based filtering.
Wed, Apr 21, 06:40
PiRK closed D9436: Only respond to requests for recently announced transactions.
Wed, Apr 21, 06:39
PiRK committed rABC76acdc0dcf8b: Only respond to requests for recently announced transactions (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Only respond to requests for recently announced transactions
Wed, Apr 21, 06:39
PiRK closed D9432: test: refactor functional tests to use restart_node.
Wed, Apr 21, 06:33
PiRK committed rABCee9e2a2ee678: test: refactor functional tests to use restart_node (authored by Christopher Coverdale <chris.coverdale24@gmail.com>).
test: refactor functional tests to use restart_node
Wed, Apr 21, 06:33
PiRK closed D9435: Introduce constant for mempool-based relay separate from mapRelay caching.
Wed, Apr 21, 06:32
PiRK committed rABCc9dd5e3d2a53: Introduce constant for mempool-based relay separate from mapRelay caching (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Introduce constant for mempool-based relay separate from mapRelay caching
Wed, Apr 21, 06:32
PiRK closed D9434: Swap relay pool and mempool lookup.
Wed, Apr 21, 06:31
PiRK committed rABC92f5dfef38e0: Swap relay pool and mempool lookup (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Swap relay pool and mempool lookup
Wed, Apr 21, 06:31
PiRK updated the summary of D9435: Introduce constant for mempool-based relay separate from mapRelay caching.
Wed, Apr 21, 06:30
PiRK closed D9429: [backport#19299] remove unused variables and add missing includes.
Wed, Apr 21, 06:24
PiRK committed rABC5e0e8c1d3eb0: [backport#19299] remove unused variables and add missing includes (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19299] remove unused variables and add missing includes
Wed, Apr 21, 06:23

Tue, Apr 20

Joey King <joseph.roy.king@gmail.com> closed D9439: [Cashtab] Re-enable send for 9-decimal tokens.
Tue, Apr 20, 19:30
Joey King <joseph.roy.king@gmail.com> committed rABC9e21054ddd64: [Cashtab] Re-enable send for 9-decimal tokens (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Re-enable send for 9-decimal tokens
Tue, Apr 20, 19:30
majcosta accepted D9439: [Cashtab] Re-enable send for 9-decimal tokens.
Tue, Apr 20, 19:28
josephroyking requested review of D9439: [Cashtab] Re-enable send for 9-decimal tokens.
Tue, Apr 20, 18:01
Joey King <joseph.roy.king@gmail.com> closed D9424: [Cashtab] Load from cache on startup.
Tue, Apr 20, 17:59
Joey King <joseph.roy.king@gmail.com> committed rABCf5e03e05bbb5: [Cashtab] Load from cache on startup (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Load from cache on startup
Tue, Apr 20, 17:59
Fabien accepted D9424: [Cashtab] Load from cache on startup.
Tue, Apr 20, 17:54