Page MenuHomePhabricator
Feed All Stories

Today

markblundeberg requested changes to D4621: allow cuckoocache to function as a map.
Tue, Dec 10, 05:26
markblundeberg added a comment to D4621: allow cuckoocache to function as a map.

I see, my strategy was to avoid the kind of refactoring done in D4641 and D4643 and this one, and have a lighter touch to avoid too much code ownership. But, this works too.

Tue, Dec 10, 04:36
teamcity added a comment to D4621: allow cuckoocache to function as a map.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Dec 10, 04:06
markblundeberg added inline comments to D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.
Tue, Dec 10, 03:57
deadalnix added a comment to D4653: Abstract EraseBlockData out of RewindBlockIndex.

That looks better, let me do a pass over this tomorow.

Tue, Dec 10, 03:50
teamcity added a comment to D4621: allow cuckoocache to function as a map.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Dec 10, 03:49
deadalnix updated the diff for D4621: allow cuckoocache to function as a map.

Address comments, except making the constructor of the test map element explicit, as it makes the test way more complex and the upside is not very clear.

Tue, Dec 10, 03:49
deadalnix requested changes to D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.
Tue, Dec 10, 03:48
Mengerian added a revision to T653: Clean up past upgrades: D4673: add SCHNORR_MULTISIG to mandatory flags.
Tue, Dec 10, 03:46
Mengerian added a task to D4673: add SCHNORR_MULTISIG to mandatory flags: T653: Clean up past upgrades.
Tue, Dec 10, 03:46
deadalnix accepted D4667: Fix cuckoocache_tests -Wcast-align warnings.
Tue, Dec 10, 03:45
deadalnix committed rABCbddacbe760f1: [cuckoocache] Use getKey and KeyType for contains (authored by deadalnix).
[cuckoocache] Use getKey and KeyType for contains
Tue, Dec 10, 03:43
deadalnix closed D4643: [cuckoocache] Use getKey and KeyType for contains.
Tue, Dec 10, 03:43
deadalnix commandeered D4621: allow cuckoocache to function as a map.
Tue, Dec 10, 03:40
deadalnix requested changes to D4659: Replace integer literals in dnshandle() with an enum.
Tue, Dec 10, 03:37
teamcity added a comment to D4676: Privatize CWallet::AddToWalletIfInvolvingMe.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Dec 10, 02:22
teamcity added a comment to D4675: Extract CWallet::MarkInputsDirty.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Dec 10, 02:18
teamcity added a comment to D4675: Extract CWallet::MarkInputsDirty.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Dec 10, 02:10
nakihito requested review of D3898: Merge #12048: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Tue, Dec 10, 02:06
nakihito updated the summary of D4676: Privatize CWallet::AddToWalletIfInvolvingMe.
Tue, Dec 10, 02:05
teamcity added a comment to D4676: Privatize CWallet::AddToWalletIfInvolvingMe.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Dec 10, 02:04
nakihito created D4676: Privatize CWallet::AddToWalletIfInvolvingMe.
Tue, Dec 10, 02:04
teamcity added a comment to D4675: Extract CWallet::MarkInputsDirty.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Dec 10, 02:03
nakihito updated the diff for D4675: Extract CWallet::MarkInputsDirty.

Reformatted comment.

Tue, Dec 10, 02:03
nakihito planned changes to D4675: Extract CWallet::MarkInputsDirty.
Tue, Dec 10, 01:59
teamcity added a comment to D4675: Extract CWallet::MarkInputsDirty.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Dec 10, 01:58
nakihito created D4675: Extract CWallet::MarkInputsDirty.
Tue, Dec 10, 01:58
teamcity added a comment to D4674: Merge #12944: [wallet] ScanforWalletTransactions should mark input txns as dirty.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Dec 10, 01:20
teamcity added a comment to D4674: Merge #12944: [wallet] ScanforWalletTransactions should mark input txns as dirty.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Dec 10, 01:09
nakihito created D4674: Merge #12944: [wallet] ScanforWalletTransactions should mark input txns as dirty.
Tue, Dec 10, 01:09
teamcity added a comment to D4665: partial revert of tx decode sanity check backport.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Dec 10, 00:27
teamcity added a comment to D4665: partial revert of tx decode sanity check backport.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Dec 10, 00:17
markblundeberg updated the diff for D4665: partial revert of tx decode sanity check backport.

add some regression tests

Tue, Dec 10, 00:17

Yesterday

teamcity added a comment to D4673: add SCHNORR_MULTISIG to mandatory flags.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 23:59
teamcity added a comment to D4673: add SCHNORR_MULTISIG to mandatory flags.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 23:46
markblundeberg created D4673: add SCHNORR_MULTISIG to mandatory flags.
Mon, Dec 9, 23:45
nakihito updated the summary of D4637: Remove gotos in seeder/dns.cpp.
Mon, Dec 9, 23:00
teamcity added a comment to D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 22:51
teamcity added a comment to D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 22:37
markblundeberg created D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.
Mon, Dec 9, 22:37
teamcity added a comment to D4671: fix incomplete txvalidationcache_tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 21:09
markblundeberg updated the summary of D4671: fix incomplete txvalidationcache_tests.
Mon, Dec 9, 21:05
teamcity added a comment to D4671: fix incomplete txvalidationcache_tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 20:59
markblundeberg created D4671: fix incomplete txvalidationcache_tests.
Mon, Dec 9, 20:59
teamcity added a comment to D4670: Fix -Wself-assign-overloaded in uint256_tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 20:20
teamcity added a comment to D4670: Fix -Wself-assign-overloaded in uint256_tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 20:10
Fabien created D4670: Fix -Wself-assign-overloaded in uint256_tests.
Mon, Dec 9, 20:09
Fabien requested changes to D4619: Merge #14451: Allow building GUI without BIP70 support.
Mon, Dec 9, 20:02
teamcity added a comment to D4659: Replace integer literals in dnshandle() with an enum.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 19:58
nakihito requested review of D4659: Replace integer literals in dnshandle() with an enum.
Mon, Dec 9, 19:47
teamcity added a comment to D4659: Replace integer literals in dnshandle() with an enum.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 19:46
nakihito planned changes to D4659: Replace integer literals in dnshandle() with an enum.
Mon, Dec 9, 19:46
nakihito updated the diff for D4659: Replace integer literals in dnshandle() with an enum.

Renamed variable error -> responseCode, fixed smurf naming, and moved enum to dns.cpp.

Mon, Dec 9, 19:46
nakihito committed rABCff2d6930d844: Merge #13627: Free keystore.h from file scope level type aliases (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13627: Free keystore.h from file scope level type aliases
Mon, Dec 9, 19:11
nakihito closed D4664: Merge #13627: Free keystore.h from file scope level type aliases.
Mon, Dec 9, 19:11
jasonbcox accepted D4667: Fix cuckoocache_tests -Wcast-align warnings.
Mon, Dec 9, 18:56
jasonbcox accepted D4664: Merge #13627: Free keystore.h from file scope level type aliases.
Mon, Dec 9, 18:52
teamcity added a comment to D4619: Merge #14451: Allow building GUI without BIP70 support.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 18:28
nakihito requested review of D4664: Merge #13627: Free keystore.h from file scope level type aliases.
Mon, Dec 9, 18:22
nakihito committed rABCb93c6e6b2775: Merge #13603: bitcoin-tx: Stricter check for valid integers (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13603: bitcoin-tx: Stricter check for valid integers
Mon, Dec 9, 18:22
nakihito closed D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.
Mon, Dec 9, 18:21
teamcity added a comment to D4619: Merge #14451: Allow building GUI without BIP70 support.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 18:19
teamcity added a comment to D4619: Merge #14451: Allow building GUI without BIP70 support.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 18:14
jasonbcox updated the summary of D4619: Merge #14451: Allow building GUI without BIP70 support.
Mon, Dec 9, 18:12
jasonbcox updated the summary of D4619: Merge #14451: Allow building GUI without BIP70 support.
Mon, Dec 9, 18:12
teamcity added a comment to D4619: Merge #14451: Allow building GUI without BIP70 support.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 18:12
jasonbcox updated the diff for D4619: Merge #14451: Allow building GUI without BIP70 support.

Rebase

Mon, Dec 9, 18:12
jasonbcox committed rABC4e65d88e3a16: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70… (authored by jasonbcox).
[move only] Move BIP70 code together in preparation to backport PR14451 BIP70…
Mon, Dec 9, 18:04
jasonbcox closed D4668: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes.
Mon, Dec 9, 18:04
Fabien accepted D4668: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes.
Mon, Dec 9, 18:03
jasonbcox updated the summary of D4668: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes.
Mon, Dec 9, 17:53
teamcity added a comment to D4668: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 17:36
teamcity added a comment to D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 17:34
fpelliccioni updated the summary of D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
Mon, Dec 9, 17:26
fpelliccioni retitled D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
Mon, Dec 9, 17:25
teamcity added a comment to D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 17:23
fpelliccioni created D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
Mon, Dec 9, 17:23
teamcity added a comment to D4667: Fix cuckoocache_tests -Wcast-align warnings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 17:20
jasonbcox updated the summary of D4668: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes.
Mon, Dec 9, 17:20
teamcity added a comment to D4668: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 17:19
jasonbcox created D4668: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes.
Mon, Dec 9, 17:19
teamcity added a comment to D4667: Fix cuckoocache_tests -Wcast-align warnings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 17:10
Fabien created D4667: Fix cuckoocache_tests -Wcast-align warnings.
Mon, Dec 9, 17:10
fpelliccioni retitled D4653: Abstract EraseBlockData out of RewindBlockIndex from Granular invalidateblock and RewindBlockIndex (Partial) to Abstract EraseBlockData out of RewindBlockIndex.
Mon, Dec 9, 15:59
teamcity added a comment to D4653: Abstract EraseBlockData out of RewindBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 15:37
teamcity added a comment to D4653: Abstract EraseBlockData out of RewindBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 15:26
fpelliccioni updated the diff for D4653: Abstract EraseBlockData out of RewindBlockIndex.

Solved Bitcoin-QT test

Mon, Dec 9, 15:25
Fabien planned changes to D4588: [tests] Add libFuzzer support..
Mon, Dec 9, 15:06
fpelliccioni retitled D4653: Abstract EraseBlockData out of RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Granular invalidateblock and RewindBlockIndex (Partial).
Mon, Dec 9, 14:39
Fabien accepted D4643: [cuckoocache] Use getKey and KeyType for contains.
Mon, Dec 9, 14:39
Fabien accepted D4620: Merge #15101: gui: Add WalletController.
Mon, Dec 9, 14:28
fpelliccioni abandoned D4550: crypto: Remove unused AES-128 code.
Mon, Dec 9, 14:23
majcosta committed rABCd688432ba632: Sanity-check script sizes in bitcoin-tx (authored by MarcoFalke <falke.marco@gmail.com>).
Sanity-check script sizes in bitcoin-tx
Mon, Dec 9, 13:57
majcosta closed D4666: Sanity-check script sizes in bitcoin-tx.
Mon, Dec 9, 13:57
Fabien accepted D4666: Sanity-check script sizes in bitcoin-tx.
Mon, Dec 9, 13:20
teamcity added a comment to D4666: Sanity-check script sizes in bitcoin-tx.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 9, 08:21
teamcity added a comment to D4666: Sanity-check script sizes in bitcoin-tx.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 9, 08:07
majcosta created D4666: Sanity-check script sizes in bitcoin-tx.
Mon, Dec 9, 08:07
Fabien added inline comments to D4629: fuzz: Script validation flags.
Mon, Dec 9, 07:42
deadalnix requested changes to D3898: Merge #12048: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

PR16161 was merged.

Mon, Dec 9, 00:45