Page MenuHomePhabricator
Feed All Stories

Today

Fabien requested changes to D9661: [avalanche] add nodes when we have received their proof.
Mon, Jun 14, 06:56
wpjheating updated wpjheating.
Mon, Jun 14, 05:59
majcosta closed D9674: refactor: consolidate both ecash CLI options under "-ecash".
Mon, Jun 14, 00:02
majcosta committed rABC8cdc87e4fc85: refactor: consolidate both ecash CLI options under "-ecash" (authored by majcosta).
refactor: consolidate both ecash CLI options under "-ecash"
Mon, Jun 14, 00:02
majcosta closed D9673: ecash: add XEC option to the GUI.
Mon, Jun 14, 00:02
majcosta committed rABCa166d02a1fe2: ecash: add XEC option to the GUI (authored by majcosta).
ecash: add XEC option to the GUI
Mon, Jun 14, 00:02

Yesterday

majcosta closed D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Sun, Jun 13, 23:56
majcosta committed rABC97d936920f75: use XEC or BCH for bitcoin-qt depending on CLI setting (authored by majcosta).
use XEC or BCH for bitcoin-qt depending on CLI setting
Sun, Jun 13, 23:56
PiRK retitled D9661: [avalanche] add nodes when we have received their proof from [avalanche] periodically check if a peer can be added as an avalanche node to [avalanche] add nodes when we have received their proof.
Sun, Jun 13, 20:07
PiRK updated the diff for D9661: [avalanche] add nodes when we have received their proof.

Work around a lock order inversion

Sun, Jun 13, 18:33
PiRK added a comment to D9674: refactor: consolidate both ecash CLI options under "-ecash".

The description is probably missing a dependency. I can't arc patch this.

Sun, Jun 13, 13:28
PiRK accepted D9674: refactor: consolidate both ecash CLI options under "-ecash".
Sun, Jun 13, 07:56
PiRK accepted D9673: ecash: add XEC option to the GUI.
Sun, Jun 13, 07:55
PiRK accepted D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Sun, Jun 13, 07:55
majcosta updated the diff for D9674: refactor: consolidate both ecash CLI options under "-ecash".

remove now unnecessary DEFAULT_XEC constant

Sun, Jun 13, 04:00
majcosta requested review of D9674: refactor: consolidate both ecash CLI options under "-ecash".
Sun, Jun 13, 03:54
majcosta updated the diff for D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.

undid irrelevant change in qt/test/test_main.cpp

Sun, Jun 13, 03:07
majcosta updated the diff for D9673: ecash: add XEC option to the GUI.

moved some of the changes to D9672

Sun, Jun 13, 03:00
majcosta planned changes to D9673: ecash: add XEC option to the GUI.

this needs changing now

Sun, Jun 13, 02:00
majcosta updated the diff for D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.

additional changes needed to be carried over for this to work

Sun, Jun 13, 01:33

Sat, Jun 12

majcosta planned changes to D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.

hm, didn't hit that error locally. investigating.

Sat, Jun 12, 23:19
majcosta requested review of D9673: ecash: add XEC option to the GUI.
Sat, Jun 12, 22:17
teamcity added a comment to D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Sat, Jun 12, 22:08
teamcity added a comment to D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Sat, Jun 12, 22:04
teamcity added a comment to D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Sat, Jun 12, 22:02
teamcity added a comment to D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Sat, Jun 12, 22:02
majcosta requested review of D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Sat, Jun 12, 21:54
sophiathomas updated sophiathomas.
Sat, Jun 12, 10:50

Fri, Jun 11

Fabien committed rABC6c8fe417321e: Fix p2p_inv_download test (authored by Fabien).
Fix p2p_inv_download test
Fri, Jun 11, 20:29
majcosta committed rABCa5b6b9631c7e: [refactor] CURRENCY_UNIT into Currency class (authored by majcosta).
[refactor] CURRENCY_UNIT into Currency class
Fri, Jun 11, 20:00
PiRK planned changes to D9661: [avalanche] add nodes when we have received their proof.

I will investigate the test failure tomorrow. For now I can't reproduce it at home.

Fri, Jun 11, 20:00
teamcity added a comment to D9661: [avalanche] add nodes when we have received their proof.
Fri, Jun 11, 19:49
PiRK published D9661: [avalanche] add nodes when we have received their proof for review.
Fri, Jun 11, 19:43
Fabien committed rABC5a05c5a37dd9: [avalanche] Fix the avalanche_proof_inventory test (authored by Fabien).
[avalanche] Fix the avalanche_proof_inventory test
Fri, Jun 11, 19:38
PiRK accepted D9668: [avalanche] Check the return value of the delegation addLevel() at startup.
Fri, Jun 11, 19:33
Fabien closed D9662: [avalanche] Manage proof reception.
Fri, Jun 11, 19:01
Fabien committed rABCe691658b0787: [avalanche] Manage proof reception (authored by Fabien).
[avalanche] Manage proof reception
Fri, Jun 11, 19:01
Fabien closed D9660: [avalanche] Don't request orphaned proofs.
Fri, Jun 11, 19:00
Fabien committed rABC645e9ffb0fa9: [avalanche] Don't request orphaned proofs (authored by Fabien).
[avalanche] Don't request orphaned proofs
Fri, Jun 11, 18:59
Fabien updated the diff for D9668: [avalanche] Check the return value of the delegation addLevel() at startup.

Rebase on top of D9365. The failure case is now unreachable from the tests, but it's still more robust to check the return value.

Fri, Jun 11, 14:16
Fabien updated the summary of D9668: [avalanche] Check the return value of the delegation addLevel() at startup.
Fri, Jun 11, 14:14
Fabien updated the diff for D9365: [avalanche] Add an option to import a delegation.

Rebase. The updated version for this diff and the compagnon D9445 should address all the feedback

Fri, Jun 11, 14:06
Fabien updated the summary of D9365: [avalanche] Add an option to import a delegation.
Fri, Jun 11, 14:04
Fabien updated the diff for D9445: [avalanche] Check the delegation generated at startup is valid.

Rebase. The updated version for this diff and the compagnon D9365 should address all the feedback

Fri, Jun 11, 14:03
Fabien updated the summary of D9445: [avalanche] Check the delegation generated at startup is valid.
Fri, Jun 11, 14:00
Fabien closed D9669: [avalanche] Make sure the master key matches the proof master.
Fri, Jun 11, 13:58
Fabien committed rABC2eaa95beb12c: [avalanche] Make sure the master key matches the proof master (authored by Fabien).
[avalanche] Make sure the master key matches the proof master
Fri, Jun 11, 13:58
PiRK accepted D9669: [avalanche] Make sure the master key matches the proof master.
Fri, Jun 11, 13:53
Fabien requested review of D9669: [avalanche] Make sure the master key matches the proof master.
Fri, Jun 11, 13:35
Fabien planned changes to D9668: [avalanche] Check the return value of the delegation addLevel() at startup.
Fri, Jun 11, 13:07
majcosta closed D9666: [refactor] use MAX_MONEY constant instead of magic number.
Fri, Jun 11, 12:49
majcosta committed rABCcf92888087fb: [refactor] use MAX_MONEY constant instead of magic number (authored by majcosta).
[refactor] use MAX_MONEY constant instead of magic number
Fri, Jun 11, 12:49
Fabien abandoned D9471: [avalanche] Improve proof checking at startup.
Fri, Jun 11, 12:47
Fabien closed D9667: [avalanche] Capitalize the init error messages and add a dot.
Fri, Jun 11, 12:45
Fabien committed rABCaa0cd148c4a4: [avalanche] Capitalize the init error messages and add a dot (authored by Fabien).
[avalanche] Capitalize the init error messages and add a dot
Fri, Jun 11, 12:45
Fabien closed D9664: [avalanche] Add a facility to build a delegation from a hex string.
Fri, Jun 11, 12:44
Fabien committed rABC8b57df1785a3: [avalanche] Add a facility to build a delegation from a hex string (authored by Fabien).
[avalanche] Add a facility to build a delegation from a hex string
Fri, Jun 11, 12:44
Fabien requested review of D9668: [avalanche] Check the return value of the delegation addLevel() at startup.
Fri, Jun 11, 12:29
PiRK accepted D9666: [refactor] use MAX_MONEY constant instead of magic number.
Fri, Jun 11, 12:16
majcosta accepted D9667: [avalanche] Capitalize the init error messages and add a dot.
Fri, Jun 11, 12:09
Fabien requested review of D9667: [avalanche] Capitalize the init error messages and add a dot.
Fri, Jun 11, 11:39
majcosta requested review of D9666: [refactor] use MAX_MONEY constant instead of magic number.
Fri, Jun 11, 10:38
PiRK accepted D9664: [avalanche] Add a facility to build a delegation from a hex string.
Fri, Jun 11, 10:29
PiRK accepted D9662: [avalanche] Manage proof reception.
Fri, Jun 11, 10:27
majcosta closed D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Fri, Jun 11, 10:15
majcosta committed rABC69794949e90c: [eCash] adapt functional tests to the XEC base unit and test it by default (authored by majcosta).
[eCash] adapt functional tests to the XEC base unit and test it by default
Fri, Jun 11, 10:15
Fabien requested review of D9664: [avalanche] Add a facility to build a delegation from a hex string.
Fri, Jun 11, 10:06
PiRK accepted D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Fri, Jun 11, 10:03
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
  • correct two erroneous amounts in wallet_txn_clone to use XEC
  • changed the repr method for CTxOut from using 8 to 2 decimals
Fri, Jun 11, 09:57
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

corrections to wallet_txn_clone.py

Fri, Jun 11, 08:44
Fabien added inline comments to D9660: [avalanche] Don't request orphaned proofs.
Fri, Jun 11, 08:04
teamcity awarded D9663: [eCash] adapt functional tests to the XEC base unit and test it by default a Haypence token.
Fri, Jun 11, 08:01
Fabien added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

@bot build-master

Fri, Jun 11, 08:01
PiRK requested changes to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Fri, Jun 11, 07:37

Thu, Jun 10

deadalnix added inline comments to D9660: [avalanche] Don't request orphaned proofs.
Thu, Jun 10, 22:14
PiRK added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

OK up to rpc_txoutproof.py

Thu, Jun 10, 20:45
majcosta added inline comments to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Thu, Jun 10, 19:36
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

thank you for the corrections.

  • updated mempool_limit.py, mempool_packages.py and mempool_unbroadcast.py
  • I've also ditched zeroes after the decimal where they aren't needed in the new unit.
Thu, Jun 10, 19:34
PiRK added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

For now I reviewed up-to and including rpc_estimatefee.py

Thu, Jun 10, 18:54
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

a few new tests were added since I worked on the diff. their Amounts have been multiplied by a million as well.

Thu, Jun 10, 18:43
majcosta planned changes to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

fixing failure

Thu, Jun 10, 17:59
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Thu, Jun 10, 17:57
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Thu, Jun 10, 17:51
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Thu, Jun 10, 17:51
PiRK accepted D9660: [avalanche] Don't request orphaned proofs.
Thu, Jun 10, 17:45
majcosta requested review of D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Thu, Jun 10, 17:38
majcosta committed rABC6668fc39897a: [eCash] add the XEC base unit and test it by default (authored by majcosta).
[eCash] add the XEC base unit and test it by default
Thu, Jun 10, 17:17
Fabien added a comment to D9662: [avalanche] Manage proof reception.

Unrelated failure

Thu, Jun 10, 15:46
teamcity added a comment to D9662: [avalanche] Manage proof reception.
Thu, Jun 10, 15:41
Fabien requested review of D9662: [avalanche] Manage proof reception.
Thu, Jun 10, 15:33
Fabien updated the diff for D9660: [avalanche] Don't request orphaned proofs.

Introduce wait_for_proof to deal with RPC exception when a proof is not found

Thu, Jun 10, 14:57
Fabien planned changes to D9660: [avalanche] Don't request orphaned proofs.
Thu, Jun 10, 14:42
Fabien updated the summary of D9660: [avalanche] Don't request orphaned proofs.
Thu, Jun 10, 13:29
Fabien updated the diff for D9660: [avalanche] Don't request orphaned proofs.

Rebase

Thu, Jun 10, 13:23
Fabien updated the summary of D9660: [avalanche] Don't request orphaned proofs.
Thu, Jun 10, 13:22
Fabien abandoned D9493: [avalanche] Prevent sending proof invs multiple times to the same peer.
Thu, Jun 10, 13:18
Fabien closed D9659: [avalanche] Add a getrawproof RPC.
Thu, Jun 10, 13:18
Fabien abandoned D9489: [avalanche] Annouce our proofs to our peers.
Thu, Jun 10, 13:18
Fabien committed rABC5f50f33f0910: [avalanche] Add a getrawproof RPC (authored by Fabien).
[avalanche] Add a getrawproof RPC
Thu, Jun 10, 13:18
Fabien closed D9658: [avalanche] Improve proof verification test coverage.
Thu, Jun 10, 13:17