Page MenuHomePhabricator
Feed All Stories

Yesterday

josephroyking abandoned D8441: Adding cashtab and draft deploy scripts.
Tue, Aug 3, 19:45
josephroyking abandoned D9016: [Cashtab] Set dust param to minimum accepted by backend.
Tue, Aug 3, 19:44
davidway195 updated davidway195.
Tue, Aug 3, 04:56

Mon, Aug 2

deadalnix requested changes to D9839: [avalanche] Compute a node activity score.

I don't understand what this whole RCU business achieves. It's trivially completely wrong: the RCU pointer is stuffed into a larger structure that might be deleted anyways, nothing's actually protected. And it seems that you fitted all the metrics into one value that is small enough to be atomic anyways, so is RCU needed at all?

Mon, Aug 2, 19:25
Fabien updated the diff for D9839: [avalanche] Compute a node activity score.

Move to AvalancheState, run the score update in the scheduler queue and use RCU to make it lock free most of the time.

Mon, Aug 2, 15:02

Fri, Jul 30

Dika added a comment to rABC18c230dedc8b: [Cashtab] prevent translation of user mnemonics.

mengandalkan bohlam petunjuk klaim tangga inti kurung buah ayam inti pasien

Fri, Jul 30, 07:14

Thu, Jul 29

deadalnix requested changes to D9844: [avalanche] exclude stakes from the hash used in stake signature.

This is lacking the bigger picture. We can't just break the proof format with every version. What's the format of a proof you are moving toward?

Thu, Jul 29, 12:24
PiRK added a comment to D9844: [avalanche] exclude stakes from the hash used in stake signature.

Note that I do not intend to land this. It is meant as an example of a possible solution, but the tradeoffs of the various solutions need to be discussed.
In particular, there is a solution that involves making the ProofId no longer depend on the stakes that would have a bunch of upsides (no need to regenerate a Delegation after updating a proof) but also challenges (if the ProofId does not change, it does not trigger proof relaying).

Thu, Jul 29, 09:17
abc-bot committed rABCaf88f4faa452: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Thu, Jul 29, 03:18
abc-bot committed rABC3c00aeafcbd0: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Thu, Jul 29, 02:14
abc-bot committed rABC265c99e9236b: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Thu, Jul 29, 02:08

Wed, Jul 28

PiRK added a task to D9844: [avalanche] exclude stakes from the hash used in stake signature: Unknown Object (Maniphest Task).
Wed, Jul 28, 14:54
PiRK requested review of D9844: [avalanche] exclude stakes from the hash used in stake signature.
Wed, Jul 28, 14:53
Hyphenpdp added a reviewer for D9836: [avalanche] Protect from eviction nodes that relayed new proofs: 1LcaSZDHPh3VXhCLZuNpNE3Zfikrta2NzU.
Wed, Jul 28, 11:40 · Unknown Object (Project)
PiRK closed D9837: [doc] start a developer documentation for avalanche.
Wed, Jul 28, 06:37
PiRK committed rABC5a046e2b5a7d: [doc] start a developer documentation for avalanche (authored by PiRK).
[doc] start a developer documentation for avalanche
Wed, Jul 28, 06:37
tobias_ruck updated the diff for D9843: Add 64-bit overflow check to CScriptNum.

Add multiprecision/cpp_int.hpp Boost dependency (Lord have mercy)

Wed, Jul 28, 06:07
tobias_ruck updated the diff for D9843: Add 64-bit overflow check to CScriptNum.

Fix off-by-one error in overflow_add_int64 and overflow_sub_int64 (doesn't seem to appear on Darwin/clang)

Wed, Jul 28, 05:55
teamcity added a comment to D9843: Add 64-bit overflow check to CScriptNum.
Wed, Jul 28, 04:59
teamcity added a comment to D9843: Add 64-bit overflow check to CScriptNum.
Wed, Jul 28, 04:55
teamcity added a comment to D9843: Add 64-bit overflow check to CScriptNum.
Wed, Jul 28, 04:52
tobias_ruck requested review of D9843: Add 64-bit overflow check to CScriptNum.
Wed, Jul 28, 04:44

Tue, Jul 27

Fabien closed D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Tue, Jul 27, 18:10 · Unknown Object (Project)
Fabien committed rABC9d952964361b: [avalanche] Protect from eviction nodes that relayed new proofs (authored by Fabien).
[avalanche] Protect from eviction nodes that relayed new proofs
Tue, Jul 27, 18:10
Fabien closed D9841: [avalanche] Fix the getavalanchepeerinfo help.
Tue, Jul 27, 18:08
Fabien committed rABC49641c3121ac: [avalanche] Fix the getavalanchepeerinfo help (authored by Fabien).
[avalanche] Fix the getavalanchepeerinfo help
Tue, Jul 27, 18:08
josephroyking accepted D9842: [cashtab] Remove fbt and I18n from app and extension.

Looks good. This is an important step in preparation for upgrading to webpack 5 and continuing to simplify the dependency tree.

Tue, Jul 27, 17:24
alcipir abandoned D9760: [cashtab] Internationalization: Switch from fbt to react-intl.
Tue, Jul 27, 17:12
alcipir requested review of D9842: [cashtab] Remove fbt and I18n from app and extension.
Tue, Jul 27, 15:07
majcosta accepted D9837: [doc] start a developer documentation for avalanche.
Tue, Jul 27, 15:05
majcosta accepted D9841: [avalanche] Fix the getavalanchepeerinfo help.
Tue, Jul 27, 15:05
Fabien requested review of D9841: [avalanche] Fix the getavalanchepeerinfo help.
Tue, Jul 27, 14:50
deadalnix closed D9840: Do not specify a line/char for prettier when not apropriate.
Tue, Jul 27, 14:18
deadalnix committed rABC4c8d559ef552: Do not specify a line/char for prettier when not apropriate (authored by deadalnix).
Do not specify a line/char for prettier when not apropriate
Tue, Jul 27, 14:18
Fabien accepted D9840: Do not specify a line/char for prettier when not apropriate.
Tue, Jul 27, 14:04
deadalnix requested changes to D9839: [avalanche] Compute a node activity score.
Tue, Jul 27, 14:00
deadalnix requested review of D9840: Do not specify a line/char for prettier when not apropriate.
Tue, Jul 27, 13:33
Fabien requested review of D9839: [avalanche] Compute a node activity score.
Tue, Jul 27, 12:26
Fabien closed D9838: [LINTER] Handle errors from the Prettier linter.
Tue, Jul 27, 06:13
Fabien committed rABCcaa8bdd07091: [LINTER] Handle errors from the Prettier linter (authored by Fabien).
[LINTER] Handle errors from the Prettier linter
Tue, Jul 27, 06:13

Mon, Jul 26

majcosta accepted D9838: [LINTER] Handle errors from the Prettier linter.
Mon, Jul 26, 19:29
Fabien requested review of D9838: [LINTER] Handle errors from the Prettier linter.
Mon, Jul 26, 18:26
PiRK accepted D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 12:01 · Unknown Object (Project)
Fabien updated the diff for D9836: [avalanche] Protect from eviction nodes that relayed new proofs.

Feedback

Mon, Jul 26, 11:29 · Unknown Object (Project)
PiRK requested changes to D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 11:06 · Unknown Object (Project)
Fabien updated the summary of D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 10:07 · Unknown Object (Project)
Fabien updated the test plan for D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 10:07 · Unknown Object (Project)
Fabien updated the diff for D9836: [avalanche] Protect from eviction nodes that relayed new proofs.

Fix functional test

Mon, Jul 26, 10:06 · Unknown Object (Project)
PiRK requested review of D9837: [doc] start a developer documentation for avalanche.
Mon, Jul 26, 09:33
Fabien planned changes to D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 06:45 · Unknown Object (Project)
teamcity added a comment to D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 06:44 · Unknown Object (Project)
teamcity added a comment to D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 06:40 · Unknown Object (Project)
teamcity added a comment to D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 06:39 · Unknown Object (Project)
Fabien requested review of D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 06:25 · Unknown Object (Project)

Sat, Jul 24

phxafinancial updated phxafinancial.
Sat, Jul 24, 09:23

Fri, Jul 23

Joey King <joseph.roy.king@gmail.com> closed D9829: [Cashtab] Add support for multiple fiat currencies.
Fri, Jul 23, 22:36
Joey King <joseph.roy.king@gmail.com> committed rABC5dea8ff63203: [Cashtab] Add support for multiple fiat currencies (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Add support for multiple fiat currencies
Fri, Jul 23, 22:36
Fabien accepted D9829: [Cashtab] Add support for multiple fiat currencies.
Fri, Jul 23, 18:22
majcosta closed D9835: add some release notes for 0.23.9.
Fri, Jul 23, 17:42
majcosta committed rABC471fa6e36e42: add some release notes for 0.23.9 (authored by majcosta).
add some release notes for 0.23.9
Fri, Jul 23, 17:42
josephroyking accepted D9835: add some release notes for 0.23.9.
Fri, Jul 23, 17:41
majcosta requested review of D9835: add some release notes for 0.23.9.
Fri, Jul 23, 17:29
josephroyking updated the diff for D9829: [Cashtab] Add support for multiple fiat currencies.

Add to Tokens page

Fri, Jul 23, 17:17
Fabien requested changes to D9829: [Cashtab] Add support for multiple fiat currencies.

You missed the main one:

Fri, Jul 23, 16:57
josephroyking updated the diff for D9829: [Cashtab] Add support for multiple fiat currencies.

Resolving comments

Fri, Jul 23, 16:31
PiRK planned changes to D9834: test: Set -logthreadnames in unit tests.

testing depends on core#16975

Fri, Jul 23, 09:36
PiRK planned changes to D9831: net: Remove forcerelay of rejected txs.

needs backporting 17984

Fri, Jul 23, 09:35
PiRK closed D9833: init: use std::thread for ThreadImport().
Fri, Jul 23, 08:13
PiRK committed rABCae09ca09e4e0: init: use std::thread for ThreadImport() (authored by fanquake <fanquake@gmail.com>).
init: use std::thread for ThreadImport()
Fri, Jul 23, 08:13
Fabien requested changes to D9834: test: Set -logthreadnames in unit tests.

The test plan is not testing the feature

Fri, Jul 23, 07:06
Fabien accepted D9832: doc: Use precise permission flags where possible.
Fri, Jul 23, 06:52
Fabien requested changes to D9831: net: Remove forcerelay of rejected txs.

Please backport 17984 in its own diff, it's difficult to make sure that nothing is missing here

Fri, Jul 23, 06:46
Fabien added a comment to D9829: [Cashtab] Add support for multiple fiat currencies.

Side note: you may want to add yourself a commit hook or something to automate the @generated mark in the snapshots

Fri, Jul 23, 06:35
Fabien requested changes to D9829: [Cashtab] Add support for multiple fiat currencies.

The display is not updated in the tokens page

Fri, Jul 23, 06:34

Thu, Jul 22

Fabien closed D9830: Improve the p2p_inv_download test by using a mocked time.
Thu, Jul 22, 20:21
Fabien committed rABC3cca01825bf8: Improve the p2p_inv_download test by using a mocked time (authored by Fabien).
Improve the p2p_inv_download test by using a mocked time
Thu, Jul 22, 20:21
deadalnix accepted D9833: init: use std::thread for ThreadImport().
Thu, Jul 22, 17:19
teamcity updated the summary of D9834: test: Set -logthreadnames in unit tests.
Thu, Jul 22, 15:48
PiRK requested review of D9834: test: Set -logthreadnames in unit tests.
Thu, Jul 22, 15:48
teamcity updated the summary of D9833: init: use std::thread for ThreadImport().
Thu, Jul 22, 15:29
PiRK requested review of D9833: init: use std::thread for ThreadImport().
Thu, Jul 22, 15:29
PiRK updated the summary of D9832: doc: Use precise permission flags where possible.
Thu, Jul 22, 15:09
teamcity updated the summary of D9832: doc: Use precise permission flags where possible.
Thu, Jul 22, 15:07
PiRK requested review of D9832: doc: Use precise permission flags where possible.
Thu, Jul 22, 15:07
PiRK updated the summary of D9831: net: Remove forcerelay of rejected txs.
Thu, Jul 22, 14:35
teamcity updated the summary of D9831: net: Remove forcerelay of rejected txs.
Thu, Jul 22, 14:33
PiRK requested review of D9831: net: Remove forcerelay of rejected txs.
Thu, Jul 22, 14:33
teamcity added a comment to D9830: Improve the p2p_inv_download test by using a mocked time.
Thu, Jul 22, 14:11
teamcity awarded D9830: Improve the p2p_inv_download test by using a mocked time a Haypence token.
Thu, Jul 22, 13:45
PiRK added a comment to D9830: Improve the p2p_inv_download test by using a mocked time.

@bot build-master

Thu, Jul 22, 13:45
PiRK accepted D9830: Improve the p2p_inv_download test by using a mocked time.
Thu, Jul 22, 13:40
Actuarial updated Actuarial.
Thu, Jul 22, 11:12
Fabien requested review of D9830: Improve the p2p_inv_download test by using a mocked time.
Thu, Jul 22, 10:17
charles243 updated charles243.
Thu, Jul 22, 08:40
nidhichopra3435 updated nidhichopra3435.
Thu, Jul 22, 07:41
nidhichopra3435 updated nidhichopra3435.
Thu, Jul 22, 07:39
abc-bot committed rABCbc18e393924f: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Thu, Jul 22, 03:18
abc-bot committed rABCcf3e49e75692: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Thu, Jul 22, 02:14
abc-bot committed rABC8da961dc2c9f: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Thu, Jul 22, 02:09

Wed, Jul 21

Fabien closed D9828: test: whitelist rpc_rawtransaction peers to speed up tests.
Wed, Jul 21, 18:48