Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Today
Today
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
bytesofman updated the diff for D20466: [alp-fusion] Add CashFusion-shaped protobuf control messages.
Address CodeRabbit: reject non-array values for repeated protobuf fields in assertUint64Fields and assertRequiredFields.
Share settle/maintain wallet queue; count postage by inventory outpoint role; require token mid-outs to be dust (blocks postage drain via inflated sats).
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
bytesofman added inline comments to D20466: [alp-fusion] Add CashFusion-shaped protobuf control messages.
bytesofman updated the diff for D20466: [alp-fusion] Add CashFusion-shaped protobuf control messages.
Rebase on master after Fabien feedback fix (schema-guided uint64 bigint checks via bigintToU64Be).
bytesofman updated the diff for D20466: [alp-fusion] Add CashFusion-shaped protobuf control messages.
Address Fabien: replace deep assertSafeNumbers walk with schema-guided uint64/fixed64 bigint checks; reuse ecash-lib bigintToU64Be for the range bound (no duplicate uint64 validator).
bytesofman committed rABCfdb602887973: [Cashtab] Resolve Firma usernames on send (authored by bytesofman).
[Cashtab] Resolve Firma usernames on send
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Require a single leading @ for explicit usernames. Keep FIRMA/fCHF/fEUR token ids next to FIRMA in constants/tokens.ts so config/firma.ts does not import constants.
Fabien committed rABC1c1d06b5b5f7: Fix a bug in the bip37 transaction bloom filter implementation (authored by Fabien).
Fix a bug in the bip37 transaction bloom filter implementation
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Drop Content-Type on Patron GET (skip CORS preflight). Time out lookups at 8s and abort in-flight requests when the hook cleans up.
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Only resolve Firma usernames when sending FIRMA, fCHF, or fEUR. XEC and other tokens stay address/contact only.
Yesterday
Yesterday
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Mon, Aug 17
Mon, Aug 17
bytesofman committed rABCbe9914ca71e7: [monorepo] Override brace-expansion 1.1.18 / 2.1.4 / 5.0.9 for DoS fixes (authored by bytesofman).
[monorepo] Override brace-expansion 1.1.18 / 2.1.4 / 5.0.9 for DoS fixes
that's a wild version spread from major 1 to 5
bytesofman published D20466: [alp-fusion] Add CashFusion-shaped protobuf control messages for review.
bytesofman published D20475: [monorepo] Override brace-expansion 1.1.18 / 2.1.4 / 5.0.9 for DoS fixes for review.
bytesofman committed rABCcb868b5ee53d: [monorepo] Override ws 6.2.4 / 7.5.11 for memory DoS fixes (authored by bytesofman).
[monorepo] Override ws 6.2.4 / 7.5.11 for memory DoS fixes
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Rebase onto latest master: keep nanoid 3.3.17 override from D20479 and add ws 6.2.4 / 7.5.11 overrides.
bytesofman committed rABC4cb69621ba24: [monorepo] Override nanoid 3.3.17 for postcss infinite-loop fix (authored by bytesofman).
[monorepo] Override nanoid 3.3.17 for postcss infinite-loop fix
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
bytesofman committed rABC8f50730cd5a7: [Cashtab] Add eye toggle to reveal full send addresses (authored by bytesofman).
[Cashtab] Add eye toggle to reveal full send addresses
bytesofman committed rABCd1e44a15eb72: [Cashtab] Import mock-chronik-client without /dist in airdrop tests (authored by bytesofman).
[Cashtab] Import mock-chronik-client without /dist in airdrop tests
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
teamcity added a comment to D20482: [Cashtab] Import mock-chronik-client without /dist in airdrop tests.
Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.
bytesofman published D20482: [Cashtab] Import mock-chronik-client without /dist in airdrop tests for review.
bytesofman published D20468: [monorepo] Override nanoid 3.3.17 for postcss infinite-loop fix for review.
Sun, Aug 16
Sun, Aug 16
[Automated] Update seeds
[Automated] Update chainparams
[Automated] Update timing.json
bytesofman committed rABC28c310db3124: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes (authored by bytesofman).
[monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes
bytesofman committed rABCa8bfbd524d9d: [Cashtab] Prompt native users when a store update is available (authored by bytesofman).
[Cashtab] Prompt native users when a store update is available
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
bytesofman updated the summary of D20477: [Cashtab] Prompt native users when a store update is available.
bytesofman updated the diff for D20477: [Cashtab] Prompt native users when a store update is available.
Drop unused iTunes/iOS store lookup; iOS is a no-op until there is an App Store listing.
bytesofman added inline comments to D20477: [Cashtab] Prompt native users when a store update is available.
bytesofman committed rABC63da4686546e: [notifications-server] Distinct push copy for XECX and Firma rewards (authored by bytesofman).
[notifications-server] Distinct push copy for XECX and Firma rewards
Sat, Aug 15
Sat, Aug 15
Fabien requested changes to D20479: [notifications-server] Distinct push copy for XECX and Firma rewards.
bytesofman published D20479: [notifications-server] Distinct push copy for XECX and Firma rewards for review.
bytesofman published D20477: [Cashtab] Prompt native users when a store update is available for review.
Fri, Aug 14
Fri, Aug 14
teamcity added a comment to D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
bytesofman updated the summary of D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
bytesofman updated the diff for D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
Apply Fabien's suggested edit exactly: drop the @vercel/node-scoped pin and use undici@>=5.0.0 <6.28.0 → 6.28.0 plus undici@>=7.0.0 <7.29.0 → 7.29.0.
teamcity added a comment to D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
bytesofman updated the summary of D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
bytesofman updated the diff for D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
Keep the existing @vercel/node>undici pin so it is not reverted to declared 5.28.4. Add generic 6.x/7.x overrides beside it.
bytesofman committed rABC70fb8baae5b1: [alp-dex] Add read-only quote HTTP API (authored by bytesofman).
[alp-dex] Add read-only quote HTTP API
teamcity added a comment to D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Fabien requested changes to D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
bytesofman updated the summary of D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
bytesofman updated the diff for D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
Drop the package-scoped @vercel/node>undici pin per Fabien. Generic 6.x/7.x overrides remain; @vercel/node keeps declared 5.28.4. Rebase on latest master.
bytesofman committed rABC09ad53356e0f: [Cashtab] Show redeeming progress toast for covered XECX and FIRMA (authored by bytesofman).
[Cashtab] Show redeeming progress toast for covered XECX and FIRMA
bytesofman added a comment to D20472: [Cashtab] Show redeeming progress toast for covered XECX and FIRMA.
In D20472#464749, @Fabien wrote:There already exist such a check when you use a payment request, can it be reused as a component?
Fabien added a comment to D20472: [Cashtab] Show redeeming progress toast for covered XECX and FIRMA.
There already exist such a check when you use a payment request, can it be reused as a component?
Fabien requested changes to D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes.
bytesofman published D20453: [monorepo] Override undici 6.28.0 / 7.29.0 for jsdom and vercel fixes for review.
Abandoning after discussion.
bytesofman committed rABC2fe6ea996398: [monorepo] Override js-yaml 3.15.1 / 4.3.1 for YAML DoS fixes (authored by bytesofman).
[monorepo] Override js-yaml 3.15.1 / 4.3.1 for YAML DoS fixes
Thu, Aug 13
Thu, Aug 13
bytesofman published D20463: [monorepo] Override js-yaml 3.15.1 / 4.3.1 for YAML DoS fixes for review.
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Address CodeRabbit: drop quoteMath blanket 400 wrap.