User Details
- User Since
- Nov 5 2020, 18:28 (298 w, 2 d)
- Roles
- Administrator
Yesterday
we don't need a extensive chronik url validation (codedrabbit comment) as chronik-client already validates
Address CodeRabbit: bound pool-key tier digit length before BigInt; watch/depend on chronik-client for alp-fusion-tests.
Address CodeRabbit: reject H=G; identity (0,0) verify; defensive getR copy; same-domain Pedersen positive control. Skip hash-to-curve H derivation (Electrum NUMS API).
Address review: zero-nonce Pedersen aggregation; validate blind-Schnorr inputs before retry; stop zeroing public s'; enforce pool-key tokenId/tier bounds.
- should also add this to the cashtab-connect demo react app so it can be tested locally / the UX can be evaluated
- when updating the diff, do not skip arc lint and arc unit
Thu, Jul 23
Address review: modular (a-k) path for Pedersen blinding; clarify HG equivalence and seckeyAdd mod n; zero blind-Schnorr temps on both c signs; stricter poolKey parsing and golden hash vectors. Rebase onto master.
- We aren't getting expected behavior on XECX (c67bf5c2b6d91cfb46a5c1772582eff80d88686887be10aa63b0945479cf4ed4) or Firma Alpha (0387947fd575db4fb19a3e322f635dec37fd192b5941625b66bc4b2c3008cbf0) pages; these need special handling as they have special handling for redeem
Rebase onto latest master.
Clarify blindSchnorr file comment: describe Uint8Array + wasm ECC scalar ops without negative phrasing.
Address Fabien feedback: real BIP39 validation; use ecash-lib Address; scrub README/index noise; clear early mnemonic errors.
Done — updated this diff with the review fixes. Sorry about the stray __draft-probe-do-not-keep__ comment from API probing; please ignore it.
Address review: Electrum amount blinding; wasm seckeyMul/seckeyNegate for blind Schnorr; Uint8Array secrets with zeroing; rejection-sampled randomScalar; rename modCurveOrder/bytesToScalar; drop constants tests and unreleased changelog.
draft-probe-do-not-keep
Wed, Jul 22
@bot preview-pay.e.cash
Reject account numbers above 0x7fffffff.
Rebase onto latest master so pnpm-lock.yaml matches CI base.
Address review: drop .env/dotenv; put port in config.json; rename a/b to aTokenId/bTokenId; remove JSON _comment keys from sample.
Rebase onto latest master.
Tue, Jul 21
imo the most recent coderabbit review should not be implemented. the firma price isn't the xec price in USD it is related to firma redeems. the accessibility thing is an optimization not a major problem.
Fix token block burn deltas: count actualBurnAtoms only (do not add intentionalBurnAtoms). Historical block_token_deltas burns stay inflated until a reindex; not charted today.
Stop Enter/Space on the staked link from bubbling to the eCash card keydown handler so keyboard users navigate to XECX instead of toggling the breakdown.
CodeRabbit follow-ups: validate real calendar dates; clamp repair --batch-size; guard STATEMENT_TIMEOUT_MS NaN + catch SET failures; fix scripts README; document that mint batons are 0-atom (default rich-list min_atoms excludes them). Skip ForkReferenceLines (recharts 3 + verified on charts) and burn double-count pending decision.
Harden pairKey; feePct in [0,1]; reject non-numeric fee/utxo JSON values.
Rebase on master (Etokens changes landed in D20362). Drop >10k XEC/XECX decimal rounding so balances stay exact.
Address review: copy env.sample in cashtab.Dockerfile only when .env is missing. Dropped the docker.pre_build CI hook. Rebased onto master so the diff is Dockerfile-only.
Address review: drop docker.pre_build; copy env.sample in cashtab.Dockerfile only when .env is missing so prod/local overrides are preserved.
Address CodeRabbit review (except burn double-count pending confirmation): migrateSchema ADD COLUMN for new blocks/days fields; charts UTC date formatting + incomplete-day filter; strict integer/date query validation; returning-vs-new sumFields + GREATEST floor; checkIndexing numeric casts + 21T wording; duplicate-coinbase comment height.
Address review: drop constants.test, fix homepage, parseInt PORT without radix 10.
superseded by D20361
See Fabien's comment: "keep the /token path for pay.e.cash, this makes the support optional for mobile wallets (e.g. marlin)"
Rebase onto current master.
Add SPEC version 1 so README/v1 settle references are grounded.