- User Since
- Nov 5 2020, 18:28 (159 w, 6 d)
Implement updated mock-chronik-client, amend unit test syntax
Note: these changes cause unit tests to fail in apps/ecash-herald and apps/alias-server. This diff does not change anything about the prod behavior of these apps. These failures are expected until D14869 and D14870, which upgrade chronik-client in these apps, land.
Need to update mock-chronik-client to correct syntax or change existing unit test
looking into why it still passed in D14860
apps/mock-chronik-client does not mock this level of specifity for chronik-client
Tue, Nov 28
testing locally and broadcasting to a dev channel
Since, previously, ecash-herald did not have built in websocket redundancy -- it was designed to bail out on app startup if the websocket connection failed (this design is also an artifact of when the app was manually deployed).
Mon, Nov 27
lines up according to test plan.
not able to arc patch this one, is this based on master?
alt approaches are available with lower complexity
Fri, Nov 24
Modify unit tests so that keepAlive = false is tested
cleaning up var name changes to clean up this diff as a reference. will still be abandoned after spllitting up.
carry var name changes throughout all uses
Bump attempt count as 6 resulted in success for only 5 of 7 blocks
will split this into smaller diffs
change _v2 naming convention to Node, layout issues
No more than 30s to wait for peername
fix comment, move wait interval to config
Thu, Nov 23
Clarify peername source, add unit test for emoji peername, remove unused param
FYI I get a rebase issue when I attempt to arc patch this diff
remove todo comments, the real todo there is adding features to the in-node chronik instance
or if the API fails
remove unrelated line break, mark peername api mock as generated
remove test script, fix comment
revert axios upgrade, was done troubleshooting
Sample output console.logging on a subscription to blocks and the ifp address
needs self-review, testing
Wed, Nov 22
gate clearinterval logic by keepalive param, reset interval to undefined after it is cleared
move url creation to helper function to avoid repeating long one-liner
Tue, Nov 21
Mon, Nov 20
Sun, Nov 19
Sat, Nov 18
the problem is that the function does too many things. You should split it into logical pieces so you can bail early for coinbase txs without adding another nesting level that makes the code harder to follow.
add test for parsing coinbase tx
If you have a coinbase tx, dont iterate through inputs at all
this fixes the bug but is not the right implementation
remove debug logging
Fri, Nov 17
will print xec amount if price is unavailable, e.g.
name the generated file specific to in-node chronik
update: draft up for review.
sharing failoverProxy, support ws iterations for in-node