Page MenuHomePhabricator

bytesofman (Joey)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2020, 18:28 (100 w, 3 h)
Roles
Administrator

Recent Activity

Today

bytesofman accepted D12166: [Cashtab] Fix reply button not showing.
Thu, Oct 6, 16:30
bytesofman requested changes to D12166: [Cashtab] Fix reply button not showing.
Thu, Oct 6, 15:55
bytesofman requested changes to D12165: [Cashtab] Fix Reply button not showing.

Need to implement this on latest master, might be easier to restart vs patch the conflicts as tx.js was changed extensively by chronik implementation in tx history

Thu, Oct 6, 15:10
bytesofman accepted D12113: [Cashtab] Equal airdrop distribution ratio option.

please rebase to latest master before landing

Thu, Oct 6, 15:08
bytesofman closed D12160: [Cashtab] [chronik tx history p22] remove debug logging.
Thu, Oct 6, 13:50
bytesofman closed D12159: [Cashtab] [chronik tx history p21] Better token burn parsing.
Thu, Oct 6, 13:50
bytesofman closed D12158: [Cashtab] [chronik tx history p20] update token info cache in tx history routine.
Thu, Oct 6, 13:50
bytesofman committed rABC362b99d6fc59: [Cashtab] [chronik tx history p22] remove debug logging (authored by bytesofman).
[Cashtab] [chronik tx history p22] remove debug logging
Thu, Oct 6, 13:50
bytesofman committed rABCe4a3e2a1b2a8: [Cashtab] [chronik tx history p20] update token info cache in tx history routine (authored by bytesofman).
[Cashtab] [chronik tx history p20] update token info cache in tx history routine
Thu, Oct 6, 13:50
bytesofman committed rABCc5d0bc4b8df9: [Cashtab] [chronik tx history p21] Better token burn parsing (authored by bytesofman).
[Cashtab] [chronik tx history p21] Better token burn parsing
Thu, Oct 6, 13:50
bytesofman closed D12148: [Cashtab] [chronik tx history p19] remove legacy object from tx parsing.
Thu, Oct 6, 13:49
bytesofman closed D12147: [Cashtab] [chronik tx history p18] remove legacy tokenTx param.
Thu, Oct 6, 13:49
bytesofman closed D12146: [Cashtab] [chronik tx history p17] Remove legacy outgoingTx param.
Thu, Oct 6, 13:49
bytesofman closed D12145: [Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived.
Thu, Oct 6, 13:49
bytesofman committed rABC0f8a3f95e529: [Cashtab] [chronik tx history p18] remove legacy tokenTx param (authored by bytesofman).
[Cashtab] [chronik tx history p18] remove legacy tokenTx param
Thu, Oct 6, 13:49
bytesofman committed rABC4bc7b700ef52: [Cashtab] [chronik tx history p17] Remove legacy outgoingTx param (authored by bytesofman).
[Cashtab] [chronik tx history p17] Remove legacy outgoingTx param
Thu, Oct 6, 13:49
bytesofman committed rABC5f508e303cc6: [Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived (authored by bytesofman).
[Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived
Thu, Oct 6, 13:49
bytesofman committed rABC6600ead38e40: [Cashtab] [chronik tx history p19] remove legacy object from tx parsing (authored by bytesofman).
[Cashtab] [chronik tx history p19] remove legacy object from tx parsing
Thu, Oct 6, 13:49
bytesofman closed D12144: [Cashtab] [chronik tx history p15] parsing token burn txs.
Thu, Oct 6, 13:49
bytesofman closed D12137: [Cashtab] [chronik tx history p12] Render tx history from chronik.
Thu, Oct 6, 13:49
bytesofman closed D12140: [Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests, and mocks.
Thu, Oct 6, 13:49
bytesofman committed rABC10c9f21d563d: [Cashtab] [chronik tx history p15] parsing token burn txs (authored by bytesofman).
[Cashtab] [chronik tx history p15] parsing token burn txs
Thu, Oct 6, 13:49
bytesofman closed D12139: [Cashtab] [chronik tx history p13] add unit tests for airdrop and encrypted msgs.
Thu, Oct 6, 13:49
bytesofman committed rABC195029ce4166: [Cashtab] [chronik tx history p12] Render tx history from chronik (authored by bytesofman).
[Cashtab] [chronik tx history p12] Render tx history from chronik
Thu, Oct 6, 13:49
bytesofman committed rABCf5ad7d2fb8e3: [Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests… (authored by bytesofman).
[Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests…
Thu, Oct 6, 13:49
bytesofman committed rABC88ea1025ad9f: [Cashtab] [chronik tx history p13] add unit tests for airdrop and encrypted msgs (authored by bytesofman).
[Cashtab] [chronik tx history p13] add unit tests for airdrop and encrypted msgs
Thu, Oct 6, 13:49
bytesofman closed D12131: [Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to use new function.
Thu, Oct 6, 13:49
bytesofman committed rABCcc96ec430689: [Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to… (authored by bytesofman).
[Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to…
Thu, Oct 6, 13:49
bytesofman closed D12130: [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals.
Thu, Oct 6, 13:49
bytesofman committed rABCa44c6d600129: [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals (authored by bytesofman).
[Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals
Thu, Oct 6, 13:49
bytesofman closed D12129: [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis txs.
Thu, Oct 6, 13:49
bytesofman closed D12066: [Cashtab] [chronik tx history p7] duplicate most legacy tx data.
Thu, Oct 6, 13:49
bytesofman closed D12089: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object.
Thu, Oct 6, 13:49
bytesofman committed rABC51d06c116735: [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis… (authored by bytesofman).
[Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis…
Thu, Oct 6, 13:49
bytesofman committed rABCde84a09dbd9a: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object (authored by bytesofman).
[Cashtab] [chronik tx history p8] Add replyAddress to legacy object
Thu, Oct 6, 13:49
bytesofman committed rABC8de6340c0620: [Cashtab] [chronik tx history p7] duplicate most legacy tx data (authored by bytesofman).
[Cashtab] [chronik tx history p7] duplicate most legacy tx data
Thu, Oct 6, 13:49
bytesofman closed D12056: [Cashtab] [chronik tx history p6] Detect OP_RETURN msgs and run through existing parse function.
Thu, Oct 6, 13:49
bytesofman committed rABCb0df15a5c6c0: [Cashtab] [chronik tx history p5] get reply hash160 (authored by bytesofman).
[Cashtab] [chronik tx history p5] get reply hash160
Thu, Oct 6, 13:49
bytesofman closed D12054: [Cashtab] [chronik tx history p5] get reply hash160.
Thu, Oct 6, 13:49
bytesofman committed rABC79f454cf7dd7: [Cashtab] [chronik tx history p6] Detect OP_RETURN msgs and run through… (authored by bytesofman).
[Cashtab] [chronik tx history p6] Detect OP_RETURN msgs and run through…
Thu, Oct 6, 13:49
bytesofman closed D12053: [Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to chronik.
Thu, Oct 6, 13:49
bytesofman committed rABCb1146b4a9f3b: [Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to… (authored by bytesofman).
[Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to…
Thu, Oct 6, 13:49
bytesofman closed D12052: [Cashtab] [chronik tx history p3] Add a function to sort chronik tx history of all addresses by blockheight and timeFirstSeen.
Thu, Oct 6, 13:49
bytesofman committed rABC07232dc03d94: [Cashtab] [chronik tx history p3] Add a function to sort chronik tx history of… (authored by bytesofman).
[Cashtab] [chronik tx history p3] Add a function to sort chronik tx history of…
Thu, Oct 6, 13:49
bytesofman closed D12051: [Cashtab] [chronik tx history p2] Add a function to combine chronik tx history for all addresses into a single array.
Thu, Oct 6, 13:49
bytesofman committed rABC594b1d1ac3e0: [Cashtab] [chronik tx history p2] Add a function to combine chronik tx history… (authored by bytesofman).
[Cashtab] [chronik tx history p2] Add a function to combine chronik tx history…
Thu, Oct 6, 13:49
bytesofman closed D12048: [Cashtab] [chronik tx history p1] Get the last 10 txs of all addresses in the wallet.
Thu, Oct 6, 13:49
bytesofman committed rABC228ad4c0b7b8: [Cashtab] [chronik tx history p1] Get the last 10 txs of all addresses in the… (authored by bytesofman).
[Cashtab] [chronik tx history p1] Get the last 10 txs of all addresses in the…
Thu, Oct 6, 13:49
bytesofman closed D12161: [Cashtab] Patch issue with burn all of a token locking UI.
Thu, Oct 6, 04:02
bytesofman committed rABCfc4d566a78df: [Cashtab] Patch issue with burn all of a token locking UI (authored by bytesofman).
[Cashtab] Patch issue with burn all of a token locking UI
Thu, Oct 6, 04:02
bytesofman updated the summary of D12158: [Cashtab] [chronik tx history p20] update token info cache in tx history routine.
Thu, Oct 6, 03:44
bytesofman requested review of D12161: [Cashtab] Patch issue with burn all of a token locking UI.

The full token balance burn issue is resolved however I noticed an edge case where sending etokens to the same etoken address it is being sent from will trigger a similar continuous loading process, however in this case it doesn't send it at all. This is reproducible in prod as well.

Thu, Oct 6, 01:47

Yesterday

bytesofman requested review of D12161: [Cashtab] Patch issue with burn all of a token locking UI.
Wed, Oct 5, 23:21
bytesofman requested review of D12160: [Cashtab] [chronik tx history p22] remove debug logging.
Wed, Oct 5, 22:51
bytesofman requested review of D12159: [Cashtab] [chronik tx history p21] Better token burn parsing.
Wed, Oct 5, 22:38
bytesofman requested review of D12158: [Cashtab] [chronik tx history p20] update token info cache in tx history routine.
Wed, Oct 5, 22:20
bytesofman added a comment to D12140: [Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests, and mocks.
  1. Also I'm seeing a reference to getTxHistory() in useWallet.js.rej - can we ignore this as this seems to be a arc patch artefact?

image.png (364×1 px, 149 KB)

Wed, Oct 5, 18:33
bytesofman requested review of D12140: [Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests, and mocks.
  1. to avoid new dev confusion in chronik.js:

change:

// Defining variables used in lines legacy parseTxData function from useBCH.js

to

// Defining variables used in line with the now removed legacy parseTxData function from useBCH.js

  1. Also I'm seeing a reference to getTxHistory() in useWallet.js.rej - can we ignore this as this seems to be a arc patch artefact?

image.png (364×1 px, 149 KB)

Otherwise app tested all ok after these deprecations. If anything, the speed improvement from this diff is VERY noticeable.

Wed, Oct 5, 18:32
bytesofman updated the diff for D12148: [Cashtab] [chronik tx history p19] remove legacy object from tx parsing.

Removing obsolete comment

Wed, Oct 5, 18:32
bytesofman requested review of D12144: [Cashtab] [chronik tx history p15] parsing token burn txs.

Burning partial amount of tokens works fine however when you choose to burn the entire balance of the token it gets into a continuous loop when it routes back to the TxHistory screen as below:

It's getting stuck somewhere after 'chronikTxHistory as flatterend array, sorted by...' and before the 'tokenInfoById' update, so it could be related to the caching of token info in cashtabCache. i.e. when the full balance is burnt, I don't think I've seen any diff that removes it from token cache. Not sure if that is causing this.

Having said that, the tx history is still getting updated with the burn tx all ok, so there's probably a gap somewhere that is not recognizing the burn token tx as part of the usual utxo update and thus not removing the passLoadingStatus.

Wed, Oct 5, 18:27
bytesofman updated the diff for D12131: [Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to use new function.

responding to review feedback

Wed, Oct 5, 18:13

Tue, Oct 4

bytesofman requested review of D12148: [Cashtab] [chronik tx history p19] remove legacy object from tx parsing.
Tue, Oct 4, 23:48
bytesofman requested review of D12147: [Cashtab] [chronik tx history p18] remove legacy tokenTx param.
Tue, Oct 4, 23:41
bytesofman updated the diff for D12146: [Cashtab] [chronik tx history p17] Remove legacy outgoingTx param.

Replacing rest of instances

Tue, Oct 4, 23:34
bytesofman requested review of D12146: [Cashtab] [chronik tx history p17] Remove legacy outgoingTx param.
Tue, Oct 4, 23:31
bytesofman requested review of D12145: [Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived.
Tue, Oct 4, 23:26
bytesofman updated the diff for D12144: [Cashtab] [chronik tx history p15] parsing token burn txs.

Clean up comments

Tue, Oct 4, 22:45
bytesofman requested review of D12144: [Cashtab] [chronik tx history p15] parsing token burn txs.
Tue, Oct 4, 22:42
bytesofman requested review of D12140: [Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests, and mocks.
Tue, Oct 4, 19:26
bytesofman requested review of D12139: [Cashtab] [chronik tx history p13] add unit tests for airdrop and encrypted msgs.
Tue, Oct 4, 19:07
bytesofman requested review of D12137: [Cashtab] [chronik tx history p12] Render tx history from chronik.
Tue, Oct 4, 17:19
bytesofman updated the diff for D12131: [Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to use new function.

Remove unused function

Tue, Oct 4, 16:49
bytesofman requested changes to D12120: [Cashtab] eCash Namespace Services prototype - part 1 base implementation.

We should get the ball rolling on this and not worry too much about optimization, since just having something that works and can be improved from is a big win.

Tue, Oct 4, 16:36
bytesofman requested changes to D12136: [Cashtab] create adjustTokenQtyForDecimals function.
  • tokenDecimals should never be a BigNumber
  • the function should accept a string or BigNumber for token quantity
  • don't implement anywhere, just create the function and its unit tests
Tue, Oct 4, 16:21
bytesofman requested changes to D12113: [Cashtab] Equal airdrop distribution ratio option.

I think the "Distribution Ratio" is confusing -- also content jumps when the switch is hit. Remove this label.

Tue, Oct 4, 16:02
bytesofman updated the summary of D12089: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object.
Tue, Oct 4, 14:06

Mon, Oct 3

bytesofman added a comment to D12089: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object.

stack is rebased

Mon, Oct 3, 23:51
bytesofman updated the diff for D12131: [Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to use new function.

rebase

Mon, Oct 3, 23:50
bytesofman updated the diff for D12130: [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals.

rebase

Mon, Oct 3, 23:50
bytesofman updated the diff for D12129: [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis txs.

rebase

Mon, Oct 3, 23:50
bytesofman updated the diff for D12089: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object.

rebase

Mon, Oct 3, 23:50
bytesofman updated the diff for D12066: [Cashtab] [chronik tx history p7] duplicate most legacy tx data.

rebase

Mon, Oct 3, 23:49
bytesofman updated the diff for D12056: [Cashtab] [chronik tx history p6] Detect OP_RETURN msgs and run through existing parse function.

rebase

Mon, Oct 3, 23:49
bytesofman updated the diff for D12054: [Cashtab] [chronik tx history p5] get reply hash160.

rebase

Mon, Oct 3, 23:49
bytesofman updated the diff for D12053: [Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to chronik.

rebase

Mon, Oct 3, 23:49
bytesofman updated the diff for D12052: [Cashtab] [chronik tx history p3] Add a function to sort chronik tx history of all addresses by blockheight and timeFirstSeen.

adh

Mon, Oct 3, 23:49
bytesofman updated the diff for D12051: [Cashtab] [chronik tx history p2] Add a function to combine chronik tx history for all addresses into a single array.

rebase

Mon, Oct 3, 23:48
bytesofman updated the diff for D12048: [Cashtab] [chronik tx history p1] Get the last 10 txs of all addresses in the wallet.

rebase

Mon, Oct 3, 23:48
bytesofman requested review of D12131: [Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to use new function.
Mon, Oct 3, 23:46
bytesofman requested review of D12130: [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals.
Mon, Oct 3, 23:01
bytesofman requested review of D12129: [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis txs.
Mon, Oct 3, 21:56

Sat, Oct 1

bytesofman accepted D12100: [Cashtab] Patched nav menu being cut off on some mobile views.
Sat, Oct 1, 15:03

Wed, Sep 28

bytesofman accepted D12088: [website] Add blog post about Avalanche Post-Consensus.
Wed, Sep 28, 23:43
bytesofman requested review of D12089: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object.
Wed, Sep 28, 23:38
bytesofman requested changes to D12088: [website] Add blog post about Avalanche Post-Consensus.
Wed, Sep 28, 21:20

Tue, Sep 27

bytesofman accepted D12079: [Cashtab] Patch font color for One To Many Airdrop Payment Outputs input.
Tue, Sep 27, 21:46
bytesofman accepted D12080: [Cashtab] Match hover effect for all icons on settings page.
Tue, Sep 27, 21:45
bytesofman accepted D11997: [Cashtab] Add hamburger menu to taskbar.
Tue, Sep 27, 21:43
bytesofman accepted D12065: [Cashtab] fix antd error in console when user clicks Create eToken.
Tue, Sep 27, 16:24

Mon, Sep 26

bytesofman updated the diff for D12066: [Cashtab] [chronik tx history p7] duplicate most legacy tx data.

Updating dev log info

Mon, Sep 26, 23:15