Page MenuHomePhabricator

bytesofman (Joey)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2020, 18:28 (298 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

bytesofman published D20380: [alp-dex] Wire Chronik sync and ALP genesis into startup for review.

we don't need a extensive chronik url validation (codedrabbit comment) as chronik-client already validates

Sat, Jul 25, 23:53
bytesofman updated the diff for D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

Address CodeRabbit: bound pool-key tier digit length before BigInt; watch/depend on chronik-client for alp-fusion-tests.

Sat, Jul 25, 23:51
bytesofman updated the diff for D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

Address CodeRabbit: reject H=G; identity (0,0) verify; defensive getR copy; same-domain Pedersen positive control. Skip hash-to-curve H derivation (Electrum NUMS API).

Sat, Jul 25, 23:16
bytesofman updated the diff for D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

Address review: zero-nonce Pedersen aggregation; validate blind-Schnorr inputs before retry; stop zeroing public s'; enforce pool-key tokenId/tier bounds.

Sat, Jul 25, 22:43
bytesofman closed D20391: [charts.e.cash] Fix rich list and mobile chart picker scrolling.
Sat, Jul 25, 21:39
bytesofman committed rABC37223dada34b: [charts.e.cash] Fix rich list and mobile chart picker scrolling (authored by bytesofman).
[charts.e.cash] Fix rich list and mobile chart picker scrolling
Sat, Jul 25, 21:39
bytesofman published D20391: [charts.e.cash] Fix rich list and mobile chart picker scrolling for review.
Sat, Jul 25, 21:14
bytesofman requested changes to D20389: [Cashtab] Add signMessage request to cashtab-connect + extension.
  • should also add this to the cashtab-connect demo react app so it can be tested locally / the UX can be evaluated
  • when updating the diff, do not skip arc lint and arc unit
Sat, Jul 25, 17:24
bytesofman published D20390: [Cashtab] Select first contact suggestion with Enter or Tab for review.
Sat, Jul 25, 17:15
bytesofman published D20388: [Cashtab] Fix burn UX for blacklisted tokens for review.
Sat, Jul 25, 01:11
bytesofman published D20387: [Cashtab] Show Firma APY in the USD header card for review.
Sat, Jul 25, 01:11
bytesofman added a comment to D20335: [Cashtab] Add and implement a standard for agora action deep links.
  1. We aren't getting expected behavior on XECX (c67bf5c2b6d91cfb46a5c1772582eff80d88686887be10aa63b0945479cf4ed4) or Firma Alpha (0387947fd575db4fb19a3e322f635dec37fd192b5941625b66bc4b2c3008cbf0) pages; these need special handling as they have special handling for redeem
  1. The dockerfile change for pay.e.cash will work for the preview, but we currently deploy this site as a pure static site. Couple of options here ... we could deploy it dockerized with nginx, or we could duplicate index.html in a /token/ dir -- thoughts on this @Fabien ?

Can you explain me what the problem is, because I don't understand? Why is this change not compatible with our current deployment?

Sat, Jul 25, 01:11
bytesofman accepted D20382: [marlin] E2E tests hardening.
Sat, Jul 25, 01:07
bytesofman published D20386: [Cashtab] Drop labels above Send address and amount fields for review.
Sat, Jul 25, 00:49

Thu, Jul 23

bytesofman updated the diff for D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

Address review: modular (a-k) path for Pedersen blinding; clarify HG equivalence and seckeyAdd mod n; zero blind-Schnorr temps on both c signs; stricter poolKey parsing and golden hash vectors. Rebase onto master.

Thu, Jul 23, 14:10
bytesofman closed D20372: [Cashtab] Target Android 16 (API 36) via Capacitor 8.
Thu, Jul 23, 14:03
bytesofman committed rABC671b588ed4be: [Cashtab] Target Android 16 (API 36) via Capacitor 8 (authored by bytesofman).
[Cashtab] Target Android 16 (API 36) via Capacitor 8
Thu, Jul 23, 14:03
bytesofman published D20372: [Cashtab] Target Android 16 (API 36) via Capacitor 8 for review.
Thu, Jul 23, 12:58
bytesofman closed D20370: [alp-dex] Derive seller/slush HD wallets; require external feeAddress.
Thu, Jul 23, 12:45
bytesofman committed rABCb82e2d0fb54c: [alp-dex] Derive seller/slush HD wallets; require external feeAddress (authored by bytesofman).
[alp-dex] Derive seller/slush HD wallets; require external feeAddress
Thu, Jul 23, 12:45
bytesofman requested changes to D20335: [Cashtab] Add and implement a standard for agora action deep links.
  1. We aren't getting expected behavior on XECX (c67bf5c2b6d91cfb46a5c1772582eff80d88686887be10aa63b0945479cf4ed4) or Firma Alpha (0387947fd575db4fb19a3e322f635dec37fd192b5941625b66bc4b2c3008cbf0) pages; these need special handling as they have special handling for redeem
Thu, Jul 23, 12:44
bytesofman accepted D20379: [marlin] Fix flaky test.
Thu, Jul 23, 12:28
bytesofman updated the diff for D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

Rebase onto latest master.

Thu, Jul 23, 12:06
bytesofman updated the diff for D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

Clarify blindSchnorr file comment: describe Uint8Array + wasm ECC scalar ops without negative phrasing.

Thu, Jul 23, 11:48
bytesofman added inline comments to D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).
Thu, Jul 23, 11:48
bytesofman updated the summary of D20370: [alp-dex] Derive seller/slush HD wallets; require external feeAddress.
Thu, Jul 23, 11:33
bytesofman updated the diff for D20370: [alp-dex] Derive seller/slush HD wallets; require external feeAddress.

Address Fabien feedback: real BIP39 validation; use ecash-lib Address; scrub README/index noise; clear early mnemonic errors.

Thu, Jul 23, 11:33
bytesofman added a comment to D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

Done — updated this diff with the review fixes. Sorry about the stray __draft-probe-do-not-keep__ comment from API probing; please ignore it.

Thu, Jul 23, 11:32
bytesofman updated the diff for D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

Address review: Electrum amount blinding; wasm seckeyMul/seckeyNegate for blind Schnorr; Uint8Array secrets with zeroing; rejection-sampled randomScalar; rename modCurveOrder/bytesToScalar; drop constants tests and unreleased changelog.

Thu, Jul 23, 11:32
bytesofman added a comment to D20318: [alp-fusion] Add protocol primitives (Pedersen, blind Schnorr, hashing).

draft-probe-do-not-keep

Thu, Jul 23, 11:32
bytesofman closed D20377: [charts.e.cash] Add % Supply column to rich list.
Thu, Jul 23, 10:53
bytesofman committed rABC0f4de91dde42: [charts.e.cash] Add % Supply column to rich list (authored by bytesofman).
[charts.e.cash] Add % Supply column to rich list
Thu, Jul 23, 10:53
bytesofman published D20377: [charts.e.cash] Add % Supply column to rich list for review.
Thu, Jul 23, 05:12

Wed, Jul 22

bytesofman added a comment to D20335: [Cashtab] Add and implement a standard for agora action deep links.

@bot preview-pay.e.cash

Wed, Jul 22, 19:26
bytesofman published D20370: [alp-dex] Derive seller/slush HD wallets; require external feeAddress for review.

Reject account numbers above 0x7fffffff.

Wed, Jul 22, 19:21
bytesofman closed D20374: [charts.e.cash] Build ecashaddrjs in Docker image.
Wed, Jul 22, 14:45
bytesofman committed rABC87d0ebd7fb14: [charts.e.cash] Build ecashaddrjs in Docker image (authored by bytesofman).
[charts.e.cash] Build ecashaddrjs in Docker image
Wed, Jul 22, 14:45
bytesofman published D20374: [charts.e.cash] Build ecashaddrjs in Docker image for review.
Wed, Jul 22, 14:35
bytesofman added inline comments to D20363: [alp-dex] Add traded-pair config parsers and tokenId asserts.
Wed, Jul 22, 14:28
bytesofman closed D20373: [metachronik] Build ecash-lib in Docker image.
Wed, Jul 22, 14:24
bytesofman committed rABCc58b71e0fbef: [metachronik] Build ecash-lib in Docker image (authored by bytesofman).
[metachronik] Build ecash-lib in Docker image
Wed, Jul 22, 14:24
bytesofman published D20373: [metachronik] Build ecash-lib in Docker image for review.
Wed, Jul 22, 14:19
bytesofman closed D20206: [metachronik, charts.e.cash] Add new indexing to support new charts.
Wed, Jul 22, 14:10
bytesofman committed rABC1f763d07e67e: [metachronik, charts.e.cash] Add new indexing to support new charts (authored by bytesofman).
[metachronik, charts.e.cash] Add new indexing to support new charts
Wed, Jul 22, 14:10
bytesofman committed rABC7f048eb527d1: [Cashtab] Show liquid XEC and XECX amounts under combined balance (authored by bytesofman).
[Cashtab] Show liquid XEC and XECX amounts under combined balance
Wed, Jul 22, 13:19
bytesofman closed D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance.
Wed, Jul 22, 13:19
bytesofman closed D20363: [alp-dex] Add traded-pair config parsers and tokenId asserts.
Wed, Jul 22, 12:35
bytesofman committed rABC1bf5d2a7ab0f: [alp-dex] Add traded-pair config parsers and tokenId asserts (authored by bytesofman).
[alp-dex] Add traded-pair config parsers and tokenId asserts
Wed, Jul 22, 12:35
bytesofman updated the diff for D20206: [metachronik, charts.e.cash] Add new indexing to support new charts.

Rebase onto latest master so pnpm-lock.yaml matches CI base.

Wed, Jul 22, 12:22
bytesofman updated the diff for D20363: [alp-dex] Add traded-pair config parsers and tokenId asserts.

Address review: drop .env/dotenv; put port in config.json; rename a/b to aTokenId/bTokenId; remove JSON _comment keys from sample.

Wed, Jul 22, 12:03
teamcity awarded D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance a Piece of Eight token.
Wed, Jul 22, 11:37
bytesofman updated the diff for D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance.

Rebase onto latest master.

Wed, Jul 22, 11:28
bytesofman closed D20360: [Cashtab] Copy env.sample in Docker build when .env is missing.
Wed, Jul 22, 11:27
bytesofman committed rABC849c06f15da7: [Cashtab] Copy env.sample in Docker build when .env is missing (authored by bytesofman).
[Cashtab] Copy env.sample in Docker build when .env is missing
Wed, Jul 22, 11:27
teamcity awarded D20360: [Cashtab] Copy env.sample in Docker build when .env is missing a Piece of Eight token.
Wed, Jul 22, 09:09

Tue, Jul 21

bytesofman added a comment to D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance.

imo the most recent coderabbit review should not be implemented. the firma price isn't the xec price in USD it is related to firma redeems. the accessibility thing is an optimization not a major problem.

Tue, Jul 21, 16:33
bytesofman updated the diff for D20206: [metachronik, charts.e.cash] Add new indexing to support new charts.

Fix token block burn deltas: count actualBurnAtoms only (do not add intentionalBurnAtoms). Historical block_token_deltas burns stay inflated until a reindex; not charted today.

Tue, Jul 21, 15:35
bytesofman updated the diff for D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance.

Stop Enter/Space on the staked link from bubbling to the eCash card keydown handler so keyboard users navigate to XECX instead of toggling the breakdown.

Tue, Jul 21, 15:32
bytesofman updated the diff for D20206: [metachronik, charts.e.cash] Add new indexing to support new charts.

CodeRabbit follow-ups: validate real calendar dates; clamp repair --batch-size; guard STATEMENT_TIMEOUT_MS NaN + catch SET failures; fix scripts README; document that mint batons are 0-atom (default rich-list min_atoms excludes them). Skip ForkReferenceLines (recharts 3 + verified on charts) and burn double-count pending decision.

Tue, Jul 21, 15:32
bytesofman updated the diff for D20363: [alp-dex] Add traded-pair config parsers and tokenId asserts.

Harden pairKey; feePct in [0,1]; reject non-numeric fee/utxo JSON values.

Tue, Jul 21, 15:06
bytesofman updated the diff for D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance.

Rebase on master (Etokens changes landed in D20362). Drop >10k XEC/XECX decimal rounding so balances stay exact.

Tue, Jul 21, 14:58
bytesofman closed D20359: [Cashtab] Use switch for token history description text.
Tue, Jul 21, 14:56
bytesofman committed rABC6ddd4feb6018: [Cashtab] Use switch for token history description text (authored by bytesofman).
[Cashtab] Use switch for token history description text
Tue, Jul 21, 14:56
bytesofman updated the diff for D20360: [Cashtab] Copy env.sample in Docker build when .env is missing.

Address review: copy env.sample in cashtab.Dockerfile only when .env is missing. Dropped the docker.pre_build CI hook. Rebased onto master so the diff is Dockerfile-only.

Tue, Jul 21, 14:55
bytesofman closed D20362: [Cashtab] Do not unmount Etokens list on context loading.
Tue, Jul 21, 14:55
bytesofman committed rABC8f5a72fdd16e: [Cashtab] Do not unmount Etokens list on context loading (authored by bytesofman).
[Cashtab] Do not unmount Etokens list on context loading
Tue, Jul 21, 14:55
bytesofman retitled D20360: [Cashtab] Copy env.sample in Docker build when .env is missing from [CI] Copy env.sample before preview-cashtab Docker build to [Cashtab] Copy env.sample in Docker build when .env is missing.
Tue, Jul 21, 14:55
bytesofman updated the diff for D20360: [Cashtab] Copy env.sample in Docker build when .env is missing.

Address review: drop docker.pre_build; copy env.sample in cashtab.Dockerfile only when .env is missing so prod/local overrides are preserved.

Tue, Jul 21, 14:55
bytesofman updated the diff for D20206: [metachronik, charts.e.cash] Add new indexing to support new charts.

Address CodeRabbit review (except burn double-count pending confirmation): migrateSchema ADD COLUMN for new blocks/days fields; charts UTC date formatting + incomplete-day filter; strict integer/date query validation; returning-vs-new sumFields + GREATEST floor; checkIndexing numeric casts + 21T wording; duplicate-coinbase comment height.

Tue, Jul 21, 14:34
bytesofman published D20363: [alp-dex] Add traded-pair config parsers and tokenId asserts for review.
Tue, Jul 21, 14:28
bytesofman published D20359: [Cashtab] Use switch for token history description text for review.
Tue, Jul 21, 14:28
bytesofman published D20362: [Cashtab] Do not unmount Etokens list on context loading for review.
Tue, Jul 21, 14:28
bytesofman published D20360: [Cashtab] Copy env.sample in Docker build when .env is missing for review.
Tue, Jul 21, 14:04
bytesofman closed D20361: [the-overmind] Remove deprecated app and CI.
Tue, Jul 21, 13:48
bytesofman committed rABC58b672ce834a: [the-overmind] Remove deprecated app and CI (authored by bytesofman).
[the-overmind] Remove deprecated app and CI
Tue, Jul 21, 13:48
bytesofman closed D20354: [alp-dex] Scaffold TypeScript package with Express health stub.
Tue, Jul 21, 13:46
bytesofman committed rABCfbb422b0e61b: [alp-dex] Scaffold TypeScript package with Express health stub (authored by bytesofman).
[alp-dex] Scaffold TypeScript package with Express health stub
Tue, Jul 21, 13:46
bytesofman added inline comments to D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance.
Tue, Jul 21, 13:45
bytesofman updated the diff for D20354: [alp-dex] Scaffold TypeScript package with Express health stub.

Address review: drop constants.test, fix homepage, parseInt PORT without radix 10.

Tue, Jul 21, 13:37
bytesofman published D20361: [the-overmind] Remove deprecated app and CI for review.
Tue, Jul 21, 13:36
bytesofman abandoned D20357: [the-overmind] Prevent concurrent registration HD index reuse.

superseded by D20361

Tue, Jul 21, 13:36
teamcity awarded D20354: [alp-dex] Scaffold TypeScript package with Express health stub a Haypence token.
Tue, Jul 21, 13:32
bytesofman planned changes to D20357: [the-overmind] Prevent concurrent registration HD index reuse.
Tue, Jul 21, 13:32
bytesofman published D20357: [the-overmind] Prevent concurrent registration HD index reuse for review.
Tue, Jul 21, 13:31
bytesofman added inline comments to D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance.
Tue, Jul 21, 13:29
teamcity awarded D20360: [Cashtab] Copy env.sample in Docker build when .env is missing a Haypence token.
Tue, Jul 21, 13:25
bytesofman requested changes to D20335: [Cashtab] Add and implement a standard for agora action deep links.

See Fabien's comment: "keep the /token path for pay.e.cash, this makes the support optional for mobile wallets (e.g. marlin)"

Tue, Jul 21, 13:17
teamcity awarded D20346: [Cashtab] Show liquid XEC and XECX amounts under combined balance a Haypence token.
Tue, Jul 21, 13:09
bytesofman closed D20342: [Cashtab] Parse Agora relist txs as Relisted instead of Canceled.
Tue, Jul 21, 12:58
bytesofman committed rABC1d1f3a6c078a: [Cashtab] Parse Agora relist txs as Relisted instead of Canceled (authored by bytesofman).
[Cashtab] Parse Agora relist txs as Relisted instead of Canceled
Tue, Jul 21, 12:58
bytesofman added inline comments to D20206: [metachronik, charts.e.cash] Add new indexing to support new charts.
Tue, Jul 21, 12:55
bytesofman accepted D20356: [CI] Strip coderabbit noise from the feedback message.
Tue, Jul 21, 12:51
bytesofman updated the diff for D20206: [metachronik, charts.e.cash] Add new indexing to support new charts.

Rebase onto current master.

Tue, Jul 21, 12:51
bytesofman closed D20330: [Cashtab] Add mobile custom amount keypad for locale input.
Tue, Jul 21, 12:50
bytesofman committed rABC2e14b0648ce1: [Cashtab] Add mobile custom amount keypad for locale input (authored by bytesofman).
[Cashtab] Add mobile custom amount keypad for locale input
Tue, Jul 21, 12:50
bytesofman accepted D20355: [CI] Run coderabbit on diffs.
Tue, Jul 21, 12:20
bytesofman published D20354: [alp-dex] Scaffold TypeScript package with Express health stub for review.
Tue, Jul 21, 12:12
bytesofman closed D20325: [alp-dex] Add AMM node README and protocol SPEC.
Tue, Jul 21, 11:37
bytesofman committed rABCcef5bd709604: [alp-dex] Add AMM node README and protocol SPEC (authored by bytesofman).
[alp-dex] Add AMM node README and protocol SPEC
Tue, Jul 21, 11:37
bytesofman updated the diff for D20325: [alp-dex] Add AMM node README and protocol SPEC.

Add SPEC version 1 so README/v1 settle references are grounded.

Tue, Jul 21, 11:37