Page MenuHomePhabricator

bytesofman (Joey)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2020, 18:28 (159 w, 6 d)
Roles
Administrator

Recent Activity

Today

bytesofman accepted D14877: [e.cash] Bump latestVersion to 0.28.4 on upgrade page.
Thu, Nov 30, 00:06

Yesterday

bytesofman closed D14870: [alias-server] Implement chronik with backup connections.
Wed, Nov 29, 18:59
bytesofman committed rABC46103b0bcf93: [alias-server] Implement chronik with backup connections (authored by bytesofman).
[alias-server] Implement chronik with backup connections
Wed, Nov 29, 18:59
bytesofman updated the diff for D14870: [alias-server] Implement chronik with backup connections.

Implement updated mock-chronik-client, amend unit test syntax

Wed, Nov 29, 18:24
bytesofman closed D14871: [mock-chronik-client] Update syntax to match chronik-client 0.9.0.
Wed, Nov 29, 18:20
bytesofman committed rABC04475ca612f1: [mock-chronik-client] Update syntax to match chronik-client 0.9.0 (authored by bytesofman).
[mock-chronik-client] Update syntax to match chronik-client 0.9.0
Wed, Nov 29, 18:20
bytesofman closed D14869: [ecash-herald] Implement chronik-client 0.9.0 with failover proxy.
Wed, Nov 29, 18:19
bytesofman committed rABCb2a1a26df9d8: [ecash-herald] Implement chronik-client 0.9.0 with failover proxy (authored by bytesofman).
[ecash-herald] Implement chronik-client 0.9.0 with failover proxy
Wed, Nov 29, 18:19
bytesofman requested changes to D14860: [alias] Update the alias server to use the new chronik client with automated backup.

Same issue present in D14859. See D14870 and D14871

Wed, Nov 29, 00:36
bytesofman added a comment to D14871: [mock-chronik-client] Update syntax to match chronik-client 0.9.0.

Note: these changes cause unit tests to fail in apps/ecash-herald and apps/alias-server. This diff does not change anything about the prod behavior of these apps. These failures are expected until D14869 and D14870, which upgrade chronik-client in these apps, land.

Wed, Nov 29, 00:34
bytesofman requested review of D14871: [mock-chronik-client] Update syntax to match chronik-client 0.9.0.
Wed, Nov 29, 00:29
bytesofman planned changes to D14870: [alias-server] Implement chronik with backup connections.

Need to update mock-chronik-client to correct syntax or change existing unit test

Wed, Nov 29, 00:19
bytesofman requested review of D14870: [alias-server] Implement chronik with backup connections.
Wed, Nov 29, 00:19
bytesofman added a comment to D14859: [herald] Use the new chronik client with the automated backup.

looking into why it still passed in D14860

Wed, Nov 29, 00:16
bytesofman added a comment to D14859: [herald] Use the new chronik client with the automated backup.

apps/mock-chronik-client does not mock this level of specifity for chronik-client

Wed, Nov 29, 00:10
bytesofman added inline comments to D14869: [ecash-herald] Implement chronik-client 0.9.0 with failover proxy.
Wed, Nov 29, 00:04

Tue, Nov 28

bytesofman added a comment to D14869: [ecash-herald] Implement chronik-client 0.9.0 with failover proxy.

testing locally and broadcasting to a dev channel

image.png (522×430 px, 68 KB)

Tue, Nov 28, 23:57
bytesofman requested changes to D14859: [herald] Use the new chronik client with the automated backup.

Since, previously, ecash-herald did not have built in websocket redundancy -- it was designed to bail out on app startup if the websocket connection failed (this design is also an artifact of when the app was manually deployed).

Tue, Nov 28, 23:56
bytesofman updated the diff for D14869: [ecash-herald] Implement chronik-client 0.9.0 with failover proxy.

lint

Tue, Nov 28, 23:54
bytesofman requested review of D14869: [ecash-herald] Implement chronik-client 0.9.0 with failover proxy.
Tue, Nov 28, 23:53
bytesofman closed D14858: [chronik hotfix] use chronik.be.cash servers for live apps.
Tue, Nov 28, 07:04
bytesofman committed rABCdf1a69cc757f: [chronik hotfix] use chronik.be.cash servers for live apps (authored by bytesofman).
[chronik hotfix] use chronik.be.cash servers for live apps
Tue, Nov 28, 07:04
bytesofman requested review of D14858: [chronik hotfix] use chronik.be.cash servers for live apps.
Tue, Nov 28, 06:56

Mon, Nov 27

bytesofman accepted D14857: [e.cash] Update instant exchanges scoring criteria.

lines up according to test plan.

Mon, Nov 27, 22:56
bytesofman added a comment to D14857: [e.cash] Update instant exchanges scoring criteria.

@bot preview-e.cash

Mon, Nov 27, 22:46
bytesofman added a comment to D14854: [electrum] use the progress bar when broadcasting multiple transactions.

not able to arc patch this one, is this based on master?

Mon, Nov 27, 20:44
bytesofman abandoned D14850: [ecash-herald] Check peername API until updated.

alt approaches are available with lower complexity

Mon, Nov 27, 16:23

Fri, Nov 24

bytesofman added inline comments to D14851: [chronik-client] Add in-node ChronikClientNode object and handle standard endpoints.
Fri, Nov 24, 22:55
bytesofman closed D14852: [chronik-client] Default true for websocket keepAlive.
Fri, Nov 24, 22:47
bytesofman committed rABC0935ae6f5067: [chronik-client] Default true for websocket keepAlive (authored by bytesofman).
[chronik-client] Default true for websocket keepAlive
Fri, Nov 24, 22:47
bytesofman updated the diff for D14852: [chronik-client] Default true for websocket keepAlive.

Modify unit tests so that keepAlive = false is tested

Fri, Nov 24, 21:42
bytesofman requested review of D14852: [chronik-client] Default true for websocket keepAlive.
Fri, Nov 24, 21:41
bytesofman planned changes to D14840: [chronik-client] Add new class to support in-node chronik server.

cleaning up var name changes to clean up this diff as a reference. will still be abandoned after spllitting up.

Fri, Nov 24, 15:54
bytesofman updated the diff for D14840: [chronik-client] Add new class to support in-node chronik server.

carry var name changes throughout all uses

Fri, Nov 24, 15:54
bytesofman added a comment to D14850: [ecash-herald] Check peername API until updated.

I simply don't understand the problem this is solving

Fri, Nov 24, 15:51
bytesofman requested review of D14851: [chronik-client] Add in-node ChronikClientNode object and handle standard endpoints.
Fri, Nov 24, 15:44
bytesofman updated the diff for D14850: [ecash-herald] Check peername API until updated.

Bump attempt count as 6 resulted in success for only 5 of 7 blocks

Fri, Nov 24, 15:19
bytesofman planned changes to D14840: [chronik-client] Add new class to support in-node chronik server.

will split this into smaller diffs

Fri, Nov 24, 15:16
bytesofman added inline comments to D14840: [chronik-client] Add new class to support in-node chronik server.
Fri, Nov 24, 15:16
bytesofman updated the diff for D14840: [chronik-client] Add new class to support in-node chronik server.

change _v2 naming convention to Node, layout issues

Fri, Nov 24, 15:16
bytesofman added inline comments to D14850: [ecash-herald] Check peername API until updated.
Fri, Nov 24, 15:04
bytesofman updated the diff for D14850: [ecash-herald] Check peername API until updated.

No more than 30s to wait for peername

Fri, Nov 24, 15:03
bytesofman updated the diff for D14850: [ecash-herald] Check peername API until updated.

fix comment, move wait interval to config

Fri, Nov 24, 15:01
bytesofman requested review of D14850: [ecash-herald] Check peername API until updated.
Fri, Nov 24, 14:56
bytesofman closed D14843: [ecash-herald] Show peerName for staking reward winner, if available.
Fri, Nov 24, 02:20
bytesofman committed rABC87143a692fb5: [ecash-herald] Show peerName for staking reward winner, if available (authored by bytesofman).
[ecash-herald] Show peerName for staking reward winner, if available
Fri, Nov 24, 02:20

Thu, Nov 23

bytesofman added inline comments to D14843: [ecash-herald] Show peerName for staking reward winner, if available.
Thu, Nov 23, 17:04
bytesofman updated the diff for D14843: [ecash-herald] Show peerName for staking reward winner, if available.

Clarify peername source, add unit test for emoji peername, remove unused param

Thu, Nov 23, 17:04
bytesofman accepted D14844: Cleanup the Nov. 15 2023 activation code and prepare for the May 15 2024 upgrade.
Thu, Nov 23, 15:47
bytesofman accepted D14842: [electrum] don't show error if the Aux Key Dialog's password prompt is cancelled.

FYI I get a rebase issue when I attempt to arc patch this diff

Thu, Nov 23, 13:00
bytesofman updated the diff for D14840: [chronik-client] Add new class to support in-node chronik server.

remove todo comments, the real todo there is adding features to the in-node chronik instance

Thu, Nov 23, 12:53
bytesofman added a comment to D14843: [ecash-herald] Show peerName for staking reward winner, if available.

or if the API fails

Thu, Nov 23, 12:48
bytesofman updated the diff for D14843: [ecash-herald] Show peerName for staking reward winner, if available.

remove unrelated line break, mark peername api mock as generated

Thu, Nov 23, 12:47
bytesofman updated the diff for D14843: [ecash-herald] Show peerName for staking reward winner, if available.

remove test script, fix comment

Thu, Nov 23, 12:43
bytesofman updated the diff for D14843: [ecash-herald] Show peerName for staking reward winner, if available.

revert axios upgrade, was done troubleshooting

Thu, Nov 23, 12:42
bytesofman requested review of D14843: [ecash-herald] Show peerName for staking reward winner, if available.
Thu, Nov 23, 12:41
bytesofman closed D14835: [herald] Simplify price api to add specific urls to mocks.
Thu, Nov 23, 11:35
bytesofman committed rABCd567420ad146: [herald] Simplify price api to add specific urls to mocks (authored by bytesofman).
[herald] Simplify price api to add specific urls to mocks
Thu, Nov 23, 11:35
bytesofman added a comment to D14840: [chronik-client] Add new class to support in-node chronik server.

Sample output console.logging on a subscription to blocks and the ifp address

Thu, Nov 23, 00:13
bytesofman planned changes to D14840: [chronik-client] Add new class to support in-node chronik server.

needs self-review, testing

Thu, Nov 23, 00:08
bytesofman requested review of D14840: [chronik-client] Add new class to support in-node chronik server.
Thu, Nov 23, 00:07

Wed, Nov 22

bytesofman closed D14831: [chronik-client] Implement keepAlive to preserve longlived connections.
Wed, Nov 22, 23:16
bytesofman committed rABCffb653302c0b: [chronik-client] Implement keepAlive to preserve longlived connections (authored by bytesofman).
[chronik-client] Implement keepAlive to preserve longlived connections
Wed, Nov 22, 23:16
bytesofman updated the diff for D14831: [chronik-client] Implement keepAlive to preserve longlived connections.

gate clearinterval logic by keepalive param, reset interval to undefined after it is cleared

Wed, Nov 22, 23:10
bytesofman updated the diff for D14835: [herald] Simplify price api to add specific urls to mocks.

move url creation to helper function to avoid repeating long one-liner

Wed, Nov 22, 22:36
bytesofman requested review of D14835: [herald] Simplify price api to add specific urls to mocks.
Wed, Nov 22, 02:29

Tue, Nov 21

bytesofman added inline comments to D14831: [chronik-client] Implement keepAlive to preserve longlived connections.
Tue, Nov 21, 21:52
bytesofman abandoned D14832: [Cashtab] Modify unknown msg warning.

What is the problem with the actual warning ? It feels more secure to me.

Tue, Nov 21, 21:46
bytesofman requested review of D14832: [Cashtab] Modify unknown msg warning.
Tue, Nov 21, 20:07
bytesofman updated the summary of D14831: [chronik-client] Implement keepAlive to preserve longlived connections.
Tue, Nov 21, 19:46
bytesofman requested review of D14831: [chronik-client] Implement keepAlive to preserve longlived connections.
Tue, Nov 21, 19:45
bytesofman closed D14824: [Cashtab] app.js format improvements.
Tue, Nov 21, 15:25
bytesofman committed rABC8270010d754c: [Cashtab] app.js format improvements (authored by bytesofman).
[Cashtab] app.js format improvements
Tue, Nov 21, 15:24
bytesofman closed D14823: [chronik-client] Organize code to prepare for additional in-node class.
Tue, Nov 21, 15:24
bytesofman committed rABCbfd65df0138a: [chronik-client] Organize code to prepare for additional in-node class (authored by bytesofman).
[chronik-client] Organize code to prepare for additional in-node class
Tue, Nov 21, 15:24

Mon, Nov 20

bytesofman requested review of D14824: [Cashtab] app.js format improvements.
Mon, Nov 20, 20:12
bytesofman requested review of D14823: [chronik-client] Organize code to prepare for additional in-node class.
Mon, Nov 20, 17:30
bytesofman closed D14814: [chronik-client] Generate proto file for in-node chronik.
Mon, Nov 20, 17:24
bytesofman committed rABCaa10724d2e84: [chronik-client] Generate proto file for in-node chronik (authored by bytesofman).
[chronik-client] Generate proto file for in-node chronik
Mon, Nov 20, 17:24

Sun, Nov 19

bytesofman closed D14816: [ecash-herald] Add amount for staking rewards.
Sun, Nov 19, 21:06
bytesofman committed rABC5a1adc6dfef8: [ecash-herald] Add amount for staking rewards (authored by bytesofman).
[ecash-herald] Add amount for staking rewards
Sun, Nov 19, 21:06
bytesofman closed D14818: [Cashtab] Do not try to parse outputscript of coinbase txs.
Sun, Nov 19, 21:05
bytesofman committed rABCde6232f1fc45: [Cashtab] Do not try to parse outputscript of coinbase txs (authored by bytesofman).
[Cashtab] Do not try to parse outputscript of coinbase txs
Sun, Nov 19, 21:05

Sat, Nov 18

bytesofman added a comment to D14818: [Cashtab] Do not try to parse outputscript of coinbase txs.

the problem is that the function does too many things. You should split it into logical pieces so you can bail early for coinbase txs without adding another nesting level that makes the code harder to follow.

Sat, Nov 18, 17:52
bytesofman updated the diff for D14818: [Cashtab] Do not try to parse outputscript of coinbase txs.

add test for parsing coinbase tx

Sat, Nov 18, 17:51
bytesofman added inline comments to D14818: [Cashtab] Do not try to parse outputscript of coinbase txs.
Sat, Nov 18, 14:59
bytesofman updated the diff for D14818: [Cashtab] Do not try to parse outputscript of coinbase txs.

If you have a coinbase tx, dont iterate through inputs at all

Sat, Nov 18, 14:57
bytesofman planned changes to D14818: [Cashtab] Do not try to parse outputscript of coinbase txs.

this fixes the bug but is not the right implementation

Sat, Nov 18, 14:53
bytesofman updated the diff for D14818: [Cashtab] Do not try to parse outputscript of coinbase txs.

remove debug logging

Sat, Nov 18, 14:50
bytesofman requested review of D14818: [Cashtab] Do not try to parse outputscript of coinbase txs.
Sat, Nov 18, 14:49

Fri, Nov 17

bytesofman added a comment to D14816: [ecash-herald] Add amount for staking rewards.

will print xec amount if price is unavailable, e.g.

image.png (120×481 px, 18 KB)

Fri, Nov 17, 22:14
bytesofman requested review of D14816: [ecash-herald] Add amount for staking rewards.
Fri, Nov 17, 22:14
bytesofman accepted D14809: [electrum] replace all len(tx.inputs()) with len(tx.txinputs()).
Fri, Nov 17, 21:58
bytesofman added a comment to D14758: [chronik-client] [DRAFT] Support in-node chronik.

Rename NNG types that will conflict with ChronikClientNode (even though these types are in separate files, bc they are used by ChronikClient and ChronikClientNode, and both objects are exported, ts will not allow them to have the same name)

Is there no kind of namespace ? Or maybe make it a member of the ChronikClient

Fri, Nov 17, 20:33
bytesofman updated the diff for D14814: [chronik-client] Generate proto file for in-node chronik.

name the generated file specific to in-node chronik

Fri, Nov 17, 20:29
bytesofman requested review of D14814: [chronik-client] Generate proto file for in-node chronik.
Fri, Nov 17, 20:24
bytesofman added a comment to D14758: [chronik-client] [DRAFT] Support in-node chronik.

This could be split into several diffs, for example file/var renames could be their own diffs. Same for the @generated mark on the proto ts file. This makes it easier to spot the where the changes are.

Fri, Nov 17, 20:04
bytesofman added a comment to D14758: [chronik-client] [DRAFT] Support in-node chronik.

update: draft up for review.

Fri, Nov 17, 19:28
bytesofman retitled D14758: [chronik-client] [DRAFT] Support in-node chronik from [chronik-client] Support in-node chronik to [chronik-client] [DRAFT] Support in-node chronik.
Fri, Nov 17, 19:23
bytesofman updated the diff for D14758: [chronik-client] [DRAFT] Support in-node chronik.

sharing failoverProxy, support ws iterations for in-node

Fri, Nov 17, 19:23