Page MenuHomePhabricator

bytesofman (Joey)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2020, 18:28 (201 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

bytesofman closed D16758: [Cashtab] Extension version bump.
Fri, Sep 13, 18:44
bytesofman committed rABCb596b9f74e4b: [Cashtab] Extension version bump (authored by bytesofman).
[Cashtab] Extension version bump
Fri, Sep 13, 18:44
bytesofman published D16759: [Cashtab] NFT screen easy improvements for review.
Fri, Sep 13, 18:42
bytesofman published D16758: [Cashtab] Extension version bump for review.
Fri, Sep 13, 18:23
bytesofman closed D16328: [Cashtab] Support NFT trading.
Fri, Sep 13, 16:21
bytesofman committed rABCc1722a1f56f6: [Cashtab] Support NFT trading (authored by bytesofman).
[Cashtab] Support NFT trading
Fri, Sep 13, 16:21
bytesofman closed D16752: [ecash-herald] Organize token send txs by token.
Fri, Sep 13, 14:38
bytesofman committed rABC599f99af36b5: [ecash-herald] Organize token send txs by token (authored by bytesofman).
[ecash-herald] Organize token send txs by token
Fri, Sep 13, 14:38

Thu, Sep 12

bytesofman published D16752: [ecash-herald] Organize token send txs by token for review.
Thu, Sep 12, 22:34
bytesofman closed D16746: [ecashaddrjs] Add missing copyright notice to new file.
Thu, Sep 12, 21:16
bytesofman committed rABC7263d78c0064: [ecashaddrjs] Add missing copyright notice to new file (authored by bytesofman).
[ecashaddrjs] Add missing copyright notice to new file
Thu, Sep 12, 21:16
bytesofman closed D16751: [explorer] Use timeFirstSeen instead of block timestamp for tx table time.
Thu, Sep 12, 18:34
bytesofman committed rABC64527f0afc12: [explorer] Use timeFirstSeen instead of block timestamp for tx table time (authored by bytesofman).
[explorer] Use timeFirstSeen instead of block timestamp for tx table time
Thu, Sep 12, 18:34
bytesofman published D16751: [explorer] Use timeFirstSeen instead of block timestamp for tx table time for review.
Thu, Sep 12, 03:14

Wed, Sep 11

bytesofman added inline comments to D16730: Return the RTT parameters in the block template.
Wed, Sep 11, 23:33
bytesofman added inline comments to D16729: Reject blocks that violate the real time target policy.
Wed, Sep 11, 23:31
bytesofman added inline comments to D16728: Compute the real-time hash target for the next block.
Wed, Sep 11, 23:26
bytesofman updated the diff for D16328: [Cashtab] Support NFT trading.

add test and improve logic for showing chronik query error when we cannot get the info we need to load the page

Wed, Sep 11, 21:34
bytesofman updated the diff for D16746: [ecashaddrjs] Add missing copyright notice to new file.

use boilerplate

Wed, Sep 11, 21:16
bytesofman published D16746: [ecashaddrjs] Add missing copyright notice to new file for review.
Wed, Sep 11, 13:46
bytesofman added inline comments to D16744: [ecashaddrjs] Convert to typescript.
Wed, Sep 11, 13:45
bytesofman closed D16744: [ecashaddrjs] Convert to typescript.
Wed, Sep 11, 13:37
bytesofman committed rABC91adf60e93c8: [ecashaddrjs] Convert to typescript (authored by bytesofman).
[ecashaddrjs] Convert to typescript
Wed, Sep 11, 13:37
teamcity awarded D16744: [ecashaddrjs] Convert to typescript a Piece of Eight token.
Wed, Sep 11, 13:03
bytesofman added a comment to D16744: [ecashaddrjs] Convert to typescript.

@bot ecash-herald-tests

Wed, Sep 11, 13:03
bytesofman requested review of D16744: [ecashaddrjs] Convert to typescript.

not sure if I called the bot correctly for these tests but the main thing we want to confirm is that none of the libs break

Wed, Sep 11, 06:03
bytesofman closed D16742: [token-server] Tighten rate limits.
Wed, Sep 11, 05:49
bytesofman committed rABC0fa945d62703: [token-server] Tighten rate limits (authored by bytesofman).
[token-server] Tighten rate limits
Wed, Sep 11, 05:49
bytesofman published D16744: [ecashaddrjs] Convert to typescript for review.
Wed, Sep 11, 03:24
teamcity awarded D16744: [ecashaddrjs] Convert to typescript a Haypence token.
Wed, Sep 11, 03:14

Tue, Sep 10

bytesofman added a comment to D16328: [Cashtab] Support NFT trading.

Big diff but I think this is enough to get into prod.

Tue, Sep 10, 21:26
bytesofman added inline comments to D16742: [token-server] Tighten rate limits.
Tue, Sep 10, 21:19
bytesofman published D16742: [token-server] Tighten rate limits for review.
Tue, Sep 10, 21:17
bytesofman updated the diff for D16328: [Cashtab] Support NFT trading.

remove unneeded lokad mocks from app test, improve comments, remove debug comments

Tue, Sep 10, 21:01
bytesofman updated the diff for D16328: [Cashtab] Support NFT trading.

more robust handling of cached token info, do not display BrowseCollection modals if offers have not loaded yet

Tue, Sep 10, 20:44
bytesofman closed D16737: [mock-chronik-client] Add support for ecash-agora stub mock.
Tue, Sep 10, 16:42
bytesofman committed rABC2e3793a9568e: [mock-chronik-client] Add support for ecash-agora stub mock (authored by bytesofman).
[mock-chronik-client] Add support for ecash-agora stub mock
Tue, Sep 10, 16:42
bytesofman closed D16738: [Cashtab] Remove unimplemented agora methods.
Tue, Sep 10, 16:41
bytesofman committed rABCc017c46f6152: [Cashtab] Remove unimplemented agora methods (authored by bytesofman).
[Cashtab] Remove unimplemented agora methods
Tue, Sep 10, 16:41
bytesofman closed D16739: [Cashtab] Remove unimplemented lokad id tx history lookup method.
Tue, Sep 10, 16:35
bytesofman committed rABC578c70efd1c4: [Cashtab] Remove unimplemented lokad id tx history lookup method (authored by bytesofman).
[Cashtab] Remove unimplemented lokad id tx history lookup method
Tue, Sep 10, 16:35
bytesofman added inline comments to D16735: [ecash-agora] Partial Agora offers: Add approximation logic.
Tue, Sep 10, 16:30
bytesofman planned changes to D16328: [Cashtab] Support NFT trading.

Still need to clean up debug logs, run some tests. This updated version has been deployed to the test site.

Tue, Sep 10, 16:24
bytesofman updated the summary of D16328: [Cashtab] Support NFT trading.
Tue, Sep 10, 00:28
bytesofman published D16739: [Cashtab] Remove unimplemented lokad id tx history lookup method for review.
Tue, Sep 10, 00:18
bytesofman published D16738: [Cashtab] Remove unimplemented agora methods for review.
Tue, Sep 10, 00:18
bytesofman published D16737: [mock-chronik-client] Add support for ecash-agora stub mock for review.
Tue, Sep 10, 00:17

Mon, Sep 9

bytesofman updated the diff for D16328: [Cashtab] Support NFT trading.

implementing upgraded ecash-agora

Mon, Sep 9, 23:35

Fri, Sep 6

bytesofman closed D16732: [token-server] Make sure we are rate limiting by client IP address.
Fri, Sep 6, 16:46
bytesofman committed rABC2ada4e35622f: [token-server] Make sure we are rate limiting by client IP address (authored by bytesofman).
[token-server] Make sure we are rate limiting by client IP address
Fri, Sep 6, 16:46
bytesofman published D16732: [token-server] Make sure we are rate limiting by client IP address for review.
Fri, Sep 6, 16:13

Thu, Sep 5

bytesofman accepted D16722: [chronik-doc] Check doc deployment on a temporary URL.
Thu, Sep 5, 15:06
bytesofman closed D16720: [chronik.e.cash] warn on broken links during docusaurus build.
Thu, Sep 5, 13:42
bytesofman committed rABC014145cf2624: [chronik.e.cash] warn on broken links during docusaurus build (authored by bytesofman).
[chronik.e.cash] warn on broken links during docusaurus build
Thu, Sep 5, 13:42
bytesofman published D16720: [chronik.e.cash] warn on broken links during docusaurus build for review.
Thu, Sep 5, 13:38
bytesofman closed D16717: [chronik.e.cash] Fix monorepo dir structure around docs.
Thu, Sep 5, 13:15
bytesofman committed rABCd9824024df91: [chronik.e.cash] Fix monorepo dir structure around docs (authored by bytesofman).
[chronik.e.cash] Fix monorepo dir structure around docs
Thu, Sep 5, 13:15
bytesofman updated the diff for D16717: [chronik.e.cash] Fix monorepo dir structure around docs.

add .dockerignore for chronik.e.cash

Thu, Sep 5, 13:13
bytesofman published D16717: [chronik.e.cash] Fix monorepo dir structure around docs for review.
Thu, Sep 5, 13:04

Wed, Sep 4

bytesofman closed D16710: [chronik-client] Version bump to publish non-nng chronik-client.
Wed, Sep 4, 23:23
bytesofman committed rABCf952efaa86a7: [chronik-client] Version bump to publish non-nng chronik-client (authored by bytesofman).
[chronik-client] Version bump to publish non-nng chronik-client
Wed, Sep 4, 23:23
bytesofman closed D16714: [token-server] Extend rate limiting to token rewards.
Wed, Sep 4, 20:41
bytesofman committed rABC62167df95862: [token-server] Extend rate limiting to token rewards (authored by bytesofman).
[token-server] Extend rate limiting to token rewards
Wed, Sep 4, 20:41
bytesofman published D16714: [token-server] Extend rate limiting to token rewards for review.
Wed, Sep 4, 20:19
bytesofman updated the summary of D16710: [chronik-client] Version bump to publish non-nng chronik-client.
Wed, Sep 4, 18:29
bytesofman updated the diff for D16710: [chronik-client] Version bump to publish non-nng chronik-client.

keep to 1.0.0 version bump

Wed, Sep 4, 18:29
bytesofman updated the summary of D16710: [chronik-client] Version bump to publish non-nng chronik-client.
Wed, Sep 4, 18:22
bytesofman updated the diff for D16710: [chronik-client] Version bump to publish non-nng chronik-client.

make the change more breaking and the version bump less breaking

Wed, Sep 4, 18:20
bytesofman added a comment to D16710: [chronik-client] Version bump to publish non-nng chronik-client.

Is it semver compatible to remove the alias without a major version bump ? If yes then it's fine and we can remove it with a minor version change. Otherwise we should remove the alias when publishing this major version.

Wed, Sep 4, 18:09
bytesofman added a comment to D16710: [chronik-client] Version bump to publish non-nng chronik-client.

Tail of the build log:

    os.makedirs(tmpdir)
  File "/usr/lib/python3.9/os.py", line 225, in makedirs
    mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/work/abc-ci-builds/ecash-lib-integration-tests/test/tmp/test_runner_₿₵_🏃_20240904_175710'
Test runner completed with code 1
----------------------------|---------|----------|---------|---------|------------------------------
File                        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s            
----------------------------|---------|----------|---------|---------|------------------------------
All files                   |   62.22 |    52.47 |   62.44 |    62.2 |                              
 ecash-lib                  |       0 |        0 |       0 |       0 |                              
  eslint.config.js          |       0 |        0 |       0 |       0 |                              
 ecash-lib/src              |    71.5 |    54.71 |    72.5 |    71.1 |                              
  consts.ts                 |       0 |      100 |     100 |       0 | 6-8                          
  ecc.ts                    |   57.14 |    83.33 |      40 |   57.14 | 23-31                        
  hash.ts                   |   88.88 |    83.33 |      80 |   88.88 | 14                           
  index.ts                  |       0 |        0 |       0 |       0 |                              
  indexBrowser.ts           |       0 |        0 |       0 |       0 |                              
  indexNodeJs.ts            |       0 |        0 |       0 |       0 |                              
  initBrowser.ts            |       0 |      100 |       0 |       0 | 11-13                        
  initNodeJs.ts             |     100 |      100 |     100 |     100 |                              
  op.ts                     |      40 |    44.44 |   66.66 |      40 | ...4,107,109,117-122,133-161 
  opcode.ts                 |     100 |    83.33 |     100 |     100 | 1                            
  script.ts                 |   52.63 |    38.09 |      60 |    50.9 | ...4-135,146,156,166,188-199 
  sigHashType.ts            |   77.77 |       44 |   85.71 |   77.77 | 26-38                        
  tx.ts                     |   93.47 |    79.16 |    90.9 |   93.18 | 123-125                      
  txBuilder.ts              |   56.17 |    48.14 |   69.23 |   54.65 | ...3-107,139-183,206,236-240 
  unsignedTx.ts             |    73.8 |    57.14 |   78.57 |   74.07 | ...3,151,159,184,192,198-201 
 ecash-lib/src/ffi          |   28.26 |    15.94 |   16.98 |   28.98 |                              
  ecash_lib_wasm_browser.js |       0 |        0 |       0 |       0 | 3-336                        
  ecash_lib_wasm_nodejs.js  |    61.9 |       55 |   39.13 |   62.75 | ...1,197-215,237,250-251,255 
 ecash-lib/src/io           |   59.55 |    60.29 |   70.58 |   58.77 |                              
  bytes.ts                  |     7.4 |    71.42 |    12.5 |     7.4 | 13-64                        
  hex.ts                    |   82.05 |     62.5 |      80 |   82.35 | 41-45,50,58                  
  int.ts                    |       0 |        0 |       0 |       0 |                              
  str.ts                    |   85.71 |    83.33 |   66.66 |   85.71 | 15                           
  varsize.ts                |      32 |    36.36 |   66.66 |      32 | 14-24,40-47                  
  writer.ts                 |       0 |        0 |       0 |       0 |                              
  writerbytes.ts            |   83.33 |    68.42 |     100 |   83.33 | 33,43,53,63,79               
  writerlength.ts           |     100 |    83.33 |     100 |     100 | 1                            
 ecash-lib/src/test         |   87.67 |    54.34 |    87.5 |   88.23 |                              
  testRunner.ts             |   87.67 |    54.34 |    87.5 |   88.23 | 71-73,86-87,110,121,164      
 ecash-lib/src/token        |   87.15 |    72.85 |   93.33 |   87.07 |                              
  alp.ts                    |   82.92 |    89.47 |   83.33 |   82.92 | 110-123,142                  
  common.ts                 |     100 |    83.33 |     100 |     100 | 1                            
  empp.ts                   |    92.3 |       75 |     100 |   91.66 | 12                           
  slp.ts                    |   89.74 |    62.16 |     100 |   89.74 | ...9,161,167,175,178,197,202 
----------------------------|---------|----------|---------|---------|------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='776']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='1247']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='244']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='465']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='133']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='213']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='757']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1217']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-lib-integration-tests-junit.xml': No such file or directory
Build ecash-lib-integration-tests failed with exit code 1
Wed, Sep 4, 17:59
bytesofman updated the diff for D16710: [chronik-client] Version bump to publish non-nng chronik-client.

improve changelog copy

Wed, Sep 4, 17:49
bytesofman closed D16709: [token-server] Bump XEC reward.
Wed, Sep 4, 01:22
bytesofman committed rABCbd474099fddc: [token-server] Bump XEC reward (authored by bytesofman).
[token-server] Bump XEC reward
Wed, Sep 4, 01:22

Tue, Sep 3

bytesofman published D16710: [chronik-client] Version bump to publish non-nng chronik-client for review.
Tue, Sep 3, 23:57
bytesofman published D16709: [token-server] Bump XEC reward for review.
Tue, Sep 3, 22:57
bytesofman closed D16703: [token-server] Improve logging.
Tue, Sep 3, 13:13
bytesofman committed rABC932af23d6614: [token-server] Improve logging (authored by bytesofman).
[token-server] Improve logging
Tue, Sep 3, 13:13

Mon, Sep 2

bytesofman published D16703: [token-server] Improve logging for review.
Mon, Sep 2, 23:01
bytesofman accepted D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
Mon, Sep 2, 21:11

Sat, Aug 31

bytesofman closed D16698: [token-server] Bump rate limit window to one hour.
Sat, Aug 31, 01:24
bytesofman committed rABCa7dca5af3af9: [token-server] Bump rate limit window to one hour (authored by bytesofman).
[token-server] Bump rate limit window to one hour
Sat, Aug 31, 01:24
bytesofman published D16698: [token-server] Bump rate limit window to one hour for review.
Sat, Aug 31, 01:22

Fri, Aug 30

bytesofman closed D16692: [Cashtab] Update dependencies.
Fri, Aug 30, 14:52
bytesofman committed rABCe07f28e11bc7: [Cashtab] Update dependencies (authored by bytesofman).
[Cashtab] Update dependencies
Fri, Aug 30, 14:52
bytesofman closed D16697: [token-server] Implement rate limiting by IP.
Fri, Aug 30, 14:49
bytesofman committed rABC4a17fbed5dfd: [token-server] Implement rate limiting by IP (authored by bytesofman).
[token-server] Implement rate limiting by IP
Fri, Aug 30, 14:49
bytesofman published D16697: [token-server] Implement rate limiting by IP for review.
Fri, Aug 30, 14:45

Thu, Aug 29

bytesofman accepted D16693: [e.cash] Swap color cashtab logos.

would be nice if both of these images took up 100% of the tile width -- but that is already not happening with the current images. This is an improvement.

Thu, Aug 29, 23:35
bytesofman added a comment to D16693: [e.cash] Swap color cashtab logos.

@bot preview-e.cash

Thu, Aug 29, 23:31
bytesofman accepted D16684: [electrum] also use libsecp256k1 for point addition.
Thu, Aug 29, 16:04
bytesofman accepted D16686: [electrum] deduplicate the ECPrivkey.sign code.
Thu, Aug 29, 16:02
bytesofman accepted D16685: [electrum] grind ecdsa low R signature when using libsecp256k1.
Thu, Aug 29, 16:00
bytesofman requested changes to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

confirmed my different signatures were from not having built libsecp

Thu, Aug 29, 15:31
bytesofman accepted D16681: [electrum] properly handle point at infinity and point not on curve.

still not able to arc patch this one, which could mean we see issues when it is landed. may want to wait until this is next off the rank.

Thu, Aug 29, 14:32
bytesofman added a comment to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

I can't get the test plan to pass but I'm also not sure it's really an issue.

Thu, Aug 29, 14:26
bytesofman closed D16344: [alias-server] Migrate to in-node chronik-client.
Thu, Aug 29, 14:16
bytesofman committed rABC41d216ffd9fd: [alias-server] Migrate to in-node chronik-client (authored by bytesofman).
[alias-server] Migrate to in-node chronik-client
Thu, Aug 29, 14:16
bytesofman added inline comments to D16344: [alias-server] Migrate to in-node chronik-client.
Thu, Aug 29, 14:15
bytesofman published D16692: [Cashtab] Update dependencies for review.
Thu, Aug 29, 14:13

Wed, Aug 28

bytesofman published D16344: [alias-server] Migrate to in-node chronik-client for review.
Wed, Aug 28, 21:32