add example to spec

not sure i totally understand the breakdown here

able to build locally, safe areas look ok

@bot preview-e.cash

rebase

TIL, same should be done in Cashtab

Tests look good and I can run them locally. We do have a CI failure tho which should be checked out; also seems like it doesn't send the msg here, just goes red?

big win to lose a critical crypto third party dep like this

remove arbitrary 25 retries, consolidateUtxo is already a complete method

That was my initial design, but it happens that having XEC being treated just like a token let me reuse a lot of code that would otherwise either be duplicated or "or typed" which makes it much harder to reason about. If it's about naming I can go with bits instead of atoms if you think it's less confusing.

Marlin is not trying to be fully featured, quite the opposite. In this context I would favor simplicity over extensibility, even if this require some refactors later on.

A couple of general issues

In D19604#449742, @Fabien wrote:

A couple nits, non blocking:

• The "hide balance" feature doesn't apply the same for XEC (all blured) and XECX/FIRMA (only the amount is blurred but not the unit).

tabs on agora screen, preserve buttons on home

I don't understand, my point was that I find the tabs better than the "buttons", e.g. in tools the "contacts", "airdrop" etc. would better be tabs as well.

tabs in tools, support import on onboarding

use the tabs on send/receive for mobile too

improve behavior of Advanced dropdown

There is still an issue, the op_return_raw is "sticky" i.e. it remains visible when unfolded, unlike the message

require exactly 1 sk, mov;e shared methods to wallet base, throw if attempt to sign already signed

feedback tweaks

One of the main complaint I have with current cashtab design is on the transactions page (home): clicking on a transaction show no additional data, but new buttons to the bottom right which is unexpected imo. I like the new design of this page but could the buttons be visible by default ? Or make the click actually useful ?

@bot preview-e.cash

superseded by improved PSBT implementations in ecash-lib; will put up a schnorr-only multisig diff for ecash-wallet using PSBT

adjust ECSDA estimate 72 to 73, simplify multisig implementation, improve tests

superseded

improve docs, version bump

In D19712#448041, @PiRK wrote:

It would be good to have a common test to check we decode the same thing. I have a test for the final tx from psbt_wallet_tests.cpp in electrumabc/tests/test_psbt.py
But can be done later.

also match electrum PSBT tests