Page MenuHomePhabricator

Mengerian (Antony Zegers)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 19:20 (137 w, 2 d)

Recent Activity

Mon, Jan 20

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

@tobias_ruck Could you change the name to OP_REVERSEBYTES in the Diff title?

Mon, Jan 20, 18:59

Sat, Jan 11

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:
In a previous proposal, this opcode has been named OP_REVERSE. After that, it has been renamed to OP_BSWAP, as that is a more technically accurate term, which is commonly used for reversing the byteorder of integers [14] [15]. However, after some more consideration, it has been renamed to OP_ENDIAN_REVERSE following Boost‘s nomenclature [16]. This is because OP_BSWAP is lexically very similar to the already existing OP_SWAP and would make Script harder to read. Also, while the technical term for the instruction is indeed bswap, it isn‘t well known for developers of higher level languages and could thus spark confusion that would be avoided by using the name OP_ENDIAN_REVERSE, which is more self-descriptive.
Also added tests for unexecuted branches, clarified tests for not yet activated case.
Merged D4859 into this diff.

Sat, Jan 11, 21:39

Wed, Jan 8

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

I‘ve left the SCRIPT_ENABLE_OP_BSWAP flag at bit 22, this should be coordinated with @markblundeberg

Wed, Jan 8, 23:29
Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

@tobias_ruck something is mangled with this Diff. Did you amend the previous Git commit? (You should amend) Or just add another commit?

Wed, Jan 8, 23:22

Tue, Jan 7

Mengerian committed rABC0a1ba77ef217: Add Accelerate book to Bitcoin ABC reading list (authored by Mengerian).
Add Accelerate book to Bitcoin ABC reading list
Tue, Jan 7, 21:10
Mengerian closed D4847: Add Accelerate book to Bitcoin ABC reading list.
Tue, Jan 7, 21:10
Mengerian added a comment to D4844: [CMAKE] Allow building secp256k1 as a standalone project.

@Fabien Should Cmake build instructions be added to the secp256k1 readme at /src/secp256k1/README.md ?
It currently has the autotools build instructions

Tue, Jan 7, 20:30
Mengerian created D4847: Add Accelerate book to Bitcoin ABC reading list.
Tue, Jan 7, 18:03
Mengerian added a comment to D4833: Add pippenger_wnaf for multi-multiplication.

Since it's coming from a different repo than most ABC backports, the Diff summary should mention what repo these backports are coming from and/or link to them

Tue, Jan 7, 04:17

Sun, Jan 5

Mengerian committed rABC1f824752ca59: Update secp256k1 README (authored by Mengerian).
Update secp256k1 README
Sun, Jan 5, 23:27
Mengerian closed D4819: Update secp256k1 README.
Sun, Jan 5, 23:27
Mengerian added inline comments to D4826: Add a facility to extract libsecp256k1 from the repository.
Sun, Jan 5, 05:34

Sat, Jan 4

Mengerian updated the diff for D4819: Update secp256k1 README.

Fix typo

Sat, Jan 4, 16:43
Mengerian updated the diff for D4819: Update secp256k1 README.

Add link directing contributors to Bitcoin ABC Phabricator repo
Re-add Travis link, now that Travis is enabled for the repo

Sat, Jan 4, 16:42

Fri, Jan 3

Mengerian added inline comments to D4819: Update secp256k1 README.
Fri, Jan 3, 06:01
Mengerian added inline comments to D4819: Update secp256k1 README.
Fri, Jan 3, 04:41
Mengerian updated the diff for D4819: Update secp256k1 README.

Add a bit more explanation of how the repository is maintained, so that people can understand what's going on.
Re-add "Use at your own risk" disclaimer as recommended by @Fabien
Add link and mention that this is the Bitcoin Cash variant of the Schnorr algorithm.

Fri, Jan 3, 04:41

Thu, Jan 2

Mengerian added a comment to D4819: Update secp256k1 README.

@markblundeberg It may also be good to add some Schnorr information to the "Implementation Details" portion, and maybe a link to the BCH Schnorr spec on bitcoincash.org. Please let me know if you have any suggestions.

Thu, Jan 2, 21:15
Mengerian created D4819: Update secp256k1 README.
Thu, Jan 2, 21:07

Dec 12 2019

Mengerian added a comment to D4673: add SCHNORR_MULTISIG to mandatory flags.

Also, what is NULLDUMMY? No such flag exists. ;-)

Dec 12 2019, 05:40

Dec 11 2019

Mengerian added a comment to D4673: add SCHNORR_MULTISIG to mandatory flags.

@markblundeberg you say " It is currently the only additive flag so it's the only one with weird behaviour like this."

Dec 11 2019, 19:33

Dec 10 2019

Mengerian added a revision to T653: Clean up past upgrades: D4679: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.
Dec 10 2019, 10:09
Mengerian added a task to D4679: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags: T653: Clean up past upgrades.
Dec 10 2019, 10:09
Mengerian added a revision to T653: Clean up past upgrades: D4673: add SCHNORR_MULTISIG to mandatory flags.
Dec 10 2019, 03:46
Mengerian added a task to D4673: add SCHNORR_MULTISIG to mandatory flags: T653: Clean up past upgrades.
Dec 10 2019, 03:46

Dec 5 2019

Mengerian added a reviewer for D4642: Cleanup graviton activation: markblundeberg.
Dec 5 2019, 19:05
Mengerian added a revision to T653: Clean up past upgrades: D4642: Cleanup graviton activation.
Dec 5 2019, 19:03
Mengerian added a task to D4642: Cleanup graviton activation: T653: Clean up past upgrades.
Dec 5 2019, 19:03
Mengerian accepted D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.

Good catch!

Dec 5 2019, 19:01

Nov 29 2019

Mengerian added a revision to T653: Clean up past upgrades: D4577: remove NULLDUMMY.
Nov 29 2019, 18:12
Mengerian added a task to D4577: remove NULLDUMMY: T653: Clean up past upgrades.
Nov 29 2019, 18:12
Mengerian added a comment to D4577: remove NULLDUMMY.

Great to see this!

Nov 29 2019, 05:25

Nov 28 2019

Mengerian added a subtask for T653: Clean up past upgrades: T703: clean up schnorr activations.
Nov 28 2019, 22:21
Mengerian added a parent task for T703: clean up schnorr activations: T653: Clean up past upgrades.
Nov 28 2019, 22:21

Nov 26 2019

Mengerian accepted D4551: Fix wrong version in clang-format error message and update the doc.

Looks good to me!

Nov 26 2019, 19:11

Nov 25 2019

Mengerian added a comment to D4539: Move to clang format 8.

Would be good to also update CONTRIBUTING.md with this version.

Nov 25 2019, 22:15
Mengerian added a revision to T653: Clean up past upgrades: D4453: [CI] Remove functional tests with graviton activation.
Nov 25 2019, 20:57
Mengerian added a task to D4453: [CI] Remove functional tests with graviton activation: T653: Clean up past upgrades.
Nov 25 2019, 20:57

Oct 30 2019

Mengerian committed rABCd785628561a0: Update user agent filter in makeseeds.py (authored by Mengerian).
Update user agent filter in makeseeds.py
Oct 30 2019, 21:08
Mengerian closed D4319: Update user agent filter in makeseeds.py.
Oct 30 2019, 21:08
Mengerian created D4319: Update user agent filter in makeseeds.py.
Oct 30 2019, 03:06
Mengerian committed rABC8d87d3d4d28b: Add testnet-seed.bchd.cash to seeder lists (authored by Mengerian).
Add testnet-seed.bchd.cash to seeder lists
Oct 30 2019, 02:17
Mengerian closed D4308: Add testnet-seed.bchd.cash to seeder lists.
Oct 30 2019, 02:17

Oct 29 2019

Mengerian created D4308: Add testnet-seed.bchd.cash to seeder lists.
Oct 29 2019, 21:10

Sep 19 2019

Mengerian committed rSTAGING978fae27bb14: Add seed.bchd.cash to seeder lists (authored by Mengerian).
Add seed.bchd.cash to seeder lists
Sep 19 2019, 02:21
Mengerian committed rSTAGING65a6198254ac: Bump automatic replay protection to May 2020 upgrade (authored by Mengerian).
Bump automatic replay protection to May 2020 upgrade
Sep 19 2019, 01:50
Mengerian committed rSTAGINGaf9fd425afd7: Add upgrade features to release notes (authored by Mengerian).
Add upgrade features to release notes
Sep 19 2019, 01:50
Mengerian committed rSTAGING6bdb4057be12: Update doc/release-process.md (authored by Mengerian).
Update doc/release-process.md
Sep 19 2019, 01:07
Mengerian committed rSTAGING8df68739c056: Prettify README title (authored by Mengerian).
Prettify README title
Sep 19 2019, 00:52
Mengerian committed rSTAGING3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian).
Update timing.json Segwit Recovery functional test name
Sep 19 2019, 00:09
Mengerian committed rSTAGINGeeed14a7916c: Clean up Segwit Recovery feature (authored by Mengerian).
Clean up Segwit Recovery feature
Sep 19 2019, 00:04

Sep 18 2019

Mengerian committed rSTAGING282991621095: Add post-upgrade testnet checkpoint (authored by Mengerian).
Add post-upgrade testnet checkpoint
Sep 18 2019, 23:54
Mengerian committed rSTAGINGa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test
Sep 18 2019, 23:54
Mengerian committed rSTAGING11febd55e5a8: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests
Sep 18 2019, 23:53
Mengerian committed rSTAGING47a8898b14e7: Add comments indicating "Schnorr" in Schnorr-related script tests. (authored by Mengerian).
Add comments indicating "Schnorr" in Schnorr-related script tests.
Sep 18 2019, 23:49
Mengerian committed rSTAGINGed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS. (authored by Mengerian).
Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
Sep 18 2019, 23:49
Mengerian committed rSTAGINGf5fac93cec01: Interpret scripts with CHECKDATASIG opcode always valid. (authored by Mengerian).
Interpret scripts with CHECKDATASIG opcode always valid.
Sep 18 2019, 23:44
Mengerian committed rSTAGINGb2d3f35dac10: Add CHECKDATASIG to standard flags. (authored by Mengerian).
Add CHECKDATASIG to standard flags.
Sep 18 2019, 23:42
Mengerian committed rSTAGINGe048372368b8: Make tests independent of whether CHECKDATASIG is included in mandatory or… (authored by Mengerian).
Make tests independent of whether CHECKDATASIG is included in mandatory or…
Sep 18 2019, 23:40
Mengerian committed rSTAGING7fe181835646: Make release-process.md IBD instruction more precise (authored by Mengerian).
Make release-process.md IBD instruction more precise
Sep 18 2019, 23:35
Mengerian committed rSTAGINGcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG (authored by Mengerian).
Clarify comment for SCRIPT_ENABLE_CHECKDATASIG
Sep 18 2019, 23:35
Mengerian committed rSTAGING1b2531c1bd90: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS (authored by Mengerian).
Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS
Sep 18 2019, 23:35
Mengerian committed rSTAGINGf4025afda6a9: Remove obsolete comment from MANDATORY_SCRIPT_VERIFICATION_FLAGS (authored by Mengerian).
Remove obsolete comment from MANDATORY_SCRIPT_VERIFICATION_FLAGS
Sep 18 2019, 23:14
Mengerian committed rSTAGINGb634084b3e11: Add function 'IsGravitonEnabled' (authored by Mengerian).
Add function 'IsGravitonEnabled'
Sep 18 2019, 23:09
Mengerian committed rSTAGINGfd941e691f43: Remove communication style article from CONTRIBUTING.md (authored by Mengerian).
Remove communication style article from CONTRIBUTING.md
Sep 18 2019, 22:54
Mengerian committed rSTAGING0e5093e64e55: Add dev articles to CONTRIBUTING.md (authored by Mengerian).
Add dev articles to CONTRIBUTING.md
Sep 18 2019, 22:54
Mengerian committed rSTAGING294bdcf3b209: Update chain parameters for 0.18.8 (authored by Mengerian).
Update chain parameters for 0.18.8
Sep 18 2019, 22:18
Mengerian committed rSTAGING200b76b815af: Fix formatting in release-process.md (authored by Mengerian).
Fix formatting in release-process.md
Sep 18 2019, 22:18
Mengerian committed rSTAGINGc27207fed9c7: Refactor signature encoding checks (authored by Mengerian).
Refactor signature encoding checks
Sep 18 2019, 22:13

Sep 14 2019

Mengerian committed rABC978fae27bb14: Add seed.bchd.cash to seeder lists (authored by Mengerian).
Add seed.bchd.cash to seeder lists
Sep 14 2019, 01:52
Mengerian closed D4073: Add seed.bchd.cash to seeder lists.
Sep 14 2019, 01:52

Sep 13 2019

Mengerian created D4073: Add seed.bchd.cash to seeder lists.
Sep 13 2019, 18:31
Mengerian accepted D4059: Update the agent pattern filter in the makeseeds.py script.

Looks good. Based on the crawler at cash.coin.dance/nodes there seem to be enough 0.20.x nodes out there to make this change now.

Sep 13 2019, 02:43

Aug 30 2019

Mengerian added a revision to T653: Clean up past upgrades: D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.
Aug 30 2019, 15:30
Mengerian added a task to D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag: T653: Clean up past upgrades.
Aug 30 2019, 15:30

Aug 29 2019

Mengerian accepted D3973: Update manpages for 0.20.1 release.
Aug 29 2019, 18:26
Mengerian requested changes to D3973: Update manpages for 0.20.1 release.

Rebase on updated D3972

Aug 29 2019, 18:17
Mengerian accepted D3972: Update chainparams.

checked on my local node, looks good.

Aug 29 2019, 17:29
Mengerian accepted D3970: Add some more release notes for 0.20.1.

Looks good to me.

Aug 29 2019, 16:47
Mengerian added inline comments to D3972: Update chainparams.
Aug 29 2019, 16:44
Mengerian requested changes to D3972: Update chainparams.

Chainwork is above the value on the Upgrade testnet, which will make it more complicated for people to run this release on the upgrade testnet.

Aug 29 2019, 16:42
Mengerian accepted D3971: Update seeds.

Seems good, but pretty soon we should update the version number in contrib/seeds/makeseeds.py

Aug 29 2019, 16:30

Aug 15 2019

Mengerian added a comment to D3884: Update chainparams.

FYI, Updating testnet params would be fine this time, as we will be re-starting the Upgrade testnet with this release.

Aug 15 2019, 20:21

Aug 14 2019

Mengerian committed rABC65a6198254ac: Bump automatic replay protection to May 2020 upgrade (authored by Mengerian).
Bump automatic replay protection to May 2020 upgrade
Aug 14 2019, 22:55
Mengerian closed D3868: Bump automatic replay protection to May 2020 upgrade.
Aug 14 2019, 22:55
Mengerian updated the diff for D3868: Bump automatic replay protection to May 2020 upgrade.

Rebase

Aug 14 2019, 18:42
Mengerian committed rABCaf9fd425afd7: Add upgrade features to release notes (authored by Mengerian).
Add upgrade features to release notes
Aug 14 2019, 18:38
Mengerian closed D3869: Add upgrade features to release notes.
Aug 14 2019, 18:38
Mengerian created D3869: Add upgrade features to release notes.
Aug 14 2019, 04:35
Mengerian created D3868: Bump automatic replay protection to May 2020 upgrade.
Aug 14 2019, 03:15

Aug 12 2019

Mengerian accepted D3853: Bump version to 0.20.0.

Looks good.

Aug 12 2019, 17:20

Aug 9 2019

Mengerian accepted D3838: Bump version to 0.20.0.

Looks fine to me.

Aug 9 2019, 20:09
Mengerian requested changes to D3836: Bumped version number to 0.19.13.

Next version should be 0.20.0 no?

Aug 9 2019, 16:33

Aug 8 2019

Mengerian accepted D3830: Update chainparams.

The chainwork should be as high as the highest seen PoW and does not need to match the assume valid block. However, it should always be greater than the assume valid block, which is obvious. See D3732

Aug 8 2019, 20:41
Mengerian requested changes to D3830: Update chainparams.

Seems strange that chainwork does not correspond to the block hashes used for assumevalid.

Aug 8 2019, 19:31

Aug 5 2019

Mengerian accepted D3794: Add a message to static_assert.

Wording now looks good to me

Aug 5 2019, 20:14

Aug 4 2019

Mengerian added a comment to D3794: Add a message to static_assert.

@Fabien @markblundeberg How about this: "Schnorr multisig checkbits implementation assumes < 32 pubkeys."

Aug 4 2019, 19:21

Aug 1 2019

Mengerian added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Aug 1 2019, 22:14

Jul 15 2019

Mengerian accepted D3675: [refactor multisig] remove redundant counters.

This makes the code more readable for me, so it seems like a good change.

Jul 15 2019, 16:42

Jul 14 2019

Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 14 2019, 19:34