Page MenuHomePhabricator

Mengerian (Antony Zegers)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 19:20 (97 w, 4 d)

Recent Activity

Fri, Apr 19

Mengerian accepted D2828: Updated chainparams for 0.19.4 release.

I compared it against my home node, parameters check out.

Fri, Apr 19, 15:32

Sun, Apr 7

Mengerian committed rABCfd941e691f43: Remove communication style article from CONTRIBUTING.md (authored by Mengerian).
Remove communication style article from CONTRIBUTING.md
Sun, Apr 7, 18:20
Mengerian closed D2781: Remove communication style article from CONTRIBUTING.md.
Sun, Apr 7, 18:20

Sat, Apr 6

Herald added a reviewer for D2781: Remove communication style article from CONTRIBUTING.md: Restricted Project.
Sat, Apr 6, 15:44
Mengerian committed rABC0e5093e64e55: Add dev articles to CONTRIBUTING.md (authored by Mengerian).
Add dev articles to CONTRIBUTING.md
Sat, Apr 6, 15:25
Mengerian closed D2780: Add dev articles to CONTRIBUTING.md.
Sat, Apr 6, 15:25
Herald added a reviewer for D2780: Add dev articles to CONTRIBUTING.md: Restricted Project.
Sat, Apr 6, 03:51

Thu, Apr 4

Mengerian accepted D2773: Update manpages for 0.19.3 release.

Looks good to me.

Thu, Apr 4, 18:34
Mengerian accepted D2772: Update chainparams for 0.19.3 release.

Values check out against my local node on main net.

Thu, Apr 4, 18:32

Tue, Mar 26

Mengerian accepted D2740: Update seeds.
Tue, Mar 26, 14:27

Mar 23 2019

Mengerian accepted D2725: Update chainparams for 0.19.2 release.

I checked the paramaters on my local node, they check out.

Mar 23 2019, 02:55

Mar 8 2019

Mengerian accepted D2670: Update manpages for 0.19.1 release.

It looks fine to me.

Mar 8 2019, 03:49

Mar 7 2019

Mengerian accepted D2669: Update chainparams for 0.19.1 release.

Good idea to make sure the testnet block is common to regular testnet, as well as the upgrade testnet.

Mar 7 2019, 21:21

Mar 6 2019

Mengerian added inline comments to D2648: doc: split FreeBSD build instructions out of build-unix.md.
Mar 6 2019, 04:22

Feb 21 2019

Mengerian accepted D2581: Add bitcoin-qt testing explicitly to the releease process.

Good idea to add this

Feb 21 2019, 18:18

Feb 17 2019

Mengerian added a comment to D2341: Enforce NULLDUMMY.

Hey @dagurval It seems this is now too late to include for "Great Wall" activation.

Feb 17 2019, 22:04

Feb 14 2019

Mengerian accepted D2554: CONTRIBUTING.md : recommend ccache.

Macro lgtm:

Feb 14 2019, 18:23
Mengerian accepted D2461: Drop support for OpenBSD.

Given that you have asked around, and no-one seems to indicate usage of Bitcoin ABC on OpenBSD, I think it's fine to drop support for it.

Feb 14 2019, 04:15

Feb 11 2019

Mengerian added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 11 2019, 05:21

Feb 10 2019

Mengerian added inline comments to D2483: Schnorr signature activation.
Feb 10 2019, 06:00

Feb 9 2019

Mengerian added a comment to D2376: Bump automatic replay protection to Nov 2019 upgrade.

Yeah, @dagurval you just need to rebase for the release notes, and then it should be ready to land

Feb 9 2019, 19:41
Mengerian added inline comments to D2483: Schnorr signature activation.
Feb 9 2019, 04:42

Feb 8 2019

Mengerian accepted D2521: Bump version to v0.19.0.

Looks fine to me.

Feb 8 2019, 17:21

Feb 7 2019

Mengerian accepted D2512: Update manpages for 0.18.8.

Looks good to me

Feb 7 2019, 23:17
Mengerian added a comment to D2483: Schnorr signature activation.

switch to generic flag-based activation that applies for all upgrades.

Feb 7 2019, 19:05
Mengerian committed rABC294bdcf3b209: Update chain parameters for 0.18.8 (authored by Mengerian).
Update chain parameters for 0.18.8
Feb 7 2019, 18:47
Mengerian closed D2510: Update chain parameters for 0.18.8.
Feb 7 2019, 18:47
Mengerian committed rABC200b76b815af: Fix formatting in release-process.md (authored by Mengerian).
Fix formatting in release-process.md
Feb 7 2019, 18:46
Mengerian closed D2509: Fix formatting in release-process.md.
Feb 7 2019, 18:46
Herald added a reviewer for D2510: Update chain parameters for 0.18.8: Restricted Project.
Feb 7 2019, 17:16
Herald added a reviewer for D2509: Fix formatting in release-process.md: Restricted Project.
Feb 7 2019, 16:37

Feb 6 2019

Mengerian requested changes to D2506: Update mandatory flags after Magnetic anomaly has activated.
Feb 6 2019, 19:40
Mengerian accepted D2505: Fix script error description.

Sure, "signature scripts" works

Feb 6 2019, 15:14
Mengerian requested changes to D2505: Fix script error description.

Good catch! I indicated a minor suggested rewording

Feb 6 2019, 05:03

Feb 3 2019

Mengerian renamed Image Macro "dog" from whydog to dog.
Feb 3 2019, 22:32
Mengerian changed the image for Image Macro "dog".
Feb 3 2019, 22:30
Mengerian added a comment to D2487: add Schnorr signing implementation to test_framework.

Typo in title:
implemenation -> implementation

Wow took me two tries to fix that...

Feb 3 2019, 22:21
Mengerian added a comment to D2487: add Schnorr signing implementation to test_framework.

Typo in title:
implemenation -> implementation

Feb 3 2019, 20:55
Mengerian accepted D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
Feb 3 2019, 20:46
Mengerian requested changes to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).

Can the title of this be changed? I find it a bit difficult to parse.

Feb 3 2019, 17:32

Feb 1 2019

Mengerian committed rABCc27207fed9c7: Refactor signature encoding checks (authored by Mengerian).
Refactor signature encoding checks
Feb 1 2019, 23:34
Mengerian closed D2477: Refactor signature encoding checks.
Feb 1 2019, 23:34
Mengerian added a comment to D2477: Refactor signature encoding checks.

OK, I put in the template to implement CheckTransactionSignatureEncoding and CheckTransactionECDSASignatureEncoding

Feb 1 2019, 18:47
Mengerian updated the diff for D2477: Refactor signature encoding checks.

Use template for CheckTransactionSignatureEncoding and
CheckTransactionECDSASignatureEncoding

Feb 1 2019, 18:41
Mengerian updated the diff for D2477: Refactor signature encoding checks.

rename IsValidECDSASignatureEncoding to IsValidDERSignatureEncoding

Feb 1 2019, 17:58
Mengerian added inline comments to D2469: Add SCRIPT_ENABLE_SCHNORR support to sigencoding.
Feb 1 2019, 16:22
Mengerian added inline comments to D2477: Refactor signature encoding checks.
Feb 1 2019, 16:19
Mengerian abandoned D2478: Refactor Signature encoding check to prepare for Schnorr inclusion..

I combined the changes, this is now superseded by D2477

Feb 1 2019, 15:19
Mengerian updated the diff for D2477: Refactor signature encoding checks.

Combine D2478 in this Diff.
it's less confusing this way

Feb 1 2019, 15:17
Mengerian planned changes to D2477: Refactor signature encoding checks.

I think I will combine D2478 with this Diff.

Feb 1 2019, 14:56
Mengerian added a comment to D2477: Refactor signature encoding checks.

@markblundeberg Have a look at D2478. Does it make more sense with that one added after?

Feb 1 2019, 14:41
Herald added a reviewer for D2478: Refactor Signature encoding check to prepare for Schnorr inclusion.: Restricted Project.
Feb 1 2019, 14:33
Mengerian added inline comments to D2469: Add SCRIPT_ENABLE_SCHNORR support to sigencoding.
Feb 1 2019, 13:33
Mengerian updated the diff for D2477: Refactor signature encoding checks.

simplify refactor

Feb 1 2019, 13:32
Herald added a reviewer for D2477: Refactor signature encoding checks: Restricted Project.
Feb 1 2019, 13:19

Jan 31 2019

Mengerian added inline comments to D2469: Add SCRIPT_ENABLE_SCHNORR support to sigencoding.
Jan 31 2019, 23:56
Mengerian added inline comments to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
Jan 31 2019, 03:25

Jan 27 2019

Mengerian accepted D2322: remove minimum total fee option.

Yup, I can confirm the it works for me also, after enabling Coin Control as Mark suggested.

Jan 27 2019, 20:54

Jan 26 2019

Mengerian added a comment to D2419: Bump version number to 0.18.8.

Shouldn't we go straight to 0.19.0?

Jan 26 2019, 17:48

Jan 24 2019

Mengerian added a comment to D2413: Update chainparams for 0.18.7.

Checked the parameters on my 0.18.6 node, looks good.

Jan 24 2019, 21:09

Jan 23 2019

Mengerian added a comment to D2322: remove minimum total fee option.

@Fabien Yeah, that's strange, I have the same issue.

Jan 23 2019, 16:27

Jan 22 2019

Mengerian accepted D2376: Bump automatic replay protection to Nov 2019 upgrade.

I double-checked the timestamps and everything looks good to me.

Jan 22 2019, 06:31

Jan 20 2019

Mengerian committed rSTAGING0f768b4acd62: Update CONTRIBUTING.md to clang-7 (authored by Mengerian).
Update CONTRIBUTING.md to clang-7
Jan 20 2019, 23:56
Mengerian committed rSTAGING5ec77822cc26: Improve documentation for seed list generation (authored by Mengerian).
Improve documentation for seed list generation
Jan 20 2019, 23:56
Mengerian committed rSTAGING072b4f327482: Fix version information in seeder documentation (authored by Mengerian).
Fix version information in seeder documentation
Jan 20 2019, 23:56
Mengerian committed rSTAGINGbba5e2b88bbd: Clarify release-process.md regarding distro package builders (authored by Mengerian).
Clarify release-process.md regarding distro package builders
Jan 20 2019, 23:56
Mengerian committed rSTAGING53a20dab4d07: Fix links in doc/release-process.md (authored by Mengerian).
Fix links in doc/release-process.md
Jan 20 2019, 23:55
Mengerian committed rSTAGING6075a015b0f1: Update gen-manpages instructions in release-process.md (authored by Mengerian).
Update gen-manpages instructions in release-process.md
Jan 20 2019, 23:55
Mengerian committed rSTAGINGec776be198ec: Update manpages for 0.18.6 (authored by Mengerian).
Update manpages for 0.18.6
Jan 20 2019, 23:55
Mengerian committed rSTAGING432b98d60252: Update Copyright year to 2019 (authored by Mengerian).
Update Copyright year to 2019
Jan 20 2019, 23:54
Mengerian committed rSTAGING5075f4b11b98: Update doc/benchmarking.md (authored by Mengerian).
Update doc/benchmarking.md
Jan 20 2019, 23:53
Mengerian committed rSTAGING70b73611affe: Add backporting suggestion to CONTRIBUTING.md (authored by Mengerian).
Add backporting suggestion to CONTRIBUTING.md
Jan 20 2019, 23:52
Mengerian committed rSTAGING255c0289cba0: Remove BTCForks Slack from CONTRIBUTING.md (authored by Mengerian).
Remove BTCForks Slack from CONTRIBUTING.md
Jan 20 2019, 23:52
Mengerian committed rSTAGING96ad4ca52218: Make links clickable in CONTRIBUTING.md (authored by Mengerian).
Make links clickable in CONTRIBUTING.md
Jan 20 2019, 23:52

Jan 19 2019

Mengerian committed rABC0f768b4acd62: Update CONTRIBUTING.md to clang-7 (authored by Mengerian).
Update CONTRIBUTING.md to clang-7
Jan 19 2019, 15:38
Mengerian closed D2343: Update CONTRIBUTING.md to clang-7.
Jan 19 2019, 15:38
Mengerian added a comment to D2343: Update CONTRIBUTING.md to clang-7.

@markblundeberg Yeah, I think that's a bit too specific, as it assumes what system the person is running, and people might have all kinds of different configurations. We don't want to get into system configuration management in these docs.

Jan 19 2019, 14:51
Mengerian updated the diff for D2343: Update CONTRIBUTING.md to clang-7.

Make link https

Jan 19 2019, 14:33
Herald added a reviewer for D2343: Update CONTRIBUTING.md to clang-7: Restricted Project.
Jan 19 2019, 04:38
Mengerian added a comment to D2342: WIP: add Schnorr opcode support.

Question, regarding this To Do item: "test op_checkmultisig still accepts 64 byte ECDSA"

Jan 19 2019, 04:11

Jan 17 2019

Mengerian committed rABC5ec77822cc26: Improve documentation for seed list generation (authored by Mengerian).
Improve documentation for seed list generation
Jan 17 2019, 03:52
Mengerian closed D2302: Improve documentation for seed list generation.
Jan 17 2019, 03:51

Jan 16 2019

Mengerian updated the diff for D2302: Improve documentation for seed list generation.

Remove some commands. The commands that I had added to generate seed
lists were too specific and may just add confusion if the lists
come from a long-running DNS seeder such as seed.bitcoinabc.org

Jan 16 2019, 19:31
Mengerian retitled D2302: Improve documentation for seed list generation from Improve documentation for seed generation to Improve documentation for seed list generation.
Jan 16 2019, 18:33
Mengerian updated the diff for D2302: Improve documentation for seed list generation.

edit title

Jan 16 2019, 18:33
Mengerian updated the diff for D2302: Improve documentation for seed list generation.

Remove relative paths

Jan 16 2019, 18:30

Jan 15 2019

Mengerian added inline comments to D2311: Initial implementation of RadixTree.
Jan 15 2019, 18:09
Mengerian added inline comments to D2311: Initial implementation of RadixTree.
Jan 15 2019, 16:55
Mengerian added inline comments to D2311: Initial implementation of RadixTree.
Jan 15 2019, 04:25

Jan 14 2019

Mengerian accepted D2310: Update disclosure and gitian signing keys.
Jan 14 2019, 20:38
Mengerian accepted D2309: Fix typo in 0.18.6 release notes.
Jan 14 2019, 18:23
Mengerian committed rABC072b4f327482: Fix version information in seeder documentation (authored by Mengerian).
Fix version information in seeder documentation
Jan 14 2019, 17:16
Mengerian closed D2301: Fix version information in seeder documentation.
Jan 14 2019, 17:16
Mengerian planned changes to D2302: Improve documentation for seed list generation.
Jan 14 2019, 17:13
Mengerian added inline comments to D2302: Improve documentation for seed list generation.
Jan 14 2019, 17:13
Mengerian updated the diff for D2301: Fix version information in seeder documentation.

Simplify wording further

Jan 14 2019, 17:00
Mengerian updated the diff for D2301: Fix version information in seeder documentation.

Remove mention of NODE_BITCOIN_CASH, which should be deprecated
and is no longer relevant.

Jan 14 2019, 16:58
Herald added a reviewer for D2302: Improve documentation for seed list generation: Restricted Project.
Jan 14 2019, 06:14
Mengerian updated the diff for D2301: Fix version information in seeder documentation.

fix typo

Jan 14 2019, 05:50
Herald added a reviewer for D2301: Fix version information in seeder documentation: Restricted Project.
Jan 14 2019, 05:33