- User Since
- Jun 10 2017, 19:20 (147 w, 3 d)
Sat, Mar 14
Fri, Mar 13
Checked out the new DNS seeder, seems good to me.
Just the list numbering fix, otherwise seems good to me.
Mar 3 2020
Feb 26 2020
Just a small comment/quibble: The name of the Diff seems misleading to me, it makes it sound like it's just adding a test, not changing behavior. But isn't it actually changing how the code work also?
Feb 15 2020
The Diff title seems to have a spurious "the":
Feb 12 2020
Looks good to me.
Feb 11 2020
Nit: Filename "abc-phonos-disconnectpool.py" should change phonos -> phonon
Feb 9 2020
Feb 8 2020
Feb 6 2020
Jan 20 2020
@tobias_ruck Could you change the name to OP_REVERSEBYTES in the Diff title?
Jan 11 2020
Jan 8 2020
@tobias_ruck something is mangled with this Diff. Did you amend the previous Git commit? (You should amend) Or just add another commit?
Jan 7 2020
@Fabien Should Cmake build instructions be added to the secp256k1 readme at /src/secp256k1/README.md ?
It currently has the autotools build instructions
Since it's coming from a different repo than most ABC backports, the Diff summary should mention what repo these backports are coming from and/or link to them
Jan 5 2020
Jan 4 2020
Add link directing contributors to Bitcoin ABC Phabricator repo
Re-add Travis link, now that Travis is enabled for the repo
Jan 3 2020
Add a bit more explanation of how the repository is maintained, so that people can understand what's going on.
Re-add "Use at your own risk" disclaimer as recommended by @Fabien
Add link and mention that this is the Bitcoin Cash variant of the Schnorr algorithm.
Jan 2 2020
@markblundeberg It may also be good to add some Schnorr information to the "Implementation Details" portion, and maybe a link to the BCH Schnorr spec on bitcoincash.org. Please let me know if you have any suggestions.
Dec 12 2019
Dec 11 2019
@markblundeberg you say " It is currently the only additive flag so it's the only one with weird behaviour like this."
Dec 10 2019
Dec 5 2019
Nov 29 2019
Nov 28 2019
Nov 26 2019
Looks good to me!
Nov 25 2019
Would be good to also update CONTRIBUTING.md with this version.
Oct 30 2019
Oct 29 2019
Sep 19 2019
Sep 18 2019
Sep 14 2019
Sep 13 2019
Looks good. Based on the crawler at cash.coin.dance/nodes there seem to be enough 0.20.x nodes out there to make this change now.