Page MenuHomePhabricator

Mengerian (Antony Zegers)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 19:20 (105 w, 13 h)

Recent Activity

Thu, Jun 13

D3325: Bump version to 0.19.9 is now accepted and ready to land.

Looks good

Thu, Jun 13, 21:16

Mon, Jun 10

Mengerian added inline comments to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Mon, Jun 10, 03:12

Sun, Jun 9

D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.

Checked throught the Diff again, looks good to me.

Sun, Jun 9, 18:52

Sat, Jun 8

Mengerian added inline comments to D3265: add new encoding checker for Schnorr sigs.
Sat, Jun 8, 22:14
Mengerian added inline comments to D3263: add CScriptNum operator>>=.
Sat, Jun 8, 20:44
D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.

This looks good to me. I played around with this a bit, it all seems to work.

Sat, Jun 8, 19:20
Mengerian committed rABC3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian).
Update timing.json Segwit Recovery functional test name
Sat, Jun 8, 17:37
Mengerian closed D3258: Update timing.json Segwit Recovery functional test name.
Sat, Jun 8, 17:37
Mengerian added a comment to D3258: Update timing.json Segwit Recovery functional test name.

Remove added newline

Sat, Jun 8, 15:27
Mengerian added inline comments to D3258: Update timing.json Segwit Recovery functional test name.
Sat, Jun 8, 15:10
Mengerian added a comment to D3253: Remove Schnorr activation.

Did another pass over the Diff today, it looks good to me.

Sat, Jun 8, 04:17
Mengerian added inline comments to D3253: Remove Schnorr activation.
Sat, Jun 8, 03:03

Fri, Jun 7

Mengerian created D3258: Update timing.json Segwit Recovery functional test name.
Fri, Jun 7, 19:04
Mengerian added inline comments to D3253: Remove Schnorr activation.
Fri, Jun 7, 06:21
D3255: Remove unused great wall activation code is now accepted and ready to land.

Looks good to me.

Fri, Jun 7, 06:00
D3253: Remove Schnorr activation now requires changes to proceed.

Looks good overall, I noted a couple minor nits.

Fri, Jun 7, 04:59
Mengerian added a revision to T653: Clean up past upgrades: D3253: Remove Schnorr activation.
Fri, Jun 7, 03:58
Mengerian added a task to D3253: Remove Schnorr activation: T653: Clean up past upgrades.
Fri, Jun 7, 03:58

Wed, Jun 5

Mengerian committed rABCeeed14a7916c: Clean up Segwit Recovery feature (authored by Mengerian).
Clean up Segwit Recovery feature
Wed, Jun 5, 20:28
Mengerian closed D3194: Clean up Segwit Recovery feature.
Wed, Jun 5, 20:28
Mengerian added reviewers for D3194: Clean up Segwit Recovery feature: markblundeberg, Fabien, jasonbcox.

Add more reviewers

Wed, Jun 5, 05:17
Mengerian added a comment to D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.

Abandon in favor of D3194

Wed, Jun 5, 05:10
Mengerian added a comment to D3148: Invert meaning of Segwit Recovery flag..

Abandon in favor of D3194

Wed, Jun 5, 05:07
Mengerian added a comment to D3065: Remove segwit recovery activation.

Abandon in favor of D3194

Wed, Jun 5, 05:07
Mengerian added a comment to D3148: Invert meaning of Segwit Recovery flag..

Abandon in favor of D3194

Wed, Jun 5, 05:06
Mengerian added a comment to D3194: Clean up Segwit Recovery feature.

Update script test comments per Mark's suggestion
Rebase

Wed, Jun 5, 05:04

Tue, Jun 4

Mengerian added a revision to T653: Clean up past upgrades: D3194: Clean up Segwit Recovery feature.
Tue, Jun 4, 04:27
Mengerian added a task to D3194: Clean up Segwit Recovery feature: T653: Clean up past upgrades.
Tue, Jun 4, 04:27
Mengerian added a comment to D3065: Remove segwit recovery activation.

@deadalnix I don't understand what you want.

Tue, Jun 4, 04:01
Mengerian added a comment to D3194: Clean up Segwit Recovery feature.

This is the same as D3148, D3065, and D3160 squashed into one change.

Tue, Jun 4, 03:55
Mengerian created D3194: Clean up Segwit Recovery feature.
Tue, Jun 4, 03:54

Fri, May 31

Mengerian updated the diff for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.

Update test plan
Improve description
Rebase on D3065

Fri, May 31, 06:01
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Rename test class

Fri, May 31, 05:57
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Rename functional test

Fri, May 31, 04:28

Thu, May 30

Mengerian updated the diff for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.

Rebase on D3065

Thu, May 30, 21:56
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Restore functional test portion that test accepting blocks containing Segwit recovery transactions.

Thu, May 30, 21:53
Mengerian updated the diff for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.

Add dependency to description.

Thu, May 30, 17:48
Herald added a reviewer for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag: Restricted Project.
Thu, May 30, 17:47
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Edit description.

Thu, May 30, 17:41
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Change functional test to run at "current" time.
Rebase on updated D3248

Thu, May 30, 17:39
Mengerian updated the diff for D3148: Invert meaning of Segwit Recovery flag..

Add unit tests for "0 left on stack" case with segwit recovery disallowed.
Clarify descriptions of script tests so that it's easier to see tests with the flag enabled.

Thu, May 30, 17:37
Mengerian committed rABCa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test
Thu, May 30, 16:40
Mengerian closed D3144: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test.
Thu, May 30, 16:40
Mengerian closed D3149: Add post-upgrade testnet checkpoint.
Thu, May 30, 16:39
Mengerian committed rABC282991621095: Add post-upgrade testnet checkpoint (authored by Mengerian).
Add post-upgrade testnet checkpoint
Thu, May 30, 16:39

Wed, May 29

Mengerian added inline comments to D3148: Invert meaning of Segwit Recovery flag..
Wed, May 29, 19:42
Mengerian added a comment to D3148: Invert meaning of Segwit Recovery flag..

@deadalnix I am trying to follow the step you outlined here: https://reviews.bitcoinabc.org/D3065#72372

Wed, May 29, 15:36
Mengerian added a task to D3148: Invert meaning of Segwit Recovery flag.: T653: Clean up past upgrades.
Wed, May 29, 15:11
Mengerian added a revision to T653: Clean up past upgrades: D3148: Invert meaning of Segwit Recovery flag..
Wed, May 29, 15:11
Mengerian added a revision to T653: Clean up past upgrades: D3149: Add post-upgrade testnet checkpoint.
Wed, May 29, 15:11
Mengerian added a task to D3149: Add post-upgrade testnet checkpoint: T653: Clean up past upgrades.
Wed, May 29, 15:11
Mengerian added a revision to T653: Clean up past upgrades: D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp.
Wed, May 29, 15:10
Mengerian added a task to D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp: T653: Clean up past upgrades.
Wed, May 29, 15:10
Mengerian abandoned D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp.
Wed, May 29, 15:10
Mengerian planned changes to D3065: Remove segwit recovery activation.

To do: add to standard flags.

Wed, May 29, 06:11
Mengerian updated the summary of D3065: Remove segwit recovery activation.
Wed, May 29, 06:09
Mengerian updated the summary of D3065: Remove segwit recovery activation.
Wed, May 29, 06:08
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Work in progress
Rebase on D3148

Wed, May 29, 06:07
Mengerian commandeered D3065: Remove segwit recovery activation.

I will rebase this on top of D3148 as-per @deadalnix review comment.

Wed, May 29, 05:44
Herald added a reviewer for D3149: Add post-upgrade testnet checkpoint: Restricted Project.
Wed, May 29, 05:37
Herald added a reviewer for D3148: Invert meaning of Segwit Recovery flag.: Restricted Project.
Wed, May 29, 04:23

Tue, May 28

Herald added a reviewer for D3144: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test: deadalnix.
Tue, May 28, 17:39
Herald added a reviewer for D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp: Restricted Project.
Tue, May 28, 17:13
Mengerian committed rABC11febd55e5a8: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests
Tue, May 28, 17:08
Mengerian closed D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.
Tue, May 28, 17:08
Mengerian updated the diff for D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.

Keep flag name in scriptflags.cpp list

Tue, May 28, 16:24
Mengerian added inline comments to D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.
Tue, May 28, 15:30
Mengerian updated the diff for D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.

Remove duplicate test cases

Tue, May 28, 15:12
Herald added a reviewer for D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests: Restricted Project.
Tue, May 28, 05:22

Mon, May 27

Mengerian committed rABC47a8898b14e7: Add comments indicating "Schnorr" in Schnorr-related script tests. (authored by Mengerian).
Add comments indicating "Schnorr" in Schnorr-related script tests.
Mon, May 27, 17:17
Mengerian closed D3130: Add comments indicating "Schnorr" in Schnorr-related script tests..
Mon, May 27, 17:17
Herald added a reviewer for D3130: Add comments indicating "Schnorr" in Schnorr-related script tests.: deadalnix.
Mon, May 27, 15:56
Mengerian committed rABCed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS. (authored by Mengerian).
Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
Mon, May 27, 15:42
Mengerian closed D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
Mon, May 27, 15:42
Mengerian updated the diff for D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..

Rebase

Mon, May 27, 15:23
Mengerian updated the diff for D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..

Rebase

Mon, May 27, 15:21
Mengerian updated the diff for D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..

Don't rename flag in script tests.
Rebase on master.

Mon, May 27, 03:15

Sat, May 25

Mengerian added a revision to T653: Clean up past upgrades: D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
Sat, May 25, 18:32
Mengerian added a task to D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.: T653: Clean up past upgrades.
Sat, May 25, 18:32
Mengerian added inline comments to D3113: Comments: More comments on functions/globals in standard.h..
Sat, May 25, 17:40
Mengerian accepted D3113: Comments: More comments on functions/globals in standard.h..

Looks good to me. I checked it against the core PR, and current Core code.

Sat, May 25, 16:22
Mengerian updated the diff for D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..

Re-comment auto-test generating #define
Rebase on master

Sat, May 25, 14:48
Mengerian added inline comments to D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
Sat, May 25, 14:47
Mengerian added a comment to D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..

In his review of D3100, @markblundeberg had suggested renaming the flag. This Diff does that.

Sat, May 25, 03:31
Herald added a reviewer for D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.: Restricted Project.
Sat, May 25, 03:28

Fri, May 24

Mengerian committed rABCf5fac93cec01: Interpret scripts with CHECKDATASIG opcode always valid. (authored by Mengerian).
Interpret scripts with CHECKDATASIG opcode always valid.
Fri, May 24, 16:07
Mengerian closed D3100: Interpret scripts with CHECKDATASIG opcode always valid..
Fri, May 24, 16:07
Mengerian updated the diff for D3100: Interpret scripts with CHECKDATASIG opcode always valid..

Fix description nit and rebase.

Fri, May 24, 15:40
Mengerian updated the diff for D3100: Interpret scripts with CHECKDATASIG opcode always valid..

Improve comments in checkdatasig_tests.cpp

Fri, May 24, 06:06
Mengerian updated the diff for D3100: Interpret scripts with CHECKDATASIG opcode always valid..

Remove test bloat.
Make comments in checkdatasig_tests.cpp more precise.
Rebase on master.

Fri, May 24, 05:52

Thu, May 23

Mengerian updated the diff for D3100: Interpret scripts with CHECKDATASIG opcode always valid..

Added duplicate CHECKDATASIG tests to script_tests.cpp to generate auto test cases.

Thu, May 23, 19:43
Mengerian planned changes to D3100: Interpret scripts with CHECKDATASIG opcode always valid..

I'm also thinking that maybe all the script tests that include the CHECKDATASIG script flag should stop referring to it, except for tests of sigops counting. However if other implementations are relying on those flags being in script_tests.json then maybe they should be kept.

Thu, May 23, 17:11
Mengerian added a task to D3100: Interpret scripts with CHECKDATASIG opcode always valid.: T653: Clean up past upgrades.
Thu, May 23, 16:07
Mengerian added a revision to T653: Clean up past upgrades: D3100: Interpret scripts with CHECKDATASIG opcode always valid..
Thu, May 23, 16:07
Herald added a reviewer for D3100: Interpret scripts with CHECKDATASIG opcode always valid.: Restricted Project.
Thu, May 23, 15:52
Mengerian committed rABCb2d3f35dac10: Add CHECKDATASIG to standard flags. (authored by Mengerian).
Add CHECKDATASIG to standard flags.
Thu, May 23, 15:26
Mengerian closed D3069: Add CHECKDATASIG to standard flags..
Thu, May 23, 15:26
Mengerian updated the diff for D3069: Add CHECKDATASIG to standard flags..

Remove redundant brackets and rebase.

Thu, May 23, 15:00

Wed, May 22

Mengerian updated the task description for T653: Clean up past upgrades.
Wed, May 22, 05:45
Mengerian updated the summary of D3069: Add CHECKDATASIG to standard flags..
Wed, May 22, 04:08