Page MenuHomePhabricator

Mengerian (Antony Zegers)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 19:20 (160 w, 4 d)

Recent Activity

Thu, Jul 2

Mengerian committed rABCWEB2f627f616a41: [website] Add ericreid91 as sponsor (authored by George Donnelly <me@georgedonnelly.com>).
[website] Add ericreid91 as sponsor
Thu, Jul 2, 16:11
Mengerian closed D6807: [website] Add ericreid91 as sponsor.
Thu, Jul 2, 16:11
Mengerian committed rABCWEB41ca95879607: [website] Add upgrade instructions (authored by Mengerian).
[website] Add upgrade instructions
Thu, Jul 2, 16:10
Mengerian closed D6808: [website] Add upgrade instructions.
Thu, Jul 2, 16:10
Mengerian added a comment to D6808: [website] Add upgrade instructions.

For reference, same article is posted at

Thu, Jul 2, 04:47
Mengerian requested review of D6808: [website] Add upgrade instructions.
Thu, Jul 2, 04:40
Mengerian requested review of D6807: [website] Add ericreid91 as sponsor.
Thu, Jul 2, 03:04

Tue, Jun 9

Mengerian committed rABCWEB41f5dcd2f520: Remove upgrade notice (authored by Mengerian).
Remove upgrade notice
Tue, Jun 9, 19:04
Mengerian closed D6484: Remove upgrade notice.
Tue, Jun 9, 19:04
Mengerian requested review of D6484: Remove upgrade notice.
Tue, Jun 9, 18:15

May 20 2020

Mengerian added a comment to D6145: Reconsider checkpointed block at startup..

Although this is already landed, I had a 0.20.12 node synced to the non-upgraded chain, so I took the opportunity to test this Diff, and it behaved as expected.

May 20 2020, 02:35

Apr 7 2020

Mengerian committed rSTAGING43e606effa6e: Fix UAHF references in dnsseed-policy.md (authored by btcfork <2880817-btcfork@users.noreply.gitlab.com>).
Fix UAHF references in dnsseed-policy.md
Apr 7 2020, 23:13
Mengerian committed rSTAGING62397a455438: Update copyright year in COPYING file (authored by Mengerian).
Update copyright year in COPYING file
Apr 7 2020, 22:55
Mengerian committed rSTAGING0a1ba77ef217: Add Accelerate book to Bitcoin ABC reading list (authored by Mengerian).
Add Accelerate book to Bitcoin ABC reading list
Apr 7 2020, 22:19
Mengerian committed rSTAGING1f824752ca59: Update secp256k1 README (authored by Mengerian).
Update secp256k1 README
Apr 7 2020, 22:16
Mengerian committed rSTAGINGd785628561a0: Update user agent filter in makeseeds.py (authored by Mengerian).
Update user agent filter in makeseeds.py
Apr 7 2020, 21:33
Mengerian committed rSTAGING8d87d3d4d28b: Add testnet-seed.bchd.cash to seeder lists (authored by Mengerian).
Add testnet-seed.bchd.cash to seeder lists
Apr 7 2020, 21:31

Mar 14 2020

Mengerian accepted D5475: Add Ubuntu PPA to release process.
Mar 14 2020, 03:40

Mar 13 2020

Mengerian accepted D5476: Update seeders list.

Checked out the new DNS seeder, seems good to me.

Mar 13 2020, 20:55
Mengerian requested changes to D5475: Add Ubuntu PPA to release process.

Just the list numbering fix, otherwise seems good to me.

Mar 13 2020, 20:28

Mar 3 2020

Mengerian committed rABC43e606effa6e: Fix UAHF references in dnsseed-policy.md (authored by btcfork <2880817-btcfork@users.noreply.gitlab.com>).
Fix UAHF references in dnsseed-policy.md
Mar 3 2020, 17:57
Mengerian closed D5406: Fix UAHF references in dnsseed-policy.md.
Mar 3 2020, 17:57
Mengerian created D5406: Fix UAHF references in dnsseed-policy.md.
Mar 3 2020, 04:45

Feb 26 2020

Mengerian added a comment to D5329: Enforce maximum name length for parse_name() and add unit tests.

Just a small comment/quibble: The name of the Diff seems misleading to me, it makes it sound like it's just adding a test, not changing behavior. But isn't it actually changing how the code work also?

Feb 26 2020, 21:37

Feb 15 2020

Mengerian added a comment to D5282: Implement miner funding features.

The Diff title seems to have a spurious "the":

Feb 15 2020, 17:38

Feb 12 2020

Mengerian accepted D5253: Bump automatic replay protection to Nov 2020 upgrade.

Looks good to me.

Feb 12 2020, 15:56

Feb 11 2020

Mengerian added a comment to D5245: [qa] Test that mempool reverts to pre-phonon policies.

Nit: Filename "abc-phonos-disconnectpool.py" should change phonos -> phonon

Feb 11 2020, 04:13

Feb 9 2020

Mengerian accepted D5229: Merge #13679: Initialize m_next_send_inv_to_incoming.
Feb 9 2020, 05:28
Mengerian committed rABC62397a455438: Update copyright year in COPYING file (authored by Mengerian).
Update copyright year in COPYING file
Feb 9 2020, 02:05
Mengerian closed D5226: Update copyright year in COPYING file.
Feb 9 2020, 02:05

Feb 8 2020

Mengerian created D5226: Update copyright year in COPYING file.
Feb 8 2020, 16:27

Feb 6 2020

Mengerian renamed T707: OP_REVERSEBYTES from OP_BSWAP to OP_REVERSEBYTES.
Feb 6 2020, 18:07 · Restricted Project
Mengerian added a revision to T707: OP_REVERSEBYTES: D5130: OP_REVERSEBYTES activation logic.
Feb 6 2020, 18:06 · Restricted Project
Mengerian added a task to D5130: OP_REVERSEBYTES activation logic: T707: OP_REVERSEBYTES.
Feb 6 2020, 18:06
Mengerian added a revision to T707: OP_REVERSEBYTES: D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Feb 6 2020, 18:06 · Restricted Project
Mengerian added a task to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag: T707: OP_REVERSEBYTES.
Feb 6 2020, 18:06

Jan 20 2020

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

@tobias_ruck Could you change the name to OP_REVERSEBYTES in the Diff title?

Jan 20 2020, 18:59

Jan 11 2020

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:

In a previous proposal, this opcode has been named OP_REVERSE. After that, it has been renamed to OP_BSWAP, as that is a more technically accurate term, which is commonly used for reversing the byteorder of integers [14] [15]. However, after some more consideration, it has been renamed to OP_ENDIAN_REVERSE following Boost‘s nomenclature [16]. This is because OP_BSWAP is lexically very similar to the already existing OP_SWAP and would make Script harder to read. Also, while the technical term for the instruction is indeed bswap, it isn‘t well known for developers of higher level languages and could thus spark confusion that would be avoided by using the name OP_ENDIAN_REVERSE, which is more self-descriptive.

Also added tests for unexecuted branches, clarified tests for not yet activated case.

Merged D4859 into this diff.

Jan 11 2020, 21:39

Jan 8 2020

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

I‘ve left the SCRIPT_ENABLE_OP_BSWAP flag at bit 22, this should be coordinated with @markblundeberg

Jan 8 2020, 23:29
Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

@tobias_ruck something is mangled with this Diff. Did you amend the previous Git commit? (You should amend) Or just add another commit?

Jan 8 2020, 23:22

Jan 7 2020

Mengerian committed rABC0a1ba77ef217: Add Accelerate book to Bitcoin ABC reading list (authored by Mengerian).
Add Accelerate book to Bitcoin ABC reading list
Jan 7 2020, 21:10
Mengerian closed D4847: Add Accelerate book to Bitcoin ABC reading list.
Jan 7 2020, 21:10
Mengerian added a comment to D4844: [CMAKE] Allow building secp256k1 as a standalone project.

@Fabien Should Cmake build instructions be added to the secp256k1 readme at /src/secp256k1/README.md ?
It currently has the autotools build instructions

Jan 7 2020, 20:30
Mengerian created D4847: Add Accelerate book to Bitcoin ABC reading list.
Jan 7 2020, 18:03
Mengerian added a comment to D4833: Add pippenger_wnaf for multi-multiplication.

Since it's coming from a different repo than most ABC backports, the Diff summary should mention what repo these backports are coming from and/or link to them

Jan 7 2020, 04:17

Jan 5 2020

Mengerian committed rABC1f824752ca59: Update secp256k1 README (authored by Mengerian).
Update secp256k1 README
Jan 5 2020, 23:27
Mengerian closed D4819: Update secp256k1 README.
Jan 5 2020, 23:27
Mengerian added inline comments to D4826: Add a facility to extract libsecp256k1 from the repository.
Jan 5 2020, 05:34

Jan 4 2020

Mengerian updated the diff for D4819: Update secp256k1 README.

Fix typo

Jan 4 2020, 16:43
Mengerian updated the diff for D4819: Update secp256k1 README.

Add link directing contributors to Bitcoin ABC Phabricator repo
Re-add Travis link, now that Travis is enabled for the repo

Jan 4 2020, 16:42

Jan 3 2020

Mengerian added inline comments to D4819: Update secp256k1 README.
Jan 3 2020, 06:01
Mengerian added inline comments to D4819: Update secp256k1 README.
Jan 3 2020, 04:41
Mengerian updated the diff for D4819: Update secp256k1 README.

Add a bit more explanation of how the repository is maintained, so that people can understand what's going on.
Re-add "Use at your own risk" disclaimer as recommended by @Fabien
Add link and mention that this is the Bitcoin Cash variant of the Schnorr algorithm.

Jan 3 2020, 04:41

Jan 2 2020

Mengerian added a comment to D4819: Update secp256k1 README.

@markblundeberg It may also be good to add some Schnorr information to the "Implementation Details" portion, and maybe a link to the BCH Schnorr spec on bitcoincash.org. Please let me know if you have any suggestions.

Jan 2 2020, 21:15
Mengerian created D4819: Update secp256k1 README.
Jan 2 2020, 21:07

Dec 12 2019

Mengerian added a comment to D4673: add SCHNORR_MULTISIG to mandatory flags.

Also, what is NULLDUMMY? No such flag exists. ;-)

Dec 12 2019, 05:40

Dec 11 2019

Mengerian added a comment to D4673: add SCHNORR_MULTISIG to mandatory flags.

@markblundeberg you say " It is currently the only additive flag so it's the only one with weird behaviour like this."

Dec 11 2019, 19:33

Dec 10 2019

Mengerian added a revision to T653: Clean up past upgrades: D4679: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.
Dec 10 2019, 10:09
Mengerian added a task to D4679: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags: T653: Clean up past upgrades.
Dec 10 2019, 10:09
Mengerian added a revision to T653: Clean up past upgrades: D4673: add SCHNORR_MULTISIG to mandatory flags.
Dec 10 2019, 03:46
Mengerian added a task to D4673: add SCHNORR_MULTISIG to mandatory flags: T653: Clean up past upgrades.
Dec 10 2019, 03:46

Dec 5 2019

Mengerian added a reviewer for D4642: Cleanup graviton activation: markblundeberg.
Dec 5 2019, 19:05
Mengerian added a revision to T653: Clean up past upgrades: D4642: Cleanup graviton activation.
Dec 5 2019, 19:03
Mengerian added a task to D4642: Cleanup graviton activation: T653: Clean up past upgrades.
Dec 5 2019, 19:03
Mengerian accepted D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.

Good catch!

Dec 5 2019, 19:01

Nov 29 2019

Mengerian added a revision to T653: Clean up past upgrades: D4577: remove NULLDUMMY.
Nov 29 2019, 18:12
Mengerian added a task to D4577: remove NULLDUMMY: T653: Clean up past upgrades.
Nov 29 2019, 18:12
Mengerian added a comment to D4577: remove NULLDUMMY.

Great to see this!

Nov 29 2019, 05:25

Nov 28 2019

Mengerian added a subtask for T653: Clean up past upgrades: T703: clean up schnorr activations.
Nov 28 2019, 22:21
Mengerian added a parent task for T703: clean up schnorr activations: T653: Clean up past upgrades.
Nov 28 2019, 22:21

Nov 26 2019

Mengerian accepted D4551: Fix wrong version in clang-format error message and update the doc.

Looks good to me!

Nov 26 2019, 19:11

Nov 25 2019

Mengerian added a comment to D4539: Move to clang format 8.

Would be good to also update CONTRIBUTING.md with this version.

Nov 25 2019, 22:15
Mengerian added a revision to T653: Clean up past upgrades: D4453: [CI] Remove functional tests with graviton activation.
Nov 25 2019, 20:57
Mengerian added a task to D4453: [CI] Remove functional tests with graviton activation: T653: Clean up past upgrades.
Nov 25 2019, 20:57

Oct 30 2019

Mengerian committed rABCd785628561a0: Update user agent filter in makeseeds.py (authored by Mengerian).
Update user agent filter in makeseeds.py
Oct 30 2019, 21:08
Mengerian closed D4319: Update user agent filter in makeseeds.py.
Oct 30 2019, 21:08
Mengerian created D4319: Update user agent filter in makeseeds.py.
Oct 30 2019, 03:06
Mengerian committed rABC8d87d3d4d28b: Add testnet-seed.bchd.cash to seeder lists (authored by Mengerian).
Add testnet-seed.bchd.cash to seeder lists
Oct 30 2019, 02:17
Mengerian closed D4308: Add testnet-seed.bchd.cash to seeder lists.
Oct 30 2019, 02:17

Oct 29 2019

Mengerian created D4308: Add testnet-seed.bchd.cash to seeder lists.
Oct 29 2019, 21:10

Sep 19 2019

Mengerian committed rSTAGING978fae27bb14: Add seed.bchd.cash to seeder lists (authored by Mengerian).
Add seed.bchd.cash to seeder lists
Sep 19 2019, 02:21
Mengerian committed rSTAGING65a6198254ac: Bump automatic replay protection to May 2020 upgrade (authored by Mengerian).
Bump automatic replay protection to May 2020 upgrade
Sep 19 2019, 01:50
Mengerian committed rSTAGINGaf9fd425afd7: Add upgrade features to release notes (authored by Mengerian).
Add upgrade features to release notes
Sep 19 2019, 01:50
Mengerian committed rSTAGING6bdb4057be12: Update doc/release-process.md (authored by Mengerian).
Update doc/release-process.md
Sep 19 2019, 01:07
Mengerian committed rSTAGING8df68739c056: Prettify README title (authored by Mengerian).
Prettify README title
Sep 19 2019, 00:52
Mengerian committed rSTAGING3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian).
Update timing.json Segwit Recovery functional test name
Sep 19 2019, 00:09
Mengerian committed rSTAGINGeeed14a7916c: Clean up Segwit Recovery feature (authored by Mengerian).
Clean up Segwit Recovery feature
Sep 19 2019, 00:04

Sep 18 2019

Mengerian committed rSTAGING282991621095: Add post-upgrade testnet checkpoint (authored by Mengerian).
Add post-upgrade testnet checkpoint
Sep 18 2019, 23:54
Mengerian committed rSTAGINGa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test
Sep 18 2019, 23:54
Mengerian committed rSTAGING11febd55e5a8: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests
Sep 18 2019, 23:53
Mengerian committed rSTAGING47a8898b14e7: Add comments indicating "Schnorr" in Schnorr-related script tests. (authored by Mengerian).
Add comments indicating "Schnorr" in Schnorr-related script tests.
Sep 18 2019, 23:49
Mengerian committed rSTAGINGed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS. (authored by Mengerian).
Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
Sep 18 2019, 23:49
Mengerian committed rSTAGINGf5fac93cec01: Interpret scripts with CHECKDATASIG opcode always valid. (authored by Mengerian).
Interpret scripts with CHECKDATASIG opcode always valid.
Sep 18 2019, 23:44
Mengerian committed rSTAGINGb2d3f35dac10: Add CHECKDATASIG to standard flags. (authored by Mengerian).
Add CHECKDATASIG to standard flags.
Sep 18 2019, 23:42
Mengerian committed rSTAGINGe048372368b8: Make tests independent of whether CHECKDATASIG is included in mandatory or… (authored by Mengerian).
Make tests independent of whether CHECKDATASIG is included in mandatory or…
Sep 18 2019, 23:40
Mengerian committed rSTAGING7fe181835646: Make release-process.md IBD instruction more precise (authored by Mengerian).
Make release-process.md IBD instruction more precise
Sep 18 2019, 23:35
Mengerian committed rSTAGINGcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG (authored by Mengerian).
Clarify comment for SCRIPT_ENABLE_CHECKDATASIG
Sep 18 2019, 23:35
Mengerian committed rSTAGING1b2531c1bd90: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS (authored by Mengerian).
Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS
Sep 18 2019, 23:35
Mengerian committed rSTAGINGf4025afda6a9: Remove obsolete comment from MANDATORY_SCRIPT_VERIFICATION_FLAGS (authored by Mengerian).
Remove obsolete comment from MANDATORY_SCRIPT_VERIFICATION_FLAGS
Sep 18 2019, 23:14
Mengerian committed rSTAGINGb634084b3e11: Add function 'IsGravitonEnabled' (authored by Mengerian).
Add function 'IsGravitonEnabled'
Sep 18 2019, 23:09