Page MenuHomePhabricator

Mengerian (Antony Zegers)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 19:20 (175 w, 6 d)

Recent Activity

Aug 24 2020

Mengerian committed rABCWEB5f446a4ba7a2: [website] Add BCHD SLP post (authored by Mengerian).
[website] Add BCHD SLP post
Aug 24 2020, 16:26
Mengerian closed D7246: [website] Add BCHD SLP post.
Aug 24 2020, 16:26
Mengerian requested review of D7246: [website] Add BCHD SLP post.
Aug 24 2020, 16:20

Aug 19 2020

Mengerian committed rABCWEB18658477763e: [website] fixes to Chinese post noted by translator (authored by Mengerian).
[website] fixes to Chinese post noted by translator
Aug 19 2020, 04:38
Mengerian closed D7221: [website] fixes to Chinese post noted by translator.
Aug 19 2020, 04:37
Mengerian requested review of D7221: [website] fixes to Chinese post noted by translator.
Aug 19 2020, 03:35

Aug 18 2020

Mengerian closed D7219: [website] Update posts to correct dates.
Aug 18 2020, 17:37
Mengerian committed rABCWEBc82d7d0e7904: [website] Update posts to correct dates (authored by Mengerian).
[website] Update posts to correct dates
Aug 18 2020, 17:37
Mengerian requested review of D7219: [website] Update posts to correct dates.
Aug 18 2020, 17:36
Mengerian committed rABCWEBa0575b69dba4: [website] Add Chinese version of Bitcoin ABC 0.22.0 release post (authored by Mengerian).
[website] Add Chinese version of Bitcoin ABC 0.22.0 release post
Aug 18 2020, 17:15
Mengerian closed D7218: [website] Add Chinese version of Bitcoin ABC 0.22.0 release post.
Aug 18 2020, 17:15
Mengerian requested review of D7218: [website] Add Chinese version of Bitcoin ABC 0.22.0 release post.
Aug 18 2020, 16:58
Mengerian committed rABCWEB2fd14e75e233: [website] Minor wording tweak to 0.22.0 announcement post (authored by Mengerian).
[website] Minor wording tweak to 0.22.0 announcement post
Aug 18 2020, 16:27
Mengerian closed D7217: [website] Minor wording tweak to 0.22.0 announcement post.
Aug 18 2020, 16:27
Mengerian requested review of D7217: [website] Minor wording tweak to 0.22.0 announcement post.
Aug 18 2020, 16:20
Mengerian committed rABCWEB293b27fde89c: Fixups to Bitcoin ABC 0.22.0 post (authored by Mengerian).
Fixups to Bitcoin ABC 0.22.0 post
Aug 18 2020, 16:10
Mengerian committed rABCWEBbd6caf0a8088: [website] Add post for Bitcoin ABC 0.22.0 release (authored by Mengerian).
[website] Add post for Bitcoin ABC 0.22.0 release
Aug 18 2020, 15:59

Aug 15 2020

Mengerian accepted D7199: Add release notes.

Looks good to me.

Aug 15 2020, 21:26

Aug 11 2020

Mengerian added inline comments to D7181: Cleanup instances of George's email.
Aug 11 2020, 04:45
Mengerian accepted D7181: Cleanup instances of George's email.

LGTM

Aug 11 2020, 03:32

Aug 6 2020

Mengerian committed rABCWEB66d7d82bc1a0: [website] Add update on George's departure from Bitcoin ABC (authored by Mengerian).
[website] Add update on George's departure from Bitcoin ABC
Aug 6 2020, 03:11
Mengerian closed D7136: [website] Add update on George's departure from Bitcoin ABC.
Aug 6 2020, 03:11

Aug 5 2020

Mengerian abandoned D2922: Add SIGPUSHONLY and CLEANSTACK to mandatory flags.
Aug 5 2020, 21:49
Mengerian requested review of D7136: [website] Add update on George's departure from Bitcoin ABC.
Aug 5 2020, 21:15

Jul 31 2020

Mengerian committed rABCWEB20612fc52ccb: [website] Add Gemini to sponsors (authored by Mengerian).
[website] Add Gemini to sponsors
Jul 31 2020, 16:29
Mengerian closed D7095: [website] Add Gemini to sponsors.
Jul 31 2020, 16:28

Jul 30 2020

Mengerian requested review of D7095: [website] Add Gemini to sponsors.
Jul 30 2020, 20:18

Jul 26 2020

Mengerian committed rABCabeb7de26ba5: Add Kent Beck link to CONTRIBUTING.md (authored by Mengerian).
Add Kent Beck link to CONTRIBUTING.md
Jul 26 2020, 00:32
Mengerian closed D7034: Add Kent Beck link to CONTRIBUTING.md.
Jul 26 2020, 00:32

Jul 24 2020

Mengerian requested review of D7034: Add Kent Beck link to CONTRIBUTING.md.
Jul 24 2020, 19:11
Mengerian added a comment to D6981: Implement Grasberg DAA.

More typos

Jul 24 2020, 18:54

Jul 23 2020

Mengerian added a comment to D6981: Implement Grasberg DAA.

Another typo

Jul 23 2020, 23:00
Mengerian added a comment to D6981: Implement Grasberg DAA.

some more typos

Jul 23 2020, 21:05

Jul 22 2020

Mengerian added inline comments to D6981: Implement Grasberg DAA.
Jul 22 2020, 20:39
Mengerian added inline comments to D6981: Implement Grasberg DAA.
Jul 22 2020, 19:47

Jul 2 2020

Mengerian committed rABCWEB2f627f616a41: [website] Add ericreid91 as sponsor (authored by George Donnelly <me@georgedonnelly.com>).
[website] Add ericreid91 as sponsor
Jul 2 2020, 16:11
Mengerian closed D6807: [website] Add ericreid91 as sponsor.
Jul 2 2020, 16:11
Mengerian committed rABCWEB41ca95879607: [website] Add upgrade instructions (authored by Mengerian).
[website] Add upgrade instructions
Jul 2 2020, 16:10
Mengerian closed D6808: [website] Add upgrade instructions.
Jul 2 2020, 16:10
Mengerian added a comment to D6808: [website] Add upgrade instructions.

For reference, same article is posted at

Jul 2 2020, 04:47
Mengerian requested review of D6808: [website] Add upgrade instructions.
Jul 2 2020, 04:40
Mengerian requested review of D6807: [website] Add ericreid91 as sponsor.
Jul 2 2020, 03:04

Jun 9 2020

Mengerian committed rABCWEB41f5dcd2f520: Remove upgrade notice (authored by Mengerian).
Remove upgrade notice
Jun 9 2020, 19:04
Mengerian closed D6484: Remove upgrade notice.
Jun 9 2020, 19:04
Mengerian requested review of D6484: Remove upgrade notice.
Jun 9 2020, 18:15

May 20 2020

Mengerian added a comment to D6145: Reconsider checkpointed block at startup..

Although this is already landed, I had a 0.20.12 node synced to the non-upgraded chain, so I took the opportunity to test this Diff, and it behaved as expected.

May 20 2020, 02:35

Apr 7 2020

Mengerian committed rSTAGING43e606effa6e: Fix UAHF references in dnsseed-policy.md (authored by btcfork <2880817-btcfork@users.noreply.gitlab.com>).
Fix UAHF references in dnsseed-policy.md
Apr 7 2020, 23:13
Mengerian committed rSTAGING62397a455438: Update copyright year in COPYING file (authored by Mengerian).
Update copyright year in COPYING file
Apr 7 2020, 22:55
Mengerian committed rSTAGING0a1ba77ef217: Add Accelerate book to Bitcoin ABC reading list (authored by Mengerian).
Add Accelerate book to Bitcoin ABC reading list
Apr 7 2020, 22:19
Mengerian committed rSTAGING1f824752ca59: Update secp256k1 README (authored by Mengerian).
Update secp256k1 README
Apr 7 2020, 22:16
Mengerian committed rSTAGINGd785628561a0: Update user agent filter in makeseeds.py (authored by Mengerian).
Update user agent filter in makeseeds.py
Apr 7 2020, 21:33
Mengerian committed rSTAGING8d87d3d4d28b: Add testnet-seed.bchd.cash to seeder lists (authored by Mengerian).
Add testnet-seed.bchd.cash to seeder lists
Apr 7 2020, 21:31

Mar 14 2020

Mengerian accepted D5475: Add Ubuntu PPA to release process.
Mar 14 2020, 03:40

Mar 13 2020

Mengerian accepted D5476: Update seeders list.

Checked out the new DNS seeder, seems good to me.

Mar 13 2020, 20:55
Mengerian requested changes to D5475: Add Ubuntu PPA to release process.

Just the list numbering fix, otherwise seems good to me.

Mar 13 2020, 20:28

Mar 3 2020

Mengerian committed rABC43e606effa6e: Fix UAHF references in dnsseed-policy.md (authored by btcfork <2880817-btcfork@users.noreply.gitlab.com>).
Fix UAHF references in dnsseed-policy.md
Mar 3 2020, 17:57
Mengerian closed D5406: Fix UAHF references in dnsseed-policy.md.
Mar 3 2020, 17:57
Mengerian created D5406: Fix UAHF references in dnsseed-policy.md.
Mar 3 2020, 04:45

Feb 26 2020

Mengerian added a comment to D5329: Enforce maximum name length for parse_name() and add unit tests.

Just a small comment/quibble: The name of the Diff seems misleading to me, it makes it sound like it's just adding a test, not changing behavior. But isn't it actually changing how the code work also?

Feb 26 2020, 21:37

Feb 15 2020

Mengerian added a comment to D5282: Implement miner funding features.

The Diff title seems to have a spurious "the":

Feb 15 2020, 17:38

Feb 12 2020

Mengerian accepted D5253: Bump automatic replay protection to Nov 2020 upgrade.

Looks good to me.

Feb 12 2020, 15:56

Feb 11 2020

Mengerian added a comment to D5245: [qa] Test that mempool reverts to pre-phonon policies.

Nit: Filename "abc-phonos-disconnectpool.py" should change phonos -> phonon

Feb 11 2020, 04:13

Feb 9 2020

Mengerian accepted D5229: Merge #13679: Initialize m_next_send_inv_to_incoming.
Feb 9 2020, 05:28
Mengerian committed rABC62397a455438: Update copyright year in COPYING file (authored by Mengerian).
Update copyright year in COPYING file
Feb 9 2020, 02:05
Mengerian closed D5226: Update copyright year in COPYING file.
Feb 9 2020, 02:05

Feb 8 2020

Mengerian created D5226: Update copyright year in COPYING file.
Feb 8 2020, 16:27

Feb 6 2020

Mengerian renamed T707: OP_REVERSEBYTES from OP_BSWAP to OP_REVERSEBYTES.
Feb 6 2020, 18:07 · Restricted Project
Mengerian added a revision to T707: OP_REVERSEBYTES: D5130: OP_REVERSEBYTES activation logic.
Feb 6 2020, 18:06 · Restricted Project
Mengerian added a task to D5130: OP_REVERSEBYTES activation logic: T707: OP_REVERSEBYTES.
Feb 6 2020, 18:06
Mengerian added a revision to T707: OP_REVERSEBYTES: D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Feb 6 2020, 18:06 · Restricted Project
Mengerian added a task to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag: T707: OP_REVERSEBYTES.
Feb 6 2020, 18:06

Jan 20 2020

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

@tobias_ruck Could you change the name to OP_REVERSEBYTES in the Diff title?

Jan 20 2020, 18:59

Jan 11 2020

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:

In a previous proposal, this opcode has been named OP_REVERSE. After that, it has been renamed to OP_BSWAP, as that is a more technically accurate term, which is commonly used for reversing the byteorder of integers [14] [15]. However, after some more consideration, it has been renamed to OP_ENDIAN_REVERSE following Boost‘s nomenclature [16]. This is because OP_BSWAP is lexically very similar to the already existing OP_SWAP and would make Script harder to read. Also, while the technical term for the instruction is indeed bswap, it isn‘t well known for developers of higher level languages and could thus spark confusion that would be avoided by using the name OP_ENDIAN_REVERSE, which is more self-descriptive.

Also added tests for unexecuted branches, clarified tests for not yet activated case.

Merged D4859 into this diff.

Jan 11 2020, 21:39

Jan 8 2020

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

I‘ve left the SCRIPT_ENABLE_OP_BSWAP flag at bit 22, this should be coordinated with @markblundeberg

Jan 8 2020, 23:29
Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

@tobias_ruck something is mangled with this Diff. Did you amend the previous Git commit? (You should amend) Or just add another commit?

Jan 8 2020, 23:22

Jan 7 2020

Mengerian committed rABC0a1ba77ef217: Add Accelerate book to Bitcoin ABC reading list (authored by Mengerian).
Add Accelerate book to Bitcoin ABC reading list
Jan 7 2020, 21:10
Mengerian closed D4847: Add Accelerate book to Bitcoin ABC reading list.
Jan 7 2020, 21:10
Mengerian added a comment to D4844: [CMAKE] Allow building secp256k1 as a standalone project.

@Fabien Should Cmake build instructions be added to the secp256k1 readme at /src/secp256k1/README.md ?
It currently has the autotools build instructions

Jan 7 2020, 20:30
Mengerian created D4847: Add Accelerate book to Bitcoin ABC reading list.
Jan 7 2020, 18:03
Mengerian added a comment to D4833: Add pippenger_wnaf for multi-multiplication.

Since it's coming from a different repo than most ABC backports, the Diff summary should mention what repo these backports are coming from and/or link to them

Jan 7 2020, 04:17

Jan 5 2020

Mengerian committed rABC1f824752ca59: Update secp256k1 README (authored by Mengerian).
Update secp256k1 README
Jan 5 2020, 23:27
Mengerian closed D4819: Update secp256k1 README.
Jan 5 2020, 23:27
Mengerian added inline comments to D4826: Add a facility to extract libsecp256k1 from the repository.
Jan 5 2020, 05:34

Jan 4 2020

Mengerian updated the diff for D4819: Update secp256k1 README.

Fix typo

Jan 4 2020, 16:43
Mengerian updated the diff for D4819: Update secp256k1 README.

Add link directing contributors to Bitcoin ABC Phabricator repo
Re-add Travis link, now that Travis is enabled for the repo

Jan 4 2020, 16:42

Jan 3 2020

Mengerian added inline comments to D4819: Update secp256k1 README.
Jan 3 2020, 06:01
Mengerian added inline comments to D4819: Update secp256k1 README.
Jan 3 2020, 04:41
Mengerian updated the diff for D4819: Update secp256k1 README.

Add a bit more explanation of how the repository is maintained, so that people can understand what's going on.
Re-add "Use at your own risk" disclaimer as recommended by @Fabien
Add link and mention that this is the Bitcoin Cash variant of the Schnorr algorithm.

Jan 3 2020, 04:41

Jan 2 2020

Mengerian added a comment to D4819: Update secp256k1 README.

@markblundeberg It may also be good to add some Schnorr information to the "Implementation Details" portion, and maybe a link to the BCH Schnorr spec on bitcoincash.org. Please let me know if you have any suggestions.

Jan 2 2020, 21:15
Mengerian created D4819: Update secp256k1 README.
Jan 2 2020, 21:07

Dec 12 2019

Mengerian added a comment to D4673: add SCHNORR_MULTISIG to mandatory flags.

Also, what is NULLDUMMY? No such flag exists. ;-)

Dec 12 2019, 05:40

Dec 11 2019

Mengerian added a comment to D4673: add SCHNORR_MULTISIG to mandatory flags.

@markblundeberg you say " It is currently the only additive flag so it's the only one with weird behaviour like this."

Dec 11 2019, 19:33

Dec 10 2019

Mengerian added a revision to T653: Clean up past upgrades: D4679: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.
Dec 10 2019, 10:09
Mengerian added a task to D4679: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags: T653: Clean up past upgrades.
Dec 10 2019, 10:09
Mengerian added a revision to T653: Clean up past upgrades: D4673: add SCHNORR_MULTISIG to mandatory flags.
Dec 10 2019, 03:46
Mengerian added a task to D4673: add SCHNORR_MULTISIG to mandatory flags: T653: Clean up past upgrades.
Dec 10 2019, 03:46

Dec 5 2019

Mengerian added a reviewer for D4642: Cleanup graviton activation: markblundeberg.
Dec 5 2019, 19:05
Mengerian added a revision to T653: Clean up past upgrades: D4642: Cleanup graviton activation.
Dec 5 2019, 19:03
Mengerian added a task to D4642: Cleanup graviton activation: T653: Clean up past upgrades.
Dec 5 2019, 19:03
Mengerian accepted D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.

Good catch!

Dec 5 2019, 19:01