Page MenuHomePhabricator

Mengerian (Antony Zegers)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 19:20 (126 w, 4 d)

Recent Activity

Wed, Oct 30

Mengerian committed rABCd785628561a0: Update user agent filter in makeseeds.py (authored by Mengerian).
Update user agent filter in makeseeds.py
Wed, Oct 30, 21:08
Mengerian closed D4319: Update user agent filter in makeseeds.py.
Wed, Oct 30, 21:08
Mengerian created D4319: Update user agent filter in makeseeds.py.
Wed, Oct 30, 03:06
Mengerian committed rABC8d87d3d4d28b: Add testnet-seed.bchd.cash to seeder lists (authored by Mengerian).
Add testnet-seed.bchd.cash to seeder lists
Wed, Oct 30, 02:17
Mengerian closed D4308: Add testnet-seed.bchd.cash to seeder lists.
Wed, Oct 30, 02:17

Tue, Oct 29

Mengerian created D4308: Add testnet-seed.bchd.cash to seeder lists.
Tue, Oct 29, 21:10

Sep 19 2019

Mengerian committed rSTAGING978fae27bb14: Add seed.bchd.cash to seeder lists (authored by Mengerian).
Add seed.bchd.cash to seeder lists
Sep 19 2019, 02:21
Mengerian committed rSTAGING65a6198254ac: Bump automatic replay protection to May 2020 upgrade (authored by Mengerian).
Bump automatic replay protection to May 2020 upgrade
Sep 19 2019, 01:50
Mengerian committed rSTAGINGaf9fd425afd7: Add upgrade features to release notes (authored by Mengerian).
Add upgrade features to release notes
Sep 19 2019, 01:50
Mengerian committed rSTAGING6bdb4057be12: Update doc/release-process.md (authored by Mengerian).
Update doc/release-process.md
Sep 19 2019, 01:07
Mengerian committed rSTAGING8df68739c056: Prettify README title (authored by Mengerian).
Prettify README title
Sep 19 2019, 00:52
Mengerian committed rSTAGING3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian).
Update timing.json Segwit Recovery functional test name
Sep 19 2019, 00:09
Mengerian committed rSTAGINGeeed14a7916c: Clean up Segwit Recovery feature (authored by Mengerian).
Clean up Segwit Recovery feature
Sep 19 2019, 00:04

Sep 18 2019

Mengerian committed rSTAGING282991621095: Add post-upgrade testnet checkpoint (authored by Mengerian).
Add post-upgrade testnet checkpoint
Sep 18 2019, 23:54
Mengerian committed rSTAGINGa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test
Sep 18 2019, 23:54
Mengerian committed rSTAGING11febd55e5a8: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests
Sep 18 2019, 23:53
Mengerian committed rSTAGING47a8898b14e7: Add comments indicating "Schnorr" in Schnorr-related script tests. (authored by Mengerian).
Add comments indicating "Schnorr" in Schnorr-related script tests.
Sep 18 2019, 23:49
Mengerian committed rSTAGINGed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS. (authored by Mengerian).
Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
Sep 18 2019, 23:49
Mengerian committed rSTAGINGf5fac93cec01: Interpret scripts with CHECKDATASIG opcode always valid. (authored by Mengerian).
Interpret scripts with CHECKDATASIG opcode always valid.
Sep 18 2019, 23:44
Mengerian committed rSTAGINGb2d3f35dac10: Add CHECKDATASIG to standard flags. (authored by Mengerian).
Add CHECKDATASIG to standard flags.
Sep 18 2019, 23:42
Mengerian committed rSTAGINGe048372368b8: Make tests independent of whether CHECKDATASIG is included in mandatory or… (authored by Mengerian).
Make tests independent of whether CHECKDATASIG is included in mandatory or…
Sep 18 2019, 23:40
Mengerian committed rSTAGING7fe181835646: Make release-process.md IBD instruction more precise (authored by Mengerian).
Make release-process.md IBD instruction more precise
Sep 18 2019, 23:35
Mengerian committed rSTAGINGcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG (authored by Mengerian).
Clarify comment for SCRIPT_ENABLE_CHECKDATASIG
Sep 18 2019, 23:35
Mengerian committed rSTAGING1b2531c1bd90: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS (authored by Mengerian).
Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS
Sep 18 2019, 23:35
Mengerian committed rSTAGINGf4025afda6a9: Remove obsolete comment from MANDATORY_SCRIPT_VERIFICATION_FLAGS (authored by Mengerian).
Remove obsolete comment from MANDATORY_SCRIPT_VERIFICATION_FLAGS
Sep 18 2019, 23:14
Mengerian committed rSTAGINGb634084b3e11: Add function 'IsGravitonEnabled' (authored by Mengerian).
Add function 'IsGravitonEnabled'
Sep 18 2019, 23:09
Mengerian committed rSTAGINGfd941e691f43: Remove communication style article from CONTRIBUTING.md (authored by Mengerian).
Remove communication style article from CONTRIBUTING.md
Sep 18 2019, 22:54
Mengerian committed rSTAGING0e5093e64e55: Add dev articles to CONTRIBUTING.md (authored by Mengerian).
Add dev articles to CONTRIBUTING.md
Sep 18 2019, 22:54
Mengerian committed rSTAGING294bdcf3b209: Update chain parameters for 0.18.8 (authored by Mengerian).
Update chain parameters for 0.18.8
Sep 18 2019, 22:18
Mengerian committed rSTAGING200b76b815af: Fix formatting in release-process.md (authored by Mengerian).
Fix formatting in release-process.md
Sep 18 2019, 22:18
Mengerian committed rSTAGINGc27207fed9c7: Refactor signature encoding checks (authored by Mengerian).
Refactor signature encoding checks
Sep 18 2019, 22:13

Sep 14 2019

Mengerian committed rABC978fae27bb14: Add seed.bchd.cash to seeder lists (authored by Mengerian).
Add seed.bchd.cash to seeder lists
Sep 14 2019, 01:52
Mengerian closed D4073: Add seed.bchd.cash to seeder lists.
Sep 14 2019, 01:52

Sep 13 2019

Mengerian created D4073: Add seed.bchd.cash to seeder lists.
Sep 13 2019, 18:31
Mengerian accepted D4059: Update the agent pattern filter in the makeseeds.py script.

Looks good. Based on the crawler at cash.coin.dance/nodes there seem to be enough 0.20.x nodes out there to make this change now.

Sep 13 2019, 02:43

Aug 30 2019

Mengerian added a revision to T653: Clean up past upgrades: D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.
Aug 30 2019, 15:30
Mengerian added a task to D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag: T653: Clean up past upgrades.
Aug 30 2019, 15:30

Aug 29 2019

Mengerian accepted D3973: Update manpages for 0.20.1 release.
Aug 29 2019, 18:26
Mengerian requested changes to D3973: Update manpages for 0.20.1 release.

Rebase on updated D3972

Aug 29 2019, 18:17
Mengerian accepted D3972: Update chainparams.

checked on my local node, looks good.

Aug 29 2019, 17:29
Mengerian accepted D3970: Add some more release notes for 0.20.1.

Looks good to me.

Aug 29 2019, 16:47
Mengerian added inline comments to D3972: Update chainparams.
Aug 29 2019, 16:44
Mengerian requested changes to D3972: Update chainparams.

Chainwork is above the value on the Upgrade testnet, which will make it more complicated for people to run this release on the upgrade testnet.

Aug 29 2019, 16:42
Mengerian accepted D3971: Update seeds.

Seems good, but pretty soon we should update the version number in contrib/seeds/makeseeds.py

Aug 29 2019, 16:30

Aug 15 2019

Mengerian added a comment to D3884: Update chainparams.

FYI, Updating testnet params would be fine this time, as we will be re-starting the Upgrade testnet with this release.

Aug 15 2019, 20:21

Aug 14 2019

Mengerian committed rABC65a6198254ac: Bump automatic replay protection to May 2020 upgrade (authored by Mengerian).
Bump automatic replay protection to May 2020 upgrade
Aug 14 2019, 22:55
Mengerian closed D3868: Bump automatic replay protection to May 2020 upgrade.
Aug 14 2019, 22:55
Mengerian updated the diff for D3868: Bump automatic replay protection to May 2020 upgrade.

Rebase

Aug 14 2019, 18:42
Mengerian committed rABCaf9fd425afd7: Add upgrade features to release notes (authored by Mengerian).
Add upgrade features to release notes
Aug 14 2019, 18:38
Mengerian closed D3869: Add upgrade features to release notes.
Aug 14 2019, 18:38
Mengerian created D3869: Add upgrade features to release notes.
Aug 14 2019, 04:35
Mengerian created D3868: Bump automatic replay protection to May 2020 upgrade.
Aug 14 2019, 03:15

Aug 12 2019

Mengerian accepted D3853: Bump version to 0.20.0.

Looks good.

Aug 12 2019, 17:20

Aug 9 2019

Mengerian accepted D3838: Bump version to 0.20.0.

Looks fine to me.

Aug 9 2019, 20:09
Mengerian requested changes to D3836: Bumped version number to 0.19.13.

Next version should be 0.20.0 no?

Aug 9 2019, 16:33

Aug 8 2019

Mengerian accepted D3830: Update chainparams.

The chainwork should be as high as the highest seen PoW and does not need to match the assume valid block. However, it should always be greater than the assume valid block, which is obvious. See D3732

Aug 8 2019, 20:41
Mengerian requested changes to D3830: Update chainparams.

Seems strange that chainwork does not correspond to the block hashes used for assumevalid.

Aug 8 2019, 19:31

Aug 5 2019

Mengerian accepted D3794: Add a message to static_assert.

Wording now looks good to me

Aug 5 2019, 20:14

Aug 4 2019

Mengerian added a comment to D3794: Add a message to static_assert.

@Fabien @markblundeberg How about this: "Schnorr multisig checkbits implementation assumes < 32 pubkeys."

Aug 4 2019, 19:21

Aug 1 2019

Mengerian added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Aug 1 2019, 22:14

Jul 15 2019

Mengerian accepted D3675: [refactor multisig] remove redundant counters.

This makes the code more readable for me, so it seems like a good change.

Jul 15 2019, 16:42

Jul 14 2019

Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 14 2019, 19:34
Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 14 2019, 05:14

Jul 13 2019

Mengerian accepted D3625: [refactor multisig] make const values up front.

The logic looks good to me.

Jul 13 2019, 16:38
Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 13 2019, 16:28
Mengerian added a comment to D3625: [refactor multisig] make const values up front.

I would suggest updating the description, which refers to "ints".

Jul 13 2019, 16:17

Jul 12 2019

Mengerian accepted D3667: Version number bumped to 0.19.11.

Oh, it is changed in master :)

Jul 12 2019, 18:05
Mengerian added a comment to D3667: Version number bumped to 0.19.11.

Someone should change doc/release-process.md to correspond to this new set of places that the version number is updated.

Jul 12 2019, 18:04

Jul 9 2019

Mengerian committed rABC6bdb4057be12: Update doc/release-process.md (authored by Mengerian).
Update doc/release-process.md
Jul 9 2019, 20:09
Mengerian closed D3603: Update doc/release-process.md.
Jul 9 2019, 20:08
Mengerian updated the diff for D3603: Update doc/release-process.md.

Update per @jasonbcox feedback

Jul 9 2019, 18:15
Mengerian added inline comments to D3603: Update doc/release-process.md.
Jul 9 2019, 15:16
Mengerian updated the diff for D3603: Update doc/release-process.md.

Update per @Fabien comments

Jul 9 2019, 15:12
Mengerian created D3603: Update doc/release-process.md.
Jul 9 2019, 03:38

Jul 8 2019

Mengerian added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 8 2019, 16:50
Mengerian added inline comments to D3473: [refactor multisig] consolidate legacy mode logic.
Jul 8 2019, 03:44

Jul 2 2019

Mengerian committed rABC8df68739c056: Prettify README title (authored by Mengerian).
Prettify README title
Jul 2 2019, 18:29
Mengerian closed D3513: Prettify README title.
Jul 2 2019, 18:29
Mengerian added a comment to D3513: Prettify README title.

Change alt text to "Bitcoin ABC Logo"

Jul 2 2019, 15:47
Mengerian updated the test plan for D3513: Prettify README title.

Update test plan for alt text

Jul 2 2019, 15:07
Mengerian added a comment to D3513: Prettify README title.

Fix alt text

Jul 2 2019, 15:04
Mengerian added a reviewer for D3513: Prettify README title: jasonbcox.
Jul 2 2019, 05:21
Mengerian created D3513: Prettify README title.
Jul 2 2019, 04:24

Jun 28 2019

D3444: Bump version to 0.19.10 is now accepted and ready to land.
Jun 28 2019, 00:54

Jun 27 2019

Mengerian added a comment to D3439: Update chainparams for 0.19.9 release.

Checked mainnet and testnet with my local node.

Jun 27 2019, 20:29

Jun 26 2019

Mengerian added a comment to D3415: rename schnorr functional test (rename-only).

Looks good to me.

Jun 26 2019, 20:53
Mengerian added a comment to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.

It all looks good to me.

Jun 26 2019, 19:39
Mengerian added inline comments to D3265: add new encoding checker for Schnorr sigs.
Jun 26 2019, 04:48

Jun 25 2019

Mengerian accepted D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Jun 25 2019, 20:25

Jun 23 2019

Mengerian added a comment to D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.

Note: in principle in this Diff, I could take out the two remaining *uses* of this flag as well, from MANDATORY_SCRIPT_VERIFY_FLAGS and from GetNextBlockScriptFlags (aka GetBlockScriptFlags). At the moment they are removed in the follow-up diff D3332.
If I did this, then D3332 would be basically a pure test-cleanup diff that quite manifestly doesn't touch any consensus code.

Jun 23 2019, 20:34

Jun 13 2019

D3325: Bump version to 0.19.9 is now accepted and ready to land.

Looks good

Jun 13 2019, 21:16

Jun 10 2019

Mengerian added inline comments to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 10 2019, 03:12

Jun 9 2019

D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.

Checked throught the Diff again, looks good to me.

Jun 9 2019, 18:52

Jun 8 2019

Mengerian added inline comments to D3265: add new encoding checker for Schnorr sigs.
Jun 8 2019, 22:14
Mengerian added inline comments to D3263: add CScriptNum operator>>=.
Jun 8 2019, 20:44
D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.

This looks good to me. I played around with this a bit, it all seems to work.

Jun 8 2019, 19:20
Mengerian committed rABC3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian).
Update timing.json Segwit Recovery functional test name
Jun 8 2019, 17:37
Mengerian closed D3258: Update timing.json Segwit Recovery functional test name.
Jun 8 2019, 17:37
Mengerian added a comment to D3258: Update timing.json Segwit Recovery functional test name.

Remove added newline

Jun 8 2019, 15:27
Mengerian added inline comments to D3258: Update timing.json Segwit Recovery functional test name.
Jun 8 2019, 15:10