Page MenuHomePhabricator

Mengerian (Antony Zegers)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 19:20 (114 w, 1 d)

Recent Activity

Thu, Aug 15

Mengerian added a comment to D3884: Update chainparams.

FYI, Updating testnet params would be fine this time, as we will be re-starting the Upgrade testnet with this release.

Thu, Aug 15, 20:21

Wed, Aug 14

Mengerian committed rABC65a6198254ac: Bump automatic replay protection to May 2020 upgrade (authored by Mengerian).
Bump automatic replay protection to May 2020 upgrade
Wed, Aug 14, 22:55
Mengerian closed D3868: Bump automatic replay protection to May 2020 upgrade.
Wed, Aug 14, 22:55
Mengerian updated the diff for D3868: Bump automatic replay protection to May 2020 upgrade.

Rebase

Wed, Aug 14, 18:42
Mengerian committed rABCaf9fd425afd7: Add upgrade features to release notes (authored by Mengerian).
Add upgrade features to release notes
Wed, Aug 14, 18:38
Mengerian closed D3869: Add upgrade features to release notes.
Wed, Aug 14, 18:38
Mengerian created D3869: Add upgrade features to release notes.
Wed, Aug 14, 04:35
Mengerian created D3868: Bump automatic replay protection to May 2020 upgrade.
Wed, Aug 14, 03:15

Mon, Aug 12

Mengerian accepted D3853: Bump version to 0.20.0.

Looks good.

Mon, Aug 12, 17:20

Fri, Aug 9

Mengerian accepted D3838: Bump version to 0.20.0.

Looks fine to me.

Fri, Aug 9, 20:09
Mengerian requested changes to D3836: Bumped version number to 0.19.13.

Next version should be 0.20.0 no?

Fri, Aug 9, 16:33

Thu, Aug 8

Mengerian accepted D3830: Update chainparams.

The chainwork should be as high as the highest seen PoW and does not need to match the assume valid block. However, it should always be greater than the assume valid block, which is obvious. See D3732

Thu, Aug 8, 20:41
Mengerian requested changes to D3830: Update chainparams.

Seems strange that chainwork does not correspond to the block hashes used for assumevalid.

Thu, Aug 8, 19:31

Mon, Aug 5

Mengerian accepted D3794: Add a message to static_assert.

Wording now looks good to me

Mon, Aug 5, 20:14

Sun, Aug 4

Mengerian added a comment to D3794: Add a message to static_assert.

@Fabien @markblundeberg How about this: "Schnorr multisig checkbits implementation assumes < 32 pubkeys."

Sun, Aug 4, 19:21

Thu, Aug 1

Mengerian added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Thu, Aug 1, 22:14

Jul 15 2019

Mengerian accepted D3675: [refactor multisig] remove redundant counters.

This makes the code more readable for me, so it seems like a good change.

Jul 15 2019, 16:42

Jul 14 2019

Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 14 2019, 19:34
Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 14 2019, 05:14

Jul 13 2019

Mengerian accepted D3625: [refactor multisig] make const values up front.

The logic looks good to me.

Jul 13 2019, 16:38
Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 13 2019, 16:28
Mengerian added a comment to D3625: [refactor multisig] make const values up front.

I would suggest updating the description, which refers to "ints".

Jul 13 2019, 16:17

Jul 12 2019

Mengerian accepted D3667: Version number bumped to 0.19.11.

Oh, it is changed in master :)

Jul 12 2019, 18:05
Mengerian added a comment to D3667: Version number bumped to 0.19.11.

Someone should change doc/release-process.md to correspond to this new set of places that the version number is updated.

Jul 12 2019, 18:04

Jul 9 2019

Mengerian committed rABC6bdb4057be12: Update doc/release-process.md (authored by Mengerian).
Update doc/release-process.md
Jul 9 2019, 20:09
Mengerian closed D3603: Update doc/release-process.md.
Jul 9 2019, 20:08
Mengerian updated the diff for D3603: Update doc/release-process.md.

Update per @jasonbcox feedback

Jul 9 2019, 18:15
Mengerian added inline comments to D3603: Update doc/release-process.md.
Jul 9 2019, 15:16
Mengerian updated the diff for D3603: Update doc/release-process.md.

Update per @Fabien comments

Jul 9 2019, 15:12
Mengerian created D3603: Update doc/release-process.md.
Jul 9 2019, 03:38

Jul 8 2019

Mengerian added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 8 2019, 16:50
Mengerian added inline comments to D3473: [refactor multisig] consolidate legacy mode logic.
Jul 8 2019, 03:44

Jul 2 2019

Mengerian committed rABC8df68739c056: Prettify README title (authored by Mengerian).
Prettify README title
Jul 2 2019, 18:29
Mengerian closed D3513: Prettify README title.
Jul 2 2019, 18:29
Mengerian added a comment to D3513: Prettify README title.

Change alt text to "Bitcoin ABC Logo"

Jul 2 2019, 15:47
Mengerian updated the test plan for D3513: Prettify README title.

Update test plan for alt text

Jul 2 2019, 15:07
Mengerian added a comment to D3513: Prettify README title.

Fix alt text

Jul 2 2019, 15:04
Mengerian added a reviewer for D3513: Prettify README title: jasonbcox.
Jul 2 2019, 05:21
Mengerian created D3513: Prettify README title.
Jul 2 2019, 04:24

Jun 28 2019

D3444: Bump version to 0.19.10 is now accepted and ready to land.
Jun 28 2019, 00:54

Jun 27 2019

Mengerian added a comment to D3439: Update chainparams for 0.19.9 release.

Checked mainnet and testnet with my local node.

Jun 27 2019, 20:29

Jun 26 2019

Mengerian added a comment to D3415: rename schnorr functional test (rename-only).

Looks good to me.

Jun 26 2019, 20:53
Mengerian added a comment to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.

It all looks good to me.

Jun 26 2019, 19:39
Mengerian added inline comments to D3265: add new encoding checker for Schnorr sigs.
Jun 26 2019, 04:48

Jun 25 2019

Mengerian accepted D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Jun 25 2019, 20:25

Jun 23 2019

Mengerian added a comment to D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.

Note: in principle in this Diff, I could take out the two remaining *uses* of this flag as well, from MANDATORY_SCRIPT_VERIFY_FLAGS and from GetNextBlockScriptFlags (aka GetBlockScriptFlags). At the moment they are removed in the follow-up diff D3332.
If I did this, then D3332 would be basically a pure test-cleanup diff that quite manifestly doesn't touch any consensus code.

Jun 23 2019, 20:34

Jun 13 2019

D3325: Bump version to 0.19.9 is now accepted and ready to land.

Looks good

Jun 13 2019, 21:16

Jun 10 2019

Mengerian added inline comments to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 10 2019, 03:12

Jun 9 2019

D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.

Checked throught the Diff again, looks good to me.

Jun 9 2019, 18:52

Jun 8 2019

Mengerian added inline comments to D3265: add new encoding checker for Schnorr sigs.
Jun 8 2019, 22:14
Mengerian added inline comments to D3263: add CScriptNum operator>>=.
Jun 8 2019, 20:44
D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.

This looks good to me. I played around with this a bit, it all seems to work.

Jun 8 2019, 19:20
Mengerian committed rABC3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian).
Update timing.json Segwit Recovery functional test name
Jun 8 2019, 17:37
Mengerian closed D3258: Update timing.json Segwit Recovery functional test name.
Jun 8 2019, 17:37
Mengerian added a comment to D3258: Update timing.json Segwit Recovery functional test name.

Remove added newline

Jun 8 2019, 15:27
Mengerian added inline comments to D3258: Update timing.json Segwit Recovery functional test name.
Jun 8 2019, 15:10
Mengerian added a comment to D3253: Remove Schnorr activation.

Did another pass over the Diff today, it looks good to me.

Jun 8 2019, 04:17
Mengerian added inline comments to D3253: Remove Schnorr activation.
Jun 8 2019, 03:03

Jun 7 2019

Mengerian created D3258: Update timing.json Segwit Recovery functional test name.
Jun 7 2019, 19:04
Mengerian added inline comments to D3253: Remove Schnorr activation.
Jun 7 2019, 06:21
D3255: Remove unused great wall activation code is now accepted and ready to land.

Looks good to me.

Jun 7 2019, 06:00
D3253: Remove Schnorr activation now requires changes to proceed.

Looks good overall, I noted a couple minor nits.

Jun 7 2019, 04:59
Mengerian added a revision to T653: Clean up past upgrades: D3253: Remove Schnorr activation.
Jun 7 2019, 03:58
Mengerian added a task to D3253: Remove Schnorr activation: T653: Clean up past upgrades.
Jun 7 2019, 03:58

Jun 5 2019

Mengerian committed rABCeeed14a7916c: Clean up Segwit Recovery feature (authored by Mengerian).
Clean up Segwit Recovery feature
Jun 5 2019, 20:28
Mengerian closed D3194: Clean up Segwit Recovery feature.
Jun 5 2019, 20:28
Mengerian added reviewers for D3194: Clean up Segwit Recovery feature: markblundeberg, Fabien, jasonbcox.

Add more reviewers

Jun 5 2019, 05:17
Mengerian added a comment to D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.

Abandon in favor of D3194

Jun 5 2019, 05:10
Mengerian added a comment to D3148: Invert meaning of Segwit Recovery flag..

Abandon in favor of D3194

Jun 5 2019, 05:07
Mengerian added a comment to D3065: Remove segwit recovery activation.

Abandon in favor of D3194

Jun 5 2019, 05:07
Mengerian added a comment to D3148: Invert meaning of Segwit Recovery flag..

Abandon in favor of D3194

Jun 5 2019, 05:06
Mengerian added a comment to D3194: Clean up Segwit Recovery feature.

Update script test comments per Mark's suggestion
Rebase

Jun 5 2019, 05:04

Jun 4 2019

Mengerian added a revision to T653: Clean up past upgrades: D3194: Clean up Segwit Recovery feature.
Jun 4 2019, 04:27
Mengerian added a task to D3194: Clean up Segwit Recovery feature: T653: Clean up past upgrades.
Jun 4 2019, 04:27
Mengerian added a comment to D3065: Remove segwit recovery activation.

@deadalnix I don't have a clear understanding of what you want.

Jun 4 2019, 04:01
Mengerian added a comment to D3194: Clean up Segwit Recovery feature.

This is the same as D3148, D3065, and D3160 squashed into one change.

Jun 4 2019, 03:55
Mengerian created D3194: Clean up Segwit Recovery feature.
Jun 4 2019, 03:54

May 31 2019

Mengerian updated the diff for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.

Update test plan
Improve description
Rebase on D3065

May 31 2019, 06:01
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Rename test class

May 31 2019, 05:57
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Rename functional test

May 31 2019, 04:28

May 30 2019

Mengerian updated the diff for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.

Rebase on D3065

May 30 2019, 21:56
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Restore functional test portion that test accepting blocks containing Segwit recovery transactions.

May 30 2019, 21:53
Mengerian updated the diff for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.

Add dependency to description.

May 30 2019, 17:48
Herald added a reviewer for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag: Restricted Project.
May 30 2019, 17:47
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Edit description.

May 30 2019, 17:41
Mengerian updated the diff for D3065: Remove segwit recovery activation.

Change functional test to run at "current" time.
Rebase on updated D3248

May 30 2019, 17:39
Mengerian updated the diff for D3148: Invert meaning of Segwit Recovery flag..

Add unit tests for "0 left on stack" case with segwit recovery disallowed.
Clarify descriptions of script tests so that it's easier to see tests with the flag enabled.

May 30 2019, 17:37
Mengerian committed rABCa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test
May 30 2019, 16:40
Mengerian closed D3144: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test.
May 30 2019, 16:40
Mengerian closed D3149: Add post-upgrade testnet checkpoint.
May 30 2019, 16:39
Mengerian committed rABC282991621095: Add post-upgrade testnet checkpoint (authored by Mengerian).
Add post-upgrade testnet checkpoint
May 30 2019, 16:39

May 29 2019

Mengerian added inline comments to D3148: Invert meaning of Segwit Recovery flag..
May 29 2019, 19:42
Mengerian added a comment to D3148: Invert meaning of Segwit Recovery flag..

@deadalnix I am trying to follow the step you outlined here: https://reviews.bitcoinabc.org/D3065#72372

May 29 2019, 15:36
Mengerian added a task to D3148: Invert meaning of Segwit Recovery flag.: T653: Clean up past upgrades.
May 29 2019, 15:11
Mengerian added a revision to T653: Clean up past upgrades: D3148: Invert meaning of Segwit Recovery flag..
May 29 2019, 15:11
Mengerian added a revision to T653: Clean up past upgrades: D3149: Add post-upgrade testnet checkpoint.
May 29 2019, 15:11
Mengerian added a task to D3149: Add post-upgrade testnet checkpoint: T653: Clean up past upgrades.
May 29 2019, 15:11
Mengerian added a revision to T653: Clean up past upgrades: D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp.
May 29 2019, 15:10
Mengerian added a task to D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp: T653: Clean up past upgrades.
May 29 2019, 15:10
Mengerian abandoned D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp.
May 29 2019, 15:10