Differential D15896

[e.cash] Add Staking to get-ecash page
ClosedPublic
Actions

Authored by Mengerian on Fri, Apr 5, 02:28.

Details

Reviewers

johnkuney

Group Reviewers

Restricted Project

Commits

rABC878efd7a4ff8: [e.cash] Add Staking to get-ecash page

Test Plan

Run it locally, check link

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Mengerian created this revision.Fri, Apr 5, 02:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Apr 5, 02:28

Mengerian requested review of this revision.Fri, Apr 5, 02:28

Harbormaster completed remote builds in B28336: Diff 46851.Fri, Apr 5, 02:28

Use ' for the apostrophe

Harbormaster completed remote builds in B28337: Diff 46852.Fri, Apr 5, 02:31

@johnkuney Could you help me make this look better? Maybe alternate the positioning of the image/text from the mining section above?

I sure can, its a bit trickier than it should be though. The image is absolutely positioned because it had a ton of whitespace around it, so I had to position it weirdly so it can be bigger.

I say lets land this one as is, and I'll touch it up next

This revision is now accepted and ready to land.Fri, Apr 5, 17:17

In D15896#359564, @johnkuney wrote:

I sure can, its a bit trickier than it should be though. The image is absolutely positioned because it had a ton of whitespace around it, so I had to position it weirdly so it can be bigger.

I say lets land this one as is, and I'll touch it up next

OK will do

Closed by commit rABC878efd7a4ff8: [e.cash] Add Staking to get-ecash page (authored by Mengerian). · Explain WhyFri, Apr 5, 19:59

This revision was automatically updated to reflect the committed changes.

Mengerian added a commit: rABC878efd7a4ff8: [e.cash] Add Staking to get-ecash page.