Page MenuHomePhabricator

[e.cash] Add Staking to get-ecash page
ClosedPublic

Authored by Mengerian on Apr 5 2024, 02:28.

Details

Reviewers
johnkuney
Group Reviewers
Restricted Project
Commits
rABC878efd7a4ff8: [e.cash] Add Staking to get-ecash page
Test Plan

Run it locally, check link

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-get-ecash-staking
Lint
Lint Errors
SeverityLocationCodeMessage
Errorweb/e.cash/pages/get-ecash.js:153ESLINTreact/no-unescaped-entities
Unit
No Test Coverage
Build Status
Buildable 28336
Build 56214: Build Diff
Build 56213: arc lint + arc unit

Event Timeline

Use ' for the apostrophe

@johnkuney Could you help me make this look better? Maybe alternate the positioning of the image/text from the mining section above?

I sure can, its a bit trickier than it should be though. The image is absolutely positioned because it had a ton of whitespace around it, so I had to position it weirdly so it can be bigger.

I say lets land this one as is, and I'll touch it up next

This revision is now accepted and ready to land.Apr 5 2024, 17:17

I sure can, its a bit trickier than it should be though. The image is absolutely positioned because it had a ton of whitespace around it, so I had to position it weirdly so it can be bigger.

I say lets land this one as is, and I'll touch it up next

OK will do

This revision was automatically updated to reflect the committed changes.