Page MenuHomePhabricator
Differential D15892

[e.cash] Prevent navbar api calls on every page load
ClosedPublic
Actions

Authored by johnkuney on Thu, Apr 4, 16:49.

Details

Reviewers
Mengerian
Group Reviewers
Restricted Project
Commits
rABC5c7f9ad23e59: [e.cash] Prevent navbar api calls on every page load
Summary

I noticed the API call for the navbar price display was getting fired on every page load. You can see it happen as the price in the navbar will disappear for a moment when you change pages.

By moving this call to a context provider and passing it through the top app level, we can expose it to the navbar without inefficient api calls.

Test Plan

preview the site and check everything still looks and functions the same, but you should only see the price call happen once, and the numbers wont disappear for a second when you change pages

Note: if you are running locally you'll probably see the call fired twice while in dev mode due to "strict-mode" being on in dev mode

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johnkuney created this revision.Thu, Apr 4, 16:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Apr 4, 16:49
johnkuney requested review of this revision.Thu, Apr 4, 16:49
Harbormaster completed remote builds in B28330: Diff 46840.Thu, Apr 4, 16:49
Mengerian added a subscriber: Mengerian.Thu, Apr 4, 16:55

@bot preview-e.cash

teamcity awarded a token.Thu, Apr 4, 16:55

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41875 for the next 60 minutes.

Mengerian requested changes to this revision.Thu, Apr 4, 17:16

No, the upgrade announcement needs to be there. We literally just released the upgrade release today.

What would be nice is to have an additional countdown for the halving. But the upgrade banner needs to stay.

This revision now requires changes to proceed.Thu, Apr 4, 17:16
johnkuney updated this revision to Diff 46848.Thu, Apr 4, 21:40

updating to include blocks left and upgrade notice as discussed

Harbormaster completed remote builds in B28335: Diff 46848.Thu, Apr 4, 21:40
johnkuney edited the summary of this revision. (Show Details)Thu, Apr 4, 21:47
johnkuney edited the test plan for this revision. (Show Details)
Mengerian added a comment.Thu, Apr 4, 23:38

@bot preview-e.cash

teamcity updated a token.Thu, Apr 4, 23:38

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41377 for the next 60 minutes.

Mengerian requested changes to this revision.Fri, Apr 5, 01:00

The preview looks fine, but the Diff is a bit confusing to review because it seems to be doing to logically distinct things: 1) reorganizing code into "getNavbarData" and 2) adding the halving countdown. Could you separate it into 2 diffs?

web/e.cash/components/navbar/getNavbarData.js
1 ↗(On Diff #46848)
This revision now requires changes to proceed.Fri, Apr 5, 01:00
johnkuney updated this revision to Diff 46883.Fri, Apr 5, 15:42
johnkuney edited the summary of this revision. (Show Details)
johnkuney edited the test plan for this revision. (Show Details)

remove blockheight info

Harbormaster completed remote builds in B28360: Diff 46883.Fri, Apr 5, 15:42
johnkuney updated this revision to Diff 46884.Fri, Apr 5, 15:43

copyright year

Harbormaster completed remote builds in B28361: Diff 46884.Fri, Apr 5, 15:43
johnkuney updated this revision to Diff 46885.Fri, Apr 5, 15:45

rebase with master

Harbormaster completed remote builds in B28362: Diff 46885.Fri, Apr 5, 15:45
johnkuney updated this revision to Diff 46886.Fri, Apr 5, 15:48

remove unrelated code

Harbormaster completed remote builds in B28363: Diff 46886.Fri, Apr 5, 15:48
johnkuney updated this revision to Diff 46887.Fri, Apr 5, 15:51

edit component path

Harbormaster completed remote builds in B28364: Diff 46887.Fri, Apr 5, 15:51
johnkuney added a comment.Fri, Apr 5, 15:52

yeah fair enough, I've reduced this one to just the api context provider, will add the new banner next. Will update this title and description

johnkuney retitled this revision from [e.cash] Add halving info to announcement bar to [e.cash] Prevent navbar api calls on every page load.Fri, Apr 5, 15:58
johnkuney edited the summary of this revision. (Show Details)
johnkuney edited the test plan for this revision. (Show Details)
Mengerian added a comment.Fri, Apr 5, 19:52

@bot preview-e.cash

teamcity updated a token.Fri, Apr 5, 19:52

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41449 for the next 60 minutes.

Mengerian accepted this revision.Fri, Apr 5, 19:56
This revision is now accepted and ready to land.Fri, Apr 5, 19:56
Closed by commit rABC5c7f9ad23e59: [e.cash] Prevent navbar api calls on every page load (authored by johnkuney). · Explain WhyFri, Apr 5, 21:13
This revision was automatically updated to reflect the committed changes.
johnkuney added a commit: rABC5c7f9ad23e59: [e.cash] Prevent navbar api calls on every page load.

Revision Contents
Changeset List

PathSize
web/
e.cash/
components/
navbar/
33 lines
16 lines
pages/
43 lines

Diff 46892

View Options

web/e.cash/components/navbar/getNavbarData.js

Loading...
View Options

web/e.cash/components/navbar/index.js

Loading...
View Options

web/e.cash/pages/_app.js

Loading...