Differential D15892
[e.cash] Prevent navbar api calls on every page load Authored by johnkuney on Apr 4 2024, 16:49.
Details
I noticed the API call for the navbar price display was getting fired on every page load. You can see it happen as the price in the navbar will disappear for a moment when you change pages. By moving this call to a context provider and passing it through the top app level, we can expose it to the navbar without inefficient api calls. preview the site and check everything still looks and functions the same, but you should only see the price call happen once, and the numbers wont disappear for a second when you change pages Note: if you are running locally you'll probably see the call fired twice while in dev mode due to "strict-mode" being on in dev mode
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed. Comment Actions No, the upgrade announcement needs to be there. We literally just released the upgrade release today. What would be nice is to have an additional countdown for the halving. But the upgrade banner needs to stay. Comment Actions Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed. Comment Actions The preview looks fine, but the Diff is a bit confusing to review because it seems to be doing to logically distinct things: 1) reorganizing code into "getNavbarData" and 2) adding the halving countdown. Could you separate it into 2 diffs?
Comment Actions yeah fair enough, I've reduced this one to just the api context provider, will add the new banner next. Will update this title and description Comment Actions Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed. | ||||||||||||||||||||