Differential D16048

Reduce port range in functional tests
ClosedPublic
Actions

Authored by Fabien on Wed, Apr 24, 13:57.

Tags

None

Subscribers

None

Tokens

"Like" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC3b3c5674a35b: Reduce port range in functional tests

Summary

So that we never use port number > 32000.
Docker uses ports 32768-65535 for its own use (containerd) so there is a risk of collision that can be avoided by reducing the range.

Test Plan

In various conditions, with chronik enabled (the only tests that can reach ports > 28000):

ninja check-functional

See CI calls in the comments in this diff.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Wed, Apr 24, 13:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 24, 13:57

@bot build-linux32 build-linux64 build-linux-arm build-linux-aarch64 build-chronik build-chronik-plugins

teamcity awarded a token.Wed, Apr 24, 13:57

Harbormaster completed remote builds in B28734: Diff 47401.Wed, Apr 24, 14:28

@bot build-linux32 build-linux64 build-linux-arm build-linux-aarch64 build-chronik build-chronik-plugins

teamcity updated a token.Wed, Apr 24, 14:39

@bot build-linux32 build-linux64 build-linux-arm build-linux-aarch64 build-chronik build-chronik-plugins

teamcity updated a token.Wed, Apr 24, 14:53

@bot build-linux32 build-linux64 build-linux-arm build-linux-aarch64 build-chronik build-chronik-plugins

teamcity updated a token.Wed, Apr 24, 15:19

@bot build-linux32 build-linux64 build-linux-arm build-linux-aarch64 build-chronik build-chronik-plugins

teamcity updated a token.Wed, Apr 24, 15:38

Fabien published this revision for review.Wed, Apr 24, 15:50

Fabien edited the summary of this revision. (Show Details)

Fabien edited the test plan for this revision. (Show Details)

PiRK accepted this revision.Wed, Apr 24, 20:36

This revision is now accepted and ready to land.Wed, Apr 24, 20:36

Closed by commit rABC3b3c5674a35b: Reduce port range in functional tests (authored by Fabien). · Explain WhyThu, Apr 25, 06:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3b3c5674a35b: Reduce port range in functional tests.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

2 lines

Diff 47412

test/functional/test_framework/util.py

Loading...