Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (185 w, 2 d)

Recent Activity

Today

PiRK accepted D15499: [Cashtab] Update loadCashtabState to not take params.
Sat, Feb 24, 12:24

Yesterday

PiRK accepted D15524: [Cashtab] Upgrade some dev dependencies used in testing.
Fri, Feb 23, 19:16
PiRK accepted D15519: [Cashtab] Upgrade slpv1 send txs.
Fri, Feb 23, 19:16
PiRK accepted D15520: [ecash-coinselect] Support specified input utxos.
Fri, Feb 23, 19:14
PiRK added inline comments to D15519: [Cashtab] Upgrade slpv1 send txs.
Fri, Feb 23, 18:50
PiRK planned changes to D15522: [electrum] bump docker to ubuntu 20.04 for AppImage building.

still checking why the build does not work on other machines. Testing a new python version.

Fri, Feb 23, 15:57
PiRK updated the diff for D15522: [electrum] bump docker to ubuntu 20.04 for AppImage building.

rebase

Fri, Feb 23, 15:56
PiRK closed D15523: [doc] document the procedure to backport from subtree projects.
Fri, Feb 23, 14:10
PiRK committed rABC3f04a19d3094: [doc] document the procedure to backport from subtree projects (authored by PiRK).
[doc] document the procedure to backport from subtree projects
Fri, Feb 23, 14:10
PiRK accepted D15501: [chronik-client] Support new tokenId endpoints.

Code looks good and test coverage seems enough, I just pointed to two nits.

Fri, Feb 23, 13:58
PiRK added a comment to D15522: [electrum] bump docker to ubuntu 20.04 for AppImage building.

not sure if there are some deps I am missing or?

OS
Pop!_OS 22.04 LTS

Ran

cd electrum
./contrib/build-linux/appimage/build.sh
Fri, Feb 23, 13:29
PiRK accepted D15521: [Cashtab] Notification instead of modal for upgrades.
Fri, Feb 23, 10:40
PiRK accepted D15518: [ecash-coinselect] Add support for utxo format of chronik-client in-node.
Fri, Feb 23, 10:36
PiRK accepted D15517: [Cashtab] Include mocked chronik for render tests of useWallet hook.
Fri, Feb 23, 10:21
PiRK accepted D15509: [Cashtab] Standardize and improve Home integration tests.
Fri, Feb 23, 10:18
PiRK updated the diff for D15523: [doc] document the procedure to backport from subtree projects.

consistent indentation (no tabs, always 4 spaces)

Fri, Feb 23, 09:29
PiRK requested review of D15523: [doc] document the procedure to backport from subtree projects.
Fri, Feb 23, 09:27
PiRK requested review of D15522: [electrum] bump docker to ubuntu 20.04 for AppImage building.
Fri, Feb 23, 09:17

Thu, Feb 22

PiRK closed D15504: doc: Simplify guix install doc, after 1.4 release.
Thu, Feb 22, 16:06
PiRK committed rABC36ac73846dd3: doc: Simplify guix install doc, after 1.4 release (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
doc: Simplify guix install doc, after 1.4 release
Thu, Feb 22, 16:06
PiRK accepted D15516: [Cashtab] Better helper function to clear localforage between tests.
Thu, Feb 22, 15:23
PiRK accepted D15510: [Cashtab] Upgrade SLPv1 genesis txs.
Thu, Feb 22, 11:58
PiRK accepted D15508: [Cashtab] Improve useWalletStorage tests.
Thu, Feb 22, 11:49
PiRK updated the diff for D15504: doc: Simplify guix install doc, after 1.4 release.

renumber lust if steps in Workaround 2

Thu, Feb 22, 07:56
PiRK accepted D15507: [cmake] Fetch Corrosion.
Thu, Feb 22, 07:12

Wed, Feb 21

PiRK accepted D15507: [cmake] Fetch Corrosion.

@bot build-linux-arm

Wed, Feb 21, 19:07
PiRK closed D15503: guix: switch from guix environment to guix shell.
Wed, Feb 21, 19:05
PiRK committed rABCdf440c7008a1: guix: switch from guix environment to guix shell (authored by fanquake <fanquake@gmail.com>).
guix: switch from guix environment to guix shell
Wed, Feb 21, 19:05
PiRK updated the summary of D15503: guix: switch from guix environment to guix shell.
Wed, Feb 21, 19:03
PiRK requested changes to D15499: [Cashtab] Update loadCashtabState to not take params.

the tests are failing now

Wed, Feb 21, 15:26
PiRK requested review of D15504: doc: Simplify guix install doc, after 1.4 release.
Wed, Feb 21, 13:22
PiRK requested review of D15503: guix: switch from guix environment to guix shell.
Wed, Feb 21, 13:05
PiRK accepted D15502: [ci] Also remove .walletlock files from the artifacts.
Wed, Feb 21, 10:07
PiRK accepted D15500: [chronik-client] Add support for getting tx history and utxos by address.
Wed, Feb 21, 08:36
PiRK accepted D15499: [Cashtab] Update loadCashtabState to not take params.
Wed, Feb 21, 08:24
PiRK accepted D15498: [Cashtab] Improve rendering of from contact name in tx history.
Wed, Feb 21, 08:18
PiRK accepted D15492: [Cashtab] Combine app integration tests into one file.
Wed, Feb 21, 08:14
PiRK added a comment to D15492: [Cashtab] Combine app integration tests into one file.

OK. Confirmed to be move-mostly ( git show --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space)

Wed, Feb 21, 08:13

Tue, Feb 20

PiRK accepted D15496: [packaging] Enforce python >= 3.9 for the debian/ubuntu packages.
Tue, Feb 20, 14:40
PiRK abandoned D15477: [lint] fix a typehint to keep supporting python 3.8 for linters.
Tue, Feb 20, 10:19
PiRK accepted D15493: [Cashtab] Pass contactList to tx history using updated format.
Tue, Feb 20, 10:19
PiRK closed D15490: guix: update time-machine.
Tue, Feb 20, 10:18
PiRK committed rABC80661d532397: guix: update time-machine (authored by fanquake <fanquake@gmail.com>).
guix: update time-machine
Tue, Feb 20, 10:18
PiRK accepted D15495: Bump version to 0.28.10.
Tue, Feb 20, 08:29
teamcity awarded D15491: macOS: Bump minimum required runtime version and prepare for building with upstream LLVM a Doubloon token.
Tue, Feb 20, 08:19

Mon, Feb 19

teamcity awarded D15491: macOS: Bump minimum required runtime version and prepare for building with upstream LLVM a Piece of Eight token.
Mon, Feb 19, 20:29
PiRK accepted D15489: [CI] Remove .lock files if some are persistent after the build..
Mon, Feb 19, 20:27
teamcity awarded D15491: macOS: Bump minimum required runtime version and prepare for building with upstream LLVM a Haypence token.
Mon, Feb 19, 16:21
PiRK closed D15488: guix: consolidate glibc & gcc packages.
Mon, Feb 19, 14:38
PiRK committed rABC4e08bb9a2ad3: guix: consolidate glibc & gcc packages (authored by fanquake <fanquake@gmail.com>).
guix: consolidate glibc & gcc packages
Mon, Feb 19, 14:38
PiRK requested review of D15490: guix: update time-machine.
Mon, Feb 19, 14:27
PiRK closed D15485: guix: pre time-machine bump changes (Windows).
Mon, Feb 19, 13:13
PiRK committed rABCd53bb4b19bd0: guix: pre time-machine bump changes (Windows) (authored by fanquake <fanquake@gmail.com>).
guix: pre time-machine bump changes (Windows)
Mon, Feb 19, 13:13
PiRK requested review of D15488: guix: consolidate glibc & gcc packages.
Mon, Feb 19, 12:39
PiRK requested review of D15485: guix: pre time-machine bump changes (Windows).
Mon, Feb 19, 11:30

Sun, Feb 18

PiRK abandoned D15433: fix more file permissions and shebangs.
Sun, Feb 18, 10:54
PiRK abandoned D15439: [lint] remove shebangs from python files that are not scripts.
Sun, Feb 18, 10:54
PiRK updated the summary of D15477: [lint] fix a typehint to keep supporting python 3.8 for linters.
Sun, Feb 18, 08:21
PiRK requested review of D15477: [lint] fix a typehint to keep supporting python 3.8 for linters.
Sun, Feb 18, 08:19
PiRK closed D15457: [guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu.
Sun, Feb 18, 08:11
PiRK committed rABCa0c976bbde8f: [guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu (authored by PiRK).
[guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu
Sun, Feb 18, 08:11

Sat, Feb 17

teamcity awarded D15457: [guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu a Haypence token.
Sat, Feb 17, 14:50
PiRK added a comment to D15457: [guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu.

@bot gitian-linux

Sat, Feb 17, 14:50
PiRK published D15457: [guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu for review.
Sat, Feb 17, 14:49

Fri, Feb 16

PiRK accepted D15471: [cmake] Enable noexecstack if hardening is set.
Fri, Feb 16, 17:37
PiRK closed D15458: lint: add new python script to check file names and permissions.
Fri, Feb 16, 16:43
PiRK committed rABC0077f4adad4c: lint: add new python script to check file names and permissions (authored by windsok <windsok@protonmail.com>).
lint: add new python script to check file names and permissions
Fri, Feb 16, 16:43
PiRK accepted D15470: [guix] Don't look for dependencies when building the source package.
Fri, Feb 16, 15:52
PiRK accepted D15469: [depends] Properly remove the native protobuf libraries.

This fixes the aarch64 guix build in D15457

Fri, Feb 16, 15:49
PiRK updated the diff for D15458: lint: add new python script to check file names and permissions.

address review comments.

Fri, Feb 16, 15:20
PiRK accepted D15464: [Cashtab] Simplify and standardize Configure integration tests.
Fri, Feb 16, 11:38
PiRK accepted D15459: [guix] Build for windows.
Fri, Feb 16, 11:19
PiRK accepted D15462: [Chronik] Add `Display` impl for `ScriptVariant`.
Fri, Feb 16, 09:15
PiRK accepted D15431: [Cashtab] Create a standardized wrapper for test rendering.

I don't really understand the issue with toStrictEqual, but it seems that toEqual is a good enough test for comparing these simple contact data structures.
Other than that, this diff adds test coverage and removes boilerplate code, which is all good.

Fri, Feb 16, 09:12
PiRK added inline comments to D15461: [chronik] Fix websocket subscription in tests.
Fri, Feb 16, 08:46
PiRK accepted D15461: [chronik] Fix websocket subscription in tests.
Fri, Feb 16, 08:44

Thu, Feb 15

PiRK published D15458: lint: add new python script to check file names and permissions for review.
Thu, Feb 15, 19:25
PiRK requested changes to D15459: [guix] Build for windows.
Thu, Feb 15, 19:25
PiRK closed D15448: [lint] remove executable flag and shebang on non-script python files.
Thu, Feb 15, 16:50
PiRK committed rABC6d1e9d0fb5d5: [lint] remove executable flag and shebang on non-script python files (authored by PiRK).
[lint] remove executable flag and shebang on non-script python files
Thu, Feb 15, 16:50
PiRK accepted D15429: [Cashtab] Helper method for initializing integration tests.
Thu, Feb 15, 13:17
PiRK accepted D15454: [chronik] Bump timeout for chronik_ws_ordering.
Thu, Feb 15, 13:12
PiRK accepted D15455: [CI] Build the chronik plugins for the automated timing update.
Thu, Feb 15, 13:12
PiRK accepted D15453: [chronik] Build the experimental release for all Linux platforms.
Thu, Feb 15, 13:11

Wed, Feb 14

PiRK updated the diff for D15448: [lint] remove executable flag and shebang on non-script python files.

rebase with hash fix from D15447

Wed, Feb 14, 16:21
PiRK closed D15449: [electrum] make the python interpreter explicit when running setup.py.
Wed, Feb 14, 16:19
PiRK committed rABC43a86462b990: [electrum] make the python interpreter explicit when running setup.py (authored by PiRK).
[electrum] make the python interpreter explicit when running setup.py
Wed, Feb 14, 16:19
PiRK closed D15446: [lint] relax the PythonShebangLinter and apply it on electrum.
Wed, Feb 14, 16:19
PiRK committed rABC4496d61f5582: [lint] relax the PythonShebangLinter and apply it on electrum (authored by PiRK).
[lint] relax the PythonShebangLinter and apply it on electrum
Wed, Feb 14, 16:18
PiRK planned changes to D15448: [lint] remove executable flag and shebang on non-script python files.

checking the infra outage, it could very well be related

Wed, Feb 14, 16:14
PiRK published D15448: [lint] remove executable flag and shebang on non-script python files for review.
Wed, Feb 14, 14:43
PiRK added inline comments to D15446: [lint] relax the PythonShebangLinter and apply it on electrum.
Wed, Feb 14, 14:42
PiRK updated the diff for D15446: [lint] relax the PythonShebangLinter and apply it on electrum.

revert the test order to skip the expensive operation on most files

Wed, Feb 14, 14:36
PiRK accepted D15447: [CI deps] Fix hash in nodejs install script.

And

$ touch file.txt
$ sha256sum file.txt
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  file.txt
Wed, Feb 14, 13:03
PiRK requested review of D15449: [electrum] make the python interpreter explicit when running setup.py.
Wed, Feb 14, 12:44
PiRK added inline comments to D15446: [lint] relax the PythonShebangLinter and apply it on electrum.
Wed, Feb 14, 11:39
PiRK updated the test plan for D15446: [lint] relax the PythonShebangLinter and apply it on electrum.
Wed, Feb 14, 11:33
PiRK requested review of D15446: [lint] relax the PythonShebangLinter and apply it on electrum.
Wed, Feb 14, 10:29
PiRK accepted D15445: Revert "[guix] disable BIP70 for the guix build".
Wed, Feb 14, 09:19
PiRK added inline comments to D15444: [chronik-client] Support for broadcast-tx and broadcast-txs endpoints.
Wed, Feb 14, 09:00