Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (11 w, 11 h)

Recent Activity

Yesterday

PiRK closed D8016: [backport#16845] test: Add notes on how to generate data/wallets/high_minversion.
Wed, Oct 21, 17:50
PiRK committed rABC51fcead18640: [backport#16845] test: Add notes on how to generate data/wallets/high_minversion (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16845] test: Add notes on how to generate data/wallets/high_minversion
Wed, Oct 21, 17:50
PiRK requested review of D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..

It's complete know. It took me some time to understand how to make the tests work for ABC.

Wed, Oct 21, 17:30
PiRK retitled D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137. from New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137. to [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Wed, Oct 21, 16:59
PiRK retitled D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code. from Added comments referencing multiple CVEs in tests and production code. to [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..
Wed, Oct 21, 16:58
PiRK added a comment to D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..

For the record, I am horrified by how this PR uses a metaclass, type and __subclasses__ to build basic python classes. This is why standard tools cannot detect dead code :)

Wed, Oct 21, 14:35
PiRK requested review of D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Wed, Oct 21, 14:32
PiRK closed D8017: [backport#16865] test: add some unit tests for merkle.cpp.
Wed, Oct 21, 12:27
PiRK committed rABC48baf4ea7c59: [backport#16865] test: add some unit tests for merkle.cpp (authored by soroosh-sdi <soroosh.sardari@gmail.com>).
[backport#16865] test: add some unit tests for merkle.cpp
Wed, Oct 21, 12:27
PiRK updated the summary of D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..
Wed, Oct 21, 12:25
PiRK updated the diff for D8016: [backport#16845] test: Add notes on how to generate data/wallets/high_minversion.

Core -> ABC

Wed, Oct 21, 12:18
PiRK added a comment to D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..

I'm still working on the second commit of that PR. I thought it would be easy, but it isn't (new test not passing). Sorry about that, I should not have sent that first diff so fast.

Wed, Oct 21, 12:05
PiRK updated the diff for D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..

address feedback about line breaks

Wed, Oct 21, 11:30
PiRK updated the summary of D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..
Wed, Oct 21, 11:29
PiRK updated the diff for D8017: [backport#16865] test: add some unit tests for merkle.cpp.

add missing braces

Wed, Oct 21, 09:39
PiRK requested review of D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..
Wed, Oct 21, 09:19
PiRK requested review of D8017: [backport#16865] test: add some unit tests for merkle.cpp.
Wed, Oct 21, 08:25
PiRK requested review of D8016: [backport#16845] test: Add notes on how to generate data/wallets/high_minversion.
Wed, Oct 21, 07:01
PiRK closed D8008: [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase().
Wed, Oct 21, 05:07
PiRK committed rABC5c69e06912f6: [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase() (authored by Jon Atack <jon@atack.com>).
[backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase()
Wed, Oct 21, 05:07

Tue, Oct 20

PiRK closed D8007: [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog.
Tue, Oct 20, 19:03
PiRK committed rABC334559d6fb45: [backport#16822 2/3] gui: fix passphrase labels/tooltip in… (authored by Jon Atack <jon@atack.com>).
[backport#16822 2/3] gui: fix passphrase labels/tooltip in…
Tue, Oct 20, 19:03
PiRK updated the diff for D8008: [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase().

rebase

Tue, Oct 20, 18:56
PiRK closed D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Tue, Oct 20, 18:55
PiRK committed rABC075c2361622f: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys() (authored by Jon Atack <jon@atack.com>).
[backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys()
Tue, Oct 20, 18:55
PiRK closed D7999: [backport#16224 5/5] util: Cleanup translation.h.
Tue, Oct 20, 18:25
PiRK committed rABC626a4fc628fc: [backport#16224 5/5] util: Cleanup translation.h (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[backport#16224 5/5] util: Cleanup translation.h
Tue, Oct 20, 18:25
PiRK closed D7998: [backport#16224 4/5] doc: Do not translate technical or extremely rare errors.
Tue, Oct 20, 18:04
PiRK committed rABC8ad96feb525e: [backport#16224 4/5] doc: Do not translate technical or extremely rare errors (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[backport#16224 4/5] doc: Do not translate technical or extremely rare errors
Tue, Oct 20, 18:04
PiRK closed D8010: [backport#16847] doc: add comments clarifying how local services are advertised.
Tue, Oct 20, 18:04
PiRK committed rABCfbda81eaa4b4: [backport#16847] doc: add comments clarifying how local services are advertised (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#16847] doc: add comments clarifying how local services are advertised
Tue, Oct 20, 18:04
PiRK updated the diff for D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().

rebase

Tue, Oct 20, 17:53
PiRK updated the diff for D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().

fix missed encrypt -> isEncryptWalletChecked

Tue, Oct 20, 16:11
PiRK requested review of D8010: [backport#16847] doc: add comments clarifying how local services are advertised.
Tue, Oct 20, 15:58
PiRK closed D7997: [backport#16224 3/5] Make InitError bilingual.
Tue, Oct 20, 15:51
PiRK committed rABC5b1bc64e8e32: [backport#16224 3/5] Make InitError bilingual (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[backport#16224 3/5] Make InitError bilingual
Tue, Oct 20, 15:50
PiRK retitled D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys() from [backport#16822]gui: rename encrypt(), blank(), disablePrivateKeys() to [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Tue, Oct 20, 15:44
PiRK updated the diff for D7999: [backport#16224 5/5] util: Cleanup translation.h.

rebase

Tue, Oct 20, 15:44
PiRK requested review of D8008: [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase().
Tue, Oct 20, 15:40
PiRK retitled D8007: [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog from gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog to [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog.
Tue, Oct 20, 15:37
PiRK requested review of D8007: [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog.
Tue, Oct 20, 15:36
PiRK updated the summary of D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Tue, Oct 20, 15:33
PiRK requested review of D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Tue, Oct 20, 15:29
PiRK closed D7987: tests: Remove unused testing code.
Tue, Oct 20, 14:57
PiRK committed rABC6ef2cd8aeae1: tests: Remove unused testing code (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Remove unused testing code
Tue, Oct 20, 14:57
PiRK closed D7981: p2p: Remove BIP61 reject messages.
Tue, Oct 20, 14:34
PiRK committed rABCeea74d5db50f: p2p: Remove BIP61 reject messages (authored by MarcoFalke <falke.marco@gmail.com>).
p2p: Remove BIP61 reject messages
Tue, Oct 20, 14:34
PiRK closed D8003: Elaborate on the need to re-login on Debian-based systems to use tor following usermod.
Tue, Oct 20, 14:33
PiRK committed rABCcd6d4b9c6762: Elaborate on the need to re-login on Debian-based systems to use tor following… (authored by clashicly <35277077+clashicly@users.noreply.github.com>).
Elaborate on the need to re-login on Debian-based systems to use tor following…
Tue, Oct 20, 14:33
PiRK closed D8002: doc: describe onlynet option in doc/tor.md.
Tue, Oct 20, 14:23
PiRK committed rABC27f0ad064662: doc: describe onlynet option in doc/tor.md (authored by Jon Atack <jon@atack.com>).
doc: describe onlynet option in doc/tor.md
Tue, Oct 20, 14:23
PiRK closed D8001: Less confusing documentation for `torpassword`.
Tue, Oct 20, 14:22
PiRK committed rABC227d162b2a5a: Less confusing documentation for `torpassword` (authored by Chakib Benziane <chakib.benz@gmail.com>).
Less confusing documentation for `torpassword`
Tue, Oct 20, 14:22
PiRK updated the diff for D7998: [backport#16224 4/5] doc: Do not translate technical or extremely rare errors.

rebase

Tue, Oct 20, 14:18
PiRK updated the diff for D7997: [backport#16224 3/5] Make InitError bilingual.

rebase

Tue, Oct 20, 14:17
PiRK closed D7986: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual.
Tue, Oct 20, 14:15
PiRK committed rABC44c87af6b56f: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual
Tue, Oct 20, 14:15
PiRK closed D7985: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.
Tue, Oct 20, 14:12
PiRK committed rABC4ca53cf0090b: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message
Tue, Oct 20, 14:12
PiRK closed D8000: added note that control port must be enabled and how to do that in torrc config file.
Tue, Oct 20, 14:11
PiRK committed rABC3df6b8c5d602: added note that control port must be enabled and how to do that in torrc config… (authored by Jordan Baczuk <Jordan.Baczuk@gmail.com>).
added note that control port must be enabled and how to do that in torrc config…
Tue, Oct 20, 14:10
PiRK updated the summary of D7999: [backport#16224 5/5] util: Cleanup translation.h.
Tue, Oct 20, 14:08
PiRK requested review of D8003: Elaborate on the need to re-login on Debian-based systems to use tor following usermod.
Tue, Oct 20, 13:26
PiRK requested review of D8002: doc: describe onlynet option in doc/tor.md.
Tue, Oct 20, 13:23
PiRK requested review of D8001: Less confusing documentation for `torpassword`.
Tue, Oct 20, 13:15
PiRK updated the diff for D8000: added note that control port must be enabled and how to do that in torrc config file.

s/Core/ABC/

Tue, Oct 20, 13:11
PiRK requested review of D8000: added note that control port must be enabled and how to do that in torrc config file.
Tue, Oct 20, 13:10
PiRK updated the diff for D7997: [backport#16224 3/5] Make InitError bilingual.

rebase

Tue, Oct 20, 11:11
PiRK requested review of D7999: [backport#16224 5/5] util: Cleanup translation.h.
Tue, Oct 20, 10:08
PiRK requested review of D7998: [backport#16224 4/5] doc: Do not translate technical or extremely rare errors.
Tue, Oct 20, 09:57
PiRK retitled D7997: [backport#16224 3/5] Make InitError bilingual from [backport#16224 2/5] Make InitError bilingual to [backport#16224 3/5] Make InitError bilingual.
Tue, Oct 20, 09:54
PiRK updated the summary of D7986: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual.
Tue, Oct 20, 09:54
PiRK updated the summary of D7997: [backport#16224 3/5] Make InitError bilingual.
Tue, Oct 20, 09:54
PiRK requested review of D7997: [backport#16224 3/5] Make InitError bilingual.
Tue, Oct 20, 09:52
PiRK added a comment to D7987: tests: Remove unused testing code.
In D7987#187502, @PiRK wrote:

Where is part 2?

I will work on adding the corresponding linter tomorrow, and take some to time to properly check that it does not degrade performances too much. Fabien told me that external linters are slower than a regex in PHP.

Tue, Oct 20, 07:33

Mon, Oct 19

PiRK added a comment to D7987: tests: Remove unused testing code.

I already ran the command locally. There will be quite a few unused functions, variables and classes to be removed. I imagine I will do that in a separate diff too.

Mon, Oct 19, 17:21
PiRK added a comment to D7987: tests: Remove unused testing code.

Where is part 2?

Mon, Oct 19, 17:17
PiRK updated the diff for D7981: p2p: Remove BIP61 reject messages.

address 2 review items: add a blank line accidentaly removed, use ABC version numbers in bip.md

Mon, Oct 19, 15:54
PiRK added inline comments to D7981: p2p: Remove BIP61 reject messages.
Mon, Oct 19, 15:51
PiRK requested review of D7987: tests: Remove unused testing code.
Mon, Oct 19, 15:49
PiRK closed D7978: doc: Remove mention of renamed mapBlocksUnlinked.
Mon, Oct 19, 15:39
PiRK committed rABC113ee003dbd0: doc: Remove mention of renamed mapBlocksUnlinked (authored by MarcoFalke <falke.marco@gmail.com>).
doc: Remove mention of renamed mapBlocksUnlinked
Mon, Oct 19, 15:39
PiRK requested review of D7986: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual.
Mon, Oct 19, 15:32
PiRK requested review of D7985: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.
Mon, Oct 19, 15:26
PiRK added inline comments to D7981: p2p: Remove BIP61 reject messages.
Mon, Oct 19, 15:22
PiRK updated the diff for D7978: doc: Remove mention of renamed mapBlocksUnlinked.

rebase

Mon, Oct 19, 11:58
PiRK closed D7977: [Doc] Add documentation for the new whitelist permissions.
Mon, Oct 19, 11:43
PiRK committed rABCfdedc9312f38: [Doc] Add documentation for the new whitelist permissions (authored by nicolas.dorier <nicolas.dorier@gmail.com>).
[Doc] Add documentation for the new whitelist permissions
Mon, Oct 19, 11:43
PiRK closed D7976: [doc] mention whitelist is inbound, and applies to blocksonly.
Mon, Oct 19, 11:34
PiRK committed rABC1118027f79db: [doc] mention whitelist is inbound, and applies to blocksonly (authored by Sjors Provoost <sjors@sprovoost.nl>).
[doc] mention whitelist is inbound, and applies to blocksonly
Mon, Oct 19, 11:34
PiRK closed D7975: Doc: remove text about txes always relayed from -whitelist.
Mon, Oct 19, 11:33
PiRK committed rABC3c35162fc448: Doc: remove text about txes always relayed from -whitelist (authored by David A. Harding <dave@dtrt.org>).
Doc: remove text about txes always relayed from -whitelist
Mon, Oct 19, 11:33
PiRK closed D7974: doc: Fix -dustrelayfee= argument docs grammar.
Mon, Oct 19, 11:32
PiRK committed rABC2ec285f844b7: doc: Fix -dustrelayfee= argument docs grammar (authored by keepkeyjon <35975617+keepkeyjon@users.noreply.github.com>).
doc: Fix -dustrelayfee= argument docs grammar
Mon, Oct 19, 11:32
PiRK requested review of D7981: p2p: Remove BIP61 reject messages.
Mon, Oct 19, 11:11
PiRK requested review of D7978: doc: Remove mention of renamed mapBlocksUnlinked.
Mon, Oct 19, 08:46
PiRK updated the diff for D7977: [Doc] Add documentation for the new whitelist permissions.

remove "<<<<<<< HEAD"

Mon, Oct 19, 08:14
PiRK updated the summary of D7977: [Doc] Add documentation for the new whitelist permissions.
Mon, Oct 19, 07:54
PiRK updated the summary of D7977: [Doc] Add documentation for the new whitelist permissions.
Mon, Oct 19, 07:52
PiRK requested review of D7977: [Doc] Add documentation for the new whitelist permissions.
Mon, Oct 19, 07:52