Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (288 w, 5 h)

Recent Activity

Today

PiRK updated the diff for D19550: [buildbot] replace Cirrus status with GitHub Actions status in phabricator.

fix another copyright date that won't pass review, and while we are touching this, improve the name of the context manager function

Wed, Feb 11, 20:13
PiRK updated the diff for D19550: [buildbot] replace Cirrus status with GitHub Actions status in phabricator.

fix comment

Wed, Feb 11, 20:08
PiRK updated the diff for D19551: [buildbot] remove dependency on third-party mock library.

rebase

Wed, Feb 11, 20:06
PiRK updated the diff for D19550: [buildbot] replace Cirrus status with GitHub Actions status in phabricator.
  • more defensive coding for unexpected build status & conclusion (hand success and failure for "status" even if I don't expect these values)
  • change GithubActions.get_latest_workflow_status to return both run_id and build_status for a single API call (don't cache the values, query the API for every call)
  • Syntactic sugar: use a contextmanager to temporarily change the run_id or build_status in tests
Wed, Feb 11, 20:04
PiRK accepted D19552: [ci] Update nodesetup.sh hash.

i'm getting the same hash, and the file content seems to match PR1911

Wed, Feb 11, 16:55
PiRK added inline comments to D19550: [buildbot] replace Cirrus status with GitHub Actions status in phabricator.
Wed, Feb 11, 16:14
PiRK retitled D19550: [buildbot] replace Cirrus status with GitHub Actions status in phabricator from [CI] replace Cirrus status with GitHub Actions status in phabricator to [buildbot] replace Cirrus status with GitHub Actions status in phabricator.
Wed, Feb 11, 15:19
PiRK added inline comments to D19551: [buildbot] remove dependency on third-party mock library.
Wed, Feb 11, 15:18
PiRK updated the summary of D19551: [buildbot] remove dependency on third-party mock library.
Wed, Feb 11, 15:17
PiRK requested review of D19551: [buildbot] remove dependency on third-party mock library.
Wed, Feb 11, 15:16
PiRK abandoned D19549: [CI] replace Cirrus status with GitHub Actions status in phabricator.

replaced by D19550

Wed, Feb 11, 15:06
PiRK requested review of D19550: [buildbot] replace Cirrus status with GitHub Actions status in phabricator.
Wed, Feb 11, 15:06
PiRK published D19549: [CI] replace Cirrus status with GitHub Actions status in phabricator for review.
Wed, Feb 11, 11:19
PiRK committed rABC7a6a03ec2e7b: [secp256k1] build: stop treating schnorrsig, extrakeys modules as experimental (authored by Jonas Nick <jonasd.nick@gmail.com>).
[secp256k1] build: stop treating schnorrsig, extrakeys modules as experimental
Wed, Feb 11, 11:18
PiRK closed D19547: [secp256k1] build: stop treating schnorrsig, extrakeys modules as experimental.
Wed, Feb 11, 11:18
PiRK updated the diff for D19547: [secp256k1] build: stop treating schnorrsig, extrakeys modules as experimental.

update the usage example note in README.md

Wed, Feb 11, 09:22
PiRK closed D19546: [secp256k1] Schnorrsig (taproot) API improvements.
Wed, Feb 11, 09:18
PiRK committed rABC824163c20dc8: [secp256k1] Schnorrsig (taproot) API improvements (authored by Tim Ruffing <crypto@timruffing.de>).
[secp256k1] Schnorrsig (taproot) API improvements
Wed, Feb 11, 09:18
PiRK closed D19548: scripted-diff: rename privkey with seckey in secp256k1 interface.
Wed, Feb 11, 09:18
PiRK committed rABCc3ec601acac7: scripted-diff: rename privkey with seckey in secp256k1 interface (authored by PiRK).
scripted-diff: rename privkey with seckey in secp256k1 interface
Wed, Feb 11, 09:18

Yesterday

PiRK published D19547: [secp256k1] build: stop treating schnorrsig, extrakeys modules as experimental for review.
Tue, Feb 10, 17:11
PiRK updated the diff for D19546: [secp256k1] Schnorrsig (taproot) API improvements.

rebase

Tue, Feb 10, 15:12
PiRK updated the diff for D19548: scripted-diff: rename privkey with seckey in secp256k1 interface.

fix the fuzzer that was backported out of sequence (https://github.com/bitcoin/bitcoin/pull/19379)

Tue, Feb 10, 14:25
PiRK closed D19545: [secp256k1] Change SHA256 byte counter from size_t to uint64_t.
Tue, Feb 10, 13:32
PiRK committed rABC93488e932dd7: [secp256k1] Change SHA256 byte counter from size_t to uint64_t (authored by Tim Ruffing <crypto@timruffing.de>).
[secp256k1] Change SHA256 byte counter from size_t to uint64_t
Tue, Feb 10, 13:32
PiRK closed D19544: [secp256k1] configure: Remove redundant pkg-config code.
Tue, Feb 10, 13:32
PiRK committed rABCa94fa1519aae: [secp256k1] configure: Remove redundant pkg-config code (authored by Tim Ruffing <crypto@timruffing.de>).
[secp256k1] configure: Remove redundant pkg-config code
Tue, Feb 10, 13:32
PiRK requested review of D19548: scripted-diff: rename privkey with seckey in secp256k1 interface.
Tue, Feb 10, 13:29
PiRK planned changes to D19546: [secp256k1] Schnorrsig (taproot) API improvements.

it is still missing something, looks like some deprecated functions are used in the node's codebase

Tue, Feb 10, 13:18
PiRK updated the diff for D19546: [secp256k1] Schnorrsig (taproot) API improvements.

apply changes missed in D19510

Tue, Feb 10, 13:13
PiRK planned changes to D19546: [secp256k1] Schnorrsig (taproot) API improvements.

see D19510

Tue, Feb 10, 13:10
PiRK requested review of D19546: [secp256k1] Schnorrsig (taproot) API improvements.
Tue, Feb 10, 12:19
PiRK requested review of D19545: [secp256k1] Change SHA256 byte counter from size_t to uint64_t.
Tue, Feb 10, 12:17
PiRK requested review of D19544: [secp256k1] configure: Remove redundant pkg-config code.
Tue, Feb 10, 12:17
PiRK closed D19542: [secp256k1] add usage examples.
Tue, Feb 10, 11:57
PiRK committed rABC05a9cea4d28e: [secp256k1] add usage examples (authored by Elichai Turkel <elichai.turkel@gmail.com>).
[secp256k1] add usage examples
Tue, Feb 10, 11:57
PiRK updated the diff for D19542: [secp256k1] add usage examples.

review items

Tue, Feb 10, 09:55

Mon, Feb 9

PiRK added a comment to D19542: [secp256k1] add usage examples.

CI link : https://github.com/PiRK/secp256k1/actions/runs/21832357666

Mon, Feb 9, 16:01
PiRK updated the diff for D19542: [secp256k1] add usage examples.

fix conflicts (see D19499)

Mon, Feb 9, 15:59
PiRK planned changes to D19542: [secp256k1] add usage examples.

I missed a conflict

Mon, Feb 9, 15:50
PiRK requested review of D19542: [secp256k1] add usage examples.
Mon, Feb 9, 15:49
PiRK accepted D19540: [marlin] Bump version to 1.8.1 (10).
Mon, Feb 9, 13:37
PiRK closed D19541: [electrum] remove is_beyond_limit quadratic code in the address tab.
Mon, Feb 9, 13:30
PiRK committed rABC41cc980dd4c7: [electrum] remove is_beyond_limit quadratic code in the address tab (authored by PiRK).
[electrum] remove is_beyond_limit quadratic code in the address tab
Mon, Feb 9, 13:30
PiRK updated the summary of D19541: [electrum] remove is_beyond_limit quadratic code in the address tab.
Mon, Feb 9, 12:48
PiRK requested review of D19541: [electrum] remove is_beyond_limit quadratic code in the address tab.
Mon, Feb 9, 12:38
PiRK accepted D19538: Cleanup the `listunspent` RPC documentation.
Mon, Feb 9, 10:39
PiRK accepted D19537: [avalanche] Remove deprecated availability_score field from getpeerinfo.
Mon, Feb 9, 10:38
PiRK accepted D19535: [avalanche] Remove deprecated availability_score field from getavalanchepeerinfo.
Mon, Feb 9, 10:37
PiRK accepted D19539: [marlin] Add Filipino language.

maganda sa akin

Mon, Feb 9, 10:36
PiRK accepted D19534: [marlin] Improve korean translations.
Mon, Feb 9, 10:34
PiRK added a comment to D19534: [marlin] Improve korean translations.

제 눈에는 좋아 보여요

Mon, Feb 9, 10:34
PiRK accepted D19536: Bump version to 0.32.8.
Mon, Feb 9, 10:33

Fri, Feb 6

PiRK closed D19530: [electrum] build 64-bit windows binaries by default.
Fri, Feb 6, 07:43
PiRK committed rABC5ff438e2cdad: [electrum] build 64-bit windows binaries by default (authored by PiRK).
[electrum] build 64-bit windows binaries by default
Fri, Feb 6, 07:43

Thu, Feb 5

PiRK updated the test plan for D19530: [electrum] build 64-bit windows binaries by default.
Thu, Feb 5, 18:49
PiRK added a comment to D19530: [electrum] build 64-bit windows binaries by default.

I'm going to edit the summary and test plan because for some reason I'm not able to make it work anymore for win32 (so i'll remove the claim that we support both)

Thu, Feb 5, 18:48
PiRK added inline comments to D19530: [electrum] build 64-bit windows binaries by default.
Thu, Feb 5, 18:41
PiRK updated the test plan for D19530: [electrum] build 64-bit windows binaries by default.
Thu, Feb 5, 17:19
PiRK updated the diff for D19530: [electrum] build 64-bit windows binaries by default.

properly support both win32 and win64 with a single ENV var (WIN_ARCH, defaults to win64)

Thu, Feb 5, 17:01
PiRK updated the diff for D19530: [electrum] build 64-bit windows binaries by default.

actually make it work for both win32 and win64, by simply using a wildcard for the platform tag. This way the switch from 64 to 32 bits will require only setting an ENV var WIN_ARCH=win64.

Thu, Feb 5, 16:48
PiRK published D19530: [electrum] build 64-bit windows binaries by default for review.
Thu, Feb 5, 16:43
PiRK committed rABCcb780721bf81: [secp256k1] ci: move test environment variable declaration to ci.yml (authored by siv2r <siv2ram@gmail.com>).
[secp256k1] ci: move test environment variable declaration to ci.yml
Thu, Feb 5, 07:20
PiRK closed D19528: [secp256k1] ci: move test environment variable declaration to ci.yml.
Thu, Feb 5, 07:20
PiRK closed D19527: [secp256k1] ci: Add "MSan" to GitHub Actions.
Thu, Feb 5, 07:20
PiRK committed rABC37fd942dd63c: [secp256k1] ci: Add "MSan" to GitHub Actions (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[secp256k1] ci: Add "MSan" to GitHub Actions
Thu, Feb 5, 07:20
PiRK closed D19526: [secp256k1] ci: Add "C++ (public headers)" to GitHub Actions.
Thu, Feb 5, 07:20
PiRK closed D19525: [secp256k1] ci: Move sanitizers and fpermissive task from Cirrus to GitHub Actions.
Thu, Feb 5, 07:20
PiRK committed rABC494d1e397040: [secp256k1] ci: Move sanitizers and fpermissive task from Cirrus to GitHub… (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[secp256k1] ci: Move sanitizers and fpermissive task from Cirrus to GitHub…
Thu, Feb 5, 07:20
PiRK committed rABC53f368bff5ea: [secp256k1] ci: Add "C++ (public headers)" to GitHub Actions (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[secp256k1] ci: Add "C++ (public headers)" to GitHub Actions
Thu, Feb 5, 07:20
PiRK committed rABC41c43418cdfa: test: disable avalanche staking preconsensus for abc_feature_persist_avapeers.py (authored by PiRK).
test: disable avalanche staking preconsensus for abc_feature_persist_avapeers.py
Thu, Feb 5, 07:18
PiRK closed D19529: test: disable avalanche staking preconsensus for abc_feature_persist_avapeers.py.
Thu, Feb 5, 07:18

Wed, Feb 4

PiRK accepted D19521: [Cashtab] Convert SignVerify component and test to ts.
Wed, Feb 4, 19:20
PiRK added a comment to D19529: test: disable avalanche staking preconsensus for abc_feature_persist_avapeers.py.

Related CI failure https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_ResourceIntensiveBuilds_BitcoinAbcCrossBuildLinuxAArch64/1059251?buildTab=

Wed, Feb 4, 15:10
PiRK updated the summary of D19529: test: disable avalanche staking preconsensus for abc_feature_persist_avapeers.py.
Wed, Feb 4, 15:10
PiRK requested review of D19529: test: disable avalanche staking preconsensus for abc_feature_persist_avapeers.py.
Wed, Feb 4, 15:08
PiRK updated the summary of D19528: [secp256k1] ci: move test environment variable declaration to ci.yml.
Wed, Feb 4, 14:58
PiRK retitled D19528: [secp256k1] ci: move test environment variable declaration to ci.yml from [secp256k1] ci: move test environment variable declaration to .cirrus.yml to [secp256k1] ci: move test environment variable declaration to ci.yml.
Wed, Feb 4, 14:56
PiRK requested review of D19528: [secp256k1] ci: move test environment variable declaration to ci.yml.
Wed, Feb 4, 14:56
PiRK added inline comments to D19526: [secp256k1] ci: Add "C++ (public headers)" to GitHub Actions.
Wed, Feb 4, 14:55
PiRK added a comment to D19527: [secp256k1] ci: Add "MSan" to GitHub Actions.

https://github.com/PiRK/secp256k1/actions/runs/21674543209

Wed, Feb 4, 14:55
PiRK updated the diff for D19527: [secp256k1] ci: Add "MSan" to GitHub Actions.

fix env var name (we are still missing the backport that renames this var)

Wed, Feb 4, 14:39
PiRK requested review of D19527: [secp256k1] ci: Add "MSan" to GitHub Actions.
Wed, Feb 4, 14:36
PiRK requested review of D19526: [secp256k1] ci: Add "C++ (public headers)" to GitHub Actions.
Wed, Feb 4, 14:34
PiRK retitled D19525: [secp256k1] ci: Move sanitizers and fpermissive task from Cirrus to GitHub Actions from ci: Move sanitizers and fpermissive task from Cirrus to GitHub Actions to [secp256k1] ci: Move sanitizers and fpermissive task from Cirrus to GitHub Actions.
Wed, Feb 4, 14:32
PiRK added a comment to D19525: [secp256k1] ci: Move sanitizers and fpermissive task from Cirrus to GitHub Actions.

https://github.com/PiRK/secp256k1/actions/runs/21673573915

Wed, Feb 4, 14:32
PiRK requested review of D19525: [secp256k1] ci: Move sanitizers and fpermissive task from Cirrus to GitHub Actions.
Wed, Feb 4, 14:31
PiRK accepted D19524: [the-overmind] Escape markdown special chars in usernames.
Wed, Feb 4, 13:14
PiRK closed D19520: [secp256k1] ci, gha: Move more non-x86_64 tasks from Cirrus CI to GitHub Actions.
Wed, Feb 4, 08:47
PiRK committed rABC03c16851b379: [secp256k1] ci, gha: Move more non-x86_64 tasks from Cirrus CI to GitHub Actions (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[secp256k1] ci, gha: Move more non-x86_64 tasks from Cirrus CI to GitHub Actions
Wed, Feb 4, 08:47
PiRK closed D19519: [secp256k1] ci, gha: Add "x86_64: Linux (Debian stable)" GitHub Actions job.
Wed, Feb 4, 08:47
PiRK committed rABC4b0569f6a34d: [secp256k1] ci, gha: Add "x86_64: Linux (Debian stable)" GitHub Actions job (authored by Tim Ruffing <crypto@timruffing.de>).
[secp256k1] ci, gha: Add "x86_64: Linux (Debian stable)" GitHub Actions job
Wed, Feb 4, 08:47
PiRK added a comment to D19520: [secp256k1] ci, gha: Move more non-x86_64 tasks from Cirrus CI to GitHub Actions.

Plus backporting everything roughly in the same order makes it easier than selecting pieces and omitting others (which causes conflicts when cherry-picking). Here we do create some conflicts by backporting something earlier than we should, but it is because Cirrus is broken and we lost CI coverage.

Wed, Feb 4, 07:54
PiRK added a comment to D19520: [secp256k1] ci, gha: Move more non-x86_64 tasks from Cirrus CI to GitHub Actions.

re: testplan

push to github, wait for github actions to complete

is this effectively duplicated with our CI, what "goes green" in this diff? Or does this happen at the github mirror?

afaik we don't use Cirrus CI or github actions, so is this really just a maintenance backport to simplify catching up with more secp256k1 things?

otherwise, seems to match the backports mentioned

Wed, Feb 4, 07:49

Tue, Feb 3

PiRK updated the summary of D19520: [secp256k1] ci, gha: Move more non-x86_64 tasks from Cirrus CI to GitHub Actions.
Tue, Feb 3, 22:26
PiRK published D19520: [secp256k1] ci, gha: Move more non-x86_64 tasks from Cirrus CI to GitHub Actions for review.
Tue, Feb 3, 22:08
PiRK requested review of D19519: [secp256k1] ci, gha: Add "x86_64: Linux (Debian stable)" GitHub Actions job.
Tue, Feb 3, 13:39
PiRK closed D19517: [secp256k1] ci, gha: Add Windows jobs based on Linux image.
Tue, Feb 3, 13:35
PiRK committed rABCb65677512835: [secp256k1] ci, gha: Add Windows jobs based on Linux image (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[secp256k1] ci, gha: Add Windows jobs based on Linux image
Tue, Feb 3, 13:35
PiRK updated the diff for D19517: [secp256k1] ci, gha: Add Windows jobs based on Linux image.

test MULTISET, remove the corresponding Cirrus job

Tue, Feb 3, 09:51