Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (37 w, 1 d)

Recent Activity

Today

PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

rebase again after fixing the wallet dependency introduced in D9441

Fri, Apr 23, 09:48
PiRK updated the test plan for D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 09:16
PiRK updated the diff for D9441: [avalanche] improve stake generation in functional test.

This new way of generating stakes requires the wallet to be compiled. Fix the test to run only when possible, update the test plan.
Use a different bad proof for the delegateavalancheproof test, so that it does not depend on the wallet.

Fri, Apr 23, 09:14
PiRK closed D9430: [backport#19178] Make mininode_lock non-reentrant.
Fri, Apr 23, 08:53
PiRK committed rABCe7039654cdb3: [backport#19178] Make mininode_lock non-reentrant (authored by John Newbery <john@johnnewbery.com>).
[backport#19178] Make mininode_lock non-reentrant
Fri, Apr 23, 08:53
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

Rebase after updating dependency D9441

Fri, Apr 23, 07:58
PiRK updated the test plan for D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:53
PiRK updated the diff for D9441: [avalanche] improve stake generation in functional test.

Fix another functional test that was affected by renaming get_stakes
Update the test plan to include the entire functional test suite.

Fri, Apr 23, 07:50
PiRK updated the summary of D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:37
PiRK updated the summary of D9345: [avalanche] set a minimum amount for a proof.
Fri, Apr 23, 07:37
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

Fix test failure by rebasing onto D9441

Fri, Apr 23, 07:36
PiRK requested review of D9441: [avalanche] improve stake generation in functional test.
Fri, Apr 23, 07:35

Yesterday

PiRK added a comment to D9345: [avalanche] set a minimum amount for a proof.

TIL that the halvings are different on regtest than on mainnet. I need to work on a fix for the functional test that uses coinbase UTXOs to build a very large proof, because the coinbase amounts are lower than the dust threshold before I can reach 1000 stakes.
The problem did not appear earlier because this revision had not been rebased for a while, and the problematic test did not exist a couple of weeks ago.

Thu, Apr 22, 13:57
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

Rebase. The test failures seem unrelated to the revision, and are definitely unrelated to my last amend.

Thu, Apr 22, 10:10
PiRK requested review of D9430: [backport#19178] Make mininode_lock non-reentrant.
Thu, Apr 22, 08:42
PiRK updated the summary of D9430: [backport#19178] Make mininode_lock non-reentrant.
Thu, Apr 22, 08:41
PiRK added a comment to D9430: [backport#19178] Make mininode_lock non-reentrant.

When I backported core#18807, I did not backport the commit introducing this mistake (https://github.com/bitcoin/bitcoin/pull/18807/commits/00d44a534b4e5ae249b8011360c6b0f7dc731581), so the change to P2PTxInvStore is not relevant to our codebase.

Thu, Apr 22, 08:37
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

refactor the unit test so that any proof size can be tested, increase the number of tested proof sizes

Thu, Apr 22, 08:18

Wed, Apr 21

PiRK planned changes to D9425: [avalanche] add an OrphanProofPool class.
Wed, Apr 21, 15:11
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

Append new proof to the end of the container, use a forward iterator for trimming from the front, use the fact that erase already returns an iterator to the next element (no need to increment the iterator again).

Wed, Apr 21, 15:11
PiRK added inline comments to D9425: [avalanche] add an OrphanProofPool class.
Wed, Apr 21, 14:23
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

Move SaltedProofIdHasher to proofid.h to make it available to both orphanproofpool and peermanager without additional includes.

Wed, Apr 21, 10:03
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

What about bool hasDustStake(Proof p);?

Wed, Apr 21, 09:13
PiRK abandoned D9368: [avalanche] move proof verification code to processor.cpp.
Wed, Apr 21, 08:54
PiRK updated the summary of D9430: [backport#19178] Make mininode_lock non-reentrant.
Wed, Apr 21, 08:01
PiRK updated the diff for D9430: [backport#19178] Make mininode_lock non-reentrant.

Don't acquire mininode_lock twice in abc_p2p_avalanche.py.
on_avahello, on_avapoll and on_avaresponse are called indirectly via mininode.P2PInterface.on_message, which does the call with the lock already acquired.

Wed, Apr 21, 07:59
PiRK closed D9438: Make sure unconfirmed parents are requestable.
Wed, Apr 21, 06:53
PiRK committed rABCbe2afa6ffbf9: Make sure unconfirmed parents are requestable (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make sure unconfirmed parents are requestable
Wed, Apr 21, 06:53
PiRK closed D9431: test: move sync_blocks and sync_mempool functions to test_framework.py.
Wed, Apr 21, 06:42
PiRK committed rABC351c23d9d425: test: move sync_blocks and sync_mempool functions to test_framework.py (authored by Roy Shao <ycshao0402@gmail.com>).
test: move sync_blocks and sync_mempool functions to test_framework.py
Wed, Apr 21, 06:41
PiRK closed D9437: Drop setInventoryTxToSend based filtering.
Wed, Apr 21, 06:41
PiRK committed rABC2ee8732b2271: Drop setInventoryTxToSend based filtering (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Drop setInventoryTxToSend based filtering
Wed, Apr 21, 06:41
PiRK updated the summary of D9437: Drop setInventoryTxToSend based filtering.
Wed, Apr 21, 06:40
PiRK closed D9436: Only respond to requests for recently announced transactions.
Wed, Apr 21, 06:39
PiRK committed rABC76acdc0dcf8b: Only respond to requests for recently announced transactions (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Only respond to requests for recently announced transactions
Wed, Apr 21, 06:39
PiRK closed D9432: test: refactor functional tests to use restart_node.
Wed, Apr 21, 06:33
PiRK committed rABCee9e2a2ee678: test: refactor functional tests to use restart_node (authored by Christopher Coverdale <chris.coverdale24@gmail.com>).
test: refactor functional tests to use restart_node
Wed, Apr 21, 06:33
PiRK closed D9435: Introduce constant for mempool-based relay separate from mapRelay caching.
Wed, Apr 21, 06:32
PiRK committed rABCc9dd5e3d2a53: Introduce constant for mempool-based relay separate from mapRelay caching (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Introduce constant for mempool-based relay separate from mapRelay caching
Wed, Apr 21, 06:32
PiRK closed D9434: Swap relay pool and mempool lookup.
Wed, Apr 21, 06:31
PiRK committed rABC92f5dfef38e0: Swap relay pool and mempool lookup (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Swap relay pool and mempool lookup
Wed, Apr 21, 06:31
PiRK updated the summary of D9435: Introduce constant for mempool-based relay separate from mapRelay caching.
Wed, Apr 21, 06:30
PiRK closed D9429: [backport#19299] remove unused variables and add missing includes.
Wed, Apr 21, 06:24
PiRK committed rABC5e0e8c1d3eb0: [backport#19299] remove unused variables and add missing includes (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19299] remove unused variables and add missing includes
Wed, Apr 21, 06:23

Tue, Apr 20

PiRK closed D9433: [net] Make cs_inventory nonrecursive.
Tue, Apr 20, 16:48
PiRK committed rABC8ef7cf94d1d8: [net] Make cs_inventory nonrecursive (authored by John Newbery <john@johnnewbery.com>).
[net] Make cs_inventory nonrecursive
Tue, Apr 20, 16:48
PiRK updated the summary of D9435: Introduce constant for mempool-based relay separate from mapRelay caching.
Tue, Apr 20, 16:39
PiRK updated the summary of D9436: Only respond to requests for recently announced transactions.
Tue, Apr 20, 16:39
PiRK updated the summary of D9437: Drop setInventoryTxToSend based filtering.
Tue, Apr 20, 16:38
PiRK updated the summary of D9438: Make sure unconfirmed parents are requestable.
Tue, Apr 20, 16:38
PiRK updated the summary of D9438: Make sure unconfirmed parents are requestable.
Tue, Apr 20, 16:38
PiRK added a comment to D9438: Make sure unconfirmed parents are requestable.

I think the deleted blank line is a result of linting. If I try to restore it, it tells me it's a code style violation

Tue, Apr 20, 16:37
PiRK added a comment to D9430: [backport#19178] Make mininode_lock non-reentrant.

This is breaking the test suite, back to your queue. Please make sure you run it, this is happening way too often.

Tue, Apr 20, 16:28
PiRK added inline comments to D9425: [avalanche] add an OrphanProofPool class.
Tue, Apr 20, 16:27
PiRK added inline comments to D9425: [avalanche] add an OrphanProofPool class.
Tue, Apr 20, 16:25
PiRK requested review of D9438: Make sure unconfirmed parents are requestable.
Tue, Apr 20, 16:11
PiRK requested review of D9437: Drop setInventoryTxToSend based filtering.
Tue, Apr 20, 16:10
PiRK requested review of D9436: Only respond to requests for recently announced transactions.
Tue, Apr 20, 16:09
PiRK requested review of D9435: Introduce constant for mempool-based relay separate from mapRelay caching.
Tue, Apr 20, 16:07
PiRK requested review of D9434: Swap relay pool and mempool lookup.
Tue, Apr 20, 16:06
PiRK requested review of D9433: [net] Make cs_inventory nonrecursive.
Tue, Apr 20, 15:18
PiRK requested review of D9432: test: refactor functional tests to use restart_node.
Tue, Apr 20, 15:02
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

fix the renaming issues.

Tue, Apr 20, 14:47
PiRK retitled D9425: [avalanche] add an OrphanProofPool class from [avalanche] add a ProofPool class to [avalanche] add an OrphanProofPool class.
Tue, Apr 20, 14:39
PiRK requested review of D9431: test: move sync_blocks and sync_mempool functions to test_framework.py.
Tue, Apr 20, 14:32
PiRK requested review of D9430: [backport#19178] Make mininode_lock non-reentrant.
Tue, Apr 20, 14:09
PiRK updated the summary of D9429: [backport#19299] remove unused variables and add missing includes.
Tue, Apr 20, 14:00
PiRK requested review of D9429: [backport#19299] remove unused variables and add missing includes.
Tue, Apr 20, 13:58
PiRK added inline comments to D9423: [avalanche] Remember rejected proofs.
Tue, Apr 20, 13:32
PiRK retitled D9423: [avalanche] Remember rejected proofs from [avalanche] Remember recently rejected proofs to [avalanche] Remember rejected proofs.
Tue, Apr 20, 09:57
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

address review:

Tue, Apr 20, 09:50

Mon, Apr 19

PiRK updated the summary of D9423: [avalanche] Remember rejected proofs.
Mon, Apr 19, 19:36
PiRK closed D9428: [avalanche] support MSG_AVA_PROOF in CInv::GetCommand.
Mon, Apr 19, 19:30
PiRK committed rABC9637276974d0: [avalanche] support MSG_AVA_PROOF in CInv::GetCommand (authored by PiRK).
[avalanche] support MSG_AVA_PROOF in CInv::GetCommand
Mon, Apr 19, 19:29
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

Make the size threshold a number of stakes, not a number of proofs.

Mon, Apr 19, 15:57
PiRK planned changes to D9425: [avalanche] add an OrphanProofPool class.
Mon, Apr 19, 14:24
PiRK added a comment to D9425: [avalanche] add an OrphanProofPool class.

I still want to change the threshold to be a maximum number of stakes, not a number of proofs. That way, it will actually represent a maximum memory footprint and a maximum number of signatures to verify.

Mon, Apr 19, 14:23
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

Use a multi-index container to avoid using multiple data structures to remember insertion order.
Contributed by @fabcien

Mon, Apr 19, 14:21
PiRK updated the diff for D9423: [avalanche] Remember rejected proofs.

rephrase the misleading comment.

Mon, Apr 19, 12:04
PiRK updated the diff for D9423: [avalanche] Remember rejected proofs.

rename recentProofRejects -> rejectedProofs.
I used the recent word to mean that the filter has a limited size and will drop the oldest entries when full. But that is an implementation detail. A proof that enters this pool will be bad forever, there is no reset of the filter done on tip updates, like there is for transactions.

Mon, Apr 19, 12:01
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

rebase onto master

Mon, Apr 19, 08:05
PiRK updated the diff for D9423: [avalanche] Remember rejected proofs.

rebase onto master (this diff has no dependency)

Mon, Apr 19, 08:03

Sun, Apr 18

PiRK updated the summary of D9428: [avalanche] support MSG_AVA_PROOF in CInv::GetCommand.
Sun, Apr 18, 20:10
PiRK updated the summary of D9428: [avalanche] support MSG_AVA_PROOF in CInv::GetCommand.
Sun, Apr 18, 20:10
PiRK requested review of D9428: [avalanche] support MSG_AVA_PROOF in CInv::GetCommand.
Sun, Apr 18, 19:55

Fri, Apr 16

PiRK accepted D9419: [avalanche] Move the session key to the PeerData structure.
Fri, Apr 16, 17:05
PiRK accepted D9418: [avalanche] Make the peer data proof and delegation optional.
Fri, Apr 16, 17:01
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

rename LOWEST_VALID_SCORE -> MIN_VALID_PROOF_SCORE

Fri, Apr 16, 14:26
PiRK requested changes to D9418: [avalanche] Make the peer data proof and delegation optional.
Fri, Apr 16, 13:25
PiRK abandoned D9394: [avalanche] rename getProof to getLocalProof and return a pointer.

This can be abandoned in favor of D9418. The reference to an optional proof is better than a bare pointer.

Fri, Apr 16, 13:25
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

check also return value of addProof is true

Fri, Apr 16, 10:17
PiRK requested review of D9425: [avalanche] add an OrphanProofPool class.
Fri, Apr 16, 10:08

Thu, Apr 15

PiRK added a comment to D9422: [avalanche] Don't turn on service bit if we don't have a proof.

I get the point that a node that does not vote is not a full avalanche peer. But it can still be a "limited avalanche peer", if it wants to relay proofs and poll other avalanche nodes. We will need some other way of signalling the "limited avalanche" state.

Thu, Apr 15, 15:47
PiRK planned changes to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.

Working on splitting this in smaller pieces, with some refactoring :
D9423

Thu, Apr 15, 13:44
PiRK requested review of D9423: [avalanche] Remember rejected proofs.
Thu, Apr 15, 13:44
PiRK abandoned D9417: [avalanche] add a fetchOrCreatePeer with ProofValidationStatus.

I think I just had a

Thu, Apr 15, 12:12
PiRK updated the diff for D9417: [avalanche] add a fetchOrCreatePeer with ProofValidationStatus.

remove the dummy state that is thrown away so that the output argument is actually used

Thu, Apr 15, 11:37
PiRK requested review of D9417: [avalanche] add a fetchOrCreatePeer with ProofValidationStatus.
Thu, Apr 15, 11:33

Wed, Apr 14

PiRK added inline comments to D9345: [avalanche] set a minimum amount for a proof.
Wed, Apr 14, 19:40
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

new attempt at getting this unstuck: restore the proof_randomè test as close as possible to its initial state, don't test for the ProofValidationResult::DUST_THRESOLD`, just make sure the score given to buildRandomProof is always valid.

Wed, Apr 14, 14:53