It's complete know. It took me some time to understand how to make the tests work for ABC.

For the record, I am horrified by how this PR uses a metaclass, type and __subclasses__ to build basic python classes. This is why standard tools cannot detect dead code :)

Core -> ABC

I'm still working on the second commit of that PR. I thought it would be easy, but it isn't (new test not passing). Sorry about that, I should not have sent that first diff so fast.

address feedback about line breaks

add missing braces

rebase

rebase

fix missed encrypt -> isEncryptWalletChecked

rebase

rebase

rebase

s/Core/ABC/

rebase

In D7987#187502, @PiRK wrote:

In D7987#187491, @deadalnix wrote:

Where is part 2?

I will work on adding the corresponding linter tomorrow, and take some to time to properly check that it does not degrade performances too much. Fabien told me that external linters are slower than a regex in PHP.

I already ran the command locally. There will be quite a few unused functions, variables and classes to be removed. I imagine I will do that in a separate diff too.

In D7987#187491, @deadalnix wrote:

Where is part 2?

address 2 review items: add a blank line accidentaly removed, use ABC version numbers in bip.md

rebase

remove "<<<<<<< HEAD"