there is a debbuging true || that needs removing

update

Suggested test plan:

fix copied comment

Tested with an address that initially has confirmed transactions, then receives a mempool transaction, then a new block gets mined: all 3 hashes are identical with Chronik and Fulcrum.

Actually I'm only getting the same result for a single tx in the mempool. When the block is mined the status differs.
I imagine that Chronik does not guarantee that the transaction history is ordered in the same order as inside the block.

I'm now getting the same results with Fulcrum and Chronik, with the expected exception of histories containing transactions with unconfirmed parents.

markdown fix for url

add a paragraph for chronik vs assumeutxo incompatibility

remove block date in comment

utack

we can only pass "-chronik" if chronik is compiled. Unfortunately there is no convenient way to start the node only if chronik is compiled, so start it with no params if we are not going to run that test.
Add a couple of chronik calls to better check that chronik was succesfully started.

optional suggestions. The bytes flipping + explicit byteorder specification hurts my brain.

@bot build-tsan

@bot build-tsan

@bot build-tsan

looks good. Tested on mainnet, results are identical to electrum.bitcoinabc.org

add back const qualifier for colorText (never moved)

In the test plan it should probably be createwallet instead of create (that worked for me)

fix remaining warning

15:34:35

/work/src/minerfund.cpp:80:13: error: this STL algorithm call should be replaced with a container method [performance-inefficient-algorithm,-warnings-as-errors]

This does not work yet. When testing on mainnet with a very recent snapshot, the node crashed before finishing background IBD because chronik tried to index a mempool tx that was spending coins not yet indexed.

The CI found more, confirmed locally by nuking the build dir & ccache and restarting the compilation from scratch

the CI keeps finding more when locally the build passes

more

i missed two

move dummy code to #else branch

don't use conditional compilation for lambda definition