Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (24 w, 1 d)

Recent Activity

Today

PiRK closed D9012: [mempool] Persist unbroadcast set to mempool.dat.
Thu, Jan 21, 19:20
PiRK committed rABCad4cfa37da85: [mempool] Persist unbroadcast set to mempool.dat (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[mempool] Persist unbroadcast set to mempool.dat
Thu, Jan 21, 19:20
PiRK closed D9011: [test] Integration tests for unbroadcast functionality.
Thu, Jan 21, 18:05
PiRK committed rABC0462bb493d52: [test] Integration tests for unbroadcast functionality (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[test] Integration tests for unbroadcast functionality
Thu, Jan 21, 18:05
PiRK accepted D9014: test: Add fuzzing harnesses for various classes/functions in primitives/.
Thu, Jan 21, 18:02
PiRK accepted D9013: fuzz: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer.
Thu, Jan 21, 18:00
PiRK closed D9010: [refactor/test] Extract P2PTxInvStore into test framework.
Thu, Jan 21, 17:46
PiRK committed rABC1167285f9107: [refactor/test] Extract P2PTxInvStore into test framework (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[refactor/test] Extract P2PTxInvStore into test framework
Thu, Jan 21, 17:46
PiRK closed D9009: [wallet] Update the rebroadcast frequency to be ~1/day..
Thu, Jan 21, 17:31
PiRK committed rABC232939a30114: [wallet] Update the rebroadcast frequency to be ~1/day. (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[wallet] Update the rebroadcast frequency to be ~1/day.
Thu, Jan 21, 17:31
PiRK closed D9008: [p2p] Reattempt initial send of unbroadcast transactions.
Thu, Jan 21, 17:08
PiRK committed rABC0ea659532280: [p2p] Reattempt initial send of unbroadcast transactions (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[p2p] Reattempt initial send of unbroadcast transactions
Thu, Jan 21, 17:08
PiRK closed D9007: [util] Add method that returns random time in milliseconds.
Thu, Jan 21, 16:59
PiRK committed rABC9a88bcf4618e: [util] Add method that returns random time in milliseconds (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[util] Add method that returns random time in milliseconds
Thu, Jan 21, 16:58
PiRK closed D9006: [mempool] Track "unbroadcast" transactions.
Thu, Jan 21, 14:43
PiRK committed rABC674a222fdbab: [mempool] Track "unbroadcast" transactions (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[mempool] Track "unbroadcast" transactions
Thu, Jan 21, 14:43
PiRK updated the diff for D9012: [mempool] Persist unbroadcast set to mempool.dat.

put a comment on its own line

Thu, Jan 21, 13:50
PiRK updated the summary of D9011: [test] Integration tests for unbroadcast functionality.
Thu, Jan 21, 13:35
PiRK updated the summary of D9011: [test] Integration tests for unbroadcast functionality.
Thu, Jan 21, 13:35
PiRK updated the diff for D9006: [mempool] Track "unbroadcast" transactions.

address feedback

Thu, Jan 21, 13:32
PiRK updated the diff for D9009: [wallet] Update the rebroadcast frequency to be ~1/day..

rebase

Thu, Jan 21, 13:26
PiRK closed D8999: tests: remove duplicate block generation.
Thu, Jan 21, 12:24
PiRK committed rABCd6caef5ba3d9: tests: remove duplicate block generation (authored by PiRK).
tests: remove duplicate block generation
Thu, Jan 21, 12:24
PiRK closed D8998: qt: remove todo bug fix for old versions of Qt.
Thu, Jan 21, 12:19
PiRK committed rABC6b149463a9f2: qt: remove todo bug fix for old versions of Qt (authored by 10xcryptodev <10xcryptodev@gmail.com>).
qt: remove todo bug fix for old versions of Qt
Thu, Jan 21, 12:19
PiRK accepted D9002: tests: Avoid fuzzer-specific nullptr dereference in libevent when handling PROXY requests.
Thu, Jan 21, 12:17
PiRK accepted D9001: fuzz: http_request workaround for libevent < 2.1.1.
Thu, Jan 21, 12:12
PiRK accepted D9000: tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions.
Thu, Jan 21, 12:11
PiRK requested review of D9012: [mempool] Persist unbroadcast set to mempool.dat.
Thu, Jan 21, 11:41
PiRK requested review of D9011: [test] Integration tests for unbroadcast functionality.
Thu, Jan 21, 11:39
PiRK requested review of D9010: [refactor/test] Extract P2PTxInvStore into test framework.
Thu, Jan 21, 11:38
PiRK requested review of D9009: [wallet] Update the rebroadcast frequency to be ~1/day..
Thu, Jan 21, 11:37
PiRK updated the summary of D9008: [p2p] Reattempt initial send of unbroadcast transactions.
Thu, Jan 21, 11:36
PiRK updated the summary of D9007: [util] Add method that returns random time in milliseconds.
Thu, Jan 21, 11:35
PiRK requested review of D9008: [p2p] Reattempt initial send of unbroadcast transactions.
Thu, Jan 21, 11:34
PiRK requested review of D9007: [util] Add method that returns random time in milliseconds.
Thu, Jan 21, 11:33
PiRK requested review of D9006: [mempool] Track "unbroadcast" transactions.
Thu, Jan 21, 11:32
PiRK requested review of D8999: tests: remove duplicate block generation.
Thu, Jan 21, 09:42
PiRK requested review of D8998: qt: remove todo bug fix for old versions of Qt.
Thu, Jan 21, 09:15
PiRK closed D8989: test: Remove raw-tx byte juggling in mempool_reorg.
Thu, Jan 21, 07:55
PiRK committed rABC0bb71bfaa24a: test: Remove raw-tx byte juggling in mempool_reorg (authored by MarcoFalke <falke.marco@gmail.com>).
test: Remove raw-tx byte juggling in mempool_reorg
Thu, Jan 21, 07:55
PiRK added a comment to D8990: [backport#18665] Do not expose and consider -logthreadnames when it does not work.

I skipped this one because I wasn't sure how to define HAVE_THREAD_LOCAL, and whether we needed to define it at all.

Thu, Jan 21, 07:50
PiRK closed D8991: test: Fix intermittent failure in wallet_importmulti.
Thu, Jan 21, 07:46
PiRK committed rABCf339a4f6d651: test: Fix intermittent failure in wallet_importmulti (authored by MarcoFalke <falke.marco@gmail.com>).
test: Fix intermittent failure in wallet_importmulti
Thu, Jan 21, 07:46
PiRK accepted D8996: [website] Remove Bitcoin Cash from project description.
Thu, Jan 21, 07:45
PiRK accepted D8995: [website] Add ViaWallet explorer to site.
Thu, Jan 21, 07:44
PiRK accepted D8994: [backport#18777] wallet: Recommend absolute path for dumpwallet.
Thu, Jan 21, 07:43
PiRK closed D8988: test: use zero-argument super() shortcut (Python 3.0+).
Thu, Jan 21, 07:40
PiRK committed rABC438dca9e5035: test: use zero-argument super() shortcut (Python 3.0+) (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: use zero-argument super() shortcut (Python 3.0+)
Thu, Jan 21, 07:40
PiRK accepted D8993: [backport#18669] log: Use Join() helper when listing log categories.
Thu, Jan 21, 07:38

Yesterday

PiRK requested review of D8991: test: Fix intermittent failure in wallet_importmulti.
Wed, Jan 20, 17:00
PiRK updated the diff for D8988: test: use zero-argument super() shortcut (Python 3.0+).

revert change in feature_block

Wed, Jan 20, 16:54
PiRK requested review of D8989: test: Remove raw-tx byte juggling in mempool_reorg.
Wed, Jan 20, 16:46
PiRK requested review of D8988: test: use zero-argument super() shortcut (Python 3.0+).
Wed, Jan 20, 16:40
PiRK accepted D8981: tests: Add fuzzing harness for functions/classes in flatfile.h, merkleblock.h, random.h, serialize.h and span.h.
Wed, Jan 20, 16:21
PiRK accepted D8986: fuzz: Add CScriptNum::getint coverage.
Wed, Jan 20, 15:01
PiRK accepted D8985: fuzz: Extend descriptor fuzz test.
Wed, Jan 20, 14:59
PiRK accepted D8984: tests: Add proof-of-work fuzzing harness.
Wed, Jan 20, 14:58
PiRK closed D8973: script: Remove undocumented and unused operator+.
Wed, Jan 20, 14:56
PiRK committed rABC67d3d6330c4e: script: Remove undocumented and unused operator+ (authored by MarcoFalke <falke.marco@gmail.com>).
script: Remove undocumented and unused operator+
Wed, Jan 20, 14:56
PiRK requested changes to D8981: tests: Add fuzzing harness for functions/classes in flatfile.h, merkleblock.h, random.h, serialize.h and span.h.
Wed, Jan 20, 14:55
PiRK accepted D8979: tests: Add fuzzing harnesses for functions/classes in chain.h and protocol.h.
Wed, Jan 20, 14:50
PiRK closed D8980: [net processing] Move all const declarations to top of net_processing.cpp.
Wed, Jan 20, 14:49
PiRK committed rABCefb9f4d807a5: [net processing] Move all const declarations to top of net_processing.cpp (authored by John Newbery <john@johnnewbery.com>).
[net processing] Move all const declarations to top of net_processing.cpp
Wed, Jan 20, 14:49
PiRK closed D8978: [validation] Move all const declarations to top of validation.h.
Wed, Jan 20, 14:49
PiRK committed rABC66491023ca7c: [validation] Move all const declarations to top of validation.h (authored by John Newbery <john@johnnewbery.com>).
[validation] Move all const declarations to top of validation.h
Wed, Jan 20, 14:49
PiRK closed D8977: [validation] Move validation-only consts to validation.cpp.
Wed, Jan 20, 14:48
PiRK committed rABC6b3bb60ac35c: [validation] Move validation-only consts to validation.cpp (authored by John Newbery <john@johnnewbery.com>).
[validation] Move validation-only consts to validation.cpp
Wed, Jan 20, 14:48
PiRK closed D8976: [net processing] Move net processing consts to net_processing.cpp.
Wed, Jan 20, 14:47
PiRK committed rABC53f4c34f57b7: [net processing] Move net processing consts to net_processing.cpp (authored by John Newbery <john@johnnewbery.com>).
[net processing] Move net processing consts to net_processing.cpp
Wed, Jan 20, 14:47
PiRK closed D8975: test: add coverage for -rpcwallet cli option.
Wed, Jan 20, 11:23
PiRK committed rABCefe531436f74: test: add coverage for -rpcwallet cli option (authored by Jon Atack <jon@atack.com>).
test: add coverage for -rpcwallet cli option
Wed, Jan 20, 11:23
PiRK closed D8974: refactor: test: use wait_for_getdata() in p2p_compactblocks.py.
Wed, Jan 20, 11:14
PiRK committed rABC9d4e2e9eedb4: refactor: test: use wait_for_getdata() in p2p_compactblocks.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: test: use wait_for_getdata() in p2p_compactblocks.py
Wed, Jan 20, 11:14
PiRK closed D8963: test: display command line options passed to send_cli() in debug log.
Wed, Jan 20, 11:08
PiRK committed rABC05eb8acb903e: test: display command line options passed to send_cli() in debug log (authored by Jon Atack <jon@atack.com>).
test: display command line options passed to send_cli() in debug log
Wed, Jan 20, 11:08
PiRK requested review of D8976: [net processing] Move net processing consts to net_processing.cpp.

Are you referring to the moves in D8978?

Wed, Jan 20, 11:04
PiRK updated the diff for D8980: [net processing] Move all const declarations to top of net_processing.cpp.

rebase after removing unused MAX_FEE_ESTIMATION_TIP_AGE in D8977 which caused build-clang to fail

Wed, Jan 20, 11:01
PiRK updated the diff for D8978: [validation] Move all const declarations to top of validation.h.

rebase after removing unused MAX_FEE_ESTIMATION_TIP_AGE in D8977

Wed, Jan 20, 10:58
PiRK updated the summary of D8977: [validation] Move validation-only consts to validation.cpp.
Wed, Jan 20, 10:57
PiRK updated the diff for D8977: [validation] Move validation-only consts to validation.cpp.

remove unused const MAX_FEE_ESTIMATION_TIP_AGE. Its only use was deleted in D2784

Wed, Jan 20, 10:56
PiRK updated the diff for D8973: script: Remove undocumented and unused operator+.

restore line 474 that should not have been deleted

Wed, Jan 20, 10:37
PiRK requested review of D8980: [net processing] Move all const declarations to top of net_processing.cpp.
Wed, Jan 20, 10:29
PiRK requested review of D8978: [validation] Move all const declarations to top of validation.h.
Wed, Jan 20, 10:21
PiRK requested review of D8977: [validation] Move validation-only consts to validation.cpp.
Wed, Jan 20, 10:15
PiRK requested review of D8976: [net processing] Move net processing consts to net_processing.cpp.
Wed, Jan 20, 09:57
PiRK requested review of D8975: test: add coverage for -rpcwallet cli option.
Wed, Jan 20, 09:25
PiRK requested review of D8974: refactor: test: use wait_for_getdata() in p2p_compactblocks.py.
Wed, Jan 20, 08:53
PiRK requested review of D8973: script: Remove undocumented and unused operator+.
Wed, Jan 20, 03:01
PiRK closed D8965: test: Check submitblock return values.
Wed, Jan 20, 02:17
PiRK committed rABCbd3d55649070: test: Check submitblock return values (authored by MarcoFalke <falke.marco@gmail.com>).
test: Check submitblock return values
Wed, Jan 20, 02:17
PiRK accepted D8972: [Cashtab] Update api to /v4/.
Wed, Jan 20, 02:11
PiRK accepted D8971: [Cashtab] Replace step with constant.
Wed, Jan 20, 02:10
PiRK accepted D8970: tests: Add fuzzing harness for classes/functions in blockfilter.h. Add integer {de,}serialization fuzzing..
Wed, Jan 20, 02:09
PiRK accepted D8969: tests: Don't assume presence of __builtin_mul_overflow in MultiplicationOverflow(...) fuzzing harness.
Wed, Jan 20, 02:06
PiRK closed D8964: fixing init.md documentation to not require rpcpassword.
Wed, Jan 20, 02:05
PiRK committed rABC7f76d4d96b50: fixing init.md documentation to not require rpcpassword (authored by “jkcd” <“jkreadsemail@gmail.com”>).
fixing init.md documentation to not require rpcpassword
Wed, Jan 20, 02:05
PiRK accepted D8968: tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker.
Wed, Jan 20, 02:05
PiRK accepted D8967: tests: Add fuzzing harnesses for classes CBlockHeader, CFeeRate and various functions.
Wed, Jan 20, 02:03
PiRK closed D8961: test: check for matching object hashes in wait_for_getdata.
Wed, Jan 20, 01:58