Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (51 w, 6 d)

Recent Activity

Thu, Jul 29

PiRK added a comment to D9844: [avalanche] exclude stakes from the hash used in stake signature.

Note that I do not intend to land this. It is meant as an example of a possible solution, but the tradeoffs of the various solutions need to be discussed.
In particular, there is a solution that involves making the ProofId no longer depend on the stakes that would have a bunch of upsides (no need to regenerate a Delegation after updating a proof) but also challenges (if the ProofId does not change, it does not trigger proof relaying).

Thu, Jul 29, 09:17

Wed, Jul 28

PiRK added a task to D9844: [avalanche] exclude stakes from the hash used in stake signature: Unknown Object (Maniphest Task).
Wed, Jul 28, 14:54
PiRK requested review of D9844: [avalanche] exclude stakes from the hash used in stake signature.
Wed, Jul 28, 14:53
PiRK closed D9837: [doc] start a developer documentation for avalanche.
Wed, Jul 28, 06:37
PiRK committed rABC5a046e2b5a7d: [doc] start a developer documentation for avalanche (authored by PiRK).
[doc] start a developer documentation for avalanche
Wed, Jul 28, 06:37

Mon, Jul 26

PiRK accepted D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 12:01 · Restricted Project
PiRK requested changes to D9836: [avalanche] Protect from eviction nodes that relayed new proofs.
Mon, Jul 26, 11:06 · Restricted Project
PiRK requested review of D9837: [doc] start a developer documentation for avalanche.
Mon, Jul 26, 09:33

Fri, Jul 23

PiRK planned changes to D9834: test: Set -logthreadnames in unit tests.

testing depends on core#16975

Fri, Jul 23, 09:36
PiRK planned changes to D9831: net: Remove forcerelay of rejected txs.

needs backporting 17984

Fri, Jul 23, 09:35
PiRK closed D9833: init: use std::thread for ThreadImport().
Fri, Jul 23, 08:13
PiRK committed rABCae09ca09e4e0: init: use std::thread for ThreadImport() (authored by fanquake <fanquake@gmail.com>).
init: use std::thread for ThreadImport()
Fri, Jul 23, 08:13

Thu, Jul 22

PiRK requested review of D9834: test: Set -logthreadnames in unit tests.
Thu, Jul 22, 15:48
PiRK requested review of D9833: init: use std::thread for ThreadImport().
Thu, Jul 22, 15:29
PiRK updated the summary of D9832: doc: Use precise permission flags where possible.
Thu, Jul 22, 15:09
PiRK requested review of D9832: doc: Use precise permission flags where possible.
Thu, Jul 22, 15:07
PiRK updated the summary of D9831: net: Remove forcerelay of rejected txs.
Thu, Jul 22, 14:35
PiRK requested review of D9831: net: Remove forcerelay of rejected txs.
Thu, Jul 22, 14:33
PiRK added a comment to D9830: Improve the p2p_inv_download test by using a mocked time.

@bot build-master

Thu, Jul 22, 13:45
PiRK accepted D9830: Improve the p2p_inv_download test by using a mocked time.
Thu, Jul 22, 13:40

Wed, Jul 21

PiRK closed D9816: make copyright headers more consistent.
Wed, Jul 21, 12:10
PiRK committed rABC5e1ee2503a55: make copyright headers more consistent (authored by PiRK).
make copyright headers more consistent
Wed, Jul 21, 12:10
PiRK closed D9827: rpc_net.py: sync blocks before mining a new block on node1.
Wed, Jul 21, 12:09
PiRK committed rABCc3d78b39f11a: rpc_net.py: sync blocks before mining a new block on node1 (authored by PiRK).
rpc_net.py: sync blocks before mining a new block on node1
Wed, Jul 21, 12:09
PiRK updated the summary of D9827: rpc_net.py: sync blocks before mining a new block on node1.
Wed, Jul 21, 08:53
PiRK requested review of D9827: rpc_net.py: sync blocks before mining a new block on node1.
Wed, Jul 21, 08:39
PiRK closed D9825: validation: Remove review-only comments + assertions.
Wed, Jul 21, 07:18
PiRK committed rABCe551bfacbff7: validation: Remove review-only comments + assertions (authored by Carl Dong <contact@carldong.me>).
validation: Remove review-only comments + assertions
Wed, Jul 21, 07:18
PiRK closed D9824: docs: Move FindFilesToPrune{,Manual} doxygen comment.
Wed, Jul 21, 07:16
PiRK committed rABCa9ecaa69dc3c: docs: Move FindFilesToPrune{,Manual} doxygen comment (authored by Carl Dong <contact@carldong.me>).
docs: Move FindFilesToPrune{,Manual} doxygen comment
Wed, Jul 21, 07:16
PiRK closed D9823: validation: Move FindFilesToPrune{,Manual} to BlockManager.
Wed, Jul 21, 07:15
PiRK committed rABCb4e269f92e77: validation: Move FindFilesToPrune{,Manual} to BlockManager (authored by Carl Dong <contact@carldong.me>).
validation: Move FindFilesToPrune{,Manual} to BlockManager
Wed, Jul 21, 07:15
PiRK closed D9822: validation: Move PruneOneBlockFile to BlockManager.
Wed, Jul 21, 07:03
PiRK committed rABC046b04cb79e9: validation: Move PruneOneBlockFile to BlockManager (authored by Carl Dong <contact@carldong.me>).
validation: Move PruneOneBlockFile to BlockManager
Wed, Jul 21, 07:03
PiRK closed D9821: validation: Pass in chainman to UnloadBlockIndex.
Wed, Jul 21, 07:02
PiRK committed rABC0082bd045768: validation: Pass in chainman to UnloadBlockIndex (authored by Carl Dong <contact@carldong.me>).
validation: Pass in chainman to UnloadBlockIndex
Wed, Jul 21, 07:02
PiRK closed D9820: validation: Move ~CMainCleanup logic to ~BlockManager.
Wed, Jul 21, 07:01
PiRK committed rABC37142f8783a6: validation: Move ~CMainCleanup logic to ~BlockManager (authored by Carl Dong <contact@carldong.me>).
validation: Move ~CMainCleanup logic to ~BlockManager
Wed, Jul 21, 07:01

Tue, Jul 20

PiRK accepted D9819: [avalanche] Track the time of the last new proof received.
Tue, Jul 20, 16:42
PiRK accepted D9818: [avalanche] Fix downloading proofs from peers that just inv'ed us.
Tue, Jul 20, 16:39
PiRK updated the summary of D9820: validation: Move ~CMainCleanup logic to ~BlockManager.
Tue, Jul 20, 16:33
PiRK requested review of D9825: validation: Remove review-only comments + assertions.
Tue, Jul 20, 16:31
PiRK updated the summary of D9824: docs: Move FindFilesToPrune{,Manual} doxygen comment.
Tue, Jul 20, 16:29
PiRK updated the summary of D9823: validation: Move FindFilesToPrune{,Manual} to BlockManager.
Tue, Jul 20, 16:28
PiRK requested review of D9824: docs: Move FindFilesToPrune{,Manual} doxygen comment.
Tue, Jul 20, 16:27
PiRK updated the summary of D9823: validation: Move FindFilesToPrune{,Manual} to BlockManager.
Tue, Jul 20, 16:26
PiRK requested review of D9823: validation: Move FindFilesToPrune{,Manual} to BlockManager.
Tue, Jul 20, 16:26
PiRK updated the summary of D9821: validation: Pass in chainman to UnloadBlockIndex.
Tue, Jul 20, 16:24
PiRK requested review of D9822: validation: Move PruneOneBlockFile to BlockManager.
Tue, Jul 20, 16:24
PiRK requested review of D9821: validation: Pass in chainman to UnloadBlockIndex.
Tue, Jul 20, 16:22
PiRK requested review of D9820: validation: Move ~CMainCleanup logic to ~BlockManager.
Tue, Jul 20, 16:21
PiRK closed D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 10:13
PiRK committed rABC3db7a09feb5c: copyright-header: add two expected holder names (authored by PiRK).
copyright-header: add two expected holder names
Tue, Jul 20, 10:12
PiRK closed D9815: scripted-diff: Add missed copyright headers.
Tue, Jul 20, 10:11
PiRK committed rABC8f12ff4b1e31: scripted-diff: Add missed copyright headers (authored by PiRK).
scripted-diff: Add missed copyright headers
Tue, Jul 20, 10:11
PiRK updated the test plan for D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 09:56
PiRK updated the diff for D9816: make copyright headers more consistent.

fix also sighastype.h (missing "The")

Tue, Jul 20, 09:56
PiRK updated the summary of D9815: scripted-diff: Add missed copyright headers.
Tue, Jul 20, 09:52
PiRK closed D9814: doc: Add missed copyright headers.
Tue, Jul 20, 09:44
PiRK committed rABCd23d7fee22c0: doc: Add missed copyright headers (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
doc: Add missed copyright headers
Tue, Jul 20, 09:44
PiRK closed D9813: scripts: update copyright_header script to include additional files.
Tue, Jul 20, 09:43
PiRK committed rABCf1430bb4289d: scripts: update copyright_header script to include additional files (authored by gchuf <gasper.cefarin@gmail.com>).
scripts: update copyright_header script to include additional files
Tue, Jul 20, 09:42
PiRK closed D9812: Include Objective-C source files.
Tue, Jul 20, 09:41
PiRK committed rABC9e2e1625dec6: Include Objective-C source files (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
Include Objective-C source files
Tue, Jul 20, 09:41
PiRK closed D9811: Scripts and tools: Drop no-longer-relevant copyright holder names.
Tue, Jul 20, 09:40
PiRK committed rABCcf7fcac26cc0: Scripts and tools: Drop no-longer-relevant copyright holder names (authored by Ben Woosley <ben.woosley@gmail.com>).
Scripts and tools: Drop no-longer-relevant copyright holder names
Tue, Jul 20, 09:40
PiRK closed D9810: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions.
Tue, Jul 20, 09:39
PiRK committed rABC8de4a6bfaab1: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions (authored by Ben Woosley <ben.woosley@gmail.com>).
Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions
Tue, Jul 20, 09:39
PiRK updated the test plan for D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 09:33
PiRK requested review of D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 09:33
PiRK updated the diff for D9816: make copyright headers more consistent.

fix another discrepency with an extra dash

Tue, Jul 20, 09:28
PiRK updated the diff for D9816: make copyright headers more consistent.

remove also a "-" that the copyright headers script cannot handle

Tue, Jul 20, 09:24
PiRK requested review of D9816: make copyright headers more consistent.
Tue, Jul 20, 09:21
PiRK requested review of D9815: scripted-diff: Add missed copyright headers.
Tue, Jul 20, 09:18
PiRK updated the summary of D9814: doc: Add missed copyright headers.
Tue, Jul 20, 09:17
PiRK requested review of D9814: doc: Add missed copyright headers.
Tue, Jul 20, 09:16
PiRK requested review of D9813: scripts: update copyright_header script to include additional files.
Tue, Jul 20, 09:14
PiRK requested review of D9812: Include Objective-C source files.
Tue, Jul 20, 09:12
PiRK requested review of D9811: Scripts and tools: Drop no-longer-relevant copyright holder names.
Tue, Jul 20, 09:11
PiRK requested review of D9810: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions.
Tue, Jul 20, 09:09

Mon, Jul 19

PiRK accepted D9806: Rebrand comments in functional tests.
Mon, Jul 19, 16:41
PiRK accepted D9807: Rebrand miscellaneous comments.
Mon, Jul 19, 16:38
PiRK accepted D9808: Rename the test unspendable address.
Mon, Jul 19, 16:37
PiRK abandoned D9478: [avalanche] make avalanche peer discovery in a simple case.

D9739

Mon, Jul 19, 12:43

Fri, Jul 16

PiRK accepted D9800: Update the seed pattern to accept 0.23 or 0.24 version.
Fri, Jul 16, 13:27
PiRK accepted D9801: Remove the 1s timeouts in p2p_inv_download.
Fri, Jul 16, 13:26
PiRK accepted D9795: Bump version to 0.23.9.
Fri, Jul 16, 10:00

Thu, Jul 15

PiRK accepted D9794: [avalanche] Check the utxo limit using the verifyavalancheproof RPC.
Thu, Jul 15, 15:24
PiRK accepted D9793: [avalanche] Improve error messages from the addavalanchenode RPC.
Thu, Jul 15, 15:23
PiRK accepted D9792: [avalanche] Supply an optional delegation to the addavalanchenode RPC.
Thu, Jul 15, 15:17
PiRK closed D9790: Remove mempool global.
Thu, Jul 15, 12:26
PiRK committed rABC08e10206cf5c: Remove mempool global (authored by MarcoFalke <falke.marco@gmail.com>).
Remove mempool global
Thu, Jul 15, 12:26
PiRK closed D9789: Remove mempool global from p2p.
Thu, Jul 15, 11:58
PiRK committed rABCae2cf3e1b0d8: Remove mempool global from p2p (authored by MarcoFalke <falke.marco@gmail.com>).
Remove mempool global from p2p
Thu, Jul 15, 11:58
PiRK closed D9788: Remove mempool global from init.
Thu, Jul 15, 11:57
PiRK committed rABCd5099f490d7a: Remove mempool global from init (authored by MarcoFalke <falke.marco@gmail.com>).
Remove mempool global from init
Thu, Jul 15, 11:57
PiRK updated the diff for D9790: Remove mempool global.

rebase onto D9791

Thu, Jul 15, 11:33
PiRK updated the diff for D9789: Remove mempool global from p2p.

rebase onto D9791

Thu, Jul 15, 11:31
PiRK updated the diff for D9788: Remove mempool global from init.

rebase onto D9791

Thu, Jul 15, 11:30
PiRK accepted D9791: [avalanche] Fix a lock order inversion on shutdown.
Thu, Jul 15, 10:11