User Details
- User Since
- Aug 5 2020, 16:14 (188 w, 5 d)
Yesterday
Fri, Mar 15
remember ownership via a flag in CachedWalletPasswordWidget.init, only clear memory if the widget owns the bytearray
try a different approach
add a comment to explain why copy
Thu, Mar 14
remove a couple more gArgs in rpc code
Wed, Mar 13
Tue, Mar 12
fix shebang and permissions, for consistency with all other tests.
can be reviewed by comparing with https://github.com/jamesob/bitcoin/blob/e4be0e9b0661a8af49c4e6d5472804913f04b8fc/test/functional/feature_maxtipage.py (file after the second commit, minus documentation nits from https://github.com/bitcoin/bitcoin/commit/faf44876db555f7488c8df96db9fa88b793f897c)
Having the function return a True or a truthy string feels a bit weird and kind of violates the principle of least astonishment imo. But I can't really think of a more concise way of doing, and you documented the behavior in the doxygen comment.
make code style consistent with the rest of the codebase
remove no-op settings.setFallbacksEnabled(false);
This only affects the settings var in the local scope, which is unused.