rebase and shorten chronik_bridge::ffi -> ffi

idiomaticity

The setup_scripts/chronik-client_websocket.py failure above seems unrelated to me. It still is a bit suspicious, as I haven't seen an unrelated chronik ws related failure in a while.

@bot chronik-client-integration-test

I'm wondering if the way each individual CBlockIndex is fetched with the cs_main lock could be an issue. I guess there could be more efficient ways to do it, but mostly I wonder if there is a risk of returning an inconsistent list of headers if a reorg happens between two locks.

sigh

rededuplicate boundary checks, keep them early in the function this time

revert deduplicate

This is weird. It looks intermittent

review

nit: use another constant for the number of blocks, make it smaller because it does not change the validity of the test

add a comment about boundary check

review

the change in how dnsseed.dump is written (int(rep.fGood) vs rep.reliabilityStatus == ReliabilityStatus::OK ? 1 : 0) is initially wrong, because it seems to me reliabilityStatus is not actually initialized before the second time we connect to the node. Still investigating.

tests

One comment nit/typo.

--unused include

rebase on D16482 to unbreak CI

revert bumping of pip for now. The corresponding alert (CVE-2023-5752) does not affect us, we don't install anything from a Mercurial VCS URL

There are still issues related to btchip-python==0.1.32 metadata

remove debugging print

no need to disable the range_check, the error is caught in main.cpp::ThreadCrawler

add tests

This one should be relatively easy to test (but hopefully without having to add a dependency to the main unit test framework like the source material does)

doc layout

improve comment, set range_check=false when calling ReadCompactSize to prevent the function from throwing if the net message is intentionnaly bad, don't duplicate MAX_HEADERS_RESULTS but include it via net_processing.h.