Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (104 w, 5 d)

Recent Activity

Wed, Jul 27

PiRK added a comment to D11796: test: test availability of ports before assigning them.

What's the impact on performance ?

Wed, Jul 27, 07:33

Sat, Jul 23

PiRK closed D11794: doc/style followups in MempoolAcceptResult.
Sat, Jul 23, 18:32
PiRK committed rABC85d22539836d: doc/style followups in MempoolAcceptResult (authored by glozow <gzhao408@berkeley.edu>).
doc/style followups in MempoolAcceptResult
Sat, Jul 23, 18:32
PiRK updated the diff for D11796: test: test availability of ports before assigning them.

functools.cache is not available prior to python version 3.9. Use functools.lru_cache(max_size=None) instead.

Sat, Jul 23, 13:25
PiRK updated the summary of D11796: test: test availability of ports before assigning them.
Sat, Jul 23, 13:19
PiRK published D11796: test: test availability of ports before assigning them for review.
Sat, Jul 23, 13:19

Fri, Jul 22

PiRK requested review of D11794: doc/style followups in MempoolAcceptResult.
Fri, Jul 22, 13:53
PiRK closed D11788: Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime.
Fri, Jul 22, 09:59
PiRK committed rABC10843101904e: Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime
Fri, Jul 22, 09:59
PiRK committed rABC7177049f17c6: Simplify GetTime (authored by MarcoFalke <falke.marco@gmail.com>).
Simplify GetTime
Fri, Jul 22, 09:55
PiRK closed D11791: Simplify GetTime.
Fri, Jul 22, 09:55
PiRK closed D11790: util: Use std::chrono for time getters.
Fri, Jul 22, 09:55
PiRK committed rABCa208aeb22905: util: Use std::chrono for time getters (authored by MarcoFalke <falke.marco@gmail.com>).
util: Use std::chrono for time getters
Fri, Jul 22, 09:55
PiRK closed D11789: time: add runtime sanity check.
Fri, Jul 22, 09:55
PiRK committed rABC7ba2b08340f9: time: add runtime sanity check (authored by Cory Fields <cory-nospam-@coryfields.com>).
time: add runtime sanity check
Fri, Jul 22, 09:55
PiRK requested review of D11791: Simplify GetTime.
Fri, Jul 22, 08:51
teamcity awarded D11789: time: add runtime sanity check a Haypence token.
Fri, Jul 22, 08:32
PiRK retitled D11790: util: Use std::chrono for time getters from util: Use std::chrono for time gettersi to util: Use std::chrono for time getters.
Fri, Jul 22, 08:24
PiRK updated the diff for D11788: Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime.

Unmerge the test. No need to duplicate this test, though, so don't put it in rpc_uptime.py

Fri, Jul 22, 08:23
PiRK requested review of D11790: util: Use std::chrono for time getters.
Fri, Jul 22, 08:14
PiRK updated the summary of D11789: time: add runtime sanity check.
Fri, Jul 22, 08:12
PiRK updated the summary of D11789: time: add runtime sanity check.
Fri, Jul 22, 08:12
PiRK requested review of D11789: time: add runtime sanity check.
Fri, Jul 22, 08:09
PiRK updated the diff for D11788: Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime.

merge abc_rpc_mocktime.py and rpc_uptime.py

Fri, Jul 22, 07:35
PiRK planned changes to D11788: Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime.

need to merge with existing test from D6022

Fri, Jul 22, 07:20
PiRK requested review of D11788: Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime.
Fri, Jul 22, 07:19
PiRK closed D11781: [refactor] improve style for touched code.
Fri, Jul 22, 06:54
PiRK closed D11780: [refactor] const ATMPArgs and non-const Workspace.
Fri, Jul 22, 06:53
PiRK committed rABC9aa6dcdcc32a: [refactor] const ATMPArgs and non-const Workspace (authored by PiRK).
[refactor] const ATMPArgs and non-const Workspace
Fri, Jul 22, 06:53
PiRK committed rABCfc122b744644: [refactor] improve style for touched code (authored by gzhao408 <gzhao408@berkeley.edu>).
[refactor] improve style for touched code
Fri, Jul 22, 06:53
PiRK closed D11779: [refactor] return MempoolAcceptResult.
Fri, Jul 22, 06:53
PiRK closed D11778: [refactor] clean up logic in testmempoolaccept.
Fri, Jul 22, 06:53
PiRK committed rABC736e02387630: [refactor] return MempoolAcceptResult (authored by gzhao408 <gzhao408@berkeley.edu>).
[refactor] return MempoolAcceptResult
Fri, Jul 22, 06:53
PiRK committed rABC9c234285e9a8: [refactor] clean up logic in testmempoolaccept (authored by gzhao408 <gzhao408@berkeley.edu>).
[refactor] clean up logic in testmempoolaccept
Fri, Jul 22, 06:53
PiRK closed D11783: [build] Fix doxygen documentation issues and enable -Wdocumentation.
Fri, Jul 22, 06:53
PiRK committed rABCf83e0a6af7cb: [build] Fix doxygen documentation issues and enable -Wdocumentation (authored by PiRK).
[build] Fix doxygen documentation issues and enable -Wdocumentation
Fri, Jul 22, 06:53

Thu, Jul 21

teamcity awarded D11779: [refactor] return MempoolAcceptResult a Haypence token.
Thu, Jul 21, 19:29
PiRK accepted D11784: Remove dead code in abc_p2p_fullblocktests.
Thu, Jul 21, 15:20
PiRK updated the summary of D11783: [build] Fix doxygen documentation issues and enable -Wdocumentation.
Thu, Jul 21, 13:54
PiRK updated the summary of D11783: [build] Fix doxygen documentation issues and enable -Wdocumentation.
Thu, Jul 21, 13:53
PiRK requested review of D11783: [build] Fix doxygen documentation issues and enable -Wdocumentation.
Thu, Jul 21, 13:47
PiRK updated the test plan for D11779: [refactor] return MempoolAcceptResult.
Thu, Jul 21, 10:09
PiRK requested review of D11781: [refactor] improve style for touched code.
Thu, Jul 21, 10:08
PiRK requested review of D11780: [refactor] const ATMPArgs and non-const Workspace.
Thu, Jul 21, 10:07
PiRK requested review of D11779: [refactor] return MempoolAcceptResult.
Thu, Jul 21, 10:05
PiRK requested review of D11778: [refactor] clean up logic in testmempoolaccept.
Thu, Jul 21, 09:58
PiRK closed D11773: validation: Guard all chainstates with cs_main.
Thu, Jul 21, 07:39
PiRK committed rABC0752566336a2: validation: Guard all chainstates with cs_main (authored by Carl Dong <contact@carldong.me>).
validation: Guard all chainstates with cs_main
Thu, Jul 21, 07:39
PiRK closed D11772: validation: remove redundant check on pindex.
Thu, Jul 21, 07:39
PiRK committed rABC602209d248fc: validation: remove redundant check on pindex (authored by PiRK).
validation: remove redundant check on pindex
Thu, Jul 21, 07:39
PiRK closed D11767: locks and docs in ATMP and CheckInputsFromMempoolAndCache.
Thu, Jul 21, 07:37
PiRK committed rABC9b904d85f5a3: locks and docs in ATMP and CheckInputsFromMempoolAndCache (authored by gzhao408 <gzhao408@berkeley.edu>).
locks and docs in ATMP and CheckInputsFromMempoolAndCache
Thu, Jul 21, 07:37

Wed, Jul 20

PiRK updated the test plan for D11773: validation: Guard all chainstates with cs_main.
Wed, Jul 20, 10:10
PiRK requested review of D11773: validation: Guard all chainstates with cs_main.
Wed, Jul 20, 09:59
PiRK requested review of D11772: validation: remove redundant check on pindex.
Wed, Jul 20, 09:36
PiRK requested review of D11767: locks and docs in ATMP and CheckInputsFromMempoolAndCache.

Test plan updated with TSAN

Wed, Jul 20, 09:18
PiRK updated the test plan for D11767: locks and docs in ATMP and CheckInputsFromMempoolAndCache.
Wed, Jul 20, 09:17
PiRK closed D11765: [mempool] Remove unnecessary try-block.
Wed, Jul 20, 06:53
PiRK committed rABC73f6a97f2608: [mempool] Remove unnecessary try-block (authored by PiRK).
[mempool] Remove unnecessary try-block
Wed, Jul 20, 06:53
PiRK closed D11764: only load unbroadcast tx if it exists in loaded mempool.
Wed, Jul 20, 06:53
PiRK committed rABCa1109e55df5f: only load unbroadcast tx if it exists in loaded mempool (authored by PiRK).
only load unbroadcast tx if it exists in loaded mempool
Wed, Jul 20, 06:53

Tue, Jul 19

teamcity awarded D11767: locks and docs in ATMP and CheckInputsFromMempoolAndCache a Haypence token.
Tue, Jul 19, 15:57
PiRK added a comment to D11767: locks and docs in ATMP and CheckInputsFromMempoolAndCache.

@bot build-tsan

Tue, Jul 19, 15:57
PiRK requested review of D11767: locks and docs in ATMP and CheckInputsFromMempoolAndCache.
Tue, Jul 19, 13:49
PiRK updated the summary of D11765: [mempool] Remove unnecessary try-block.
Tue, Jul 19, 13:10
PiRK requested review of D11765: [mempool] Remove unnecessary try-block.
Tue, Jul 19, 13:09
PiRK updated the diff for D11764: only load unbroadcast tx if it exists in loaded mempool.

remove blank line

Tue, Jul 19, 13:07
PiRK updated the summary of D11764: only load unbroadcast tx if it exists in loaded mempool.
Tue, Jul 19, 13:05
PiRK updated the diff for D11764: only load unbroadcast tx if it exists in loaded mempool.

include relevant minor changes from core#19879: comment improvements and don't use an unnecessary intermediate variable added_tx

Tue, Jul 19, 13:04
PiRK requested review of D11764: only load unbroadcast tx if it exists in loaded mempool.
Tue, Jul 19, 12:52
PiRK accepted D11763: [avalanche][trivial] Fix bad wording in log.
Tue, Jul 19, 11:53

Fri, Jul 15

PiRK accepted D11757: [avalanche] Print the proofid in getavalancheoeerinfo.
Fri, Jul 15, 14:13
PiRK closed D11755: Fix outdated comments referring to ::ChainActive().
Fri, Jul 15, 13:12
PiRK committed rABC1b305875768a: Fix outdated comments referring to ::ChainActive() (authored by Samuel Dobson <dobsonsa68@gmail.com>).
Fix outdated comments referring to ::ChainActive()
Fri, Jul 15, 13:12
PiRK updated the diff for D11755: Fix outdated comments referring to ::ChainActive().

fix also the last remaining reference to ChainstateActive() (this one is still unfixed in Core)

Fri, Jul 15, 11:56
PiRK updated the test plan for D11755: Fix outdated comments referring to ::ChainActive().
Fri, Jul 15, 11:52
PiRK updated the test plan for D11755: Fix outdated comments referring to ::ChainActive().
Fri, Jul 15, 11:52
PiRK requested review of D11755: Fix outdated comments referring to ::ChainActive().
Fri, Jul 15, 11:50
PiRK closed D11753: validation: Farewell, global Chainstate!.
Fri, Jul 15, 10:45
PiRK committed rABCf78286b329af: validation: Farewell, global Chainstate! (authored by Carl Dong <contact@carldong.me>).
validation: Farewell, global Chainstate!
Fri, Jul 15, 10:45
PiRK closed D11752: qt/test: Reset chainman in ~ChainstateManager instead.
Fri, Jul 15, 10:45
PiRK closed D11744: make FindBlockToFinalize a CChainState member.
Fri, Jul 15, 10:45
PiRK committed rABC3151d3637eac: qt/test: Reset chainman in ~ChainstateManager instead (authored by Carl Dong <contact@carldong.me>).
qt/test: Reset chainman in ~ChainstateManager instead
Fri, Jul 15, 10:45
PiRK committed rABC9d99cccc3809: make FindBlockToFinalize a CChainState member (authored by PiRK).
make FindBlockToFinalize a CChainState member
Fri, Jul 15, 10:45
PiRK closed D11751: refactor: Replace uses ChainActive() in interfaces/chain.cpp (follow-up).
Fri, Jul 15, 10:45
PiRK committed rABCde05c8ddedd6: refactor: Replace uses ChainActive() in interfaces/chain.cpp (follow-up) (authored by PiRK).
refactor: Replace uses ChainActive() in interfaces/chain.cpp (follow-up)
Fri, Jul 15, 10:45
PiRK accepted D11754: [avalanche] Fix the inboud requesting functional test.
Fri, Jul 15, 09:49
PiRK updated the diff for D11753: validation: Farewell, global Chainstate!.

include the change in src/qt/test/apptests.cpp that Core incorrectly included in the previous commit (D11752)

Fri, Jul 15, 09:27
PiRK updated the diff for D11752: qt/test: Reset chainman in ~ChainstateManager instead.

restore the g_chainman reset code in apptests.cpp, as it is still needed at this point. It should be removed in D11753, when the chain state manager actually becomes a member of the test setup (constructed and destructed in each test) rather than a global.

Fri, Jul 15, 09:23
PiRK planned changes to D11753: validation: Farewell, global Chainstate!.
Fri, Jul 15, 08:45
PiRK planned changes to D11752: qt/test: Reset chainman in ~ChainstateManager instead.

Looks like I missed something related to the GUI and or PaymentServer code.

Fri, Jul 15, 08:44
PiRK requested review of D11753: validation: Farewell, global Chainstate!.
Fri, Jul 15, 08:33
PiRK requested review of D11752: qt/test: Reset chainman in ~ChainstateManager instead.
Fri, Jul 15, 08:29
PiRK requested review of D11751: refactor: Replace uses ChainActive() in interfaces/chain.cpp (follow-up).
Fri, Jul 15, 08:15
PiRK closed D11748: use m_chain in CChainState::UpdateFlagsForBlock and CChainState::FinalizeBlock.
Fri, Jul 15, 07:43
PiRK committed rABCb562de8831b1: use m_chain in CChainState::UpdateFlagsForBlock and CChainState::FinalizeBlock (authored by PiRK).
use m_chain in CChainState::UpdateFlagsForBlock and CChainState::FinalizeBlock
Fri, Jul 15, 07:43
PiRK closed D11742: pass active_chainstate to buildRandomProof.
Fri, Jul 15, 07:34
PiRK committed rABCc9189fd7a317: pass active_chainstate to buildRandomProof (authored by PiRK).
pass active_chainstate to buildRandomProof
Fri, Jul 15, 07:34
PiRK closed D11704: [avalanche] pass chainman to Proof::verify.
Fri, Jul 15, 07:33
PiRK committed rABC6c8d3340dc7f: [avalanche] pass chainman to Proof::verify (authored by PiRK).
[avalanche] pass chainman to Proof::verify
Fri, Jul 15, 07:33