In D11796#264462, @Fabien wrote:

What's the impact on performance ?

functools.cache is not available prior to python version 3.9. Use functools.lru_cache(max_size=None) instead.

Unmerge the test. No need to duplicate this test, though, so don't put it in rpc_uptime.py

merge abc_rpc_mocktime.py and rpc_uptime.py

need to merge with existing test from D6022

Test plan updated with TSAN

@bot build-tsan

remove blank line

include relevant minor changes from core#19879: comment improvements and don't use an unnecessary intermediate variable added_tx

fix also the last remaining reference to ChainstateActive() (this one is still unfixed in Core)

include the change in src/qt/test/apptests.cpp that Core incorrectly included in the previous commit (D11752)

restore the g_chainman reset code in apptests.cpp, as it is still needed at this point. It should be removed in D11753, when the chain state manager actually becomes a member of the test setup (constructed and destructed in each test) rather than a global.

Looks like I missed something related to the GUI and or PaymentServer code.