Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (188 w, 5 d)

Recent Activity

Yesterday

PiRK accepted D15725: Bump version to 0.28.12.
Mon, Mar 18, 16:23
PiRK closed D15724: Move {Load,Dump}Mempool to kernel namespace.
Mon, Mar 18, 15:17
PiRK closed D15721: test/fuzz: Invoke LoadMempool via Chainstate.
Mon, Mar 18, 15:17
PiRK committed rABC6abd8113c18c: Move {Load,Dump}Mempool to kernel namespace (authored by Carl Dong <contact@carldong.me>).
Move {Load,Dump}Mempool to kernel namespace
Mon, Mar 18, 15:17
PiRK closed D15722: LoadMempool: Pass in load_path, stop using gArgs.
Mon, Mar 18, 15:17
PiRK closed D15723: Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel.
Mon, Mar 18, 15:17
PiRK committed rABC94e3f92a3f83: test/fuzz: Invoke LoadMempool via Chainstate (authored by Carl Dong <contact@carldong.me>).
test/fuzz: Invoke LoadMempool via Chainstate
Mon, Mar 18, 15:17
PiRK committed rABCc22846677483: Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel (authored by Carl Dong <contact@carldong.me>).
Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel
Mon, Mar 18, 15:17
PiRK committed rABCdc25f8f0ba45: LoadMempool: Pass in load_path, stop using gArgs (authored by Carl Dong <contact@carldong.me>).
LoadMempool: Pass in load_path, stop using gArgs
Mon, Mar 18, 15:17
PiRK closed D15719: mempool: Use NodeClock+friends for LoadMempool.
Mon, Mar 18, 15:17
PiRK closed D15718: Rename m_is_loaded -> m_load_tried.
Mon, Mar 18, 15:17
PiRK closed D15720: Move FopenFn to fsbridge namespace.
Mon, Mar 18, 15:17
PiRK committed rABC1bb3732dd70b: mempool: Use NodeClock+friends for LoadMempool (authored by Carl Dong <contact@carldong.me>).
mempool: Use NodeClock+friends for LoadMempool
Mon, Mar 18, 15:17
PiRK committed rABC75122e33aa92: Rename m_is_loaded -> m_load_tried (authored by PiRK).
Rename m_is_loaded -> m_load_tried
Mon, Mar 18, 15:17
PiRK committed rABC181f33bef0fd: Move FopenFn to fsbridge namespace (authored by Carl Dong <contact@carldong.me>).
Move FopenFn to fsbridge namespace
Mon, Mar 18, 15:17
PiRK closed D15716: DumpMempool: Use std::chrono instead of weird int64_t arthmetics.
Mon, Mar 18, 15:17
PiRK closed D15717: DumpMempool: Pass in dump_path, stop using gArgs.
Mon, Mar 18, 15:17
PiRK committed rABC54d2d1dd8893: DumpMempool: Pass in dump_path, stop using gArgs (authored by Carl Dong <contact@carldong.me>).
DumpMempool: Pass in dump_path, stop using gArgs
Mon, Mar 18, 15:17
PiRK committed rABC09d7c7ce2b96: DumpMempool: Use std::chrono instead of weird int64_t arthmetics (authored by Carl Dong <contact@carldong.me>).
DumpMempool: Use std::chrono instead of weird int64_t arthmetics
Mon, Mar 18, 15:17
PiRK closed D15715: test/mempool_persist: Test manual savemempool when -persistmempool=0.
Mon, Mar 18, 15:17
PiRK committed rABCc164bd190fa3: test/mempool_persist: Test manual savemempool when -persistmempool=0 (authored by Carl Dong <contact@carldong.me>).
test/mempool_persist: Test manual savemempool when -persistmempool=0
Mon, Mar 18, 15:17
PiRK updated the summary of D15724: Move {Load,Dump}Mempool to kernel namespace.
Mon, Mar 18, 13:50
PiRK requested review of D15724: Move {Load,Dump}Mempool to kernel namespace.
Mon, Mar 18, 13:49
PiRK requested review of D15723: Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel.
Mon, Mar 18, 13:46
PiRK requested review of D15722: LoadMempool: Pass in load_path, stop using gArgs.
Mon, Mar 18, 13:44
PiRK updated the test plan for D15721: test/fuzz: Invoke LoadMempool via Chainstate.
Mon, Mar 18, 13:42
PiRK requested review of D15721: test/fuzz: Invoke LoadMempool via Chainstate.
Mon, Mar 18, 13:41
PiRK updated the summary of D15720: Move FopenFn to fsbridge namespace.
Mon, Mar 18, 13:39
PiRK requested review of D15720: Move FopenFn to fsbridge namespace.
Mon, Mar 18, 13:38
PiRK requested review of D15719: mempool: Use NodeClock+friends for LoadMempool.
Mon, Mar 18, 13:35
PiRK updated the summary of D15718: Rename m_is_loaded -> m_load_tried.
Mon, Mar 18, 13:31
PiRK updated the summary of D15718: Rename m_is_loaded -> m_load_tried.
Mon, Mar 18, 13:30
PiRK requested review of D15718: Rename m_is_loaded -> m_load_tried.
Mon, Mar 18, 13:28
PiRK requested review of D15717: DumpMempool: Pass in dump_path, stop using gArgs.
Mon, Mar 18, 13:26
PiRK requested review of D15716: DumpMempool: Use std::chrono instead of weird int64_t arthmetics.
Mon, Mar 18, 13:24
PiRK requested review of D15715: test/mempool_persist: Test manual savemempool when -persistmempool=0.
Mon, Mar 18, 13:23
PiRK closed D15713: fuzz: Rework strong and weak net enum fuzzing.
Mon, Mar 18, 12:31
PiRK committed rABCbf123f046d93: fuzz: Rework strong and weak net enum fuzzing (authored by MarcoFalke <falke.marco@gmail.com>).
fuzz: Rework strong and weak net enum fuzzing
Mon, Mar 18, 12:31
PiRK requested review of D15713: fuzz: Rework strong and weak net enum fuzzing.
Mon, Mar 18, 09:09

Fri, Mar 15

PiRK closed D15699: fuzz: Add fuzzing harness for LoadMempool(...) and DumpMempool(...).
Fri, Mar 15, 14:29
PiRK committed rABCd361d204b892: fuzz: Add fuzzing harness for LoadMempool(...) and DumpMempool(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).
fuzz: Add fuzzing harness for LoadMempool(...) and DumpMempool(...)
Fri, Mar 15, 14:29
PiRK closed D15709: [electrum] fix error when cached password is forwarded to subwidget.
Fri, Mar 15, 14:26
PiRK committed rABC46bfa5ca7e27: [electrum] fix error when cached password is forwarded to subwidget (authored by PiRK).
[electrum] fix error when cached password is forwarded to subwidget
Fri, Mar 15, 14:26
PiRK closed D15708: [electrum] prefill the delegator key in the delegation editor when possible.
Fri, Mar 15, 14:26
PiRK committed rABC220efcb592cf: [electrum] prefill the delegator key in the delegation editor when possible (authored by PiRK).
[electrum] prefill the delegator key in the delegation editor when possible
Fri, Mar 15, 14:26
PiRK updated the diff for D15709: [electrum] fix error when cached password is forwarded to subwidget.

remember ownership via a flag in CachedWalletPasswordWidget.init, only clear memory if the widget owns the bytearray

Fri, Mar 15, 14:08
PiRK planned changes to D15709: [electrum] fix error when cached password is forwarded to subwidget.

try a different approach

Fri, Mar 15, 13:48
PiRK updated the summary of D15709: [electrum] fix error when cached password is forwarded to subwidget.
Fri, Mar 15, 09:58
PiRK accepted D15706: [chronik] Don't ever use mainnet on tests.
Fri, Mar 15, 09:57
PiRK accepted D15707: [chronik] Prevent potential port collision in chronik_serve.
Fri, Mar 15, 09:55
PiRK updated the diff for D15709: [electrum] fix error when cached password is forwarded to subwidget.

add a comment to explain why copy

Fri, Mar 15, 09:49
PiRK requested review of D15709: [electrum] fix error when cached password is forwarded to subwidget.
Fri, Mar 15, 09:42
PiRK requested review of D15708: [electrum] prefill the delegator key in the delegation editor when possible.
Fri, Mar 15, 09:25
PiRK accepted D15705: Make combine_logs.py executable.
Fri, Mar 15, 08:29

Thu, Mar 14

PiRK accepted D15702: [chronik] Fix a race in chronik_ws.
Thu, Mar 14, 19:10
PiRK accepted D15700: [Cashtab] Improve and simplify fiat API.
Thu, Mar 14, 17:19
PiRK accepted D15697: [mock-chronik-client] Match shape of subs in ws to ChronikClientNode for ChronikClientNode methods.
Thu, Mar 14, 17:10
PiRK accepted D15690: [token-server] Serve token icons (or blockie if unset).
Thu, Mar 14, 17:04
PiRK accepted D15698: Use GetConflictTx() where possible.
Thu, Mar 14, 15:09
PiRK closed D15696: rpc: Add EnsureArgsman helper.
Thu, Mar 14, 14:35
PiRK committed rABC9aaf86775f68: rpc: Add EnsureArgsman helper (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Add EnsureArgsman helper
Thu, Mar 14, 14:35
PiRK requested review of D15699: fuzz: Add fuzzing harness for LoadMempool(...) and DumpMempool(...).
Thu, Mar 14, 14:33
PiRK updated the diff for D15696: rpc: Add EnsureArgsman helper.

remove a couple more gArgs in rpc code

Thu, Mar 14, 13:33
PiRK closed D15695: rpc: Move mempool RPCs to new file.
Thu, Mar 14, 13:13
PiRK committed rABCeddfd16fbd77: rpc: Move mempool RPCs to new file (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Move mempool RPCs to new file
Thu, Mar 14, 13:13
PiRK requested review of D15696: rpc: Add EnsureArgsman helper.
Thu, Mar 14, 10:34
PiRK requested review of D15695: rpc: Move mempool RPCs to new file.
Thu, Mar 14, 10:09
PiRK accepted D15694: [mock-chronik-client] Support in-node websocket subscription methods.
Thu, Mar 14, 07:56
PiRK accepted D15692: [Cashtab] Bump extension version.
Thu, Mar 14, 07:51
PiRK accepted D15691: [Cashtab] Better css for configure options.
Thu, Mar 14, 07:50

Wed, Mar 13

PiRK closed D15688: test: add functional test for `-maxtipage` parameter.
Wed, Mar 13, 08:36
PiRK committed rABC23f60e0bd66b: test: add functional test for `-maxtipage` parameter (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: add functional test for `-maxtipage` parameter
Wed, Mar 13, 08:36
PiRK accepted D15684: [Cashtab] Create custom modal for version upgrades.
Wed, Mar 13, 08:35
PiRK accepted D15678: [token-server] Add endpoint to check address eligiblity for token rewards.
Wed, Mar 13, 08:30
PiRK updated the diff for D15688: test: add functional test for `-maxtipage` parameter.

Partial backport of https://github.com/bitcoin/bitcoin/pull/25704/commits/faf44876db555f7488c8df96db9fa88b793f897c

Wed, Mar 13, 07:47

Tue, Mar 12

PiRK updated the diff for D15688: test: add functional test for `-maxtipage` parameter.

fix shebang and permissions, for consistency with all other tests.

Tue, Mar 12, 17:13
PiRK added a comment to D15688: test: add functional test for `-maxtipage` parameter.

can be reviewed by comparing with https://github.com/jamesob/bitcoin/blob/e4be0e9b0661a8af49c4e6d5472804913f04b8fc/test/functional/feature_maxtipage.py (file after the second commit, minus documentation nits from https://github.com/bitcoin/bitcoin/commit/faf44876db555f7488c8df96db9fa88b793f897c)

Tue, Mar 12, 17:11
PiRK requested review of D15688: test: add functional test for `-maxtipage` parameter.
Tue, Mar 12, 17:09
PiRK closed D14993: Extend bilingual_str support for tinyformat.
Tue, Mar 12, 14:26
PiRK committed rABC58c73bcf68fb: Extend bilingual_str support for tinyformat (authored by Ryan Ofsky <ryan@ofsky.org>).
Extend bilingual_str support for tinyformat
Tue, Mar 12, 14:26
PiRK accepted D15676: [Cashtab] Consolidate send xec validation functions.

Having the function return a True or a truthy string feels a bit weird and kind of violates the principle of least astonishment imo. But I can't really think of a more concise way of doing, and you documented the behavior in the doxygen comment.

Tue, Mar 12, 14:20
PiRK accepted D15681: [Cashtab] Simplify and standardize buttons.
Tue, Mar 12, 13:25
PiRK closed D15682: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core.
Tue, Mar 12, 10:46
PiRK committed rABC886f8a898827: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core (authored by PiRK).
[gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core
Tue, Mar 12, 10:46
PiRK updated the diff for D14993: Extend bilingual_str support for tinyformat.

make code style consistent with the rest of the codebase

Tue, Mar 12, 10:21
PiRK updated the diff for D15682: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core.

remove no-op settings.setFallbacksEnabled(false);
This only affects the settings var in the local scope, which is unused.

Tue, Mar 12, 10:12
PiRK planned changes to D15682: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core.
Tue, Mar 12, 10:10
PiRK accepted D15680: [Cashtab] Faster onboarding for new users.
Tue, Mar 12, 09:54
PiRK accepted D15675: [Cashtab] Move domain names for alias and token icons.
Tue, Mar 12, 09:11
PiRK added inline comments to D15682: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core.
Tue, Mar 12, 09:08
PiRK added inline comments to D15682: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core.
Tue, Mar 12, 09:01
PiRK updated the summary of D15682: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core.
Tue, Mar 12, 08:55
PiRK requested review of D15682: [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core.
Tue, Mar 12, 08:53
PiRK added a comment to D15674: [CI] Add CI configuration for the GUIX builds.

I tried reviewing one of these guix diffs but got an error about not having the required deps (and running the script wiped my build/ dir and also all node_modules.

Tue, Mar 12, 08:38
PiRK accepted D15674: [CI] Add CI configuration for the GUIX builds.
Tue, Mar 12, 08:32
PiRK closed D15673: refactor: Move ChainstateManager options into m_options struct.
Tue, Mar 12, 07:46
PiRK committed rABCc6e0d37e537e: refactor: Move ChainstateManager options into m_options struct (authored by Ryan Ofsky <ryan@ofsky.org>).
refactor: Move ChainstateManager options into m_options struct
Tue, Mar 12, 07:45

Mon, Mar 11

PiRK requested review of D15673: refactor: Move ChainstateManager options into m_options struct.
Mon, Mar 11, 14:59
PiRK accepted D15670: [Cashtab] Better function to convert user-entered fiat prices to satoshis.
Mon, Mar 11, 13:36
PiRK accepted D15671: [Cashtab] Add and implement new helper function to get user locale.
Mon, Mar 11, 13:32