PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since: Aug 5 2020, 16:14 (232 w, 1 d)

Recent Activity
View All

Today

PiRK closed D17553: [electrum] trezor: implement "seedless" mode (option during initialization).

Fri, Jan 17, 11:39

PiRK committed rABC0377d768572f: [electrum] trezor: implement "seedless" mode (option during initialization) (authored by PiRK).

[electrum] trezor: implement "seedless" mode (option during initialization)

Fri, Jan 17, 11:39

PiRK accepted D17554: [electrum] Better trezor homescreen support.

Fri, Jan 17, 10:52

PiRK retitled D17553: [electrum] trezor: implement "seedless" mode (option during initialization) from trezor: implement "seedless" mode (option during initialization) to [electrum] trezor: implement "seedless" mode (option during initialization).

Fri, Jan 17, 10:34

PiRK requested review of D17553: [electrum] trezor: implement "seedless" mode (option during initialization).

Fri, Jan 17, 10:32

PiRK accepted D17547: [electrum] Bugfix: close the "Check your trezor" popup after entering a passphrase.

tested with a Trezor T

Fri, Jan 17, 08:10

PiRK closed D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.

Fri, Jan 17, 08:08

PiRK committed rABCaf7dbeb97b63: Cache block index entry corresponding to assumeutxo snapshot base blockhash (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Cache block index entry corresponding to assumeutxo snapshot base blockhash

Fri, Jan 17, 08:08

PiRK closed D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.

Fri, Jan 17, 08:08

PiRK closed D17536: Documentation improvements for assumeutxo.

Fri, Jan 17, 08:08

PiRK closed D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

Fri, Jan 17, 08:08

PiRK committed rABCa5d25d3b48f3: Move CheckBlockIndex() from Chainstate to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Move CheckBlockIndex() from Chainstate to ChainstateManager

Fri, Jan 17, 08:08

PiRK committed rABC781f67df62a8: Documentation improvements for assumeutxo (authored by Ryan Ofsky <ryan@ofsky.org>).

Documentation improvements for assumeutxo

Fri, Jan 17, 08:08

PiRK committed rABCce02141a9db8: Fix initialization of setBlockIndexCandidates when working with multiple… (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Fix initialization of setBlockIndexCandidates when working with multiple…

Fri, Jan 17, 08:07

PiRK closed D17534: Tighten requirements for adding elements to setBlockIndexCandidates.

Fri, Jan 17, 08:07

PiRK committed rABCc3eb66ed6134: Tighten requirements for adding elements to setBlockIndexCandidates (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Tighten requirements for adding elements to setBlockIndexCandidates

Fri, Jan 17, 08:07

PiRK closed D17533: Move block-storage-related logic to ChainstateManager.

Fri, Jan 17, 08:07

PiRK committed rABC2edc904cea06: Move block-storage-related logic to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Move block-storage-related logic to ChainstateManager

Fri, Jan 17, 08:07

PiRK committed rABCe476633f2c51: Add wrapper for adding entries to a chainstate's block index candidates (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Add wrapper for adding entries to a chainstate's block index candidates

Fri, Jan 17, 08:07

PiRK closed D17532: Add wrapper for adding entries to a chainstate's block index candidates.

Fri, Jan 17, 08:07

PiRK closed D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.

Fri, Jan 17, 08:07

PiRK committed rABCca86cbd58f3e: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot

Fri, Jan 17, 08:07

PiRK closed D17433: Move block-arrival information / preciousblock counters to ChainstateManager.

Fri, Jan 17, 08:07

PiRK committed rABC5ad8a704fdcb: Move block-arrival information / preciousblock counters to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Move block-arrival information / preciousblock counters to ChainstateManager

Fri, Jan 17, 08:07

PiRK closed D17432: Explicitly track maximum block height stored in undo files.

Fri, Jan 17, 08:07

PiRK committed rABCcfc92ee56946: Explicitly track maximum block height stored in undo files (authored by Suhas Daftuar <sdaftuar@chaincode.com>).

Explicitly track maximum block height stored in undo files

Fri, Jan 17, 08:07

Yesterday

PiRK accepted D17546: [electrum] Fix the homescreen change with all devices.

Thu, Jan 16, 17:08

PiRK updated the diff for D17533: Move block-storage-related logic to ChainstateManager.

feedback

Thu, Jan 16, 08:55

PiRK accepted D17543: [mock-chronik-client] Clean up test mocks file.

Thu, Jan 16, 07:37

PiRK accepted D17542: [mock-chronik-client] Improve path defs for typescript build.

Thu, Jan 16, 07:36

Wed, Jan 15

PiRK requested review of D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.

Wed, Jan 15, 20:55

PiRK updated the diff for D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.

rebase

Wed, Jan 15, 20:42

PiRK updated the diff for D17536: Documentation improvements for assumeutxo.

rebase

Wed, Jan 15, 20:30

PiRK updated the diff for D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

rebase

Wed, Jan 15, 20:29

PiRK updated the diff for D17534: Tighten requirements for adding elements to setBlockIndexCandidates.

rebase

Wed, Jan 15, 19:56

PiRK updated the diff for D17533: Move block-storage-related logic to ChainstateManager.

remove wrong negative lock annotation

Wed, Jan 15, 19:54

PiRK accepted D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.

Wed, Jan 15, 19:47

PiRK accepted D17530: test: Fail if connect_nodes fails.

Wed, Jan 15, 19:46

PiRK planned changes to D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.

needs a rebase

Wed, Jan 15, 11:11

PiRK planned changes to D17536: Documentation improvements for assumeutxo.

needs a rebase

Wed, Jan 15, 11:10

PiRK planned changes to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

Wed, Jan 15, 11:10

PiRK added a comment to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

needs

Wed, Jan 15, 11:10

PiRK planned changes to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.

needs a rebase

Wed, Jan 15, 11:10

PiRK planned changes to D17533: Move block-storage-related logic to ChainstateManager.

lock issue detected by clang

Wed, Jan 15, 11:10

PiRK requested review of D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.

Wed, Jan 15, 11:00

PiRK requested review of D17536: Documentation improvements for assumeutxo.

Wed, Jan 15, 10:57

PiRK added inline comments to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.

Wed, Jan 15, 10:56

PiRK requested review of D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

Wed, Jan 15, 10:54

PiRK requested review of D17534: Tighten requirements for adding elements to setBlockIndexCandidates.

Wed, Jan 15, 10:53

PiRK requested review of D17533: Move block-storage-related logic to ChainstateManager.

Wed, Jan 15, 10:51

PiRK requested review of D17532: Add wrapper for adding entries to a chainstate's block index candidates.

Wed, Jan 15, 10:50

PiRK updated the diff for D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.

rebase, remove now useless hack to skip checkblockindex from D14653

Wed, Jan 15, 10:48

PiRK accepted D17531: [test] Fix intermittent timeouts in various functional tests.

Wed, Jan 15, 09:21

PiRK requested changes to D17530: test: Fail if connect_nodes fails.

Wed, Jan 15, 09:18

PiRK accepted D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.

Wed, Jan 15, 09:16

Tue, Jan 14

PiRK accepted D17526: [website] Fix the macos release download link.

Tue, Jan 14, 14:40

PiRK closed D17370: [chronik] add blockchain.transaction.broadcast electrum method.

Tue, Jan 14, 12:44

PiRK committed rABCa19427fa9855: [chronik] add blockchain.transaction.broadcast electrum method (authored by PiRK).

[chronik] add blockchain.transaction.broadcast electrum method

Tue, Jan 14, 12:44

PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

rebase and add a syncwithvalidationinterfacequeue to the test

Tue, Jan 14, 08:38

Mon, Jan 13

PiRK closed D17514: [chronik] implement blockchain.transaction.get_merkle Electrum method.

Mon, Jan 13, 19:19

PiRK committed rABCd1d73830cfbf: [chronik] implement blockchain.transaction.get_merkle Electrum method (authored by PiRK).

[chronik] implement blockchain.transaction.get_merkle Electrum method

Mon, Jan 13, 19:19

PiRK closed D17522: [chronik] rename the MerkleTree struct.

Mon, Jan 13, 19:19

PiRK committed rABC798aa50067a8: [chronik] rename the MerkleTree struct (authored by PiRK).

[chronik] rename the MerkleTree struct

Mon, Jan 13, 19:19

PiRK updated the diff for D17514: [chronik] implement blockchain.transaction.get_merkle Electrum method.

fix clippy error

Mon, Jan 13, 15:56

PiRK retitled D17522: [chronik] rename the MerkleTree struct from [chronik] make the MerkleTree struct more generic to [chronik] rename the MerkleTree struct.

Mon, Jan 13, 15:55

PiRK updated the diff for D17522: [chronik] rename the MerkleTree struct.

revert accidental changes to package(-lock).json

Mon, Jan 13, 15:41

PiRK published D17514: [chronik] implement blockchain.transaction.get_merkle Electrum method for review.

Mon, Jan 13, 12:26

PiRK requested review of D17522: [chronik] rename the MerkleTree struct.

Mon, Jan 13, 12:18

PiRK accepted D17521: Bump version to 0.30.9.

Mon, Jan 13, 12:17

PiRK accepted D17520: [Cashtab] Use locale thousands separators for large prices.

Mon, Jan 13, 08:01

Fri, Jan 10

PiRK closed D17507: [chronik] cleanup of json_to_u31 helper function.

Fri, Jan 10, 14:39

PiRK committed rABCf3dfa6c485fe: [chronik] cleanup of json_to_u31 helper function (authored by PiRK).

[chronik] cleanup of json_to_u31 helper function

Fri, Jan 10, 14:39

PiRK closed D17501: [chronik] implement electrum RPC blockchain.block.headers.

Fri, Jan 10, 14:39

PiRK committed rABC98839217de42: [chronik] implement electrum RPC blockchain.block.headers (authored by PiRK).

[chronik] implement electrum RPC blockchain.block.headers

Fri, Jan 10, 14:39

PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

collect the headers_hex

Fri, Jan 10, 13:31

PiRK requested review of D17507: [chronik] cleanup of json_to_u31 helper function.

Fri, Jan 10, 12:17

PiRK added inline comments to D17501: [chronik] implement electrum RPC blockchain.block.headers.

Fri, Jan 10, 11:56

PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

use headers_by_range which simplifies the code a lot

Fri, Jan 10, 11:56

Thu, Jan 9

PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

rename helper function json_to_u31. We still return a i32, because that's what all functions expect a block height to be in the node and the indexer, but with the added guarantee that it is >=0 . Returning a u32 would just shift the problem from checking >= 0 to checking <=2**31 -1, while requiring a lot of as i32 conversions when calling the indexer functions.

Thu, Jan 9, 20:58

PiRK added inline comments to D17501: [chronik] implement electrum RPC blockchain.block.headers.

Thu, Jan 9, 20:30

PiRK planned changes to D17501: [chronik] implement electrum RPC blockchain.block.headers.

Thu, Jan 9, 20:29

PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

remove a duplicated test and improve another comment

Thu, Jan 9, 20:27

PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

fix comment in test

Thu, Jan 9, 20:21

PiRK updated the summary of D17501: [chronik] implement electrum RPC blockchain.block.headers.

Thu, Jan 9, 20:11

PiRK requested review of D17501: [chronik] implement electrum RPC blockchain.block.headers.

Thu, Jan 9, 20:08

PiRK closed D17486: [chronik] actually run the functional test for blockchain.transaction.get_height.

Thu, Jan 9, 14:32

PiRK committed rABCdbf5c9e950da: [chronik] actually run the functional test for blockchain.transaction.get_height (authored by PiRK).

[chronik] actually run the functional test for blockchain.transaction.get_height

Thu, Jan 9, 14:31

PiRK committed rABC7f1a9b1a895d: [chronik] implement blockchain.block.header electrum method (authored by PiRK).

[chronik] implement blockchain.block.header electrum method

Thu, Jan 9, 14:31

PiRK closed D17485: [chronik] implement blockchain.block.header electrum method.

Thu, Jan 9, 14:31

PiRK updated the diff for D17485: [chronik] implement blockchain.block.header electrum method.

the todo is done

Thu, Jan 9, 10:38

PiRK committed rABC5cea6272b9ba: [chronik] bump karyon_jsonrpc (authored by PiRK).

[chronik] bump karyon_jsonrpc

Thu, Jan 9, 10:35

PiRK closed D17496: [chronik] bump karyon_jsonrpc.

Thu, Jan 9, 10:35

PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

comment phrasing nit

Thu, Jan 9, 08:10

PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

rebase on D17496

Thu, Jan 9, 08:04

PiRK updated the diff for D17485: [chronik] implement blockchain.block.header electrum method.

rebase on D17496

Thu, Jan 9, 07:58

PiRK added inline comments to D17496: [chronik] bump karyon_jsonrpc.

Thu, Jan 9, 07:25

PiRK updated the diff for D17496: [chronik] bump karyon_jsonrpc.

remove unneeded import

Thu, Jan 9, 07:12

PiRK added inline comments to D17496: [chronik] bump karyon_jsonrpc.

Thu, Jan 9, 07:12

Wed, Jan 8

PiRK updated the diff for D17496: [chronik] bump karyon_jsonrpc.

same

Wed, Jan 8, 18:59

PiRK updated the diff for D17496: [chronik] bump karyon_jsonrpc.

nit: use format! rather than concat! and save a to_string() conversion

Wed, Jan 8, 18:56