Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Yesterday

PiRK closed D17883: fix fuzzer: remove fuzzing of non-existent assumedvalid methods.
Wed, Apr 2, 22:04
PiRK committed rABCfb4acd93a04a: fix fuzzer: remove fuzzing of non-existent assumedvalid methods (authored by PiRK).
fix fuzzer: remove fuzzing of non-existent assumedvalid methods
Wed, Apr 2, 22:04
PiRK accepted D17881: [avalanche] Clarify separation of responsibilities for setting local winner contender statuses.
Wed, Apr 2, 20:36
PiRK accepted D17880: [avalanche] Cleanup unused addStakeContender in Processor.
Wed, Apr 2, 20:32
PiRK requested review of D17883: fix fuzzer: remove fuzzing of non-existent assumedvalid methods.
Wed, Apr 2, 20:29
PiRK closed D17877: validation: don't consider background IBD blocks as deep reorgs.
Wed, Apr 2, 19:50
PiRK committed rABC5f2017bbb0d1: validation: don't consider background IBD blocks as deep reorgs (authored by PiRK).
validation: don't consider background IBD blocks as deep reorgs
Wed, Apr 2, 19:50
PiRK closed D17874: assumeutxo: Remove BLOCK_ASSUMED_VALID flag.
Wed, Apr 2, 19:48
PiRK committed rABCe7c479c48955: assumeutxo: Remove BLOCK_ASSUMED_VALID flag (authored by Ryan Ofsky <ryan@ofsky.org>).
assumeutxo: Remove BLOCK_ASSUMED_VALID flag
Wed, Apr 2, 19:48
PiRK closed D17873: assumeutxo: Get rid of faked nTx and nChainTx values.
Wed, Apr 2, 19:47
PiRK committed rABC382b443ee2c0: assumeutxo: Get rid of faked nTx and nChainTx values (authored by James O'Beirne <james.obeirne@pm.me>).
assumeutxo: Get rid of faked nTx and nChainTx values
Wed, Apr 2, 19:47
PiRK committed rABC36faf8a589c2: block index: split ResetChainStats from UpdateChainStats (authored by PiRK).
block index: split ResetChainStats from UpdateChainStats
Wed, Apr 2, 19:47
PiRK closed D17872: block index: split ResetChainStats from UpdateChainStats.
Wed, Apr 2, 19:47
PiRK closed D17878: remove unused nChainSize.
Wed, Apr 2, 19:46
PiRK committed rABC8fd7122e4ec1: remove unused nChainSize (authored by PiRK).
remove unused nChainSize
Wed, Apr 2, 19:46
PiRK updated the diff for D17873: assumeutxo: Get rid of faked nTx and nChainTx values.

rebase

Wed, Apr 2, 09:40
PiRK updated the diff for D17872: block index: split ResetChainStats from UpdateChainStats.

rebase

Wed, Apr 2, 09:39
PiRK updated the diff for D17878: remove unused nChainSize.

fix fuzzer and add compiling bitcoin-fuzzers to test plan

Wed, Apr 2, 09:39
PiRK updated the diff for D17873: assumeutxo: Get rid of faked nTx and nChainTx values.

rebase, merge two if branches now that we only need to compute one value and already know its results prior to the branch

Wed, Apr 2, 08:20
PiRK added inline comments to D17873: assumeutxo: Get rid of faked nTx and nChainTx values.
Wed, Apr 2, 08:19
PiRK updated the diff for D17872: block index: split ResetChainStats from UpdateChainStats.

rebase on D17878

Wed, Apr 2, 08:04
PiRK updated the diff for D17878: remove unused nChainSize.

comment fix

Wed, Apr 2, 07:52
PiRK requested review of D17878: remove unused nChainSize.
Wed, Apr 2, 07:50

Tue, Apr 1

PiRK updated the diff for D17877: validation: don't consider background IBD blocks as deep reorgs.

comment nits, const, update test plan to include a full background validation (test still ongoing)

Tue, Apr 1, 13:36
PiRK requested review of D17877: validation: don't consider background IBD blocks as deep reorgs.
Tue, Apr 1, 08:57

Mon, Mar 31

PiRK added inline comments to D17872: block index: split ResetChainStats from UpdateChainStats.
Mon, Mar 31, 15:35

Fri, Mar 28

PiRK added inline comments to D17873: assumeutxo: Get rid of faked nTx and nChainTx values.
Fri, Mar 28, 21:43
PiRK requested review of D17874: assumeutxo: Remove BLOCK_ASSUMED_VALID flag.
Fri, Mar 28, 21:39
PiRK requested review of D17873: assumeutxo: Get rid of faked nTx and nChainTx values.
Fri, Mar 28, 21:37
PiRK added inline comments to D17872: block index: split ResetChainStats from UpdateChainStats.
Fri, Mar 28, 21:34
PiRK requested review of D17872: block index: split ResetChainStats from UpdateChainStats.
Fri, Mar 28, 21:28
PiRK accepted D17870: [website] Don't mix permissions when building the documentation.
Fri, Mar 28, 17:25
PiRK accepted D17868: [website] Update the upgrade page for May 2025.
Fri, Mar 28, 12:24
PiRK accepted D17869: [explorer] Fix address conversion on testnet.
Fri, Mar 28, 12:22
PiRK closed D17866: doc: Improve comments describing setBlockIndexCandidates checks.
Fri, Mar 28, 07:43
PiRK committed rABCfda261378276: doc: Improve comments describing setBlockIndexCandidates checks (authored by PiRK).
doc: Improve comments describing setBlockIndexCandidates checks
Fri, Mar 28, 07:43
PiRK updated the summary of D17866: doc: Improve comments describing setBlockIndexCandidates checks.
Fri, Mar 28, 07:40

Thu, Mar 27

PiRK requested review of D17866: doc: Improve comments describing setBlockIndexCandidates checks.
Thu, Mar 27, 20:58
PiRK committed rABCac987c34e50d: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note (authored by James O'Beirne <james.obeirne@pm.me>).
chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note
Thu, Mar 27, 20:51
PiRK closed D17864: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note.
Thu, Mar 27, 20:51
PiRK requested review of D17864: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note.
Thu, Mar 27, 15:00
PiRK accepted D17863: [website] Make the 0.29.x releases obsolete.
Thu, Mar 27, 13:59

Wed, Mar 26

PiRK closed D17858: [electrum] bump version to 5.4.2 and add release notes.
Wed, Mar 26, 15:05
PiRK committed rABC2dcd21093b82: [electrum] bump version to 5.4.2 and add release notes (authored by PiRK).
[electrum] bump version to 5.4.2 and add release notes
Wed, Mar 26, 15:05
PiRK requested review of D17858: [electrum] bump version to 5.4.2 and add release notes.
Wed, Mar 26, 13:14
PiRK accepted D17856: Bump replay protection to November 2025.
Wed, Mar 26, 12:40
PiRK added a comment to D17856: Bump replay protection to November 2025.
$ date -ud @1763208000
sam. 15 nov. 2025 12:00:00 UTC
Wed, Mar 26, 11:07

Tue, Mar 25

PiRK closed D17855: script: Enhance validations in utxo_snapshot.sh.
Tue, Mar 25, 22:53
PiRK committed rABCdebc1be254f1: script: Enhance validations in utxo_snapshot.sh (authored by pablomartin4btc <pablomartin4btc@gmail.com>).
script: Enhance validations in utxo_snapshot.sh
Tue, Mar 25, 22:53
PiRK requested review of D17855: script: Enhance validations in utxo_snapshot.sh.
Tue, Mar 25, 15:03
PiRK accepted D17854: [Cashtab] Show the normal list workflow for XECX from the list option.
Tue, Mar 25, 07:11

Mon, Mar 24

PiRK closed D17851: blockstorage: add return codes on flush functions, force callers to handle them.
Mon, Mar 24, 19:27
PiRK committed rABCaa67c37d0718: blockstorage: add return codes on flush functions, force callers to handle them (authored by TheCharlatan <seb.kung@gmail.com>).
blockstorage: add return codes on flush functions, force callers to handle them
Mon, Mar 24, 19:27
PiRK updated the summary of D17851: blockstorage: add return codes on flush functions, force callers to handle them.
Mon, Mar 24, 15:33
PiRK updated the diff for D17851: blockstorage: add return codes on flush functions, force callers to handle them.

fix diff summary, implement review suggestion (return AbortNode....)

Mon, Mar 24, 15:31
PiRK added inline comments to D17851: blockstorage: add return codes on flush functions, force callers to handle them.
Mon, Mar 24, 15:17
PiRK planned changes to D17851: blockstorage: add return codes on flush functions, force callers to handle them.

I think my summary (a copy paste of the initial message in the pull request) is misleading. The PR later change it's scope to make no change in behavior (besides additional logging) and basically just force future users of these functions to handle the return value.
I will fix this

Mon, Mar 24, 15:13
PiRK accepted D17852: [electrum] Add support for an eCash firmware on Trezor One.
Mon, Mar 24, 14:58
PiRK requested review of D17851: blockstorage: add return codes on flush functions, force callers to handle them.
Mon, Mar 24, 13:46
PiRK added inline comments to D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Mon, Mar 24, 11:08

Sat, Mar 22

PiRK closed D17846: [electrum] improve layout for Trezor firmware tools.
Sat, Mar 22, 11:49
PiRK committed rABC017aa9c0d98b: [electrum] improve layout for Trezor firmware tools (authored by PiRK).
[electrum] improve layout for Trezor firmware tools
Sat, Mar 22, 11:49
PiRK added a comment to D17846: [electrum] improve layout for Trezor firmware tools.

Screenshot from 2025-03-22 08-24-52.png (593×526 px, 43 KB)

Sat, Mar 22, 07:28
PiRK requested review of D17846: [electrum] improve layout for Trezor firmware tools.
Sat, Mar 22, 07:28

Fri, Mar 21

PiRK closed D17845: [electrum] fix opening Trezor settings menu while the device is locked.
Fri, Mar 21, 16:29
PiRK committed rABC381c284405a2: [electrum] fix opening Trezor settings menu while the device is locked (authored by PiRK).
[electrum] fix opening Trezor settings menu while the device is locked
Fri, Mar 21, 16:29
PiRK requested review of D17845: [electrum] fix opening Trezor settings menu while the device is locked.
Fri, Mar 21, 16:00
PiRK accepted D17844: [electrum] Catch a potential LibUSB error during session close when jumping to bootloader.
Fri, Mar 21, 11:21
PiRK accepted D17843: [electrum] Increase the timeout for entering the bootloader mode.

translation nit

Fri, Mar 21, 10:09
PiRK accepted D17842: [electrum] Alllow for downgrading the Trezor firmware.
Fri, Mar 21, 10:05

Thu, Mar 20

PiRK accepted D17839: [fuzzer] Include missing header.
Thu, Mar 20, 13:33
PiRK committed rABCefe279d43307: test_framework: improve the syntax of serialize() methods (authored by PiRK).
test_framework: improve the syntax of serialize() methods
Thu, Mar 20, 11:32
PiRK closed D17835: test_framework: improve the syntax of serialize() methods.
Thu, Mar 20, 11:32
PiRK accepted D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Thu, Mar 20, 11:08
PiRK accepted D17838: [avalanche] Don't include validation.h via proof.h.
Thu, Mar 20, 09:35
PiRK accepted D17837: [avalanche] Add some missing headers.

lgtm (if the bitcoin-chainstate / kernel build does not fail)

Thu, Mar 20, 09:34
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Thu, Mar 20, 08:57
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Thu, Mar 20, 08:56
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Thu, Mar 20, 08:52
PiRK added inline comments to D17835: test_framework: improve the syntax of serialize() methods.
Thu, Mar 20, 08:40
PiRK added a comment to D17835: test_framework: improve the syntax of serialize() methods.

This whole diff is a test on how Grok v3 can helpful to do semi-automated changes on a large amount of code.
It worked quite well, I just had to revert a few changes msg_avaproofs.serialize and msg_avaproofsreq.serialize, which imo were not trivial enough to justify removing the intermadiate var and all the comments to make it a one-liner.

Thu, Mar 20, 08:38
PiRK updated the diff for D17835: test_framework: improve the syntax of serialize() methods.

back-off unrelated changes

Thu, Mar 20, 08:33
PiRK planned changes to D17835: test_framework: improve the syntax of serialize() methods.
Thu, Mar 20, 08:30
PiRK requested review of D17835: test_framework: improve the syntax of serialize() methods.
Thu, Mar 20, 08:27
PiRK accepted D17834: [avalanche] Refactor helpers to build avaproofs messages.
Thu, Mar 20, 07:37

Wed, Mar 19

PiRK closed D17816: [electrum] bump the version to 5.4.1 and add release notes.
Wed, Mar 19, 11:46
PiRK committed rABCe5e31cf6c69a: [electrum] bump the version to 5.4.1 and add release notes (authored by PiRK).
[electrum] bump the version to 5.4.1 and add release notes
Wed, Mar 19, 11:46
PiRK closed D17823: [electrum] fix pyopenssl version.
Wed, Mar 19, 10:52
PiRK committed rABC79a912688729: [electrum] fix pyopenssl version (authored by Jonas Lundqvist <jonas@gannon.se>).
[electrum] fix pyopenssl version
Wed, Mar 19, 10:52
PiRK accepted D17825: [electrum] Pin version of shamir-mnemonic.
Wed, Mar 19, 10:44
PiRK accepted D17824: [electrum] No python 3.12 syntax.
Wed, Mar 19, 10:43
PiRK updated the summary of D17823: [electrum] fix pyopenssl version.
Wed, Mar 19, 09:10
PiRK requested review of D17823: [electrum] fix pyopenssl version.
Wed, Mar 19, 09:09
PiRK closed D17819: [electrum] include metadata for slip10 for the windows and osx releases.
Wed, Mar 19, 08:17
PiRK committed rABCa370271feb5e: [electrum] include metadata for slip10 for the windows and osx releases (authored by PiRK).
[electrum] include metadata for slip10 for the windows and osx releases
Wed, Mar 19, 08:17
PiRK published D17819: [electrum] include metadata for slip10 for the windows and osx releases for review.
Wed, Mar 19, 07:46

Tue, Mar 18

PiRK accepted D17817: [avalanche] Improve performance of inventory filtering.
Tue, Mar 18, 15:50
PiRK updated the diff for D17816: [electrum] bump the version to 5.4.1 and add release notes.

mention which devices have a custom Trezor firmware

Tue, Mar 18, 15:38
PiRK updated the diff for D17816: [electrum] bump the version to 5.4.1 and add release notes.

reflow release note

Tue, Mar 18, 15:28
PiRK requested review of D17816: [electrum] bump the version to 5.4.1 and add release notes.
Tue, Mar 18, 15:25
Next