Page MenuHomePhabricator
Feed Advanced Search

Today

PiRK added a reviewer for D9290: [avalanche] implement getavalanchepeerinfo: deadalnix.
Tue, Mar 2, 17:08
PiRK retitled D9290: [avalanche] implement getavalanchepeerinfo from implement getavalanchepeerinfo to [avalanche] implement getavalanchepeerinfo.
Tue, Mar 2, 17:08
PiRK updated the diff for D9290: [avalanche] implement getavalanchepeerinfo.

add tests

Tue, Mar 2, 16:10
PiRK planned changes to D9290: [avalanche] implement getavalanchepeerinfo.
Tue, Mar 2, 15:18
PiRK updated the diff for D9290: [avalanche] implement getavalanchepeerinfo.

fix pushKV --> push_back for array of node ids

Tue, Mar 2, 15:18
PiRK planned changes to D9290: [avalanche] implement getavalanchepeerinfo.
Tue, Mar 2, 14:54
PiRK updated the diff for D9290: [avalanche] implement getavalanchepeerinfo.

fix RPCExamples and remove duplicated RPCHelpMan

Tue, Mar 2, 14:54
PiRK planned changes to D9290: [avalanche] implement getavalanchepeerinfo.
Tue, Mar 2, 14:40
PiRK updated the diff for D9290: [avalanche] implement getavalanchepeerinfo.

hold the mutex before using peerManager

Tue, Mar 2, 14:38
PiRK planned changes to D9290: [avalanche] implement getavalanchepeerinfo.
Tue, Mar 2, 14:31
PiRK updated the diff for D9290: [avalanche] implement getavalanchepeerinfo.

fix parameter name

Tue, Mar 2, 14:31
PiRK planned changes to D9290: [avalanche] implement getavalanchepeerinfo.
Tue, Mar 2, 14:28
PiRK requested review of D9290: [avalanche] implement getavalanchepeerinfo.
Tue, Mar 2, 14:27

Yesterday

PiRK updated the diff for D9277: doc: noban precludes maxuploadtarget disconnects.

use /* */ for comment

Mon, Mar 1, 14:48
PiRK closed D9275: validation: delay flushing undo files in syncing node case.
Mon, Mar 1, 14:44
PiRK committed rABC5ab1c1ba38c0: validation: delay flushing undo files in syncing node case (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
validation: delay flushing undo files in syncing node case
Mon, Mar 1, 14:44
PiRK closed D9279: refactor: Replace RecursiveMutex with Mutex in Shutdown().
Mon, Mar 1, 14:44
PiRK committed rABCc9c716200e6e: refactor: Replace RecursiveMutex with Mutex in Shutdown() (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Replace RecursiveMutex with Mutex in Shutdown()
Mon, Mar 1, 14:43
PiRK closed D9276: [test] CScriptNum Decode Check as Unit Tests.
Mon, Mar 1, 14:43
PiRK committed rABC2a3ba49ebbbf: [test] CScriptNum Decode Check as Unit Tests (authored by Gillian Chu <gillianchu@Gillians-MacBook-Pro.local>).
[test] CScriptNum Decode Check as Unit Tests
Mon, Mar 1, 14:43
PiRK closed D9278: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call.
Mon, Mar 1, 14:42
PiRK committed rABCea64418dcb25: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call (authored by Calvin Kim <calvin@kcalvinalvin.info>).
doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call
Mon, Mar 1, 14:42

Thu, Feb 25

PiRK requested review of D9279: refactor: Replace RecursiveMutex with Mutex in Shutdown().
Thu, Feb 25, 16:27
PiRK requested review of D9278: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call.
Thu, Feb 25, 16:18
PiRK requested review of D9277: doc: noban precludes maxuploadtarget disconnects.
Thu, Feb 25, 16:01
PiRK updated the summary of D9276: [test] CScriptNum Decode Check as Unit Tests.
Thu, Feb 25, 09:50
PiRK requested review of D9276: [test] CScriptNum Decode Check as Unit Tests.
Thu, Feb 25, 09:48
PiRK requested review of D9275: validation: delay flushing undo files in syncing node case.
Thu, Feb 25, 08:58
PiRK closed D9273: test: type hints in Python tests.
Thu, Feb 25, 08:27
PiRK committed rABCe98dd8358d9c: test: type hints in Python tests (authored by Kiminuo <kiminuo@protonmail.com>).
test: type hints in Python tests
Thu, Feb 25, 08:27

Wed, Feb 24

PiRK closed D9272: fix a potential regex search error in cdefs.py.
Wed, Feb 24, 17:22
PiRK committed rABC9cd19beca9d5: fix a potential regex search error in cdefs.py (authored by PiRK).
fix a potential regex search error in cdefs.py
Wed, Feb 24, 17:21
PiRK closed D9271: Delete outdated "self tests" for the test framework.
Wed, Feb 24, 17:20
PiRK committed rABC89048c5c1310: Delete outdated "self tests" for the test framework (authored by PiRK).
Delete outdated "self tests" for the test framework
Wed, Feb 24, 17:20
PiRK closed D9270: bump minimum python version to 3.6.
Wed, Feb 24, 17:20
PiRK committed rABCa6ae76a055dc: bump minimum python version to 3.6 (authored by PiRK).
bump minimum python version to 3.6
Wed, Feb 24, 17:20
PiRK retitled D9273: test: type hints in Python tests from This PR adds initial support for type hints checking in python scripts. to test: type hints in Python tests.
Wed, Feb 24, 17:18
PiRK updated the summary of D9273: test: type hints in Python tests.
Wed, Feb 24, 17:15
PiRK requested review of D9273: test: type hints in Python tests.
Wed, Feb 24, 17:14
PiRK updated the diff for D9272: fix a potential regex search error in cdefs.py.

testing match is not None is more pythonic

Wed, Feb 24, 15:55
PiRK requested review of D9272: fix a potential regex search error in cdefs.py.
Wed, Feb 24, 15:52
PiRK requested review of D9271: Delete outdated "self tests" for the test framework.
Wed, Feb 24, 15:49
PiRK requested review of D9270: bump minimum python version to 3.6.
Wed, Feb 24, 15:47
PiRK closed D9269: validation: Make VerifyDB level 4 interruptible.
Wed, Feb 24, 13:42
PiRK committed rABC9ecabf23be40: validation: Make VerifyDB level 4 interruptible (authored by MarcoFalke <falke.marco@gmail.com>).
validation: Make VerifyDB level 4 interruptible
Wed, Feb 24, 13:42
PiRK closed D9268: validation: use std::chrono in CChainState::FlushStateToDisk().
Wed, Feb 24, 13:42
PiRK committed rABC089a3050c344: validation: use std::chrono in CChainState::FlushStateToDisk() (authored by fanquake <fanquake@gmail.com>).
validation: use std::chrono in CChainState::FlushStateToDisk()
Wed, Feb 24, 13:42
PiRK closed D9261: test: Explain that a bug should be filed when the test fail.
Wed, Feb 24, 13:41
PiRK committed rABCdb540ee05396: test: Explain that a bug should be filed when the test fail (authored by MarcoFalke <falke.marco@gmail.com>).
test: Explain that a bug should be filed when the test fail
Wed, Feb 24, 13:41
PiRK requested review of D9269: validation: Make VerifyDB level 4 interruptible.
Wed, Feb 24, 11:05
PiRK requested review of D9268: validation: use std::chrono in CChainState::FlushStateToDisk().
Wed, Feb 24, 10:51
PiRK closed D9265: test: Add missing sync_blocks to wallet_hd.
Wed, Feb 24, 07:24
PiRK committed rABC5d6633fee668: test: Add missing sync_blocks to wallet_hd (authored by MarcoFalke <falke.marco@gmail.com>).
test: Add missing sync_blocks to wallet_hd
Wed, Feb 24, 07:24
PiRK closed D9264: Limit scope of all global std::once_flag.
Wed, Feb 24, 07:23
PiRK committed rABC5dc4b6e02fce: Limit scope of all global std::once_flag (authored by MarcoFalke <falke.marco@gmail.com>).
Limit scope of all global std::once_flag
Wed, Feb 24, 07:23
PiRK closed D9262: tests: implement base58_decode.
Wed, Feb 24, 07:22
PiRK committed rABC06eae6f27d14: tests: implement base58_decode (authored by 10xcryptodev <10xcryptodev@gmail.com>).
tests: implement base58_decode
Wed, Feb 24, 07:22
PiRK updated the diff for D9261: test: Explain that a bug should be filed when the test fail.

rebase

Wed, Feb 24, 07:20
PiRK closed D9260: qt: Fix shutdown when waitfor* cmds are called from RPC console.
Wed, Feb 24, 07:19
PiRK committed rABCcaf502a98acd: qt: Fix shutdown when waitfor* cmds are called from RPC console (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
qt: Fix shutdown when waitfor* cmds are called from RPC console
Wed, Feb 24, 07:19

Tue, Feb 23

PiRK updated the summary of D9265: test: Add missing sync_blocks to wallet_hd.
Tue, Feb 23, 17:33
PiRK updated the summary of D9265: test: Add missing sync_blocks to wallet_hd.
Tue, Feb 23, 17:32
PiRK requested review of D9265: test: Add missing sync_blocks to wallet_hd.
Tue, Feb 23, 17:32
PiRK updated the summary of D9264: Limit scope of all global std::once_flag.
Tue, Feb 23, 17:17
PiRK requested review of D9264: Limit scope of all global std::once_flag.
Tue, Feb 23, 17:15
PiRK updated the diff for D9262: tests: implement base58_decode.

fix formatting (the linter did not find an elegant solution this time)

Tue, Feb 23, 16:39
PiRK requested review of D9262: tests: implement base58_decode.
Tue, Feb 23, 16:35
PiRK requested review of D9261: test: Explain that a bug should be filed when the test fail.
Tue, Feb 23, 16:27
PiRK requested review of D9260: qt: Fix shutdown when waitfor* cmds are called from RPC console.
Tue, Feb 23, 16:17
PiRK accepted D9259: [backport#18637] coins: allow cache resize after init.

I'm not blocking on this, but FYI there are a bunch of same line comments in validation_chainstate_tests.cpp

Tue, Feb 23, 14:08
PiRK closed D9257: qt: Fix regression in TransactionTableModel.
Tue, Feb 23, 12:55
PiRK committed rABC1efc1fd37759: qt: Fix regression in TransactionTableModel (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
qt: Fix regression in TransactionTableModel
Tue, Feb 23, 12:54
PiRK closed D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Tue, Feb 23, 12:54
PiRK committed rABC1730a7452cb7: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip… (authored by furszy <matiasfurszyfer@protonmail.com>).
BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip…
Tue, Feb 23, 12:54
PiRK closed D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Tue, Feb 23, 12:53
PiRK committed rABC9ad2859f2e58: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals. (authored by furszy <matiasfurszyfer@protonmail.com>).
Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals.
Tue, Feb 23, 12:53
PiRK closed D9236: wallet: descriptor wallet cleanups.
Tue, Feb 23, 09:36
PiRK committed rABCdaabc6926d49: wallet: descriptor wallet cleanups (authored by Andrew Chow <achow101-github@achow101.com>).
wallet: descriptor wallet cleanups
Tue, Feb 23, 09:36
PiRK updated the diff for D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

fix accidental revert of core#19132

Tue, Feb 23, 09:26
PiRK updated the diff for D9257: qt: Fix regression in TransactionTableModel.

fix accidental revert of core#19132

Tue, Feb 23, 09:24
PiRK added a comment to D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

now you reverted PR19132's changes completely

Tue, Feb 23, 09:13
PiRK updated the diff for D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

remove unnecessary line added accidentaly when fixing conflict

Tue, Feb 23, 07:24
PiRK closed D9255: qt: Use parent-child relation to manage lifetime of OptionsModel object.
Tue, Feb 23, 07:20
PiRK committed rABCf5235191842a: qt: Use parent-child relation to manage lifetime of OptionsModel object (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
qt: Use parent-child relation to manage lifetime of OptionsModel object
Tue, Feb 23, 07:20
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Tue, Feb 23, 07:16
PiRK accepted D9258: [buildbot] make bot link to backports of core-gui repo.
Tue, Feb 23, 07:14
PiRK updated the diff for D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..

remove line accidentaly added while fixing a conflict

Tue, Feb 23, 07:10

Mon, Feb 22

PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Mon, Feb 22, 21:02
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Mon, Feb 22, 21:00
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Mon, Feb 22, 20:57
PiRK added a comment to D9257: qt: Fix regression in TransactionTableModel.

Ok wirh core-gui

Mon, Feb 22, 20:56
PiRK updated the summary of D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Mon, Feb 22, 15:45
PiRK updated the diff for D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..

rebase

Mon, Feb 22, 15:40
PiRK abandoned D9256: qt: lock cs_main, m_cached_tip_mutex in that order.

squasjed with D9253

Mon, Feb 22, 15:39
PiRK updated the summary of D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Mon, Feb 22, 15:38
PiRK updated the diff for D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

squash D9253 and D9256

Mon, Feb 22, 15:36
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Mon, Feb 22, 15:19
PiRK requested review of D9257: qt: Fix regression in TransactionTableModel.
Mon, Feb 22, 15:18
PiRK requested review of D9256: qt: lock cs_main, m_cached_tip_mutex in that order.
Mon, Feb 22, 15:04
PiRK requested review of D9255: qt: Use parent-child relation to manage lifetime of OptionsModel object.
Mon, Feb 22, 14:53