Differential D17842

[electrum] Alllow for downgrading the Trezor firmware
ClosedPublic
Actions

Authored by Fabien on Fri, Mar 21, 09:55.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCea7437f90053: [electrum] Alllow for downgrading the Trezor firmware

Summary

When the user selects to install a custom firmware, Electrum detects whether it's an official firmware and applies some checks on the header including a version check that prevents from downgrading the firmware. This is not the expected behavior when the firmware is installed from a file and the user should be able to downgrade if desired.

Test Plan

Downgrade an official Trezor firmware using this method.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Fri, Mar 21, 09:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Mar 21, 09:55

Fabien requested review of this revision.Fri, Mar 21, 09:55

Harbormaster completed remote builds in B32794: Diff 53216.Fri, Mar 21, 09:58

PiRK accepted this revision.Fri, Mar 21, 10:05

PiRK added a subscriber: PiRK.

PiRK added inline comments.

electrum/electrumabc_plugins/trezor/clientbase.py
470 ↗	(On Diff #53216)

This revision is now accepted and ready to land.Fri, Mar 21, 10:05

Closed by commit rABCea7437f90053: [electrum] Alllow for downgrading the Trezor firmware (authored by Fabien). · Explain WhyFri, Mar 21, 10:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCea7437f90053: [electrum] Alllow for downgrading the Trezor firmware.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_plugins/

trezor/

10 lines

6 lines

Diff 53218

electrum/electrumabc_plugins/trezor/clientbase.py

Loading...

electrum/electrumabc_plugins/trezor/qt.py

Loading...