Page MenuHomePhabricator

doc: Improve comments describing setBlockIndexCandidates checks
ClosedPublic

Authored by PiRK on Thu, Mar 27, 20:58.

Details

Summary

The checks are changing slightly in the next commit, so try to explains the
ones that exist to avoid confusioni

This is a partial backport of core#29370
https://github.com/bitcoin/bitcoin/pull/29370/commits/9b97d5bbf980d657a277c85d113c2ae3e870e0ec

Note that the logic is slightly different in our codebase vs Bitcoin Core because of the special case of pindex->nStatus.isOnParkedChain(). For non-parked block everythong should be strictly equivalent

Test Plan

proof-read

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable