[Chronik] Upgrade pyo3 to 0.22
ClosedPublic
Actions

Authored by tobias_ruck on Jul 23 2024, 11:35.

Details

Reviewers

Fabien
PiRK

Group Reviewers

Restricted Project

Commits

rABC5642de615225: [Chronik] Upgrade pyo3 to 0.22

Summary

0.22 introduced a lot of breaking changes (especially with the move from &references to the Bound wrapper), so it's better to do it now.

Depends on D16522.

Test Plan

ninja check-crates && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Jul 23 2024, 11:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2024, 11:35

Harbormaster completed remote builds in B29670: Diff 48787.Jul 23 2024, 12:04

Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

    Checking topo_sort v0.4.0
    Checking mime v0.3.17
   Compiling indoc v2.0.5
    Checking matchit v0.7.3
    Checking sync_wrapper v1.0.1
    Checking unindent v0.2.3
    Checking unicode-segmentation v1.11.0
    Checking base64 v0.21.7
   Compiling prost-derive v0.11.9
   Compiling serde_derive v1.0.197
   Compiling thiserror-impl v1.0.58
   Compiling futures-macro v0.3.30
   Compiling tokio-macros v2.2.0
   Compiling cxxbridge-macro v1.0.121
   Compiling pin-project-internal v1.1.5
    Checking convert_case v0.6.0
    Checking futures-util v0.3.30
   Compiling chronik-bridge v0.1.0 (/work/chronik/chronik-bridge)
    Checking thiserror v1.0.58
    Checking pin-project v1.1.5
   Compiling librocksdb-sys v0.11.0+8.1.1
   Compiling pyo3-macros v0.22.2
    Checking serde v1.0.197
    Checking futures-executor v0.3.30
    Checking futures v0.3.30
    Checking bytes v1.6.0
    Checking toml_datetime v0.6.6
    Checking serde_spanned v0.6.6
    Checking serde_urlencoded v0.7.1
    Checking serde_path_to_error v0.1.16
    Checking toml_edit v0.22.14
    Checking http v1.1.0
    Checking bitcoinsuite-core v0.1.0 (/work/chronik/bitcoinsuite-core)
    Checking tokio v1.37.0
   Compiling prost v0.11.9
    Checking postcard v1.0.8
    Checking http-body v1.0.0
    Checking abc-rust-error v0.1.0 (/work/chronik/abc-rust-error)
    Checking http-body-util v0.1.1
    Checking tungstenite v0.21.0
   Compiling prost-types v0.11.9
    Checking toml v0.8.14
    Checking bitcoinsuite-slp v0.1.0 (/work/chronik/bitcoinsuite-slp)
    Checking tower-http v0.5.2
   Compiling prost-build v0.11.9
    Checking chronik-plugin-common v0.1.0 (/work/chronik/chronik-plugin-common)
    Checking chronik-plugin v0.1.0 (/work/chronik/chronik-plugin)
    Checking chronik-plugin-impl v0.1.0 (/work/chronik/chronik-plugin-impl)
    Checking hyper v1.2.0
    Checking tokio-tungstenite v0.21.0
    Checking tower v0.4.13
   Compiling chronik-proto v0.1.0 (/work/chronik/chronik-proto)
    Checking hyper-util v0.1.3
    Checking rocksdb v0.21.0
    Checking chronik-db v0.1.0 (/work/chronik/chronik-db)
    Checking chronik-indexer v0.1.0 (/work/chronik/chronik-indexer)
    Checking chronik-http v0.1.0 (/work/chronik/chronik-http)
    Finished dev [unoptimized + debuginfo] target(s) in 2m 16s
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

    Checking bimap v0.6.3
    Checking winnow v0.6.13
    Checking base64 v0.21.7
    Checking unindent v0.2.3
    Checking sync_wrapper v1.0.1
   Compiling indoc v2.0.5
    Checking unicode-segmentation v1.11.0
    Checking matchit v0.7.3
   Compiling prost-derive v0.11.9
   Compiling serde_derive v1.0.197
   Compiling thiserror-impl v1.0.58
   Compiling futures-macro v0.3.30
   Compiling tokio-macros v2.2.0
   Compiling cxxbridge-macro v1.0.121
   Compiling pin-project-internal v1.1.5
    Checking convert_case v0.6.0
   Compiling chronik-bridge v0.1.0 (/work/chronik/chronik-bridge)
    Checking futures-util v0.3.30
    Checking thiserror v1.0.58
    Checking pin-project v1.1.5
   Compiling librocksdb-sys v0.11.0+8.1.1
   Compiling pyo3-macros v0.22.2
    Checking serde v1.0.197
    Checking futures-executor v0.3.30
    Checking futures v0.3.30
    Checking bytes v1.6.0
    Checking serde_spanned v0.6.6
    Checking toml_datetime v0.6.6
    Checking serde_path_to_error v0.1.16
    Checking serde_urlencoded v0.7.1
    Checking toml_edit v0.22.14
    Checking http v1.1.0
    Checking bitcoinsuite-core v0.1.0 (/work/chronik/bitcoinsuite-core)
    Checking tokio v1.37.0
    Checking prost v0.11.9
    Checking postcard v1.0.8
    Checking http-body v1.0.0
    Checking abc-rust-error v0.1.0 (/work/chronik/abc-rust-error)
   Compiling prost-types v0.11.9
    Checking http-body-util v0.1.1
    Checking tungstenite v0.21.0
    Checking bitcoinsuite-slp v0.1.0 (/work/chronik/bitcoinsuite-slp)
    Checking toml v0.8.14
    Checking tower-http v0.5.2
   Compiling prost-build v0.11.9
    Checking chronik-plugin-common v0.1.0 (/work/chronik/chronik-plugin-common)
    Checking chronik-plugin v0.1.0 (/work/chronik/chronik-plugin)
    Checking chronik-plugin-impl v0.1.0 (/work/chronik/chronik-plugin-impl)
   Compiling chronik-proto v0.1.0 (/work/chronik/chronik-proto)
    Checking hyper v1.2.0
    Checking tokio-tungstenite v0.21.0
    Checking tower v0.4.13
    Checking hyper-util v0.1.3
    Checking rocksdb v0.21.0
    Checking chronik-db v0.1.0 (/work/chronik/chronik-db)
    Checking chronik-indexer v0.1.0 (/work/chronik/chronik-indexer)
    Checking chronik-http v0.1.0 (/work/chronik/chronik-http)
    Finished dev [unoptimized + debuginfo] target(s) in 2m 15s
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (ecash-agora-integration-tests) failed.

Tail of the build log:

[239/581] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[240/581] Building CXX object src/CMakeFiles/common.dir/base58.cpp.o
[241/581] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[242/581] Building CXX object src/CMakeFiles/common.dir/common/system.cpp.o
[243/581] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[244/581] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[245/581] Building CXX object src/CMakeFiles/common.dir/common/configfile.cpp.o
[246/581] Building CXX object src/CMakeFiles/common.dir/consensus/merkle.cpp.o
[247/581] Building CXX object src/CMakeFiles/common.dir/common/bloom.cpp.o
[248/581] Building CXX object src/CMakeFiles/common.dir/chainparams.cpp.o
[249/581] Building CXX object src/CMakeFiles/common.dir/common/args.cpp.o
[250/581] Building CXX object src/CMakeFiles/common.dir/eventloop.cpp.o
[251/581] Building CXX object src/CMakeFiles/common.dir/cashaddrenc.cpp.o
[252/581] Building CXX object src/CMakeFiles/common.dir/coins.cpp.o
[253/581] Building CXX object src/CMakeFiles/common.dir/feerate.cpp.o
[254/581] Building CXX object src/CMakeFiles/common.dir/compressor.cpp.o
[255/581] Building CXX object src/CMakeFiles/common.dir/key.cpp.o
[256/581] Building CXX object src/CMakeFiles/common.dir/merkleblock.cpp.o
[257/581] Building CXX object src/CMakeFiles/common.dir/net_permissions.cpp.o
[258/581] Building CXX object src/CMakeFiles/common.dir/core_read.cpp.o
[259/581] Building CXX object src/CMakeFiles/common.dir/key_io.cpp.o
[260/581] Building CXX object src/CMakeFiles/common.dir/netaddress.cpp.o
[261/581] Building CXX object src/CMakeFiles/common.dir/core_write.cpp.o
[262/581] Building CXX object src/CMakeFiles/common.dir/netbase.cpp.o
[263/581] Building CXX object src/CMakeFiles/common.dir/primitives/block.cpp.o
[264/581] Building CXX object src/CMakeFiles/common.dir/outputtype.cpp.o
[265/581] Building CXX object src/CMakeFiles/common.dir/protocol.cpp.o
[266/581] Building CXX object src/CMakeFiles/common.dir/scheduler.cpp.o
[267/581] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[268/581] Building CXX object src/CMakeFiles/common.dir/policy/policy.cpp.o
[269/581] Building CXX object src/CMakeFiles/common.dir/warnings.cpp.o
[270/581] Building CXX object src/CMakeFiles/common.dir/networks/abc/checkpoints.cpp.o
[271/581] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[272/581] Building CXX object src/CMakeFiles/common.dir/psbt.cpp.o
[273/581] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[274/581] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[275/581] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[276/581] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[277/581] Linking C static library src/secp256k1/libsecp256k1.a
[278/581] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[279/581] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[280/581] Linking C executable src/secp256k1/sign-bench
[281/581] Linking C executable src/secp256k1/recover-bench
[282/581] Linking C executable src/secp256k1/internal-bench
[283/581] Linking C executable src/secp256k1/verify-bench
[284/581] Building CXX object src/CMakeFiles/common.dir/config.cpp.o
[285/581] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[286/581] Linking C executable src/secp256k1/ecmult-bench
[287/581] Building CXX object src/CMakeFiles/common.dir/networks/abc/chainparamsconstants.cpp.o
[288/581] Building CXX object src/CMakeFiles/common.dir/kernel/chainparams.cpp.o
[289/581] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[290/581] Linking CXX static library src/libcommon.a
[291/581] Linking CXX static library src/libscript.a
[292/581] Linking CXX static library src/libbitcoinconsensus.a
[293/581] Linking CXX shared library src/libbitcoinconsensus.so.0.29.9
[294/581] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[295/581] Linking CXX executable src/bitcoin-cli
[296/581] Linking CXX executable src/bitcoin-tx
ninja: build stopped: cannot make progress due to previous errors.
Build ecash-agora-integration-tests failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Tail of the build log:

[239/581] Building CXX object src/CMakeFiles/script.dir/script/sigencoding.cpp.o
[240/581] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[241/581] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[242/581] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[243/581] Building CXX object src/CMakeFiles/common.dir/chainparams.cpp.o
[244/581] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[245/581] Building CXX object src/CMakeFiles/common.dir/cashaddrenc.cpp.o
[246/581] Building CXX object src/CMakeFiles/common.dir/common/args.cpp.o
[247/581] Building CXX object src/CMakeFiles/common.dir/consensus/merkle.cpp.o
[248/581] Building CXX object src/CMakeFiles/common.dir/eventloop.cpp.o
[249/581] Building CXX object src/CMakeFiles/common.dir/common/configfile.cpp.o
[250/581] Building CXX object src/CMakeFiles/common.dir/feerate.cpp.o
[251/581] Building CXX object src/CMakeFiles/common.dir/common/bloom.cpp.o
[252/581] Building CXX object src/CMakeFiles/common.dir/common/system.cpp.o
[253/581] Building CXX object src/CMakeFiles/common.dir/config.cpp.o
[254/581] Building CXX object src/CMakeFiles/common.dir/kernel/chainparams.cpp.o
[255/581] Building CXX object src/CMakeFiles/common.dir/coins.cpp.o
[256/581] Building CXX object src/CMakeFiles/common.dir/merkleblock.cpp.o
[257/581] Building CXX object src/CMakeFiles/common.dir/key.cpp.o
[258/581] Building CXX object src/CMakeFiles/common.dir/core_read.cpp.o
[259/581] Building CXX object src/CMakeFiles/common.dir/netaddress.cpp.o
[260/581] Building CXX object src/CMakeFiles/common.dir/compressor.cpp.o
[261/581] Building CXX object src/CMakeFiles/common.dir/net_permissions.cpp.o
[262/581] Building CXX object src/CMakeFiles/common.dir/primitives/block.cpp.o
[263/581] Building CXX object src/CMakeFiles/common.dir/core_write.cpp.o
[264/581] Building CXX object src/CMakeFiles/common.dir/key_io.cpp.o
[265/581] Building CXX object src/CMakeFiles/common.dir/outputtype.cpp.o
[266/581] Building CXX object src/CMakeFiles/common.dir/netbase.cpp.o
[267/581] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[268/581] Building CXX object src/CMakeFiles/common.dir/networks/abc/chainparamsconstants.cpp.o
[269/581] Building CXX object src/CMakeFiles/common.dir/warnings.cpp.o
[270/581] Building CXX object src/CMakeFiles/common.dir/policy/policy.cpp.o
[271/581] Building CXX object src/CMakeFiles/common.dir/networks/abc/checkpoints.cpp.o
[272/581] Building CXX object src/CMakeFiles/common.dir/protocol.cpp.o
[273/581] Building CXX object src/CMakeFiles/common.dir/scheduler.cpp.o
[274/581] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[275/581] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[276/581] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[277/581] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[278/581] Building CXX object src/CMakeFiles/common.dir/psbt.cpp.o
[279/581] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[280/581] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[281/581] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[282/581] Linking C static library src/secp256k1/libsecp256k1.a
[283/581] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[284/581] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[285/581] Linking C executable src/secp256k1/ecmult-bench
[286/581] Linking C executable src/secp256k1/recover-bench
[287/581] Linking C executable src/secp256k1/sign-bench
[288/581] Linking C executable src/secp256k1/verify-bench
[289/581] Linking C executable src/secp256k1/internal-bench
[290/581] Linking CXX static library src/libcommon.a
[291/581] Linking CXX static library src/libscript.a
[292/581] Linking CXX static library src/libbitcoinconsensus.a
[293/581] Linking CXX shared library src/libbitcoinconsensus.so.0.29.9
[294/581] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[295/581] Linking CXX executable src/bitcoin-cli
[296/581] Linking CXX executable src/bitcoin-tx
ninja: build stopped: cannot make progress due to previous errors.
Build ecash-lib-integration-tests failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Tail of the build log:

[239/581] Building CXX object src/CMakeFiles/common.dir/cashaddr.cpp.o
[240/581] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[241/581] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[242/581] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[243/581] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[244/581] Building CXX object src/CMakeFiles/common.dir/common/system.cpp.o
[245/581] Building CXX object src/CMakeFiles/common.dir/config.cpp.o
[246/581] Building CXX object src/CMakeFiles/common.dir/common/configfile.cpp.o
[247/581] Building CXX object src/CMakeFiles/common.dir/consensus/merkle.cpp.o
[248/581] Building CXX object src/CMakeFiles/common.dir/common/args.cpp.o
[249/581] Building CXX object src/CMakeFiles/common.dir/cashaddrenc.cpp.o
[250/581] Building CXX object src/CMakeFiles/common.dir/chainparams.cpp.o
[251/581] Building CXX object src/CMakeFiles/common.dir/eventloop.cpp.o
[252/581] Building CXX object src/CMakeFiles/common.dir/feerate.cpp.o
[253/581] Building CXX object src/CMakeFiles/common.dir/coins.cpp.o
[254/581] Building CXX object src/CMakeFiles/common.dir/compressor.cpp.o
[255/581] Building CXX object src/CMakeFiles/common.dir/common/bloom.cpp.o
[256/581] Building CXX object src/CMakeFiles/common.dir/merkleblock.cpp.o
[257/581] Building CXX object src/CMakeFiles/common.dir/kernel/chainparams.cpp.o
[258/581] Building CXX object src/CMakeFiles/common.dir/net_permissions.cpp.o
[259/581] Building CXX object src/CMakeFiles/common.dir/key_io.cpp.o
[260/581] Building CXX object src/CMakeFiles/common.dir/netaddress.cpp.o
[261/581] Building CXX object src/CMakeFiles/common.dir/netbase.cpp.o
[262/581] Building CXX object src/CMakeFiles/common.dir/core_read.cpp.o
[263/581] Building CXX object src/CMakeFiles/common.dir/key.cpp.o
[264/581] Building CXX object src/CMakeFiles/common.dir/primitives/block.cpp.o
[265/581] Building CXX object src/CMakeFiles/common.dir/core_write.cpp.o
[266/581] Building CXX object src/CMakeFiles/common.dir/outputtype.cpp.o
[267/581] Building CXX object src/CMakeFiles/common.dir/policy/policy.cpp.o
[268/581] Building CXX object src/CMakeFiles/common.dir/scheduler.cpp.o
[269/581] Building CXX object src/CMakeFiles/common.dir/protocol.cpp.o
[270/581] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[271/581] Building CXX object src/CMakeFiles/common.dir/networks/abc/chainparamsconstants.cpp.o
[272/581] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[273/581] Building CXX object src/CMakeFiles/common.dir/warnings.cpp.o
[274/581] Building CXX object src/CMakeFiles/common.dir/networks/abc/checkpoints.cpp.o
[275/581] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[276/581] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[277/581] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[278/581] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[279/581] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[280/581] Building CXX object src/CMakeFiles/common.dir/psbt.cpp.o
[281/581] Linking C static library src/secp256k1/libsecp256k1.a
[282/581] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[283/581] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[284/581] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[285/581] Linking C executable src/secp256k1/ecmult-bench
[286/581] Linking C executable src/secp256k1/recover-bench
[287/581] Linking C executable src/secp256k1/sign-bench
[288/581] Linking C executable src/secp256k1/internal-bench
[289/581] Linking C executable src/secp256k1/verify-bench
[290/581] Linking CXX static library src/libcommon.a
[291/581] Linking CXX static library src/libscript.a
[292/581] Linking CXX static library src/libbitcoinconsensus.a
[293/581] Linking CXX shared library src/libbitcoinconsensus.so.0.29.9
[294/581] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[295/581] Linking CXX executable src/bitcoin-cli
[296/581] Linking CXX executable src/bitcoin-tx
ninja: build stopped: cannot make progress due to previous errors.
Build chronik-client-integration-tests failed with exit code 1

fix Cargo.lock

tobias_ruck added a child revision: D16525: [Chronik] Add `plugin` field to `TxInput` in `tx.py`.Jul 23 2024, 13:14

Harbormaster completed remote builds in B29672: Diff 48789.Jul 23 2024, 13:22

tobias_ruck published this revision for review.Jul 23 2024, 19:37

PiRK accepted this revision.Jul 24 2024, 06:29

This revision is now accepted and ready to land.Jul 24 2024, 06:29

Closed by commit rABC5642de615225: [Chronik] Upgrade pyo3 to 0.22 (authored by tobias_ruck). · Explain WhyJul 24 2024, 19:25

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC5642de615225: [Chronik] Upgrade pyo3 to 0.22.