HomePhabricator

net processing: clamp PeerManager::Options user input

Description

net processing: clamp PeerManager::Options user input

Summary:
Document PeerManager::Options members.

Clamp -maxorphantx to uint32_t bounds.

Clamp -blockreconstructionextratxn to uint32_t bounds.
Also changes max_extra_txs into a uint32_t to avoid platform-specific behaviour.

-maxaddrtosend is hidden option used only for tests, so we only do minimal boundary checks.

This is a backport of core#28149

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16456

Details

Provenance
stickies-v <stickies-v@protonmail.com>Authored on Jul 25 2023, 13:57
PiRKCommitted on Jul 12 2024, 14:30
PiRKPushed on Jul 12 2024, 14:30
Reviewer
Restricted Project
Differential Revision
D16456: net processing: clamp PeerManager::Options user input
Parents
rABCf3ea6de5679d: bugfix, Change up submitpackage results to return results for all transactions
Branches
Unknown
Tags
Unknown