Paths

Table of Contentst

Differential D16489

Seeder: do not exclude nodes that use a non-default port
ClosedPublic
Actions

Authored by PiRK on Jul 17 2024, 16:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC505f186dc297: Seeder: do not exclude nodes that use a non-default port

Summary

Historically Bitcoin (ABC) had a strong preference for using the default port, but as of D12344 this is no longer the case. So the seeder should stop considering nodes using non-default ports unreliable.

Test Plan

ninja check-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 17 2024, 16:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2024, 16:17

--unused include

Harbormaster completed remote builds in B29598: Diff 48688.Jul 17 2024, 16:31

Harbormaster completed remote builds in B29599: Diff 48689.Jul 17 2024, 16:43

Fabien accepted this revision.Jul 17 2024, 17:43

This revision is now accepted and ready to land.Jul 17 2024, 17:43

Closed by commit rABC505f186dc297: Seeder: do not exclude nodes that use a non-default port (authored by PiRK). · Explain WhyJul 18 2024, 05:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC505f186dc297: Seeder: do not exclude nodes that use a non-default port.

Revision Contents
Changeset List

Path

Size

src/

seeder/

db.h

3 lines

test/

CMakeLists.txt

1 line

db_tests.cpp

79 lines

Diff 48713

View Options

src/seeder/db.h

View Options

src/seeder/test/CMakeLists.txt

View Options

src/seeder/test/db_tests.cpp

Seeder: do not exclude nodes that use a non-default portClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48713

src/seeder/db.h

src/seeder/test/CMakeLists.txt

src/seeder/test/db_tests.cpp

Seeder: do not exclude nodes that use a non-default port
ClosedPublic
Actions

Revision Contents
Changeset List