Page MenuHomePhabricator

net: open p2p connections to nodes that listen on non-default ports
ClosedPublic

Authored by Fabien on Oct 20 2022, 18:14.

Details

Summary
By default, for mainnet, the p2p listening port is 8333. Bitcoin Core
has a strong preference for only connecting to nodes that listen on that
port.

Remove that preference because connections over clearnet that involve
port 8333 make it easy to detect, analyze, block or divert Bitcoin p2p
traffic before the connection is even established (at TCP SYN time).

Backport of core#23542.

Depends on D12342 and D12343.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Oct 20 2022, 18:14
PiRK added a subscriber: PiRK.

Great stuff!

This revision is now accepted and ready to land.Oct 21 2022, 08:11