Page MenuHomePhabricator
Differential D12338

scripted-diff: Rename CAddrInfo to AddrInfo
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:59.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC04cc356dea7e: scripted-diff: Rename CAddrInfo to AddrInfo
Summary

Completes backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/375750387e35ed751d1f5ab48860bdec93977f64

No change in behavior.

Depends on D12337.

Test Plan
ninja all check
ninja bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2022, 12:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:59
Fabien requested review of this revision.Oct 20 2022, 12:59
teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:59
Fabien added a child revision: D12339: log: improve addrman logging.Oct 20 2022, 13:13
Harbormaster completed remote builds in B20645: Diff 35891.Oct 20 2022, 14:15
PiRK requested changes to this revision.Oct 20 2022, 15:39
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/addrman.cpp
931 ↗(On Diff #35891)

something changed, here. Does this add an extra map lookup?

This revision now requires changes to proceed.Oct 20 2022, 15:39
Fabien updated this revision to Diff 35901.Oct 20 2022, 18:23

Reverse merge conflict oversight

PiRK accepted this revision.Oct 20 2022, 18:27
This revision is now accepted and ready to land.Oct 20 2022, 18:27
Harbormaster completed remote builds in B20654: Diff 35901.Oct 20 2022, 18:38
Closed by commit rABC04cc356dea7e: scripted-diff: Rename CAddrInfo to AddrInfo (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 21 2022, 08:34
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC04cc356dea7e: scripted-diff: Rename CAddrInfo to AddrInfo.

Revision Contents
Changeset List

PathSize
src/
79 lines
18 lines
test/
86 lines
fuzz/
2 lines

Diff 35919

View Options

src/addrman.cpp

Loading...
View Options

src/addrman_impl.h

Loading...
View Options

src/test/addrman_tests.cpp

Loading...
View Options

src/test/fuzz/deserialize.cpp

Loading...