Page MenuHomePhabricator
Differential D12330

[net, addrman] Remove external dependencies on CAddrInfo objects
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:56.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC4413bf85b465: [net, addrman] Remove external dependencies on CAddrInfo objects
Summary
CAddrInfo objects are an implementation detail of how AddrMan manages and adds metadata to different records. Encapsulate this logic by updating Select & SelectTriedCollision to return the additional info that the callers need.

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/7cba9d56185b9325ce41d79364e448462fff0f6a

Depends on D12329.

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
17 lines
34 lines
12 lines
bench/
2 lines
13 lines
test/
57 lines

Diff 35910

View Options

src/addrman.h

Loading...
View Options

src/addrman.cpp

Loading...
View Options

src/addrman_impl.h

Loading...
View Options

src/bench/addrman.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/test/addrman_tests.cpp

Loading...