Differential D12330

[net, addrman] Remove external dependencies on CAddrInfo objects
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:56.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4413bf85b465: [net, addrman] Remove external dependencies on CAddrInfo objects

Summary

CAddrInfo objects are an implementation detail of how AddrMan manages and adds metadata to different records. Encapsulate this logic by updating Select & SelectTriedCollision to return the additional info that the callers need.

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/7cba9d56185b9325ce41d79364e448462fff0f6a

Depends on D12329.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR22950_p4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20637
Build 40938: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 40937: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 20 2022, 12:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:56

Fabien requested review of this revision.Oct 20 2022, 12:56

teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:56

Fabien added a child revision: D12331: [move-only] Move CAddrInfo to test-only header file.Oct 20 2022, 12:56

Harbormaster completed remote builds in B20637: Diff 35883.Oct 20 2022, 13:26

PiRK accepted this revision.Oct 20 2022, 15:00

This revision is now accepted and ready to land.Oct 20 2022, 15:00

Closed by commit rABC4413bf85b465: [net, addrman] Remove external dependencies on CAddrInfo objects (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 21 2022, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4413bf85b465: [net, addrman] Remove external dependencies on CAddrInfo objects.

Revision Contents
Changeset List

Path

Size

src/

17 lines

34 lines

12 lines

bench/

2 lines

13 lines

test/

addrman_tests.cpp

57 lines

Diff 35883

src/addrman.h

Loading...

src/addrman.cpp

Loading...

src/addrman_impl.h

Loading...

src/bench/addrman.cpp

Loading...

src/net.cpp

Loading...

src/test/addrman_tests.cpp

Loading...