Differential D12332

[addrman] Change CAddrInfo access
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:57.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC88cbd67a7643: [addrman] Change CAddrInfo access

Summary

Since knowledge of CAddrInfo is limited to callsites that import addrman_impl.h, only objects in addrman.cpp or the tests have access. Thus we can remove calling them friends and make the members  public.

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/7cf41bbb38db5008f9b69037b88138076d6a6cc5

Depends on D12331.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2022, 12:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:57

Fabien requested review of this revision.Oct 20 2022, 12:57

teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:57

Fabien added a child revision: D12333: [move-only] Move constants to test-only header.Oct 20 2022, 12:57

Harbormaster completed remote builds in B20639: Diff 35885.Oct 20 2022, 13:37

PiRK accepted this revision.Oct 20 2022, 15:07

This revision is now accepted and ready to land.Oct 20 2022, 15:07

Closed by commit rABC88cbd67a7643: [addrman] Change CAddrInfo access (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 21 2022, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC88cbd67a7643: [addrman] Change CAddrInfo access.

Revision Contents
Changeset List

Path

Size

src/

addrman_impl.h

4 lines

Diff 35914

View Options

[addrman] Change CAddrInfo accessClosedPublicActions