HomePhabricator

[addrman] Change CAddrInfo access

Description

[addrman] Change CAddrInfo access

Summary:

Since knowledge of CAddrInfo is limited to callsites that import addrman_impl.h, only objects in addrman.cpp or the tests have access. Thus we can remove calling them friends and make the members  public.

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/7cf41bbb38db5008f9b69037b88138076d6a6cc5

Depends on D12331.

Test Plan:

ninja all check

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D12332

Details

Provenance
Amiti Uttarwar <amiti@uttarwar.org>Authored on Sep 10 2021, 20:32
FabienCommitted on Oct 21 2022, 08:34
FabienPushed on Oct 21 2022, 08:34
Reviewer
Restricted Project
Differential Revision
D12332: [addrman] Change CAddrInfo access
Parents
rABC9e47c5912da1: [move-only] Move CAddrInfo to test-only header file
Branches
Unknown
Tags
Unknown