Differential D12335

[doc] Update comments
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:58.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4e34300aa0e8: [doc] Update comments

Summary

Maintain comments on the external interfaces rather than on the internal
functions that implement them.

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/29727c2aa1233f7c5b91a17884c405e0aef10c6e

Depends on D12334.

Test Plan

Read the comments

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2022, 12:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:58

Fabien requested review of this revision.Oct 20 2022, 12:58

teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:58

Fabien added a child revision: D12336: [includes] Fix up included files.Oct 20 2022, 12:58

Harbormaster completed remote builds in B20642: Diff 35888.Oct 20 2022, 13:56

PiRK accepted this revision.Oct 20 2022, 15:17

This revision is now accepted and ready to land.Oct 20 2022, 15:17

Closed by commit rABC4e34300aa0e8: [doc] Update comments (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 21 2022, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4e34300aa0e8: [doc] Update comments.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

19 lines

addrman.cpp

2 lines

addrman_impl.h

35 lines

Diff 35916

View Options

src/addrman.h

View Options

src/addrman.cpp

View Options

[doc] Update commentsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35916

src/addrman.h

src/addrman.cpp

src/addrman_impl.h

[doc] Update comments
ClosedPublic
Actions

Revision Contents
Changeset List