Differential D12334

[refactor] Update GetAddr_() function signature
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:57.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4956ab642004: [refactor] Update GetAddr_() function signature

Summary

Update so the internal function signature matches the external one, as is the case for the other addrman functions.

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/14f9e000d05f82b364d5a142cafc70b10406b660

Depends on D12333.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2022, 12:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:57

Fabien requested review of this revision.Oct 20 2022, 12:57

teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:57

Fabien added a child revision: D12335: [doc] Update comments.Oct 20 2022, 12:58

Harbormaster completed remote builds in B20641: Diff 35887.Oct 20 2022, 13:48

PiRK accepted this revision.Oct 20 2022, 15:11

This revision is now accepted and ready to land.Oct 20 2022, 15:11

Closed by commit rABC4956ab642004: [refactor] Update GetAddr_() function signature (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 21 2022, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4956ab642004: [refactor] Update GetAddr_() function signature.

Revision Contents
Changeset List

Path

Size

src/

addrman.cpp

18 lines

addrman_impl.h

9 lines

Diff 35915

View Options

src/addrman.cpp