Differential D12333

[move-only] Move constants to test-only header
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:57.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCa4315672f093: [move-only] Move constants to test-only header

Summary

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/40acd6fc9a8098fed85abf4fb727a5f0dff8a2ff

Depends on D12332.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2022, 12:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:57

Fabien requested review of this revision.Oct 20 2022, 12:57

teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:57

Fabien added a child revision: D12334: [refactor] Update GetAddr_() function signature.Oct 20 2022, 12:57

Harbormaster completed remote builds in B20640: Diff 35886.Oct 20 2022, 13:41

PiRK accepted this revision.Oct 20 2022, 15:08

This revision is now accepted and ready to land.Oct 20 2022, 15:08

Closed by commit rABCa4315672f093: [move-only] Move constants to test-only header (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 21 2022, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa4315672f093: [move-only] Move constants to test-only header.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

17 lines

addrman_impl.h

14 lines

Diff 35913

View Options

src/addrman.h