Paths

Table of Contentst

Differential D16517

[test] remove pointless block_hashes.append(...)
ClosedPublic
Actions

Authored by PiRK on Jul 22 2024, 15:50.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCbbe8d5dd70a0: [test] remove pointless block_hashes.append(...)

Summary

This line duplicated the block hashes, as they were already saved in that list using the list returned by generatetoaddress. It didn't cause any issue because all the following tests looped over the 101 first indices of that list, so the duplicated values were just ignored.

Test Plan

with chronik
ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 22 2024, 15:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2024, 15:50

PiRK requested review of this revision.Jul 22 2024, 15:50

Harbormaster completed remote builds in B29657: Diff 48771.Jul 22 2024, 16:11

roqqit accepted this revision.Jul 22 2024, 17:41

This revision is now accepted and ready to land.Jul 22 2024, 17:41

Closed by commit rABCbbe8d5dd70a0: [test] remove pointless block_hashes.append(...) (authored by PiRK). · Explain WhyJul 23 2024, 06:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbbe8d5dd70a0: [test] remove pointless block_hashes.append(...).

Revision Contents
Changeset List

Path

Size

test/

functional/

chronik_block.py

1 line

Diff 48782

test/functional/chronik_block.py

Loading...