Differential D17929

[avalanche] Test: Simplify checking for undesired hashes in polls
ClosedPublic
Actions

Authored by Fabien on Apr 14 2025, 10:48.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC894ffc7982c4: [avalanche] Test: Simplify checking for undesired hashes in polls

Summary

So far we used a custom solution in abc_p2p_avalanche_transaction_finalization.py to against undesired polls. We can greatly simplify this is and make it more reusable by making this an option in the common avatools function.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_transaction_finalization

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 14 2025, 10:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2025, 10:48

Fabien requested review of this revision.Apr 14 2025, 10:48

Fabien added a child revision: D17832: [avalanche] Poll for the transactions that didn't make it into the last block.Apr 14 2025, 10:52

Harbormaster completed remote builds in B32956: Diff 53467.Apr 14 2025, 11:01

PiRK accepted this revision.Apr 14 2025, 13:33

This revision is now accepted and ready to land.Apr 14 2025, 13:33

Closed by commit rABC894ffc7982c4: [avalanche] Test: Simplify checking for undesired hashes in polls (authored by Fabien). · Explain WhyApr 14 2025, 16:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC894ffc7982c4: [avalanche] Test: Simplify checking for undesired hashes in polls.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_transaction_finalization.py

56 lines

test_framework/

avatools.py

5 lines

Diff 53476

View Options

test/functional/abc_p2p_avalanche_transaction_finalization.py