Differential D17909

Remove the deprecated address_type field from the getnewaddress RPC
ClosedPublic
Actions

Authored by Fabien on Tue, Apr 8, 10:06.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC087e5a09d024: Remove the deprecated address_type field from the getnewaddress RPC

Summary

This field was causing confusion because the "legacy" output type doesn't lead to the generation of a legacy (aka btc) address. This has been deprecated since 0.30.4 so it's time to remove it.

Depends on D17908.

Test Plan

ninja all check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Tue, Apr 8, 10:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Apr 8, 10:06

Fabien requested review of this revision.Tue, Apr 8, 10:06

PiRK accepted this revision.Tue, Apr 8, 10:30

This revision is now accepted and ready to land.Tue, Apr 8, 10:30

Harbormaster completed remote builds in B32920: Diff 53412.Tue, Apr 8, 10:37

Closed by commit rABC087e5a09d024: Remove the deprecated address_type field from the getnewaddress RPC (authored by Fabien). · Explain WhyTue, Apr 8, 12:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC087e5a09d024: Remove the deprecated address_type field from the getnewaddress RPC.

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

4 lines

src/

wallet/

rpcwallet.cpp

20 lines

test/

functional/

rpc_createmultisig.py

4 lines

rpc_help.py

8 lines

rpc_rawtransaction.py

115 lines

wallet_avoidreuse.py

2 lines

wallet_createwallet.py

5 lines

wallet_descriptor.py

2 lines

wallet_txn_clone.py

6 lines

Diff 53419

View Options

doc/release-notes.md

View Options

src/wallet/rpcwallet.cpp

View Options

test/functional/rpc_createmultisig.py

View Options

test/functional/rpc_help.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/wallet_avoidreuse.py

View Options

test/functional/wallet_createwallet.py

View Options

test/functional/wallet_descriptor.py

View Options

test/functional/wallet_txn_clone.py

Remove the deprecated address_type field from the getnewaddress RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53419

doc/release-notes.md

src/wallet/rpcwallet.cpp

test/functional/rpc_createmultisig.py

test/functional/rpc_help.py

test/functional/rpc_rawtransaction.py

test/functional/wallet_avoidreuse.py

test/functional/wallet_createwallet.py

test/functional/wallet_descriptor.py

test/functional/wallet_txn_clone.py

Remove the deprecated address_type field from the getnewaddress RPC
ClosedPublic
Actions

Revision Contents
Changeset List