Differential D17836

[avalanche] Improve lock annotations for AvalancheFinalizeBlock
ClosedPublic
Actions

Authored by Fabien on Thu, Mar 20, 09:08.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC48b7eae57e55: [avalanche] Improve lock annotations for AvalancheFinalizeBlock

Summary

The migration of the stake contender cache to the peer manager changed the locking expectations, so let's update the annotations to reflect this.
I didn't add the negative annotation for cs_main because it bubbles up everywhere which is more annoying than helpful, but kept the runtime assertion so debug build would catch it anyway.

Test Plan

With clang:

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Thu, Mar 20, 09:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 20, 09:08

Fabien requested review of this revision.Thu, Mar 20, 09:08

Harbormaster completed remote builds in B32784: Diff 53199.Thu, Mar 20, 09:11

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[474/528] Running utility command for check-seeder-message_writer_tests
[475/528] Running utility command for check-bitcoin-walletdb_tests
[476/528] bitcoin: testing validation_block_tests
[477/528] Running utility command for check-seeder-db_tests
[478/528] pow: testing eda_tests
[479/528] bitcoin: testing psbt_wallet_tests
[480/528] Running utility command for check-bitcoin-validation_block_tests
[481/528] Running utility command for check-pow-eda_tests
[482/528] Running utility command for check-bitcoin-psbt_wallet_tests
[483/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[484/528] seeder: testing options_tests
[485/528] seeder: testing p2p_messaging_tests
[486/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[487/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[488/528] Running utility command for check-seeder-options_tests
[489/528] Running utility command for check-seeder-p2p_messaging_tests
[490/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[491/528] seeder: testing parse_name_tests
[492/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[493/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[494/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[495/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[496/528] Running utility command for check-seeder-parse_name_tests
[497/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[498/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[499/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[500/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[501/528] seeder: testing write_name_tests
[502/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[503/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[504/528] Running utility command for check-seeder-write_name_tests
[505/528] Running seeder test suite
PASSED: seeder test suite
[506/528] pow: testing grasberg_tests
[507/528] Running utility command for check-pow-grasberg_tests
[508/528] Running pow test suite
PASSED: pow test suite
[509/528] Linking CXX executable src/qt/test/test_bitcoin-qt
[510/528] bitcoin: testing wallet_crypto_tests
[511/528] Running utility command for check-bitcoin-wallet_crypto_tests
[512/528] bitcoin: testing coins_tests
[513/528] Running utility command for check-bitcoin-coins_tests
[514/528] bitcoin-qt: testing test_bitcoin-qt
[515/528] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[516/528] bitcoin: testing transaction_tests
[517/528] Running utility command for check-bitcoin-transaction_tests
[518/528] bitcoin: testing wallet_tests
[519/528] Running utility command for check-bitcoin-wallet_tests
[520/528] bitcoin: testing coinselector_tests
[521/528] Running utility command for check-bitcoin-coinselector_tests
[522/528] bitcoin: testing validation_chainstatemanager_tests
[523/528] Running utility command for check-bitcoin-validation_chainstatemanager_tests
[524/528] Running bitcoin test suite
PASSED: bitcoin test suite
[525/528] secp256k1: testing secp256k1-tests
[526/528] Running secp256k1 test suite
PASSED: secp256k1 test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Fabien planned changes to this revision.Thu, Mar 20, 09:30

Rebase

Harbormaster completed remote builds in B32929: Diff 53428.Wed, Apr 9, 14:09

roqqit accepted this revision.Wed, Apr 9, 16:34

This revision is now accepted and ready to land.Wed, Apr 9, 16:34

Closed by commit rABC48b7eae57e55: [avalanche] Improve lock annotations for AvalancheFinalizeBlock (authored by Fabien). · Explain WhyWed, Apr 9, 18:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC48b7eae57e55: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.