test: fix generation of conflicting transactions in chronik_electrum_blockchain.py
ClosedPublic
Actions

Authored by PiRK on Wed, Apr 16, 11:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC087505795565: test: fix generation of conflicting transactions in chronik_electrum_blockchain.

Summary

I missed this in D17933. Apply the same solution as D17902: to make a conflicting tx now that MiniWallet is deterministic, we can specify a different target_size.

Also do some minor refactoring to avoid an extra call to self.wallet.create_self_transfer and pad_tx

Test Plan

with chronik compiled, ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Apr 16, 11:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 16, 11:37

PiRK requested review of this revision.Wed, Apr 16, 11:37

Harbormaster completed remote builds in B32980: Diff 53504.Wed, Apr 16, 11:53

Fabien accepted this revision.Wed, Apr 16, 12:26

This revision is now accepted and ready to land.Wed, Apr 16, 12:26

Closed by commit rABC087505795565: test: fix generation of conflicting transactions in chronik_electrum_blockchain. (authored by PiRK). · Explain WhyWed, Apr 16, 13:13

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC087505795565: test: fix generation of conflicting transactions in chronik_electrum_blockchain..

Revision Contents
Changeset List

Path

Size

test/

functional/

chronik_electrum_blockchain.py

23 lines

Diff 53510

View Options

test/functional/chronik_electrum_blockchain.py

test: fix generation of conflicting transactions in chronik_electrum_blockchain.pyClosedPublicActions