Page MenuHomePhabricator
Differential D11464

Lint test_framework/messages.py
AbandonedPublic
Actions

Authored by sdulfari on May 13 2022, 23:38.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Summary

Because it needs de-linting and I don't want this showing up in my other diff.

Test Plan
ninja check-functional

Diff Detail

Event Timeline

sdulfari created this revision.May 13 2022, 23:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2022, 23:38
sdulfari requested review of this revision.May 13 2022, 23:38
Harbormaster completed remote builds in B19026: Diff 33513.May 13 2022, 23:51
PiRK added a subscriber: PiRK.May 15 2022, 10:16

This change is an improvement imho, but I find it strange that on my machine the linter does not pick it up.

Did you identify which linter does the change?
Which versions of autopep8 and flake8 are you running (pip list)?

I'm just trying to make sure that it will not conflict with any previous version of theses linters. Maybe we can bump the minimum version number for them so that we all get consistent results.

PiRK accepted this revision.May 16 2022, 06:05
This revision is now accepted and ready to land.May 16 2022, 06:05
sdulfari abandoned this revision.May 16 2022, 16:20

I compared versions with Fabien and the version I'm on is older. Installing flake8 and autopep8 via pip3 instead of apt gives the newer versions which give clean linting for this file.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
24 lines

Diff 33513

View Options

test/functional/test_framework/messages.py

Loading...