Differential D11477

[avalanche] Remove unecessary timeout in the abc_p2p_getavaaddr.py test
ClosedPublic
Actions

Authored by Fabien on May 17 2022, 12:28.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC53a5929c0141: [avalanche] Remove unecessary timeout in the abc_p2p_getavaaddr.py test

Summary

I noticed the test sometimes fails due to some timeout on the addnode call, which is unrelated to the test:https://build.bitcoinabc.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=390761&_focus=3753&guest=1 . In general there is little advantage to use short timeouts as it can make the test flacky on slow machines, which doesn't help in detecting the actual issues.

Test Plan

./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 17 2022, 12:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 17 2022, 12:28

Fabien requested review of this revision.May 17 2022, 12:28

Harbormaster completed remote builds in B19055: Diff 33554.May 17 2022, 12:44

These timeouts are a symptom that the default is too long. They make local testing painful when debugging tests. We should consider lowering the default timeout if not too many tests are impacted, but that will be a separate change.

This revision is now accepted and ready to land.May 17 2022, 15:58

Closed by commit rABC53a5929c0141: [avalanche] Remove unecessary timeout in the abc_p2p_getavaaddr.py test (authored by Fabien). · Explain WhyMay 17 2022, 18:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC53a5929c0141: [avalanche] Remove unecessary timeout in the abc_p2p_getavaaddr.py test.