Differential D11746

[avalanche] Use proof dust threshold in unit tests instead of low coin amounts
ClosedPublic
Actions

Authored by sdulfari on Jul 13 2022, 21:44.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC80c5993fb9d6: [avalanche] Use proof dust threshold in unit tests instead of low coin amounts

Summary

This makes it much easier to bump PROOF_DUST_THRESHOLD without breaking tons of tests.
I did not update every conceivable Amount, but focused on those that will break if the
dust threshold is bumped by a factor of 10 to 100. Any further tweaks can be made by
that future patch.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Jul 13 2022, 21:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 13 2022, 21:44

sdulfari requested review of this revision.Jul 13 2022, 21:44

Harbormaster completed remote builds in B19635: Diff 34367.Jul 13 2022, 22:00

Fabien accepted this revision.Jul 14 2022, 07:15

This revision is now accepted and ready to land.Jul 14 2022, 07:15

Closed by commit rABC80c5993fb9d6: [avalanche] Use proof dust threshold in unit tests instead of low coin amounts (authored by sdulfari). · Explain WhyJul 14 2022, 16:47

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC80c5993fb9d6: [avalanche] Use proof dust threshold in unit tests instead of low coin amounts.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

102 lines

processor_tests.cpp

9 lines

Diff 34371

src/avalanche/test/peermanager_tests.cpp

Loading...

src/avalanche/test/processor_tests.cpp

Loading...