Page MenuHomePhabricator

[avalanche] Fix an log error during proof rejection

Authored by Fabien on Jul 15 2022, 13:23.


Group Reviewers
Restricted Project
rABCd5f6df1596a6: [avalanche] Fix an log error during proof rejection

The message ERROR: Failed to reject proof is printed when a proof is rejected due to conflicts. This diff fixes the issue by simply using the output from the PeerManager::rejectProof() method instead of another layer of logic.

Test Plan
./test/functional/ abc_p2p_avalanche_proof_voting

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jul 15 2022, 13:23

Failed tests logs:

====== Bitcoin ABC functional tests: ======

------- Stdout: -------
2022-07-15T13:36:10.691000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220715_133516/abc_p2p_compactproofs_17
2022-07-15T13:36:11.383000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-07-15T13:36:13.374000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-07-15T13:36:13.982000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-07-15T13:36:18.690000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/", line 136, in main
  File "/work/test/functional/", line 674, in run_test
  File "/work/test/functional/", line 190, in test_send_outbound_getavaproofs
  File "/usr/lib/python3.7/", line 119, in __exit__
  File "/work/test/functional/test_framework/", line 535, in assert_debug_log
    str(expected_msgs), print_log))
  File "/work/test/functional/test_framework/", line 213, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected messages "['received: avaproofs']" does not partially match log:


2022-07-15T13:36:18.745000Z TestFramework (INFO): Stopping nodes
2022-07-15T13:36:19.499000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220715_133516/abc_p2p_compactproofs_17
2022-07-15T13:36:19.499000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220715_133516/abc_p2p_compactproofs_17/test_framework.log
2022-07-15T13:36:19.499000Z TestFramework (ERROR): 
2022-07-15T13:36:19.499000Z TestFramework (ERROR): Hint: Call /work/test/functional/ '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220715_133516/abc_p2p_compactproofs_17' to consolidate all logs
2022-07-15T13:36:19.499000Z TestFramework (ERROR): 
2022-07-15T13:36:19.499000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-07-15T13:36:19.499000Z TestFramework (ERROR):
2022-07-15T13:36:19.499000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests:

Fabien planned changes to this revision.Jul 15 2022, 13:44
Fabien requested review of this revision.Jul 15 2022, 13:57

Restart the builds. The failure is unrelated to this change.

This revision is now accepted and ready to land.Jul 15 2022, 16:45