Page MenuHomePhabricator
Differential D11822

[avalanche] Add coins directly instead of using coinbases in processor unit tests
ClosedPublic
Actions

Authored by sdulfari on Aug 3 2022, 07:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC90b5164c2248: [avalanche] Add coins directly instead of using coinbases in processor unit…
Summary

Using the coinbases was efficient since they are already available in the test, but this will break if/when the dust treshold exceeds the coinbase reward. This patch replaces that implementation of GetProof() with one that adds the coins directly with the minimum amount instead of using the coinbases.

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sdulfari created this revision.Aug 3 2022, 07:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 3 2022, 07:57
sdulfari requested review of this revision.Aug 3 2022, 07:57
Harbormaster completed remote builds in B19763: Diff 34571.Aug 3 2022, 07:58
teamcity added a comment.Aug 3 2022, 07:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Aug 3 2022, 07:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Aug 3 2022, 07:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Aug 3 2022, 07:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Aug 3 2022, 07:59
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Aug 3 2022, 07:59
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien accepted this revision.Aug 3 2022, 13:16
This revision is now accepted and ready to land.Aug 3 2022, 13:16
Closed by commit rABC90b5164c2248: [avalanche] Add coins directly instead of using coinbases in processor unit… (authored by sdulfari). · Explain WhyAug 3 2022, 15:26
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC90b5164c2248: [avalanche] Add coins directly instead of using coinbases in processor unit….

Revision Contents
Changeset List

PathSize
src/
avalanche/
test/
19 lines

Diff 34576

View Options

src/avalanche/test/processor_tests.cpp

Loading...