Differential D11839

[avalanche] Hide the master and session keys in the debug log and console
ClosedPublic
Actions

Authored by Fabien on Aug 10 2022, 19:35.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCe758dde8096e: [avalanche] Hide the master and session keys in the debug log and console

Summary

The configuration is printed out to the debug.log/console which can leak the avalanche master key or session key set as options. This diff fixes that:

2022-08-10T19:31:48Z Command-line arg: avamasterkey=****
2022-08-10T19:31:48Z Command-line arg: avasessionkey=****

Test Plan

./src/bitcoind -avamasterkey=<key> -avasessionkey=<key>

Make sure both keys are obfuscated.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 10 2022, 19:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 10 2022, 19:35

Fabien requested review of this revision.Aug 10 2022, 19:35

Harbormaster completed remote builds in B19794: Diff 34617.Aug 10 2022, 19:52

sdulfari accepted this revision.Aug 10 2022, 21:08

This revision is now accepted and ready to land.Aug 10 2022, 21:08

Closed by commit rABCe758dde8096e: [avalanche] Hide the master and session keys in the debug log and console (authored by Fabien). · Explain WhyAug 11 2022, 07:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe758dde8096e: [avalanche] Hide the master and session keys in the debug log and console.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

6 lines

Diff 34618

View Options

[avalanche] Hide the master and session keys in the debug log and consoleClosedPublicActions