Differential D11840

[avalanche] Bump the peer replacement cooldown
ClosedPublic
Actions

Authored by Fabien on Aug 11 2022, 09:24.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC621d6b79ad74: [avalanche] Bump the peer replacement cooldown

Summary

This used to be 1h, bump this value to 1 day instead. This means that a user cannot change its proof more than once per day, which should help having a stable quorum.

Because the tests override the default value, no other change is needed.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 11 2022, 09:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 11 2022, 09:24

Fabien requested review of this revision.Aug 11 2022, 09:24

Harbormaster completed remote builds in B19795: Diff 34619.Aug 11 2022, 09:41

This should be a std::chrono::duration

This revision is now accepted and ready to land.Aug 11 2022, 16:20

Problem is that the arg manager doesn't work with std::chrono, so even if it is chrono internally the default value needs to be integer compatible

Closed by commit rABC621d6b79ad74: [avalanche] Bump the peer replacement cooldown (authored by Fabien). · Explain WhyAug 12 2022, 12:10

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC621d6b79ad74: [avalanche] Bump the peer replacement cooldown.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

avalanche.h

3 lines

Diff 34633

View Options

[avalanche] Bump the peer replacement cooldownClosedPublicActions