Page MenuHomePhabricator

[avalanche] Tests: stop the scheduler before the fixture is destructed
AbandonedPublic

Authored by Fabien on Sep 13 2022, 07:45.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Summary

This will avoid having the dangling proof cleanup task triggered after the fixture processor is destructed. This only affects the processor unit tests.

Test Plan

Run the ASAN and TSAN builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_stop_scheduler_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20007
Build 39703: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39702: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Sep 13 2022, 07:45
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
sdulfari requested changes to this revision.Sep 13 2022, 16:29
sdulfari added a subscriber: sdulfari.

This only fixes the case where the scheduled cleanup happens post-test-cleanup, but not the case where m_processor is replaced and the test is still running, therefore the first processor instance's cleanup gets run on the destructed processor. I think my solution here is more complete: D11965

This revision now requires changes to proceed.Sep 13 2022, 16:29