Page MenuHomePhabricator
Differential D11999

[avalanche] Add a way to retrieve all proof ids in a proofpool
ClosedPublic
Actions

Authored by sdulfari on Sep 16 2022, 19:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6efbe90b2307: [avalanche] Add a way to retrieve all proof ids in a proofpool
Summary

Currently unused. This will be used to fetch proof ids via RPC.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sdulfari created this revision.Sep 16 2022, 19:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2022, 19:10
sdulfari requested review of this revision.Sep 16 2022, 19:10
Fabien requested changes to this revision.Sep 16 2022, 19:25
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/proofpool.cpp
111 ↗(On Diff #34998)

The set has unique keys, you don't need that test at all.

This revision now requires changes to proceed.Sep 16 2022, 19:25
Harbormaster completed remote builds in B20055: Diff 34998.Sep 16 2022, 19:27
sdulfari requested review of this revision.Sep 19 2022, 18:00
sdulfari added inline comments.
src/avalanche/proofpool.cpp
111 ↗(On Diff #34998)

It's unique by utxo, not proofid.

Fabien added inline comments.Sep 19 2022, 19:35
src/avalanche/proofpool.cpp
111 ↗(On Diff #34998)

std::unordered_set<ProofId, SaltedProofIdHasher> proofIds;

Looks like ProofId is the key to me.

sdulfari updated this revision to Diff 35010.Sep 19 2022, 20:14

Remove unnecessary dedup logic

Harbormaster completed remote builds in B20066: Diff 35010.Sep 19 2022, 20:30
Fabien accepted this revision.Sep 20 2022, 06:16
This revision is now accepted and ready to land.Sep 20 2022, 06:16
Closed by commit rABC6efbe90b2307: [avalanche] Add a way to retrieve all proof ids in a proofpool (authored by sdulfari). · Explain WhySep 20 2022, 15:54
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC6efbe90b2307: [avalanche] Add a way to retrieve all proof ids in a proofpool.
sdulfari mentioned this in D12013: [avalanche] Add a way to retrieve proof ids from each pool.Sep 20 2022, 19:10

Revision Contents
Changeset List

PathSize
src/
avalanche/
1 line
12 lines
test/
40 lines

Diff 35046

View Options

src/avalanche/proofpool.h

Loading...
View Options

src/avalanche/proofpool.cpp

Loading...
View Options

src/avalanche/test/proofpool_tests.cpp

Loading...