Page MenuHomePhabricator
Differential D12257

refactor: Make CAddrMan::cs non-recursive
ClosedPublic
Actions

Authored by Fabien on Oct 14 2022, 14:09.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCb8bdc0c6dd89: refactor: Make CAddrMan::cs non-recursive
Summary
This PR replaces RecursiveMutex CAddrMan::cs with Mutex CAddrMan::cs.

All of the related code branches are covered by appropriate lock assertions to insure that the mutex locking policy has not been changed by accident.

Backport of core#19238.

Depends no D12252 and D12254.

Test Plan

With Debug and Clang:

ninja all check-all

Run the TSAN build.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 14 2022, 14:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2022, 14:09
Fabien requested review of this revision.Oct 14 2022, 14:09
teamcity edited the summary of this revision. (Show Details)Oct 14 2022, 14:10
Harbormaster completed remote builds in B20523: Diff 35703.Oct 14 2022, 15:27
sdulfari accepted this revision.Oct 14 2022, 17:17
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/addrman.h
508 ↗(On Diff #35703)

Nit: undo moving the comment

This revision is now accepted and ready to land.Oct 14 2022, 17:17
Fabien added inline comments.Oct 14 2022, 18:40
src/addrman.h
508 ↗(On Diff #35703)

Good catch

Closed by commit rABCb8bdc0c6dd89: refactor: Make CAddrMan::cs non-recursive (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyOct 14 2022, 18:59
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb8bdc0c6dd89: refactor: Make CAddrMan::cs non-recursive.

Revision Contents
Changeset List

PathSize
src/
94 lines
34 lines
test/
3 lines

Diff 35713

View Options

src/addrman.h

Loading...
View Options

src/addrman.cpp

Loading...
View Options

src/test/addrman_tests.cpp

Loading...