Differential D12290

[avalanche] Separate pubkey from AvalancheState
ClosedPublic
Actions

Authored by sdulfari on Oct 17 2022, 21:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC080be4129500: [avalanche] Separate pubkey from AvalancheState

Summary

AvalancheState is really a container for various Avalanche statistics rather than the entire state. Decoupling the pubkey from this makes sense. I made it optional to make it clear that not all nodes must have an Avalanche pubkey.

Future patches will refactor and rename AvalancheState.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Oct 17 2022, 21:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 21:40

sdulfari requested review of this revision.Oct 17 2022, 21:40

Harbormaster completed remote builds in B20569: Diff 35779.Oct 17 2022, 21:54

Fabien accepted this revision.Oct 18 2022, 11:33

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
5079 ↗	(On Diff #35779)	Not necessarily this diff, but it's an opportunity to make it a different error message. If you get a response from a peer with no pubkey, you have a signature issue for sure but you shouldn't have the message in the first place and it might be adversarial