Page MenuHomePhabricator
Differential D12632

[Cashtab] [experimental] local tests in bitcoincashjs-lib
AbandonedPublic
Actions

Authored by bytesofman on Nov 25 2022, 14:18.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

T2730

Local implementation of getECPairFromWIF does not preserve types as required for tx builder to properly create a tx. This issue only occurs in prod (built) version, not in npm start version.

This will be a stacked diff where the library is pulled in and modified locally.

In part 1, we pull in bitcoincashjs-lib unchanged from https://github.com/Permissionless-Software-Foundation/bitcoincashjs-lib

Test Plan

Confirm no other changes but new library copied in

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecpair-patching-stack
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixweb/bitcoincashjs-lib/README.md:3WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:4WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:7WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:10WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:13WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:16WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:19WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:22WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:25WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:28WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:31WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:34WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:37WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:40WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:43WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:46WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:49WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:52WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:55WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:58WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:61WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:64WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:67WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:70WHITESPACE1Found trailing whitespace(s).
Auto-Fixweb/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json:73WHITESPACE1Found trailing whitespace(s).
Unit
No Test Coverage
Build Status
Buildable 21146
Build 41944: Build Diff
Build 41943: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 25 2022, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 14:18
bytesofman requested review of this revision.Nov 25 2022, 14:18
Harbormaster completed remote builds in B21146: Diff 36641.Nov 25 2022, 14:18
bytesofman abandoned this revision.Nov 25 2022, 19:20

Issue is better resolved in webpack. May want to bring this into the monorepo later for further optimizations, but not on this stack.

Made obsolete by D12638

Revision Contents
Changeset List

PathSize
web/
bitcoincashjs-lib/
4 lines
18 lines
190 lines
21 lines
3 lines
2751 lines
62 lines
src/
124 lines
182 lines
61 lines
29 lines
100 lines
149 lines
115 lines
331 lines
23 lines
37 lines
75 lines
156 lines
285 lines
75 lines
templates/
75 lines
multisig/
4 lines
77 lines
71 lines
35 lines
pubkey/
4 lines
41 lines
37 lines
pubkeyhash/
4 lines
59 lines
46 lines
scripthash/
4 lines
100 lines
38 lines
witnesscommitment/
3 lines
46 lines
witnesspubkeyhash/
4 lines
52 lines
33 lines
witnessscripthash/
4 lines
78 lines
33 lines
623 lines
962 lines
55 lines
test/
156 lines
256 lines
40 lines
161 lines
171 lines
52 lines
26 lines
168 lines
288 lines
154 lines
fixtures/
180 lines
126 lines
117 lines
core/
26 lines
20 lines
102 lines
452 lines
27 lines
7 lines
36 lines
3503 lines
1959 lines
34 lines
200 lines
130 lines
214 lines
313 lines
103 lines
187 lines
225 lines
503 lines
835 lines
2144 lines
476 lines
integration/
7 lines
130 lines
186 lines
135 lines
175 lines
210 lines
207 lines
329 lines
74 lines
193 lines
30 lines
611 lines
352 lines
738 lines
73 lines

Diff 36641

View Options

web/bitcoincashjs-lib/.gitignore

Loading...
View Options

web/bitcoincashjs-lib/.travis.yml

Loading...
View Options

web/bitcoincashjs-lib/CHANGELOG.md

Loading...
View Options

web/bitcoincashjs-lib/LICENSE

Loading...
View Options

web/bitcoincashjs-lib/README.md

Loading...
View Options

web/bitcoincashjs-lib/package-lock.json

Loading...
View Options

web/bitcoincashjs-lib/package.json

Loading...
View Options

web/bitcoincashjs-lib/src/address.js

Loading...
View Options

web/bitcoincashjs-lib/src/block.js

Loading...
View Options

web/bitcoincashjs-lib/src/bufferutils.js

Loading...
View Options

web/bitcoincashjs-lib/src/crypto.js

Loading...
View Options

web/bitcoincashjs-lib/src/ecdsa.js

Loading...
View Options

web/bitcoincashjs-lib/src/ecpair.js

Loading...
View Options

web/bitcoincashjs-lib/src/ecsignature.js

Loading...
View Options

web/bitcoincashjs-lib/src/hdnode.js

Loading...
View Options

web/bitcoincashjs-lib/src/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/networks.js

Loading...
View Options

web/bitcoincashjs-lib/src/rfc6979.js

Loading...
View Options

web/bitcoincashjs-lib/src/schnorr.js

Loading...
View Options

web/bitcoincashjs-lib/src/script.js

Loading...
View Options

web/bitcoincashjs-lib/src/script_number.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/multisig/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/multisig/input.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/multisig/output.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/nulldata.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/pubkey/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/pubkey/input.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/pubkey/output.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/pubkeyhash/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/pubkeyhash/input.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/pubkeyhash/output.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/scripthash/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/scripthash/input.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/scripthash/output.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/witnesscommitment/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/witnesscommitment/output.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/witnesspubkeyhash/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/witnesspubkeyhash/input.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/witnesspubkeyhash/output.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/witnessscripthash/index.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/witnessscripthash/input.js

Loading...
View Options

web/bitcoincashjs-lib/src/templates/witnessscripthash/output.js

Loading...
View Options

web/bitcoincashjs-lib/src/transaction.js

Loading...
View Options

web/bitcoincashjs-lib/src/transaction_builder.js

Loading...
View Options

web/bitcoincashjs-lib/src/types.js

Loading...
View Options

web/bitcoincashjs-lib/test/address.js

Loading...
View Options

web/bitcoincashjs-lib/test/bitcoin.core.js

Loading...
View Options

web/bitcoincashjs-lib/test/bitcoincash.test.js

Loading...
View Options

web/bitcoincashjs-lib/test/block.js

Loading...
View Options

web/bitcoincashjs-lib/test/bufferutils.js

Loading...
View Options

web/bitcoincashjs-lib/test/compile.js

Loading...
View Options

web/bitcoincashjs-lib/test/crypto.js

Loading...
View Options

web/bitcoincashjs-lib/test/ecdsa.js

Loading...
View Options

web/bitcoincashjs-lib/test/ecpair.js

Loading...
View Options

web/bitcoincashjs-lib/test/ecsignature.js

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/address.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/block.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/bufferutils.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/README.md

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/base58_encode_decode.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/base58_keys_invalid.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/base58_keys_valid.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/blocks.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/sig_canonical.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/sig_noncanonical.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/sighash.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/core/tx_valid.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/crypto.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/ecdsa.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/ecpair.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/ecsignature.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/hdnode.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/schnorr.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/script.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/script_number.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/templates.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/transaction.json

Loading...
View Options

web/bitcoincashjs-lib/test/fixtures/transaction_builder.json

Loading...
View Options

web/bitcoincashjs-lib/test/hdnode.js

Loading...
View Options

web/bitcoincashjs-lib/test/integration/_mainnet.js

Loading...
View Options

web/bitcoincashjs-lib/test/integration/_testnet.js

Loading...
View Options

web/bitcoincashjs-lib/test/integration/addresses.js

Loading...
View Options

web/bitcoincashjs-lib/test/integration/bip32.js

Loading...
View Options

web/bitcoincashjs-lib/test/integration/cltv.js

Loading...
View Options

web/bitcoincashjs-lib/test/integration/crypto.js

Loading...
View Options

web/bitcoincashjs-lib/test/integration/stealth.js

Loading...
View Options

web/bitcoincashjs-lib/test/integration/transactions.js

Loading...
View Options

web/bitcoincashjs-lib/test/schnorr.js

Loading...
View Options

web/bitcoincashjs-lib/test/script.js

Loading...
View Options

web/bitcoincashjs-lib/test/script_number.js

Loading...
View Options

web/bitcoincashjs-lib/test/templates.js

Loading...
View Options

web/bitcoincashjs-lib/test/transaction.js

Loading...
View Options

web/bitcoincashjs-lib/test/transaction_builder.js

Loading...
View Options

web/bitcoincashjs-lib/test/types.js

Loading...