Differential D12875

[avalanche] Actually finalize block in voting functional test
ClosedPublic
Actions

Authored by sdulfari on Dec 12 2022, 22:02.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbf4a9cfa2e30: [avalanche] Actually finalize block in voting functional test

Summary

The log clearly indicates the block was intended to be finalized here.
It gets to block acceptance but stops prematurely. This is not desirable
since it does not match expectations nor does it lend itself well to
expanding this test in the future.

Test Plan

ninja
./test/functional/test_runner.py abc_p2p_avalanche_voting

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Dec 12 2022, 22:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 12 2022, 22:02

sdulfari requested review of this revision.Dec 12 2022, 22:02

Harbormaster completed remote builds in B21551: Diff 37243.Dec 12 2022, 22:02

Remove unused import

Harbormaster completed remote builds in B21552: Diff 37244.Dec 12 2022, 22:20

Fabien accepted this revision.Dec 13 2022, 08:28

This revision is now accepted and ready to land.Dec 13 2022, 08:28

Closed by commit rABCbf4a9cfa2e30: [avalanche] Actually finalize block in voting functional test (authored by sdulfari). · Explain WhyDec 13 2022, 17:01

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABCbf4a9cfa2e30: [avalanche] Actually finalize block in voting functional test.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_voting.py

12 lines

Diff 37256

View Options

test/functional/abc_p2p_avalanche_voting.py

[avalanche] Actually finalize block in voting functional testClosedPublicActions