Page MenuHomePhabricator
Differential D12890

Add sane timeout in tests when waiting for parked blocks
AbandonedPublic
Actions

Authored by sdulfari on Dec 14 2022, 17:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Improves debugging experience. Functional tests should never take a minute to park/unpark blocks.

Test Plan
ninja && ./test/functional/test_runner.py abc_p2p_avalanche_voting abc-parkedchain

Diff Detail

Repository
rABC Bitcoin ABC
Branch
test-park-timeout
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21581
Build 42804: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 42803: arc lint + arc unit

Event Timeline

sdulfari created this revision.Dec 14 2022, 17:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 14 2022, 17:41
sdulfari requested review of this revision.Dec 14 2022, 17:41
Fabien requested changes to this revision.Dec 14 2022, 17:44
Fabien added a subscriber: Fabien.

Please don't add flakiness to the tests. There is no point lowering the timeout manually, thus overriding the build environment config, and cause occasional failures.

This revision now requires changes to proceed.Dec 14 2022, 17:44
Harbormaster completed remote builds in B21581: Diff 37299.Dec 14 2022, 18:02
sdulfari abandoned this revision.Dec 14 2022, 19:15

TIL you can set timeout-factor on the command line. Inspired some improvement to the docs: D12893

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
2 lines

Diff 37299

View Options

test/functional/abc-parkedchain.py

Loading...
View Options

test/functional/abc_p2p_avalanche_voting.py

Loading...