Fix a -Wreturn-type warning with GCC
ClosedPublic
Actions

Authored by Fabien on Jan 4 2023, 15:24.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCb19d99828848: Fix a -Wreturn-type warning with GCC

Summary

The RPCArg::ToStringObj method is supposed to return a string, but in the case of an unused type conversion it will raise an error and not return anything.

Test Plan

With GCC 12:

ninja

Check the warning is gone.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 4 2023, 15:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2023, 15:24

Fabien requested review of this revision.Jan 4 2023, 15:24

Harbormaster completed remote builds in B21695: Diff 37458.Jan 4 2023, 15:39

Although we don't expect this code to execute, it should at least appear sane if it did.

src/rpc/util.cpp
952 ↗	(On Diff #37458)

This revision now requires changes to proceed.Jan 4 2023, 21:28

Return unknown when the type is unknown

Harbormaster completed remote builds in B21697: Diff 37460.Jan 5 2023, 09:21

sdulfari accepted this revision.Jan 5 2023, 17:27

This revision is now accepted and ready to land.Jan 5 2023, 17:27

Closed by commit rABCb19d99828848: Fix a -Wreturn-type warning with GCC (authored by Fabien). · Explain WhyJan 5 2023, 21:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb19d99828848: Fix a -Wreturn-type warning with GCC.

Revision Contents
Changeset List

Path

Size

src/

rpc/

util.cpp

1 line

Diff 37469

View Options

Fix a -Wreturn-type warning with GCCClosedPublicActions