Page MenuHomePhabricator
Differential D12986

[avalanche] Merge the block and proof vote records into a single data structure
ClosedPublic
Actions

Authored by Fabien on Jan 17 2023, 20:59.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC87635dd940fc: [avalanche] Merge the block and proof vote records into a single data structure
Summary

This will prevent duplicating the code several time when adding vote records for transactions.
More cleanups and factorizations will follow.

There is no change in behavior.

Test Plan
ninja all check-extended
../contrib/teamcity/build-configurations.py build-tsan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 17 2023, 20:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2023, 20:59
Fabien requested review of this revision.Jan 17 2023, 20:59
Harbormaster completed remote builds in B21763: Diff 37559.Jan 17 2023, 21:16
sdulfari accepted this revision.Jan 17 2023, 21:26
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/avalanche/processor.cpp
908 ↗(On Diff #37559)

Does this fail to build if a type is missing?

This revision is now accepted and ready to land.Jan 17 2023, 21:26
Fabien added inline comments.Jan 18 2023, 08:36
src/avalanche/processor.cpp
908 ↗(On Diff #37559)

yes :) how cool is that ?

Closed by commit rABC87635dd940fc: [avalanche] Merge the block and proof vote records into a single data structure (authored by Fabien). · Explain WhyJan 18 2023, 08:38
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC87635dd940fc: [avalanche] Merge the block and proof vote records into a single data structure.
Fabien mentioned this in D12990: Fix a missing lock when accessing the block status.Jan 18 2023, 09:25
Fabien mentioned this in rABC385822354ff7: Fix a missing lock when accessing the block status.Jan 18 2023, 14:45
Fabien mentioned this in D13006: [avalanche] Drop unused reverse_iterator header from the processor.Jan 19 2023, 13:21
Fabien mentioned this in rABCfceba6c82a58: [avalanche] Drop unused reverse_iterator header from the processor.Jan 20 2023, 14:32

Revision Contents
Changeset List

PathSize
src/
avalanche/
57 lines
262 lines
test/
22 lines
2 lines
2 lines

Diff 37561

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/validation.cpp

Loading...