Page MenuHomePhabricator
Differential D13102

[buildbot] Add links to bchn repo when porting code
ClosedPublic
Actions

Authored by Fabien on Feb 6 2023, 11:01.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC1938c579b1bc: [buildbot] Add links to bchn repo when porting code
Summary

Uses a similar syntax than core, core-gui and secp256k1 with prefix bchn.

Test Plan
ninja check-buildbot

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 6 2023, 11:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2023, 11:01
Fabien requested review of this revision.Feb 6 2023, 11:01
Harbormaster completed remote builds in B21940: Diff 37824.Feb 6 2023, 11:02
Fabien retitled this revision from [buildbot] Add links to bchn repo when backporting to [buildbot] Add links to bchn repo when porting code.Feb 6 2023, 18:40
Fabien updated this revision to Diff 37825.Feb 6 2023, 18:41

backport => port

Harbormaster completed remote builds in B21941: Diff 37825.Feb 6 2023, 18:42
sdulfari accepted this revision.Feb 6 2023, 19:11
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
contrib/buildbot/test/test_endpoint_backportcheck.py
148 ↗(On Diff #37825)

I do not know what the significance of the /- is but the URL you provide in the test does a redirect. Consider adding the dash in if you can figure out what it is for.

This revision is now accepted and ready to land.Feb 6 2023, 19:11
Fabien added inline comments.Feb 6 2023, 19:13
contrib/buildbot/test/test_endpoint_backportcheck.py
148 ↗(On Diff #37825)

I noticed it but I don't know if it exists the same for all gitlab repos so I decided to not include it. The natural URL is hopefully more robust despite the redirect.

Closed by commit rABC1938c579b1bc: [buildbot] Add links to bchn repo when porting code (authored by Fabien). · Explain WhyFeb 6 2023, 19:19
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1938c579b1bc: [buildbot] Add links to bchn repo when porting code.

Revision Contents
Changeset List

PathSize
contrib/
buildbot/
4 lines
test/
9 lines

Diff 37826

View Options

contrib/buildbot/server.py

Loading...
View Options

contrib/buildbot/test/test_endpoint_backportcheck.py

Loading...