Page MenuHomePhabricator
Differential D14061

[e.cash] Fix subpage hero display issue
ClosedPublic
Actions

Authored by johnkuney on Jun 14 2023, 21:34.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC673fe77da251: [e.cash] Fix subpage hero display issue
Summary

There were some display issues with the hero section height/video background height. fixing with some CSS tweaks

Basic issue before was the video background and the hero container height were disjointed resulting in some weird alignment on extra tall screen, and a shortened video background on small screens

image.png (1×2 px, 2 MB)

Test Plan

npm run dev or preview site
navigate to /wealth-redefined page
inspect the hero section on an extra tall screen. You can use developer tools and set the screen height to like 1500
it should look okay here, ie text and image is lined up and hero section video background doesnt have weird gaps.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johnkuney created this revision.Jun 14 2023, 21:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2023, 21:34
johnkuney requested review of this revision.Jun 14 2023, 21:34
Harbormaster completed remote builds in B24048: Diff 40802.Jun 14 2023, 21:34
bytesofman added a subscriber: bytesofman.Jun 14 2023, 22:40

not totally clear to me what the issue was before and what has been fixed now.

test plan should be more specific, i.e. "navigate to this page and notice that this [specific undesired thing] does not occur"

johnkuney edited the summary of this revision. (Show Details)Jun 15 2023, 04:40
johnkuney edited the test plan for this revision. (Show Details)

okay clarified

bytesofman added a comment.Jun 15 2023, 15:20

@bot preview-e.cash

teamcity awarded a token.Jun 15 2023, 15:20

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41063 for the next 60 minutes.

bytesofman accepted this revision.Jun 15 2023, 15:33
This revision is now accepted and ready to land.Jun 15 2023, 15:33
Closed by commit rABC673fe77da251: [e.cash] Fix subpage hero display issue (authored by johnkuney). · Explain WhyJun 15 2023, 16:36
This revision was automatically updated to reflect the committed changes.
johnkuney added a commit: rABC673fe77da251: [e.cash] Fix subpage hero display issue.

Revision Contents
Changeset List

PathSize
web/
e.cash/
components/
sub-page-hero/
6 lines
9 lines
videobackground/
3 lines

Diff 40813

View Options

web/e.cash/components/sub-page-hero/index.js

Loading...
View Options

web/e.cash/components/sub-page-hero/styles.js

Loading...
View Options

web/e.cash/components/videobackground/styles.js

Loading...