Differential D14255

[e.cash] Add animations to site
ClosedPublic
Actions

Authored by johnkuney on Jul 11 2023, 23:09.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC84d11f525242: [e.cash] Add animations to site

Summary

Adding animations to all of the pages. Just applying the new animation definition to a handfull of styled components
note I also added one max-width css rule that was needed

Test Plan

preview the site and see if all of the pages have animaitons

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Jul 11 2023, 23:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2023, 23:09

johnkuney requested review of this revision.Jul 11 2023, 23:09

Harbormaster completed remote builds in B24457: Diff 41394.Jul 11 2023, 23:09

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41179 for the next 60 minutes.

bytesofman added inline comments.Jul 11 2023, 23:32

web/e.cash/components/navbar/styles.js
8 ↗	(On Diff #41394)	all the other changes are adding animation and this one is removing -- what was going on here?
web/e.cash/styles/pages/blog.js
84 ↗	(On Diff #41394)	why was this required?
148 ↗	(On Diff #41394)	ditto

johnkuney added inline comments.Jul 11 2023, 23:58

web/e.cash/components/navbar/styles.js
8 ↗	(On Diff #41394)	it was doing the animation to the navbar every time you navigated to another page, which I thought was no good
web/e.cash/styles/pages/blog.js
84 ↗	(On Diff #41394)	the transition all was messing with the animation timing, so specified the value
148 ↗	(On Diff #41394)	same here